Re: [PATCH net 6/8] net: bcmgenet: validate Ethernet address in bcmgenet_set_mac_addr

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] Submission hygiene: the commit message of "net: bcmgenet:
  validate Ethernet address in bcmgenet_set_mac_addr" (2c00a16cb1e7)…

--

net: bcmgenet: validate Ethernet address in bcmgenet_set_mac_addr

This adds an is_valid_ether_addr() check to bcmgenet_set_mac_addr() so that
zero and multicast addresses are rejected with -EADDRNOTAVAIL instead of
being programmed while the interface is down.

The only comment below concerns the commit message trailers, so the diff
hunk is not quoted.

>     Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
>     Assisted-by: LLM
>     Co-authored-by: Cursor <cursoragent@cursor.com>
>     Change-Id: I1cae9178ff2c9243510556f42a194058c10aea7e

[Severity: Low]
This isn't a bug in the code, but two things about this trailer block stand
out.

First, the Change-Id line:

    Change-Id: I1cae9178ff2c9243510556f42a194058c10aea7e

That is a Gerrit-specific tag with no meaning in Linux git history.  Could
it be dropped before reposting, as described in
Documentation/process/submitting-patches.rst?

Second, there is no Signed-off-by line from the author or from the listed
co-author, so the Developer's Certificate of Origin is not asserted and the
patch cannot be applied as posted.  Could a respin add the Signed-off-by
and handle the co-author attribution accordingly?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260918000732.276506-1-florian.fainelli%40broadcom.com