From: Neil Brown <neilb@suse.de>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Replace misspelled "PRINTK" with "CONFIG_PRINTK".
Date: Thu, 8 Mar 2007 12:41:24 +1100 [thread overview]
Message-ID: <17903.27076.860958.900374@notabene.brown> (raw)
In-Reply-To: message from Robert P. J. Day on Wednesday March 7
On Wednesday March 7, rpjday@mindspring.com wrote:
>
> Replace the apparently misspelled preprocessor variable "PRINTK"
> with "CONFIG_PRINTK".
No, it is meant to be "PRINTK".
It dates way way back before my time, but presumably the idea was you
could -DPRINTK=something and if you didn't do that, it would figure
out what it thought you wanted.
Definitely not meant to be CONFIG_PRINTK.
NeilBrown
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> not sure who the official maintainer here is, sorry.
>
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 5554ada..0c09772 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -53,7 +53,7 @@
> //#define DPRINTK PRINTK /* set this NULL to avoid verbose debug output */
> #define DPRINTK(x...) do { } while(0)
>
> -#ifndef PRINTK
> +#ifndef CONFIG_PRINTK
> # if DEBUG > 0
> # define PRINTK(x...) printk(KERN_DEBUG x)
> # else
>
> --
> ========================================================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
>
> http://fsdev.net/wiki/index.php?title=Main_Page
> ========================================================================
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2007-03-08 1:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 23:38 Robert P. J. Day
2007-03-08 0:08 ` Dave Jones
2007-03-08 0:25 ` Robert P. J. Day
2007-03-08 1:41 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17903.27076.860958.900374@notabene.brown \
--to=neilb@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®