From: Dave Jones <davej@redhat.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Replace misspelled "PRINTK" with "CONFIG_PRINTK".
Date: Wed, 7 Mar 2007 19:08:58 -0500 [thread overview]
Message-ID: <20070308000858.GE31910@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703071836420.3888@CPE00045a9c397f-CM001225dbafb6>
On Wed, Mar 07, 2007 at 06:38:32PM -0500, Robert P. J. Day wrote:
>
> Replace the apparently misspelled preprocessor variable "PRINTK"
> with "CONFIG_PRINTK".
this looks wrong.
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 5554ada..0c09772 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -53,7 +53,7 @@
> //#define DPRINTK PRINTK /* set this NULL to avoid verbose debug output */
> #define DPRINTK(x...) do { } while(0)
>
> -#ifndef PRINTK
> +#ifndef CONFIG_PRINTK
> # if DEBUG > 0
> # define PRINTK(x...) printk(KERN_DEBUG x)
> # else
the intention here is to only define 'PRINTK' if no-one else
has defined it already.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-03-08 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 23:38 Robert P. J. Day
2007-03-08 0:08 ` Dave Jones [this message]
2007-03-08 0:25 ` Robert P. J. Day
2007-03-08 1:41 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070308000858.GE31910@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®