mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: opendmb@gmail.com, florian.fainelli@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, justin.chen@broadcom.com,
	f.fainelli@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: fix NULL dereference in set_coalesce before first open
Date: Wed, 30 Sep 2026 00:30:06 +0000	[thread overview]
Message-ID: <179072820677.1181068.7188904034956035359.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260928105642.856210-1-nb@tipi-net.de>

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 28 Sep 2026 12:56:41 +0200 you wrote:
> The Rx ring priv and index are only set in bcmgenet_init_rx_ring(),
> which runs at open. Setting the Rx coalescing parameters on an interface
> that was never opened, e.g. "ethtool -C eth0 rx-usecs 50", dereferences
> a NULL ring->priv. The oops happens with RTNL held, so networking
> stays stuck until a reboot:
> 
>   Unable to handle kernel paging request at virtual address 0000000000002788
>   pc : bcmgenet_set_rx_coalesce.isra.0+0x10/0x88
>   lr : bcmgenet_set_coalesce+0xe8/0x180
>   Call trace:
>    bcmgenet_set_rx_coalesce.isra.0+0x10/0x88 (P)
>    __ethnl_set_coalesce.isra.0+0x490/0x570
>    ethnl_set_coalesce+0x48/0xc0
>    ethnl_default_set_doit+0xf4/0x230
>    genl_family_rcv_msg_doit+0xe8/0x160
>    genl_rcv_msg+0x220/0x2a0
>    netlink_rcv_skb+0x68/0x140
>    genl_rcv+0x40/0x60
>    netlink_unicast+0x338/0x3c0
>    netlink_sendmsg+0x19c/0x3f8
>    __sock_sendmsg+0x64/0xc0
>    __sys_sendto+0x124/0x198
>    __arm64_sys_sendto+0x30/0x48
> 
> [...]

Here is the summary with links:
  - [net] net: bcmgenet: fix NULL dereference in set_coalesce before first open
    https://git.kernel.org/netdev/net/c/19419faf58df

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2026-09-30  0:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 10:56 Nicolai Buchwitz
2026-09-28 10:59 ` netdev-bot+sinfo
2026-09-28 11:03   ` Nicolai Buchwitz
2026-09-28 17:29 ` Florian Fainelli
2026-09-30  0:30 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179072820677.1181068.7188904034956035359.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=justin.chen@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®