mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: 6lowpan: Pin module for 6lowpan_control debugfs file
@ 2026-10-08  5:11 Bui Viet Dung
  2026-10-09 14:20 ` patchwork-bot+bluetooth
  0 siblings, 1 reply; 2+ messages in thread
From: Bui Viet Dung @ 2026-10-08  5:11 UTC (permalink / raw)
  To: Marcel Holtmann, Luiz Augusto von Dentz
  Cc: linux-bluetooth, linux-kernel, stable, Bui Viet Dung

An open debugfs file retains lowpan_control_fops in the debugfs proxy
state. However, lowpan_control_fops has no .owner set to THIS_MODULE.
As a result, full_proxy_open_regular() calls fops_get() which succeeds
without taking a reference to the bluetooth_6lowpan module.

With CONFIG_BT_6LOWPAN=m, a userspace process can keep the debugfs file
descriptor for 6lowpan_control open across module unload
(delete_module / rmmod bluetooth_6lowpan). When the process subsequently
closes the file descriptor, full_proxy_release() accesses the already
freed and unmapped lowpan_control_fops table, causing a kernel page fault
or oops.

The issue was discovered via manual code audit of
net/bluetooth/6lowpan.c.

Set .owner = THIS_MODULE on lowpan_control_fops so that debugfs pins
the module until all open file descriptors have finished.

Fixes: 6b8d4a6a0314 ("Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one")
Cc: stable@vger.kernel.org
Signed-off-by: Bui Viet Dung <dungvn2345@gmail.com>
---
 net/bluetooth/6lowpan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 30f4afa18bc8..20fb20eea8e7 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -1209,6 +1209,7 @@ static int lowpan_control_open(struct inode *inode, struct file *file)
 }
 
 static const struct file_operations lowpan_control_fops = {
+	.owner		= THIS_MODULE,
 	.open		= lowpan_control_open,
 	.read		= seq_read,
 	.write		= lowpan_control_write,
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: 6lowpan: Pin module for 6lowpan_control debugfs file
  2026-10-08  5:11 [PATCH] Bluetooth: 6lowpan: Pin module for 6lowpan_control debugfs file Bui Viet Dung
@ 2026-10-09 14:20 ` patchwork-bot+bluetooth
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+bluetooth @ 2026-10-09 14:20 UTC (permalink / raw)
  To: Bui Viet Dung; +Cc: marcel, luiz.dentz, linux-bluetooth, linux-kernel, stable

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu,  8 Oct 2026 12:11:29 +0700 you wrote:
> An open debugfs file retains lowpan_control_fops in the debugfs proxy
> state. However, lowpan_control_fops has no .owner set to THIS_MODULE.
> As a result, full_proxy_open_regular() calls fops_get() which succeeds
> without taking a reference to the bluetooth_6lowpan module.
> 
> With CONFIG_BT_6LOWPAN=m, a userspace process can keep the debugfs file
> descriptor for 6lowpan_control open across module unload
> (delete_module / rmmod bluetooth_6lowpan). When the process subsequently
> closes the file descriptor, full_proxy_release() accesses the already
> freed and unmapped lowpan_control_fops table, causing a kernel page fault
> or oops.
> 
> [...]

Here is the summary with links:
  - Bluetooth: 6lowpan: Pin module for 6lowpan_control debugfs file
    https://git.kernel.org/bluetooth/bluetooth-next/c/b019e48cee2d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-09 14:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-08  5:11 [PATCH] Bluetooth: 6lowpan: Pin module for 6lowpan_control debugfs file Bui Viet Dung
2026-10-09 14:20 ` patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®