* [PATCH] mfd: mc13xxx-spi: Reject devices without match data
@ 2026-09-25 13:37 Jiale Yao
2026-10-15 11:32 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Jiale Yao @ 2026-09-25 13:37 UTC (permalink / raw)
To: Lee Jones, Rob Herring, mfd, linux-kernel; +Cc: Jiale Yao
A device bound through driver_override need not match an entry in the
driver tables. In that case spi_get_device_match_data() returns NULL,
but mc13xxx_common_init() later uses the missing variant data.
Reject devices without match data before entering the common probe path.
Fixes: 15d71e678ec1 ("mfd: mc13xxx-spi/wm831x-spi: Use spi_get_device_match_data()")
Signed-off-by: Jiale Yao <yaojiale02@163.com>
---
drivers/mfd/mc13xxx-spi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/mc13xxx-spi.c b/drivers/mfd/mc13xxx-spi.c
index 56d2e57b7d73..d1523321152a 100644
--- a/drivers/mfd/mc13xxx-spi.c
+++ b/drivers/mfd/mc13xxx-spi.c
@@ -150,6 +150,8 @@ static int mc13xxx_spi_probe(struct spi_device *spi)
}
mc13xxx->variant = spi_get_device_match_data(spi);
+ if (!mc13xxx->variant)
+ return -ENODATA;
return mc13xxx_common_init(&spi->dev);
}
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: mc13xxx-spi: Reject devices without match data
2026-09-25 13:37 [PATCH] mfd: mc13xxx-spi: Reject devices without match data Jiale Yao
@ 2026-10-15 11:32 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2026-10-15 11:32 UTC (permalink / raw)
To: Jiale Yao; +Cc: Rob Herring, mfd, linux-kernel
On Fri, 25 Sep 2026, Jiale Yao wrote:
> A device bound through driver_override need not match an entry in the
> driver tables. In that case spi_get_device_match_data() returns NULL,
> but mc13xxx_common_init() later uses the missing variant data.
>
> Reject devices without match data before entering the common probe path.
>
> Fixes: 15d71e678ec1 ("mfd: mc13xxx-spi/wm831x-spi: Use spi_get_device_match_data()")
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
> ---
> drivers/mfd/mc13xxx-spi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/mc13xxx-spi.c b/drivers/mfd/mc13xxx-spi.c
> index 56d2e57b7d73..d1523321152a 100644
> --- a/drivers/mfd/mc13xxx-spi.c
> +++ b/drivers/mfd/mc13xxx-spi.c
> @@ -150,6 +150,8 @@ static int mc13xxx_spi_probe(struct spi_device *spi)
> }
>
> mc13xxx->variant = spi_get_device_match_data(spi);
> + if (!mc13xxx->variant)
> + return -ENODATA;
Shouldn't this check happen at the start of 'mc13xxx_spi_probe()', before we
allocate memory, configure the SPI bus and initialise 'regmap'? Also, we
generally return '-ENODEV' when match data is missing.
>
> return mc13xxx_common_init(&spi->dev);
> }
> --
> 2.34.1
>
--
Lee Jones
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-15 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-25 13:37 [PATCH] mfd: mc13xxx-spi: Reject devices without match data Jiale Yao
2026-10-15 11:32 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®