mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: fujo <hooyan2024@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] selftests/pidfd: wait for POLLHUP before reading exit info
Date: Tue, 20 Oct 2026 15:45:18 -0400	[thread overview]
Message-ID: <179252551833.59967.6484153471898928809@gmail.com> (raw)
In-Reply-To: <atc59R5-oBnyOIb8@redhat.com>

Hi Oleg,

> Confused... V3 still changes the 1st poll(&pfd, 1, 0) to use POLLHUP?

You are right, and I'm sorry for the noise.  I fixed the source but
amended the commit without staging the fix, so the v3 patch still
carried the old hunk.  That was my mistake and it wasted your time.

v4 no longer touches that poll at all; only the polls that are followed
by PIDFD_GET_INFO wait for POLLHUP (and check POLLHUP in revents).  With
the corrected tree the tests pass ten consecutive runs.

Thanks for catching this,
fujo

  reply	other threads:[~2026-10-20 19:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17  5:43 [RFC PATCH] pidfs: don't report autoreaped tasks readable before exit info exists fujo
2026-10-17 13:48 ` Oleg Nesterov
2026-10-17 19:23 ` fujo
2026-10-18 16:30   ` Oleg Nesterov
2026-10-17 19:23 ` [PATCH v2] selftests/pidfd: wait for POLLHUP before reading exit info fujo
2026-10-18 16:25   ` Oleg Nesterov
2026-10-18 16:48     ` [PATCH v3] " fujo
2026-10-20  9:52       ` Oleg Nesterov
2026-10-20 19:45         ` fujo [this message]
2026-10-20 19:45         ` [PATCH v4] " fujo
2026-10-18 16:48     ` [PATCH v2] " fujo
2026-10-18 19:27       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179252551833.59967.6484153471898928809@gmail.com \
    --to=hooyan2024@gmail.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®