mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net] tg3: Add Datto SIRIS 5 1U Server to restart AER quirk table
@ 2026-10-19 20:03 Travis Howard via B4 Relay
  2026-10-22  1:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Travis Howard via B4 Relay @ 2026-10-19 20:03 UTC (permalink / raw)
  To: Pavan Chebbi, Michael Chan, Andrew Lunn, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
	Lenny Szubowicz
  Cc: netdev, linux-kernel, Travis Howard

From: Travis Howard <thoward@lafayetteinstrument.com>

The Datto SIRIS 5 1U Server is a Dell OEMR XL R640 (Dell's OEM-ready
variant of the PowerEdge R640) sold under Datto's identity. Its DMI
strings report sys_vendor "datto" and product_name "SIRIS 5 1U Server",
so it does not match the existing "PowerEdge R640" entry in
tg3_restart_aer_quirk_table.

As on the PowerEdge R640, a system restart triggers a fatal PCIe AER
on the BCM5720 during ACPI _PTS for S5, which the iDRAC logs as
PCI1318 and which hangs the reboot. Power off is unaffected.

Clearing the same PCI_EXP_DEVCTL error-reporting bits on both BCM5720
functions from userspace immediately before restart allows the system
to reboot normally, confirming the quirk applies to this platform.

Fixes: e0efe83ed325 ("tg3: Disable tg3 PCIe AER on system reboot")
Signed-off-by: Travis Howard <thoward@lafayetteinstrument.com>
---
Tested on the affected system (Ubuntu 26.04, 7.0.0-38-generic) with
this change applied to tg3: reboot completes and no PCI1318 is logged.
Without it, every restart hangs with PCI1318 logged against the BCM5720.
---
 drivers/net/ethernet/broadcom/tg3.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 8b6806a79edf..b6aa10f2bdf7 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -18229,6 +18229,12 @@ static const struct dmi_system_id tg3_restart_aer_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R750"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "datto"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "SIRIS 5 1U Server"),
+		},
+	},
 	{}
 };
 

---
base-commit: 78731b46967e3e7102b5cd5062bef185f3404b5c
change-id: 20261019-tg3-datto-aer-quirk-1c380e393ec6

Best regards,
-- 
Travis Howard <thoward@lafayetteinstrument.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net] tg3: Add Datto SIRIS 5 1U Server to restart AER quirk table
  2026-10-19 20:03 [PATCH net] tg3: Add Datto SIRIS 5 1U Server to restart AER quirk table Travis Howard via B4 Relay
@ 2026-10-22  1:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-10-22  1:00 UTC (permalink / raw)
  To: Travis Howard
  Cc: pavan.chebbi, mchan, andrew+netdev, davem, edumazet, kuba,
	pabeni, horms, lszubowi, netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 19 Oct 2026 20:03:10 +0000 you wrote:
> From: Travis Howard <thoward@lafayetteinstrument.com>
> 
> The Datto SIRIS 5 1U Server is a Dell OEMR XL R640 (Dell's OEM-ready
> variant of the PowerEdge R640) sold under Datto's identity. Its DMI
> strings report sys_vendor "datto" and product_name "SIRIS 5 1U Server",
> so it does not match the existing "PowerEdge R640" entry in
> tg3_restart_aer_quirk_table.
> 
> [...]

Here is the summary with links:
  - [net] tg3: Add Datto SIRIS 5 1U Server to restart AER quirk table
    https://git.kernel.org/netdev/net/c/a55eb6a62214

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-22  1:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-19 20:03 [PATCH net] tg3: Add Datto SIRIS 5 1U Server to restart AER quirk table Travis Howard via B4 Relay
2026-10-22  1:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®