Re: [PATCH net-next v3 3/5] net: phy: mxl-gpy: release MxL86211C Super Isolate

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The concern is that the patch lacks a Fixes: tag.

--

net: phy: mxl-gpy: release MxL86211C Super Isolate

This patch releases Super Isolate mode on the MxL86211C PHY in
mxl86211c_probe(), before gpy_probe() reads the firmware version. It
also adds a new mxl86211c_config_init(), which reapplies the optional
VDDP MDIO voltage and releases Super Isolate again after each hardware
reset.

> diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
> index 952272faac1e..dba0777158b2 100644
> --- a/drivers/net/phy/mxl-gpy.c
> +++ b/drivers/net/phy/mxl-gpy.c

[ ... ]

> +static int mxl86211c_config_init(struct phy_device *phydev)
> +{
> +	struct gpy_priv *priv = phydev->priv;
> +	int ret;
> +
> +	if (priv->vddp) {
> +		ret = mxl86211c_configure_mdio_voltage(phydev, priv->vddp);
> +		if (ret)
> +			return ret;
> +	}

[ ... ]

> @@ -456,6 +481,10 @@ static int mxl86211c_probe(struct phy_device *phydev)
>  			return ret;
>  	}
>  
> +	ret = mxl86211c_release_super_isolate(phydev);
> +	if (ret)
> +		return ret;
> +
>  	ret = gpy_probe(phydev);
>  	if (ret)
>  		return ret;

[Severity: Low]
This isn't a bug, but should this patch have a Fixes: tag?

Commit 9d844da693d6d ("net: phy: mxl-gpy: add support for MxL86211C")
added MxL86211C support without any Super Isolate handling. Boards
strapped into Super Isolate would never have come up with that driver.

That said, this looks more like support for a strap configuration the
driver never handled than a fix for a regression.

There is also a dependency. mxl86211c_config_init() uses priv->vddp
and mxl86211c_configure_mdio_voltage(), which come from the previous
patch in the series ("net: phy: mxl-gpy: add MxL86211C VDDP supply").
A Fixes: tag pointing at 9d844da693d6d would trigger a stable backport
that does not apply on its own.

Leaving the tag off seems reasonable for a net-next feature series.
I am raising it only in case the maintainers see it differently.

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261020093655.344585-1-robert.marko%40sartura.hr