Re: [PATCH net-next v3 4/5] dt-bindings: net: maxlinear: add MxL86211C lane mapping support

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] Concern: the binding adds `maxlinear,lane-asp-map` for the
  MxL86211C, but no driver code reads it, so the title "add MxL86211C…

--

dt-bindings: net: maxlinear: add MxL86211C lane mapping support

This patch documents an optional maxlinear,lane-asp-map property for the
MxL86211C. The property describes how the physical TPI lanes are wired to
the analog front ends (ASPs). The select block now also matches nodes that
carry the property, and the property is rejected for non-MxL86211C
compatibles.

> diff --git a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> index 53f430e12151..7b6140baf175 100644
> --- a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> +++ b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml

[ ... ]

> @@ -41,6 +44,21 @@ properties:
>        Optional regulator supplying the VDDP pin. Its voltage configures the
>        MDIO, MDC, and MDINT pad voltage and must be either 1.8 V or 3.3 V.
>  
> +  maxlinear,lane-asp-map:
> +    description: |
> +      Mapping of physical TPI lanes A through D to analog front ends (ASPs)
> +      A through D. The array index identifies the physical TPI lane, while
> +      its value identifies the analog front end, encoded as 0 through 3.
> +      Each analog front end must be mapped exactly once. Omit the property to
> +      retain the hardware reset mapping.
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    minItems: 4
> +    maxItems: 4
> +    uniqueItems: true
> +    items:
> +      minimum: 0
> +      maximum: 3
> +

[Severity: Low]
The subject says "add MxL86211C lane mapping support", but this commit
only documents maxlinear,lane-asp-map. Nothing in this commit reads the
property. Does the driver support come in a separate patch?

The next patch in the series appears to cover it. "net: phy: mxl-gpy:
support MxL86211C lane mapping" adds mxl86211c_configure_lane_asp_map() to
drivers/net/phy/mxl-gpy.c. That function:

  - reads the property with device_property_count_u32() and
    device_property_read_u32_array()
  - checks that each value is in the range 0 to 3 and appears only once
  - writes VSPEC1_LANE_ASP_MAP with phy_modify_mmd()

mxl86211c_config_init() calls it, so the mapping is programmed again after
each hardware reset.

At the end of the series the property has an in-tree user, so this looks
resolved. It is noted here only for completeness.

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261020093655.344585-1-robert.marko%40sartura.hr