mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <mani@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-arm-kernel@lists.infradead.org,
	"Vinod Koul" <vkoul@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Yendapally Reddy Dhananjaya Reddy"
	<yendapally.reddy@broadcom.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/9] phy: broadcom: ns-usb3: Coordinate NSP USB2 and USB3 initialization
Date: Sun, 01 Nov 2026 16:27:10 +0530	[thread overview]
Message-ID: <179353063083.2955.13880869162770253902.b4-reply@b4> (raw)
In-Reply-To: <20261021172819.668120-4-florian.fainelli@broadcom.com>

On 2026-10-21 10:28 -0700, Florian Fainelli wrote:
> The iProc SDK holds both USB2 and USB3 cores in reset while programming
> the USB3 PLL, then releases USB2 before USB3. It also enables the USB2
> IDM interface clock. The Northstar Bx initialization used by NSP does
> not perform the USB2 setup or retain the SDK settling intervals.
> 
> Implement an NSP variant with the coordinated reset sequence and
> interface clock enable. Sharing one PHY between the HCDs lets the PHY
> core serialize and reference-count initialization, preventing a later
> host probe from resetting an already active USB2 controller.
> 
> Retain the downstream delays around reset and MDIO operations, and
> leave both NSP cores reset if programming fails. Keep existing
> Northstar Ax and Bx reset behavior unchanged.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

- Mani



  reply	other threads:[~2026-11-01 10:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 17:28 [PATCH 0/9] Fix USB2 and USB3 on NSP SoCs Florian Fainelli
2026-10-21 17:28 ` [PATCH 2/9] dt-bindings: phy: bcm-ns-usb3-phy: Describe the NSP variant Florian Fainelli
2026-10-30 18:21   ` Rob Herring
2026-10-30 19:14     ` Florian Fainelli
2026-10-21 17:28 ` [PATCH 3/9] phy: broadcom: ns-usb3: Coordinate NSP USB2 and USB3 initialization Florian Fainelli
2026-11-01 10:57   ` Manivannan Sadhasivam [this message]
2026-10-21 17:28 ` [PATCH 6/9] dt-bindings: usb: generic-ehci: Add the NSP compatible Florian Fainelli
2026-10-30 18:22   ` Rob Herring (Arm)
2026-10-21 17:28 ` [PATCH 7/9] usb: host: ehci-platform: Set the FIFO threshold on NSP Florian Fainelli
2026-10-21 17:28 ` [PATCH 8/9] ARM: dts: broadcom: Identify the NSP EHCI controller Florian Fainelli
2026-10-21 17:28 ` [PATCH 9/9] ARM: dts: broadcom: Use noncoherent USB DMA on BCM958625HR Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179353063083.2955.13880869162770253902.b4-reply@b4 \
    --to=mani@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rafal@milecki.pl \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stern@rowland.harvard.edu \
    --cc=vkoul@kernel.org \
    --cc=yendapally.reddy@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®