mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Thorsten Lannynd <t-lannynd@ti.com>,
	linux-arm-kernel@lists.infradead.org
Cc: b-brnich@ti.com, praneeth@ti.com, r-donadkar@ti.com,
	devarsht@ti.com, jai.luthra@ideasonboard.com,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am62x-sk: Add orientation to IMX219 sensor node
Date: Thu, 05 Nov 2026 10:12:40 +0000	[thread overview]
Message-ID: <179387356065.194410.14555444564110226308@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20261105033224.2880607-1-t-lannynd@ti.com>

Quoting Thorsten Lannynd (2026-11-05 03:32:24)
> The IMX219 CSI2 expansion module is externally attached. Without the
> orientation property, V4L2_CID_CAMERA_ORIENTATION (0x009a0922) is not
> exposed and libcamera fails with:
> 
>   ERROR CameraSensor camera_sensor_raw.cpp:465 'imx219 4-0010':
>   Mandatory V4L2 control 0x009a0922 not available
> 
> Set orientation = <MEDIA_ORIENTATION_EXTERNAL> to fix this.
> 
> Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
> v2:
>   - Use MEDIA_ORIENTATION_EXTERNAL instead of <2> (Kieran Bingham)
>   - Add #include <dt-bindings/media/video-interface-devices.h>
> 
>  arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> index 149c59c07182..70c2a197f1dd 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> @@ -8,6 +8,7 @@
>  /plugin/;
>  
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/media/video-interface-devices.h>
>  
>  &{/} {
>         clk_imx219_fixed: imx219-xclk {
> @@ -72,6 +73,7 @@ ov5640: camera@10 {
>                                 VDDL-supply = <&reg_1p2v>;
>  
>                                 reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>;
> +                               orientation = <MEDIA_ORIENTATION_EXTERNAL>;
>  
>                                 port {
>                                         csi2_cam0: endpoint {
> -- 
> 2.34.1
>

  reply	other threads:[~2026-11-05 10:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  3:32 Thorsten Lannynd
2026-11-05 10:12 ` Kieran Bingham [this message]
2026-11-05 11:09 ` Jai Luthra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179387356065.194410.14555444564110226308@ping.linuxembedded.co.uk \
    --to=kieran.bingham@ideasonboard.com \
    --cc=b-brnich@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jai.luthra@ideasonboard.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=r-donadkar@ti.com \
    --cc=robh@kernel.org \
    --cc=t-lannynd@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®