mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: ti: k3-am62x-sk: Add orientation to IMX219 sensor node
@ 2026-11-05  3:32 Thorsten Lannynd
  2026-11-05 10:12 ` Kieran Bingham
  2026-11-05 11:09 ` Jai Luthra
  0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Lannynd @ 2026-11-05  3:32 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: b-brnich, praneeth, r-donadkar, devarsht, kieran.bingham,
	jai.luthra, Nishanth Menon, Vignesh Raghavendra, Tero Kristo,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-kernel

The IMX219 CSI2 expansion module is externally attached. Without the
orientation property, V4L2_CID_CAMERA_ORIENTATION (0x009a0922) is not
exposed and libcamera fails with:

  ERROR CameraSensor camera_sensor_raw.cpp:465 'imx219 4-0010':
  Mandatory V4L2 control 0x009a0922 not available

Set orientation = <MEDIA_ORIENTATION_EXTERNAL> to fix this.

Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>
---
v2:
  - Use MEDIA_ORIENTATION_EXTERNAL instead of <2> (Kieran Bingham)
  - Add #include <dt-bindings/media/video-interface-devices.h>

 arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
index 149c59c07182..70c2a197f1dd 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
@@ -8,6 +8,7 @@
 /plugin/;
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/media/video-interface-devices.h>
 
 &{/} {
 	clk_imx219_fixed: imx219-xclk {
@@ -72,6 +73,7 @@ ov5640: camera@10 {
 				VDDL-supply = <&reg_1p2v>;
 
 				reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>;
+				orientation = <MEDIA_ORIENTATION_EXTERNAL>;
 
 				port {
 					csi2_cam0: endpoint {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: ti: k3-am62x-sk: Add orientation to IMX219 sensor node
  2026-11-05  3:32 [PATCH v2] arm64: dts: ti: k3-am62x-sk: Add orientation to IMX219 sensor node Thorsten Lannynd
@ 2026-11-05 10:12 ` Kieran Bingham
  2026-11-05 11:09 ` Jai Luthra
  1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2026-11-05 10:12 UTC (permalink / raw)
  To: Thorsten Lannynd, linux-arm-kernel
  Cc: b-brnich, praneeth, r-donadkar, devarsht, jai.luthra,
	Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel

Quoting Thorsten Lannynd (2026-11-05 03:32:24)
> The IMX219 CSI2 expansion module is externally attached. Without the
> orientation property, V4L2_CID_CAMERA_ORIENTATION (0x009a0922) is not
> exposed and libcamera fails with:
> 
>   ERROR CameraSensor camera_sensor_raw.cpp:465 'imx219 4-0010':
>   Mandatory V4L2 control 0x009a0922 not available
> 
> Set orientation = <MEDIA_ORIENTATION_EXTERNAL> to fix this.
> 
> Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
> v2:
>   - Use MEDIA_ORIENTATION_EXTERNAL instead of <2> (Kieran Bingham)
>   - Add #include <dt-bindings/media/video-interface-devices.h>
> 
>  arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> index 149c59c07182..70c2a197f1dd 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> @@ -8,6 +8,7 @@
>  /plugin/;
>  
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/media/video-interface-devices.h>
>  
>  &{/} {
>         clk_imx219_fixed: imx219-xclk {
> @@ -72,6 +73,7 @@ ov5640: camera@10 {
>                                 VDDL-supply = <&reg_1p2v>;
>  
>                                 reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>;
> +                               orientation = <MEDIA_ORIENTATION_EXTERNAL>;
>  
>                                 port {
>                                         csi2_cam0: endpoint {
> -- 
> 2.34.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: ti: k3-am62x-sk: Add orientation to IMX219 sensor node
  2026-11-05  3:32 [PATCH v2] arm64: dts: ti: k3-am62x-sk: Add orientation to IMX219 sensor node Thorsten Lannynd
  2026-11-05 10:12 ` Kieran Bingham
@ 2026-11-05 11:09 ` Jai Luthra
  1 sibling, 0 replies; 3+ messages in thread
From: Jai Luthra @ 2026-11-05 11:09 UTC (permalink / raw)
  To: Thorsten Lannynd, linux-arm-kernel
  Cc: b-brnich, praneeth, r-donadkar, devarsht, kieran.bingham,
	Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel

Hi Thorsten,

Thank you for the patch.

Quoting Thorsten Lannynd (2026-11-05 09:02:24)
> The IMX219 CSI2 expansion module is externally attached. Without the
> orientation property, V4L2_CID_CAMERA_ORIENTATION (0x009a0922) is not
> exposed and libcamera fails with:
> 
>   ERROR CameraSensor camera_sensor_raw.cpp:465 'imx219 4-0010':
>   Mandatory V4L2 control 0x009a0922 not available
> 
> Set orientation = <MEDIA_ORIENTATION_EXTERNAL> to fix this.
> 
> Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>

Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com>

Thanks,
    Jai

> ---
> v2:
>   - Use MEDIA_ORIENTATION_EXTERNAL instead of <2> (Kieran Bingham)
>   - Add #include <dt-bindings/media/video-interface-devices.h>
> 
>  arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> index 149c59c07182..70c2a197f1dd 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> @@ -8,6 +8,7 @@
>  /plugin/;
>  
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/media/video-interface-devices.h>
>  
>  &{/} {
>         clk_imx219_fixed: imx219-xclk {
> @@ -72,6 +73,7 @@ ov5640: camera@10 {
>                                 VDDL-supply = <&reg_1p2v>;
>  
>                                 reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>;
> +                               orientation = <MEDIA_ORIENTATION_EXTERNAL>;
>  
>                                 port {
>                                         csi2_cam0: endpoint {
> -- 
> 2.34.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-05 11:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-05  3:32 [PATCH v2] arm64: dts: ti: k3-am62x-sk: Add orientation to IMX219 sensor node Thorsten Lannynd
2026-11-05 10:12 ` Kieran Bingham
2026-11-05 11:09 ` Jai Luthra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®