From: "Rob Herring (Arm)" <robh@kernel.org>
To: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
Cc: "Conor Dooley" <conor+dt@kernel.org>,
"André Apitzsch" <git@apitzsch.eu>,
"Hans Verkuil" <hverkuil+cisco@kernel.org>,
linux-media@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Luca Weiss" <luca.weiss@fairphone.com>,
"Daniel Scally" <dan.scally@ideasonboard.com>,
"Bjorn Andersson" <andersson@kernel.org>,
stable@vger.kernel.org,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: media: i2c: dw9800: Redocument DW9800K
Date: Thu, 05 Nov 2026 06:03:41 -0600 [thread overview]
Message-ID: <179388014029.1297019.12610765343474899975.robh@kernel.org> (raw)
In-Reply-To: <20261105-b4-dw9800k_cleanup-v3-1-6850ee6a5a5a@fairphone.com>
On Thu, 05 Nov 2026 11:29:00 +0100, Griffin Kroah-Hartman wrote:
> The DW9800K's properties are too different to justify sharing the same
> bindings file as the dw9719, Create a separate bindings documentation
> for the Dongwoon Anatech DW9800K with its updated properties.
>
> More specifically:
>
> The DW9800K did not share the SAC1 and SAC6 modes
> that the DW9719 used.
>
> Description of vcm-prescale does not match the calculations labeled in
> the DW9800K datasheet for how clock diving rate is computed.
>
> New property timing-control introduced to offer more fine-tuned dividing
> options available to the DW9800K.
>
> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
> ---
> .../bindings/media/i2c/dongwoon,dw9719.yaml | 1 -
> .../bindings/media/i2c/dongwoon,dw9800k.yaml | 91 ++++++++++++++++++++++
> 2 files changed, 91 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.example.dtb: actuator@c (dongwoon,dw9800k): 'dongwoon,vcm-presc' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9800k.yaml
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9800k.example.dtb: actuator@c (dongwoon,dw9800k): dongwoon,vcm-presc: b'\x00\x00\x00\x00' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20261105-b4-dw9800k_cleanup-v3-1-6850ee6a5a5a@fairphone.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-11-05 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 10:28 [PATCH v3 0/3] Dongwoon DW9800K update patchset Griffin Kroah-Hartman
2026-11-05 10:29 ` [PATCH v3 1/3] dt-bindings: media: i2c: dw9800: Redocument DW9800K Griffin Kroah-Hartman
2026-11-05 12:03 ` Rob Herring (Arm) [this message]
2026-11-05 10:29 ` [PATCH v3 2/3] media: i2c: dw9719: Update DW9800K driver Griffin Kroah-Hartman
2026-11-05 18:14 ` kernel test robot
2026-11-05 10:29 ` [PATCH v3 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Fix DW9800K support Griffin Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179388014029.1297019.12610765343474899975.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=git@apitzsch.eu \
--cc=griffin.kroah@fairphone.com \
--cc=hverkuil+cisco@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®