mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Saravana Kannan <saravanak@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] of: reserved_mem: Drop node_fixup, CMA can handle it internally again
Date: Fri, 6 Nov 2026 15:18:15 -0600	[thread overview]
Message-ID: <179399989427.1724666.16449745308990999422.robh@kernel.org> (raw)
In-Reply-To: <20261105215413.1439745-1-m.szyprowski@samsung.com>


On Thu, 05 Nov 2026 22:54:11 +0100, Marek Szyprowski wrote:
> The separate fixup step was needed because node initialization used to
> run too late, after paging_init(). Since commit aa05faf81583 ("of:
> reserved_mem: allocate and map the reserved_mem array early") node_init
> runs early enough again, so dma_contiguous_early_fixup() can be called
> directly from rmem_cma_setup() once the CMA region has been successfully
> initialized, as it was before commit 2c223f7239f37 ("of: reserved_mem:
> Restructure call site for dma_contiguous_early_fixup()").
> 
> Drop the now unused node_fixup callback and its helper. This also fixes
> the premature call to fixup when region fails to initialize.
> 
> Closes: https://sashiko.dev/#/bug/linux-61818eaa-5dc1-4457-bd21-3a9be2ed4d6d
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/of/of_reserved_mem.c    | 34 ---------------------------------
>  include/linux/of_reserved_mem.h |  2 --
>  kernel/dma/contiguous.c         | 17 +++--------------
>  3 files changed, 3 insertions(+), 50 deletions(-)
> 

Applied, thanks!


      reply	other threads:[~2026-11-06 21:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20261105215426eucas1p1fb2de3113bd185a84e1d0925e14fc4fc@eucas1p1.samsung.com>
2026-11-05 21:54 ` Marek Szyprowski
2026-11-06 21:18   ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179399989427.1724666.16449745308990999422.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robin.murphy@arm.com \
    --cc=saravanak@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®