[PATCH] remoteproc: qcom_q6v5_mss: Fix proxy regulator array overflow

[PATCH] remoteproc: qcom_q6v5_mss: Fix proxy regulator array overflow

[Anup Vishwakarma]

The proxy supply tables of msm8974, msm8226 and msm8926 list two
regulators (pll and mx), but proxy_regs[] has room for one. The second
entry written by q6v5_regulator_init() lands in fallback_proxy_regs[0].

On msm8974 with a device tree that has no cx power domain, the
fallback table then overwrites that entry with cx, so mx is never
enabled and cx is enabled twice.

Make proxy_regs[] large enough for the largest proxy supply table.

Fixes: 4641840341f3 ("remoteproc: qcom_q6v5_mss: Handle platforms with one power domain")
Cc: stable@vger.kernel.org
Signed-off-by: Anup Vishwakarma <anup.vishwakarma@oss.qualcomm.com>
---
 drivers/remoteproc/qcom_q6v5_mss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index 2f71ed2feff6..7dea3bad9f5d 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -216,7 +216,7 @@ struct q6v5 {
 	int proxy_pd_count;
 
 	struct reg_info active_regs[1];
-	struct reg_info proxy_regs[1];
+	struct reg_info proxy_regs[2];
 	struct reg_info fallback_proxy_regs[2];
 	int active_reg_count;
 	int proxy_reg_count;

---
base-commit: 20a33c6b6cbe7e4805dfb6cd68816937443aa148
change-id: 20261027-b4-q6v5_mss_proxy_regs-2d780c0095c6

Best regards,
--  
Anup Vishwakarma <anup.vishwakarma@oss.qualcomm.com>

Re: [PATCH] remoteproc: qcom_q6v5_mss: Fix proxy regulator array overflow

[Konrad Dybcio]

On 10/27/26 1:01 PM, Anup Vishwakarma wrote:
> The proxy supply tables of msm8974, msm8226 and msm8926 list two
> regulators (pll and mx), but proxy_regs[] has room for one. The second
> entry written by q6v5_regulator_init() lands in fallback_proxy_regs[0].
> 
> On msm8974 with a device tree that has no cx power domain, the
> fallback table then overwrites that entry with cx, so mx is never
> enabled and cx is enabled twice.
> 
> Make proxy_regs[] large enough for the largest proxy supply table.
> 
> Fixes: 4641840341f3 ("remoteproc: qcom_q6v5_mss: Handle platforms with one power domain")
> Cc: stable@vger.kernel.org
> Signed-off-by: Anup Vishwakarma <anup.vishwakarma@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH] remoteproc: qcom_q6v5_mss: Fix proxy regulator array overflow

[Bjorn Andersson]

On Tue, 27 Oct 2026 17:31:22 +0530, Anup Vishwakarma wrote:
> The proxy supply tables of msm8974, msm8226 and msm8926 list two
> regulators (pll and mx), but proxy_regs[] has room for one. The second
> entry written by q6v5_regulator_init() lands in fallback_proxy_regs[0].
> 
> On msm8974 with a device tree that has no cx power domain, the
> fallback table then overwrites that entry with cx, so mx is never
> enabled and cx is enabled twice.
> 
> [...]

Applied, thanks!

[1/1] remoteproc: qcom_q6v5_mss: Fix proxy regulator array overflow
      commit: ec1f9ba57b02fe12a6fa5f141206d439ba3d044e

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>