Re: [PATCH net-next v3 2/9] net: devmem: charge the frag length to TX skb truesize

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit author and the Signed-off-by use different email
  addresses.

--

net: devmem: charge the frag length to TX skb truesize

This patch changes zerocopy_fill_skb_from_devmem() so each devmem TX frag
charges its length to skb->truesize, not PAGE_SIZE. TX net_iovs are about
to grow up to 2MB. Charging the net_iov size per frag could then fill the
send buffer with a single skb, and charging by length also matches what
TCP uncharges.

> Author: Stanislav Fomichev <sdf.kernel@gmail.com>

[ ... ]

>     Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>

[Severity: Low]
This isn't a bug, but the author address and the Signed-off-by address are
different.

The author is sdf.kernel@gmail.com, and the only Signed-off-by is
sdf@fomichev.me. The body has no in-body From: line to override the
authorship.

The .mailmap entries for sdf@fomichev.me only map sdf@google.com and
stfomichev@gmail.com, so tools that read .mailmap won't match the two
either. checkpatch.pl reports this as "From:/Signed-off-by: email address
mismatch".

The other patches in the series appear to have the same mismatch. Could the
git author identity be updated, or a matching From: line added, before
resending?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261105222058.944293-1-sdf%40fomichev.me