Re: [PATCH net-next v3 9/9] selftests: drv-net: devmem: TX from a hugepage-backed dmabuf

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit author is "Stanislav Fomichev <sdf.kernel@gmail.com>"
  but the only Signed-off-by is "Stanislav Fomichev <sdf@fomichev.me>".

--

selftests: drv-net: devmem: TX from a hugepage-backed dmabuf

This commit adds a -H option to ncdevmem that backs the udmabuf with 2MB
hugepages. It also adds a TX test that sends a 3MB buffer from that
dmabuf, so frags end at the 2MB net_iov boundary and continue past it.
The payload repeats every 7 bytes so that offset errors are caught.

> Author: Stanislav Fomichev <sdf.kernel@gmail.com>
> ...
> Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>

[Severity: Low]
This isn't a bug, but the author address doesn't match the Signed-off-by
address. The author is sdf.kernel@gmail.com, and the only sign-off is from
sdf@fomichev.me.

checkpatch.pl reports this as FROM_SIGN_OFF_MISMATCH ("From:/Signed-off-by:
email address mismatch"), and the netdev automated checks will flag it too.

Could a Signed-off-by be added for the author address? Alternatively, an
in-body "From: Stanislav Fomichev <sdf@fomichev.me>" line would make the
author match the sign-off.

Every commit in the series has the same mismatch, from "bnxt_en: let the
stack segment GSO skbs with too many frags" through this one. It probably
comes from how the series was sent, so the fix would need to go into every
patch.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261105222058.944293-1-sdf%40fomichev.me