From: "tip-bot2 for Zhan Xusheng" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Zhan Xusheng <zhanxusheng@xiaomi.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Qais Yousef <qyousef@layalina.io>,
Chen Yu <yu.c.chen@intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/cache: Don't use fits_capacity() to compare thread and CPU counts
Date: Mon, 09 Nov 2026 09:28:56 -0000 [thread overview]
Message-ID: <179421653682.2093942.9506608994284902524.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20261102021536.1026143-1-zhanxusheng1024@gmail.com>
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 78b47fb995b5f3e7e54f0bde365063b530299726
Gitweb: https://git.kernel.org/tip/78b47fb995b5f3e7e54f0bde365063b530299726
Author: Zhan Xusheng <zhanxusheng@xiaomi.com>
AuthorDate: Mon, 02 Nov 2026 10:15:36 +08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Mon, 09 Nov 2026 10:09:27 +01:00
sched/cache: Don't use fits_capacity() to compare thread and CPU counts
invalid_llc_nr() uses fits_capacity() to compare a thread count with a
CPU count, only for its 20% margin. Qais's series changes
fits_capacity() to take a CPU number as its second argument, and this
call would then pass the CPU count as a CPU number without a warning.
Give the check its own helper. x * 5 < y * 4 is the same comparison as
x * 1280 < y * 1024, so there is no functional change.
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Qais Yousef <qyousef@layalina.io>
Reviewed-by: Chen Yu <yu.c.chen@intel.com>
Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
Link: https://lore.kernel.org/all/20260504020003.71306-5-qyousef@layalina.io/
Link: https://patch.msgid.link/20261102021536.1026143-1-zhanxusheng1024@gmail.com
---
kernel/sched/fair.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 79f6b3a..0c8af1c 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1469,6 +1469,12 @@ static bool exceed_llc_capacity(struct sched_cache_group *grp, int cpu)
return false;
}
+/* Are the running threads (in SMT siblings) below ~80% of the LLC's CPUs? */
+static inline bool fits_llc_nr(u64 nr_threads, unsigned int nr_cpus)
+{
+ return nr_threads * 5 < (u64)nr_cpus * 4;
+}
+
static bool invalid_llc_nr(struct sched_cache_group *grp, struct task_struct *p,
int cpu)
{
@@ -1485,8 +1491,8 @@ static bool invalid_llc_nr(struct sched_cache_group *grp, struct task_struct *p,
if (scale == INT_MAX)
return false;
- return !fits_capacity((READ_ONCE(grp->nr_running_avg) * cpu_smt_num_threads),
- (scale * per_cpu(sd_llc_size, cpu)));
+ return !fits_llc_nr(READ_ONCE(grp->nr_running_avg) * cpu_smt_num_threads,
+ scale * per_cpu(sd_llc_size, cpu));
}
/*
prev parent reply other threads:[~2026-11-09 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 2:15 [PATCH] " Zhan Xusheng
2026-11-03 1:31 ` Qais Yousef
2026-11-03 2:24 ` Chen Yu
2026-11-03 21:07 ` Tim Chen
2026-11-03 2:27 ` Chen Yu
2026-11-03 18:30 ` Tim Chen
2026-11-03 18:34 ` Tim Chen
2026-11-09 8:38 ` [tip: sched/urgent] " tip-bot2 for Zhan Xusheng
2026-11-09 9:28 ` tip-bot2 for Zhan Xusheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179421653682.2093942.9506608994284902524.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®