From: Niklas Cassel <cassel@kernel.org>
To: dlemoal@kernel.org, hansg@kernel.org, linux-ide@vger.kernel.org,
shao.mingyin@zte.com.cn
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] ata: remove dead checks and redundant code
Date: Mon, 09 Nov 2026 21:29:17 +0100 [thread overview]
Message-ID: <179425615780.1643572.14054800803860937480.b4-ty@kernel.org> (raw)
In-Reply-To: <20261104211432688UOs4v84BESagMmLFH30Er@zte.com.cn>
On Wed, 04 Nov 2026 21:14:32 +0800, shao.mingyin@zte.com.cn wrote:
> This series removes two checks that the surrounding code already
> guarantees and folds five duplicated cleanup paths in
> zpodd_get_mech_type() into one. It was found while reading libata.
> There is no functional change intended; every patch is independent and
> can be applied on its own or as any subset.
>
> Patch 1 drops a test that is constant-false at compile time.
> SATA_PMP_GSCR_DWORDS is 128, so "SATA_PMP_GSCR_DWORDS & 3" is zero and
> the loop already terminates every fourth dword with a newline.
>
> [...]
Applied to libata/linux.git (for-7.5), thanks!
[1/3] ata: libata-transport: drop the dead GSCR newline check
https://git.kernel.org/libata/linux/c/f6e285e1
[2/3] ata: libahci_platform: drop the dead error check
https://git.kernel.org/libata/linux/c/54bd1984
[3/3] ata: libata-zpodd: use a single exit in zpodd_get_mech_type()
https://git.kernel.org/libata/linux/c/3a533a66
Kind regards,
Niklas
prev parent reply other threads:[~2026-11-09 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 13:14 shao.mingyin
2026-11-04 13:14 ` [PATCH 1/3] ata: libata-transport: drop the dead GSCR newline check shao.mingyin
2026-11-05 3:12 ` Damien Le Moal
2026-11-04 13:14 ` [PATCH 2/3] ata: libahci_platform: drop the dead error check shao.mingyin
2026-11-05 3:12 ` Damien Le Moal
2026-11-04 13:14 ` [PATCH 3/3] ata: libata-zpodd: use a single exit in zpodd_get_mech_type() shao.mingyin
2026-11-05 3:13 ` Damien Le Moal
2026-11-09 20:29 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179425615780.1643572.14054800803860937480.b4-ty@kernel.org \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hansg@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shao.mingyin@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®