* [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips
@ 2026-11-06 7:21 Birger Koblitz
2026-11-06 7:21 ` [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt Birger Koblitz
` (12 more replies)
0 siblings, 13 replies; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz, Nicolai Buchwitz
This adds support for the current generation of ASIX network adapter chips,
which are based on the AX88179A. This includes the AX88179A/B (1GBit-PHY),
AX88772D/E (100MBit) and AX88279 (2.5GBit).
The AX179A-based chips all provide both a CDC-NCM compatible USB interface,
and a proprietary vendor interface with more features. By default, the
proprietary vendor interface is not active and Linux will load the CDC-NCM
driver to support the devices. If the ax88179_178a module is configured by
the OS to have precedence over CDC-NCM, then this driver will switch the
device to use the vendor interface, and the device will be controlled by
the ax88179_178a driver when the device is probed again after an automatic
reset of the device bringing up the vendor interface.
The following hardware was tested:
Delock 66046 2.5GBit adapter (AX88279, FW: 1.2.0.0)
TP-Link UE306 1GBit adapter (AX88179B, FW: 1.3.0.0)
Renkforce RF-4708614 1GBit adapter (AX88179A, FW: 1.0.4.0)
UGREEN CR110 100MBit adapter (AX88722E, FW: 1.3.0.0)
The driver supports the following features
- EEE
- TCP segmentation offload
- VLAN filtering/tagging offload
(NETIF_F_HW_VLAN_CTAG_FILTER, NETIF_F_HW_VLAN_CTAG_RX/TX)
- RX/TX checksum offload
- FC/Pause configuration
- EEPROM read access
The code is based on the ASIX 4.1.0 out-of-tree driver published under
the GPL,, the aqc111 driver which provides support for the AX88279A,
and some tracing of USB-transfers of the Windows-driver.
Tested-by: Jianhui Xu <neuromoments@gmail.com>
Tested-by: Emir Beganovic <beganovic.emir@gmail.com>
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
---
Changes in v20:
- fixed goto-label being called in patch before label defined in later patch
- Link to v19: https://lore.kernel.org/r/20261010-ax88179a-v19-0-7475173cfb56@birger-koblitz.de
Changes in v19:
- Use WRITE_ONCE to set net->mtu and move before changing JUMBO-register flag
- Set TX-Offload HW flags depending on dev->net->features at reset
- In ax88179_set_features() init stack variables to prevent leaking stack memory
to device
- Fix back writing of VLAN table using Write-Execute bit, add futher comments
and make sure VFE and VSO bits are preserved
- Make manipulating data->rxctl in ax88179_set_multicast() atomic
- Include include phylink_resume() in error-exit path of suspend(()
- Exclude setting MAC-address in resume path in ax88179a_reset()
- Ensure to restart auto-negotiation if a user only changes the
2.5G advertisement bit
- Link to v18: https://lore.kernel.org/r/20261008-ax88179a-v18-0-6fa1d4c40422@birger-koblitz.de
Changes in v18:
- Add also check for PHY_BROKEN_FORCED in phy_mii_ioctl() to prevent
users to circumvent check via ioctl.
- Do not unconditionally dereference phydev->drv when it might be NULL
in phy_ethtool_ksettings_set()
- Fix RTNL deadlock accessing mtu-settings by using dedicated lock for mtu access
- Use get_unaligned_le64() instead of le64_to_cpup() to
support older architectures
- Add check for skb_cloned() before buffer resize
- Add explicit handling of disabling of NETIF_F_HW_VLAN_CTAG_FILTER
- Fix clobbering of AX_VLAN_CONTROL_VFE bit when setting AX_VLAN_CONTROL_WE
- Do no longer use XOR to change AX_VLAN_CONTROL_VFE by conditional clear/set
of bit in if/else block to prevent theoretical de-synching of bit and OS state
- Make sure interface is enabled when resuming phylink in suspend error-path
- Fix leaking in_pm / unbalanced suspend_count in suspend error-path
- Add pm_runtime_put_noidle() to unbind()
- Reorder setting MII_ADVERTISE and genphy_config_aneg()
- Remove possible 1000M-bits reported by AX88772D when reading MII_ESTATUS
- Link to v17: https://lore.kernel.org/r/20261006-ax88179a-v17-0-252814fe35ea@birger-koblitz.de
Changes in v17:
- Fix clang warnings from kernel-robot
- Link to v16: https://lore.kernel.org/r/20261004-ax88179a-v16-0-2a9ae4e68f7b@birger-koblitz.de
Changes in v16:
- Fix error-checking in VLAN-offload code
as Suggested-by: Jianhui Xu <neuromoments@gmail.com>
- Link to v15: https://lore.kernel.org/r/20261002-ax88179a-v15-0-131d9286fcd7@birger-koblitz.de
Changes in v15:
- Removed already committed patch fixing pause watermark register
endianess
- Rebased
- Link to v14: https://lore.kernel.org/r/20260929-ax88179a-v14-0-a1f2249e42ea@birger-koblitz.de
Changes in v14:
- Fix return value handling in VLAN offload functions
- Add explanatory comment for phylink_mac_interrupt()
- Link to v13: https://lore.kernel.org/r/20260927-ax88179a-v13-0-4fac6b3e032e@birger-koblitz.de
Changes in v13:
- Add MODULE_ALIAS to ax88179_178a
- Squashed commit adding netdev2data() into the first one needing it
- Add wrappers ax88179_write_u8/ax88179_write_u16
- Use FIELD_GET() FIELD_PREP() in fixups.
- Add guard for phydev->drv NULL in phy_ethtool_ksettings_set()
- Various endianess fixes in fixups
- Add error checking for too small packets in ax88179a_rx_fixup
- Typo fixed: ax88179_read_cmd -> ax88179_write_cmd setting PHY power
- Changed call to usbnet_nway_reset by phy_ethtool_nway_reset
- ax88179a_bulkin_config() handles FS USB now for all chip versions
- Use phylink versions of calls for get/set_link_ksettings
- Add handling of return values of ax88179_read_cmd() in various places
- Removed usbnet_link_change(dev, 0, 0); at the end of ax88179a_reset().
- Add RTLN-lock to protect AX_MEDIUM_STATUS_MODE register,
WRITE_ONCE/READONCE for rxctl.
- Changed to clearing AX_XGMII_EN for all speeds != SPEED_2500 independent
of chip-id.
- Fix access to AX88179A_MAC_RX_DATA_CDC_CNT by using 2 1-byte writes.
- In ax88179a_mac_link_up initialize link_status.
- Added setting of AX_GPHY_EEE_CTRL to disabled in ax88179a_reset(),
consistent with phylink default.
- Various commit messages fixed
- Conditionally set AX_VLAN_CONTROL_VFE after loop over the VLAN-entries
- Moved code in wrong commits to the right ones (2x).
- Fix races around rx_checksum flag setting.
- Suspend/resume fixes: correct sequence of WoL settings and usbnet/phylink
suspend calls.
- Read revision number into the 4th field of software version
- Kconfig descriptiona and module description mention 2.5GBit
- Fix orphaned defconfigs
- Fix EEPROM access settings derived from chip versions
- Fix EEPROM read error checking
- Return value checking in asix_ax88279_read_status()
- Added clearing of ETHTOOL_LINK_MODE_2500baseT_Full_BIT in lp_advertising
before modifying the bit.
- In asix_ax88279_read_status() add if (!phydev->link) guard
- Linkmode cleaning code shortened.
- Link to v12: https://lore.kernel.org/r/20260916-ax88179a-v12-0-60c04c9924a2@birger-koblitz.de
Changes in v12:
- Fix BCD ranges for USB device detection
- Free SKB in ax88179a_tx_fixup() when skb_linearize() fails
- Use phylink_mii_ioctl instead of usbnet_mii_ioctl
- Link to v11: https://lore.kernel.org/r/20260914-ax88179a-v11-0-5ea7a925ba6d@birger-koblitz.de
Changes in v11:
- Fix sparse warnings
- Link to v10: https://lore.kernel.org/r/20260904-ax88179a-v10-0-b5e60eca7690@birger-koblitz.de
Changes in v10:
- Fix missing variable declaration in ax88179a_status()
- Add reviewed-bys
- Link to v9: https://lore.kernel.org/r/20260902-ax88179a-v9-0-8e6d7710a2ae@birger-koblitz.de
Changes in v9:
- Fix ax88179a_status() to not call carrier-related netif or usbnet methods
- Use genphy_read_mmd_c45() and genphy_write_mmd_c45()
- Link to v8: https://lore.kernel.org/r/20260831-ax88179a-v8-0-de905f2ee426@birger-koblitz.de
Changes in v8:
- Fix resume sequence as Suggested-by: Jianhui Xu <neuromoments@gmail.com>
- Add handling of PHYs with broken forced mode in phylib to handle AX88279 PHY
- Multple formatting fixes
- Fix transiently unused functions ax88179a_mac_disable_tx_lpi() and
ax88179a_mac_enable_tx_lpi()
- Removed unnecessary checks for dev initialized
- Link to v7: https://lore.kernel.org/r/20260810-ax88179a-v7-0-da633191c129@birger-koblitz.de
Changes in v7:
- Add phylink_mac_interrupt() function to phylink and stop
polling the PHY to prevent a race condition between the controller
and phylink when configuring a new link.
- Fix typo in ax88179_read_cmd Reported-by: Jianhui Xu <neuromoments@gmail.com>
- Return -EOPNOTSUPP in asix_ax88279_config_aneg when autoneg is being disabled
- Link to v6: https://lore.kernel.org/r/20260806-ax88179a-v6-0-fde7414619e6@birger-koblitz.de
Changes in v6:
- Use genphy_read_status() in asix_ax88279_read_status()
- Use SGMII and 2500BaseX interfaces for PHY
- Fix speed determination of MAC/PHY link
- Fix bulk transfer configuration to use enums for bulk configuration types
- Link to v5: https://lore.kernel.org/r/20260802-ax88179a-v5-0-dcb9fea4acd4@birger-koblitz.de
Changes in v5:
- Fixed read_status() and config_aneg() in PHY driver
- Introduced netdev2data() as convenience function
- netdev_info instances and debugging relicts removed
- Several instances of badly written/formatted code that was copy and pasted from
the original driver corrected
- select PHYLINK added to Kconfig when phylib dependency added
- PHYLINK selects PHYLIB, so not needed to specify separately
- Link to v4: https://lore.kernel.org/r/20260731-ax88179a-v4-0-2cf1f71b1dd2@birger-koblitz.de
Changes in v4:
- Split driver into library part and part2 for AX88179 and AX88179A-based
controllers
- Driver renamed ax88179
- Improved phylink use: use phylink standard functions for speed and EEE-settings,
correct MAC capabilities, removed ax88179_status() irq-urb callback
- Fixes in PHY driver for AX88179A integrated PHYs
- Link to v3: https://lore.kernel.org/r/20260724-ax88179a-v3-0-bdde4f905883@birger-koblitz.de
Changes in v3:
- Add PHY drivers for the PHYs of the AX88179A-based controllers
- Use phylink for the AX88179A-based chips
- Link to v2: https://lore.kernel.org/r/20260708-ax88179a-v2-0-0800fedb2e16@birger-koblitz.de
Changes in v2:
- Correctly use net-next prefix
- Fix compilation issue in HW support patch
- Split MMD support patch into patches for EEE/new chip support
- Do not use ADVERTISE_RESV but private flag definition
- Fix pause configuration to keep track of settings when autoneg disabled
- Fix issue with unitialized variable reported by kernel test robot <lkp@intel.com>
- Avoid white-space changes
- Link to v1: https://lore.kernel.org/r/20260701-ax88179a-v1-0-13685df67515@birger-koblitz.de
---
Birger Koblitz (13):
phylink: Add phylink_mac_interrupt
phylib: Add support for PHYs with broken forced mode
ax88179_178a: Split driver into library and device specific code
ax88179_178a: Add HW support for AX179A-based chips
ax88179_178a: Add EEE configuration support for AX88179A MACs
ax88179_178a: Add EEE configuration support for AX88179A PHYs
ax88179_178a: Add VLAN offload support for AX88179A
ax88179_178a: Add AX179A/AX279 multicast configuration
ax88179_178a: Add Suspend/resume support for AX88179A/772D/279
ax88179_178a: Add ethtool get_drvinfo
ax88179_178a: Update driver name and information
ax88179_178a: Add support for AX88179A/772D/279 EEPROM access
ax88796b: Add support for AX88772D, AX88179A and AX88279
MAINTAINERS | 6 +
arch/loongarch/configs/loongson32_defconfig | 2 +-
arch/loongarch/configs/loongson64_defconfig | 2 +-
drivers/net/phy/ax88796b.c | 165 ++++
drivers/net/phy/phy.c | 7 +
drivers/net/phy/phylink.c | 20 +
drivers/net/usb/Kconfig | 10 +-
drivers/net/usb/Makefile | 3 +-
drivers/net/usb/ax88179_178a.c | 661 +-------------
drivers/net/usb/ax88179_lib.c | 546 +++++++++++
drivers/net/usb/ax88179_lib.h | 360 ++++++++
drivers/net/usb/ax88179a_devices.c | 1311 +++++++++++++++++++++++++++
include/linux/phy.h | 1 +
include/linux/phylink.h | 1 +
14 files changed, 2472 insertions(+), 623 deletions(-)
---
base-commit: 6584acd42820478910a771efb28a355a707e9cb0
change-id: 20260630-ax88179a-a1d89fe21730
Best regards,
--
Birger Koblitz <mail@birger-koblitz.de>
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-06 10:11 ` Maxime Chevallier
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 02/13] phylib: Add support for PHYs with broken forced mode Birger Koblitz
` (11 subsequent siblings)
12 siblings, 2 replies; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz, Nicolai Buchwitz
Add the phylink_mac_interrupt() function to phylink, which
passes a link-change interrupt received by the MAC to phylib.
This function can be used by drivers which want to avoid
polling the PHY and instead rely on an interrupt received by
the MAC when a link-change happens.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
---
drivers/net/phy/phylink.c | 20 ++++++++++++++++++++
include/linux/phylink.h | 1 +
2 files changed, 21 insertions(+)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index e885da1c28311a12a869e29ceb3c96886f31adc6..a87eaa2f3db5bef8fe56e12b90375bdb7f9c52e7 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -1616,6 +1616,26 @@ static bool phylink_link_is_up(struct phylink *pl)
return pl->netdev ? netif_carrier_ok(pl->netdev) : pl->old_link_state;
}
+/**
+ * phylink_mac_interrupt() - wrapper for phy_mac_interrupt()
+ * @pl: a pointer to a &struct phylink returned from phylink_create()
+ *
+ * Passes a link-change interrupt received by the MAC to phylib.
+ * This function may be called in interrupt context, and therefore cannot take
+ * a mutex. However, it is safe to assume that the reference to phy does not
+ * disappear during the call, as only an SFP module may be unplugged to make a
+ * PHY disappear. SFP modules however do not support interrupts.
+ */
+void phylink_mac_interrupt(struct phylink *pl)
+{
+ struct phy_device *phy;
+
+ phy = pl->phydev;
+ if (phy)
+ phy_mac_interrupt(phy);
+}
+EXPORT_SYMBOL_GPL(phylink_mac_interrupt);
+
static void phylink_resolve(struct work_struct *w)
{
struct phylink *pl = container_of(w, struct phylink, resolve);
diff --git a/include/linux/phylink.h b/include/linux/phylink.h
index 3a88a69882a610afb868b55df6f6e77aea918649..a7b6294cc4a075bd2aaa43ed6484de17a6cb88b1 100644
--- a/include/linux/phylink.h
+++ b/include/linux/phylink.h
@@ -768,6 +768,7 @@ int phylink_ethtool_set_eee(struct phylink *link, struct ethtool_keee *eee);
int phylink_mii_ioctl(struct phylink *, struct ifreq *, int);
int phylink_speed_down(struct phylink *pl, bool sync);
int phylink_speed_up(struct phylink *pl);
+void phylink_mac_interrupt(struct phylink *pl);
#define phylink_zero(bm) \
bitmap_zero(bm, __ETHTOOL_LINK_MODE_MASK_NBITS)
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 02/13] phylib: Add support for PHYs with broken forced mode
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-11-06 7:21 ` [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-06 7:21 ` [PATCH net-next v20 03/13] ax88179_178a: Split driver into library and device specific code Birger Koblitz
` (10 subsequent siblings)
12 siblings, 0 replies; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz, Nicolai Buchwitz
Add support for PHYs which only supported auto-negotiated
speed modes. This prevents a kernel warning and stack-trace within the
phy_state_machine when PHYs return -EOPNOTSUPP from config_aneg()
because they do not support forced modes.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
---
drivers/net/phy/phy.c | 7 +++++++
include/linux/phy.h | 1 +
2 files changed, 8 insertions(+)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index fce9bc7be3304b408c9f3ec9b5b95c76d3680a88..079c53516f424ca5f8d50292f1912af04b45b07a 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -354,6 +354,9 @@ int phy_mii_ioctl(struct phy_device *phydev, struct ifreq *ifr, int cmd)
switch (devad) {
case MII_BMCR:
if ((val & (BMCR_RESET | BMCR_ANENABLE)) == 0) {
+ if (phydev->drv &&
+ (phydev->drv->flags & PHY_BROKEN_FORCED))
+ return -EOPNOTSUPP;
if (phydev->autoneg == AUTONEG_ENABLE)
change_autoneg = true;
phydev->autoneg = AUTONEG_DISABLE;
@@ -1190,6 +1193,10 @@ int phy_ethtool_ksettings_set(struct phy_device *phydev,
duplex != DUPLEX_FULL)))
return -EINVAL;
+ if (autoneg == AUTONEG_DISABLE && phydev->drv &&
+ (phydev->drv->flags & PHY_BROKEN_FORCED))
+ return -EOPNOTSUPP;
+
mutex_lock(&phydev->lock);
phydev->autoneg = autoneg;
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 21afc2082b1741ff276a9588246c2f98351464f5..f1b1ad1dd82f5c51ddd2f0759666e17802894c96 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -64,6 +64,7 @@ extern const int phy_basic_ports_array[3];
#define PHY_RST_AFTER_CLK_EN 0x00000002
#define PHY_POLL_CABLE_TEST 0x00000004
#define PHY_ALWAYS_CALL_SUSPEND 0x00000008
+#define PHY_BROKEN_FORCED 0x00000010
#define MDIO_DEVICE_IS_PHY 0x80000000
/**
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 03/13] ax88179_178a: Split driver into library and device specific code
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-11-06 7:21 ` [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt Birger Koblitz
2026-11-06 7:21 ` [PATCH net-next v20 02/13] phylib: Add support for PHYs with broken forced mode Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 04/13] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
` (9 subsequent siblings)
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz, Nicolai Buchwitz
Split the ax88179_178a module code into code common to the
AX88179/178a/179a and 279 family of controllers and device
specific code for the currently supported devices based
on the AX88179 and AX88178a.
Rename the module to ax88179 to reflect the broader scope of
controllers supported by the module and add an alias to the old
module name:
MODULE_ALIAS("ax88179_178a");
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
---
drivers/net/usb/Makefile | 3 +-
drivers/net/usb/ax88179_178a.c | 613 +----------------------------------------
drivers/net/usb/ax88179_lib.c | 461 +++++++++++++++++++++++++++++++
drivers/net/usb/ax88179_lib.h | 195 +++++++++++++
4 files changed, 661 insertions(+), 611 deletions(-)
diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile
index 4964f7b326fbcedffc1e5a1bf004aea95560db8c..ddd76fa71e2ee670888df1c9715632e5c04a8149 100644
--- a/drivers/net/usb/Makefile
+++ b/drivers/net/usb/Makefile
@@ -12,7 +12,8 @@ obj-$(CONFIG_USB_HSO) += hso.o
obj-$(CONFIG_USB_LAN78XX) += lan78xx.o
obj-$(CONFIG_USB_NET_AX8817X) += asix.o
asix-y := asix_devices.o asix_common.o ax88172a.o
-obj-$(CONFIG_USB_NET_AX88179_178A) += ax88179_178a.o
+obj-$(CONFIG_USB_NET_AX88179_178A) += ax88179.o
+ax88179-y := ax88179_178a.o ax88179_lib.o
obj-$(CONFIG_USB_NET_CDCETHER) += cdc_ether.o
obj-$(CONFIG_USB_NET_CDC_EEM) += cdc_eem.o
obj-$(CONFIG_USB_NET_DM9601) += dm9601.o
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index c179e2319081738d1d342c808578772b7ef9b36c..55268d0890d1200be07b87f2dc9e62d2d7b69fc1 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -8,179 +8,12 @@
#include <linux/module.h>
#include <linux/etherdevice.h>
#include <linux/mii.h>
-#include <linux/usb.h>
-#include <linux/crc32.h>
-#include <linux/usb/usbnet.h>
#include <uapi/linux/mdio.h>
#include <linux/mdio.h>
-
-#define AX88179_PHY_ID 0x03
-#define AX_EEPROM_LEN 0x100
-#define AX88179_EEPROM_MAGIC 0x17900b95
-#define AX_MCAST_FLTSIZE 8
-#define AX_MAX_MCAST 64
-#define AX_INT_PPLS_LINK ((u32)BIT(16))
-#define AX_RXHDR_L4_TYPE_MASK 0x1c
-#define AX_RXHDR_L4_TYPE_UDP 4
-#define AX_RXHDR_L4_TYPE_TCP 16
-#define AX_RXHDR_L3CSUM_ERR 2
-#define AX_RXHDR_L4CSUM_ERR 1
-#define AX_RXHDR_CRC_ERR ((u32)BIT(29))
-#define AX_RXHDR_DROP_ERR ((u32)BIT(31))
-#define AX_ACCESS_MAC 0x01
-#define AX_ACCESS_PHY 0x02
-#define AX_ACCESS_EEPROM 0x04
-#define AX_ACCESS_EFUS 0x05
-#define AX_RELOAD_EEPROM_EFUSE 0x06
-#define AX_PAUSE_WATERLVL_LOW 0x54
-#define AX_PAUSE_WATERLVL_HIGH 0x55
-
-#define PHYSICAL_LINK_STATUS 0x02
- #define AX_USB_SS 0x04
- #define AX_USB_HS 0x02
-
-#define GENERAL_STATUS 0x03
-/* Check AX88179 version. UA1:Bit2 = 0, UA2:Bit2 = 1 */
- #define AX_SECLD 0x04
-
-#define AX_SROM_ADDR 0x07
-#define AX_SROM_CMD 0x0a
- #define EEP_RD 0x04
- #define EEP_BUSY 0x10
-
-#define AX_SROM_DATA_LOW 0x08
-#define AX_SROM_DATA_HIGH 0x09
-
-#define AX_RX_CTL 0x0b
- #define AX_RX_CTL_DROPCRCERR 0x0100
- #define AX_RX_CTL_IPE 0x0200
- #define AX_RX_CTL_START 0x0080
- #define AX_RX_CTL_AP 0x0020
- #define AX_RX_CTL_AM 0x0010
- #define AX_RX_CTL_AB 0x0008
- #define AX_RX_CTL_AMALL 0x0002
- #define AX_RX_CTL_PRO 0x0001
- #define AX_RX_CTL_STOP 0x0000
-
-#define AX_NODE_ID 0x10
-#define AX_MULFLTARY 0x16
-
-#define AX_MEDIUM_STATUS_MODE 0x22
- #define AX_MEDIUM_GIGAMODE 0x01
- #define AX_MEDIUM_FULL_DUPLEX 0x02
- #define AX_MEDIUM_EN_125MHZ 0x08
- #define AX_MEDIUM_RXFLOW_CTRLEN 0x10
- #define AX_MEDIUM_TXFLOW_CTRLEN 0x20
- #define AX_MEDIUM_RECEIVE_EN 0x100
- #define AX_MEDIUM_PS 0x200
- #define AX_MEDIUM_JUMBO_EN 0x8040
-
-#define AX_MONITOR_MOD 0x24
- #define AX_MONITOR_MODE_RWLC 0x02
- #define AX_MONITOR_MODE_RWMP 0x04
- #define AX_MONITOR_MODE_PMEPOL 0x20
- #define AX_MONITOR_MODE_PMETYPE 0x40
-
-#define AX_GPIO_CTRL 0x25
- #define AX_GPIO_CTRL_GPIO3EN 0x80
- #define AX_GPIO_CTRL_GPIO2EN 0x40
- #define AX_GPIO_CTRL_GPIO1EN 0x20
-
-#define AX_PHYPWR_RSTCTL 0x26
- #define AX_PHYPWR_RSTCTL_BZ 0x0010
- #define AX_PHYPWR_RSTCTL_IPRL 0x0020
- #define AX_PHYPWR_RSTCTL_AT 0x1000
-
-#define AX_RX_BULKIN_QCTRL 0x2e
-#define AX_CLK_SELECT 0x33
- #define AX_CLK_SELECT_BCS 0x01
- #define AX_CLK_SELECT_ACS 0x02
- #define AX_CLK_SELECT_ULR 0x08
-
-#define AX_RXCOE_CTL 0x34
- #define AX_RXCOE_IP 0x01
- #define AX_RXCOE_TCP 0x02
- #define AX_RXCOE_UDP 0x04
- #define AX_RXCOE_TCPV6 0x20
- #define AX_RXCOE_UDPV6 0x40
-
-#define AX_TXCOE_CTL 0x35
- #define AX_TXCOE_IP 0x01
- #define AX_TXCOE_TCP 0x02
- #define AX_TXCOE_UDP 0x04
- #define AX_TXCOE_TCPV6 0x20
- #define AX_TXCOE_UDPV6 0x40
-
-#define AX_LEDCTRL 0x73
-
-#define GMII_PHY_PHYSR 0x11
- #define GMII_PHY_PHYSR_SMASK 0xc000
- #define GMII_PHY_PHYSR_GIGA 0x8000
- #define GMII_PHY_PHYSR_100 0x4000
- #define GMII_PHY_PHYSR_FULL 0x2000
- #define GMII_PHY_PHYSR_LINK 0x400
-
-#define GMII_LED_ACT 0x1a
- #define GMII_LED_ACTIVE_MASK 0xff8f
- #define GMII_LED0_ACTIVE BIT(4)
- #define GMII_LED1_ACTIVE BIT(5)
- #define GMII_LED2_ACTIVE BIT(6)
-
-#define GMII_LED_LINK 0x1c
- #define GMII_LED_LINK_MASK 0xf888
- #define GMII_LED0_LINK_10 BIT(0)
- #define GMII_LED0_LINK_100 BIT(1)
- #define GMII_LED0_LINK_1000 BIT(2)
- #define GMII_LED1_LINK_10 BIT(4)
- #define GMII_LED1_LINK_100 BIT(5)
- #define GMII_LED1_LINK_1000 BIT(6)
- #define GMII_LED2_LINK_10 BIT(8)
- #define GMII_LED2_LINK_100 BIT(9)
- #define GMII_LED2_LINK_1000 BIT(10)
- #define LED0_ACTIVE BIT(0)
- #define LED0_LINK_10 BIT(1)
- #define LED0_LINK_100 BIT(2)
- #define LED0_LINK_1000 BIT(3)
- #define LED0_FD BIT(4)
- #define LED0_USB3_MASK 0x001f
- #define LED1_ACTIVE BIT(5)
- #define LED1_LINK_10 BIT(6)
- #define LED1_LINK_100 BIT(7)
- #define LED1_LINK_1000 BIT(8)
- #define LED1_FD BIT(9)
- #define LED1_USB3_MASK 0x03e0
- #define LED2_ACTIVE BIT(10)
- #define LED2_LINK_1000 BIT(13)
- #define LED2_LINK_100 BIT(12)
- #define LED2_LINK_10 BIT(11)
- #define LED2_FD BIT(14)
- #define LED_VALID BIT(15)
- #define LED2_USB3_MASK 0x7c00
-
-#define GMII_PHYPAGE 0x1e
-#define GMII_PHY_PAGE_SELECT 0x1f
- #define GMII_PHY_PGSEL_EXT 0x0007
- #define GMII_PHY_PGSEL_PAGE0 0x0000
- #define GMII_PHY_PGSEL_PAGE3 0x0003
- #define GMII_PHY_PGSEL_PAGE5 0x0005
+#include "ax88179_lib.h"
static int ax88179_reset(struct usbnet *dev);
-struct ax88179_data {
- u8 eee_enabled;
- u8 eee_active;
- u16 rxctl;
- u8 in_pm;
- u32 wol_supported;
- u32 wolopts;
- u8 disconnecting;
-};
-
-struct ax88179_int_data {
- __le32 intdata1;
- __le32 intdata2;
-};
-
static const struct {
unsigned char ctrl, timer_l, timer_h, size, ifg;
} AX88179_BULKIN_SIZE[] = {
@@ -190,165 +23,6 @@ static const struct {
{7, 0xcc, 0x4c, 0x18, 8},
};
-static void ax88179_set_pm_mode(struct usbnet *dev, bool pm_mode)
-{
- struct ax88179_data *ax179_data = dev->driver_priv;
-
- ax179_data->in_pm = pm_mode;
-}
-
-static int ax88179_in_pm(struct usbnet *dev)
-{
- struct ax88179_data *ax179_data = dev->driver_priv;
-
- return ax179_data->in_pm;
-}
-
-static int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
- u16 size, void *data)
-{
- int ret;
- int (*fn)(struct usbnet *, u8, u8, u16, u16, void *, u16);
- struct ax88179_data *ax179_data = dev->driver_priv;
-
- BUG_ON(!dev);
-
- if (!ax88179_in_pm(dev))
- fn = usbnet_read_cmd;
- else
- fn = usbnet_read_cmd_nopm;
-
- ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
- value, index, data, size);
-
- if (unlikely((ret < 0) && !(ret == -ENODEV && ax179_data->disconnecting)))
- netdev_warn(dev->net, "Failed to read reg index 0x%04x: %d\n",
- index, ret);
-
- return ret;
-}
-
-static int __ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
- u16 size, const void *data)
-{
- int ret;
- int (*fn)(struct usbnet *, u8, u8, u16, u16, const void *, u16);
- struct ax88179_data *ax179_data = dev->driver_priv;
-
- BUG_ON(!dev);
-
- if (!ax88179_in_pm(dev))
- fn = usbnet_write_cmd;
- else
- fn = usbnet_write_cmd_nopm;
-
- ret = fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
- value, index, data, size);
-
- if (unlikely((ret < 0) && !(ret == -ENODEV && ax179_data->disconnecting)))
- netdev_warn(dev->net, "Failed to write reg index 0x%04x: %d\n",
- index, ret);
-
- return ret;
-}
-
-static void ax88179_write_cmd_async(struct usbnet *dev, u8 cmd, u16 value,
- u16 index, u16 size, void *data)
-{
- u16 buf;
-
- if (2 == size) {
- buf = *((u16 *)data);
- cpu_to_le16s(&buf);
- usbnet_write_cmd_async(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR |
- USB_RECIP_DEVICE, value, index, &buf,
- size);
- } else {
- usbnet_write_cmd_async(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR |
- USB_RECIP_DEVICE, value, index, data,
- size);
- }
-}
-
-static int ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
- u16 size, void *data)
-{
- int ret;
-
- if (2 == size) {
- u16 buf = 0;
- ret = __ax88179_read_cmd(dev, cmd, value, index, size, &buf);
- le16_to_cpus(&buf);
- *((u16 *)data) = buf;
- } else if (4 == size) {
- u32 buf = 0;
- ret = __ax88179_read_cmd(dev, cmd, value, index, size, &buf);
- le32_to_cpus(&buf);
- *((u32 *)data) = buf;
- } else {
- ret = __ax88179_read_cmd(dev, cmd, value, index, size, data);
- }
-
- return ret;
-}
-
-static int ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
- u16 size, const void *data)
-{
- int ret;
-
- if (2 == size) {
- u16 buf;
- buf = *((u16 *)data);
- cpu_to_le16s(&buf);
- ret = __ax88179_write_cmd(dev, cmd, value, index,
- size, &buf);
- } else {
- ret = __ax88179_write_cmd(dev, cmd, value, index,
- size, data);
- }
-
- return ret;
-}
-
-static void ax88179_status(struct usbnet *dev, struct urb *urb)
-{
- struct ax88179_int_data *event;
- u32 link;
-
- if (urb->actual_length < 8)
- return;
-
- event = urb->transfer_buffer;
- le32_to_cpus((void *)&event->intdata1);
-
- link = (((__force u32)event->intdata1) & AX_INT_PPLS_LINK) >> 16;
-
- if (netif_carrier_ok(dev->net) != link) {
- usbnet_link_change(dev, link, 1);
- if (!link)
- netdev_info(dev->net, "ax88179 - Link status is: 0\n");
- }
-}
-
-static int ax88179_mdio_read(struct net_device *netdev, int phy_id, int loc)
-{
- struct usbnet *dev = netdev_priv(netdev);
- u16 res;
-
- ax88179_read_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)loc, 2, &res);
- return res;
-}
-
-static void ax88179_mdio_write(struct net_device *netdev, int phy_id, int loc,
- int val)
-{
- struct usbnet *dev = netdev_priv(netdev);
- u16 res = (u16) val;
-
- ax88179_write_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)loc, 2, &res);
-}
-
static inline int ax88179_phy_mmd_indirect(struct usbnet *dev, u16 prtad,
u16 devad)
{
@@ -510,146 +184,11 @@ static void ax88179_disconnect(struct usb_interface *intf)
usbnet_disconnect(intf);
}
-static void
-ax88179_get_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
-{
- struct usbnet *dev = netdev_priv(net);
- struct ax88179_data *priv = dev->driver_priv;
-
- wolinfo->supported = priv->wol_supported;
- wolinfo->wolopts = priv->wolopts;
-}
-
-static int
-ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
-{
- struct usbnet *dev = netdev_priv(net);
- struct ax88179_data *priv = dev->driver_priv;
-
- if (wolinfo->wolopts & ~(priv->wol_supported))
- return -EINVAL;
-
- priv->wolopts = wolinfo->wolopts;
-
- return 0;
-}
-
static int ax88179_get_eeprom_len(struct net_device *net)
{
return AX_EEPROM_LEN;
}
-static int
-ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom,
- u8 *data)
-{
- struct usbnet *dev = netdev_priv(net);
- u16 *eeprom_buff;
- int first_word, last_word;
- int i, ret;
-
- if (eeprom->len == 0)
- return -EINVAL;
-
- eeprom->magic = AX88179_EEPROM_MAGIC;
-
- first_word = eeprom->offset >> 1;
- last_word = (eeprom->offset + eeprom->len - 1) >> 1;
- eeprom_buff = kmalloc_array(last_word - first_word + 1, sizeof(u16),
- GFP_KERNEL);
- if (!eeprom_buff)
- return -ENOMEM;
-
- /* ax88179/178A returns 2 bytes from eeprom on read */
- for (i = first_word; i <= last_word; i++) {
- ret = __ax88179_read_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2,
- &eeprom_buff[i - first_word]);
- if (ret < 0) {
- kfree(eeprom_buff);
- return -EIO;
- }
- }
-
- memcpy(data, (u8 *)eeprom_buff + (eeprom->offset & 1), eeprom->len);
- kfree(eeprom_buff);
- return 0;
-}
-
-static int
-ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom,
- u8 *data)
-{
- struct usbnet *dev = netdev_priv(net);
- u16 *eeprom_buff;
- int first_word;
- int last_word;
- int ret;
- int i;
-
- netdev_dbg(net, "write EEPROM len %d, offset %d, magic 0x%x\n",
- eeprom->len, eeprom->offset, eeprom->magic);
-
- if (eeprom->len == 0)
- return -EINVAL;
-
- if (eeprom->magic != AX88179_EEPROM_MAGIC)
- return -EINVAL;
-
- first_word = eeprom->offset >> 1;
- last_word = (eeprom->offset + eeprom->len - 1) >> 1;
-
- eeprom_buff = kmalloc_array(last_word - first_word + 1, sizeof(u16),
- GFP_KERNEL);
- if (!eeprom_buff)
- return -ENOMEM;
-
- /* align data to 16 bit boundaries, read the missing data from
- the EEPROM */
- if (eeprom->offset & 1) {
- ret = ax88179_read_cmd(dev, AX_ACCESS_EEPROM, first_word, 1, 2,
- &eeprom_buff[0]);
- if (ret < 0) {
- netdev_err(net, "Failed to read EEPROM at offset 0x%02x.\n", first_word);
- goto free;
- }
- }
-
- if ((eeprom->offset + eeprom->len) & 1) {
- ret = ax88179_read_cmd(dev, AX_ACCESS_EEPROM, last_word, 1, 2,
- &eeprom_buff[last_word - first_word]);
- if (ret < 0) {
- netdev_err(net, "Failed to read EEPROM at offset 0x%02x.\n", last_word);
- goto free;
- }
- }
-
- memcpy((u8 *)eeprom_buff + (eeprom->offset & 1), data, eeprom->len);
-
- for (i = first_word; i <= last_word; i++) {
- netdev_dbg(net, "write to EEPROM at offset 0x%02x, data 0x%04x\n",
- i, eeprom_buff[i - first_word]);
- ret = ax88179_write_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2,
- &eeprom_buff[i - first_word]);
- if (ret < 0) {
- netdev_err(net, "Failed to write EEPROM at offset 0x%02x.\n", i);
- goto free;
- }
- msleep(20);
- }
-
- /* reload EEPROM data */
- ret = ax88179_write_cmd(dev, AX_RELOAD_EEPROM_EFUSE, 0x0000, 0, 0, NULL);
- if (ret < 0) {
- netdev_err(net, "Failed to reload EEPROM data\n");
- goto free;
- }
-
- ret = 0;
-free:
- kfree(eeprom_buff);
- return ret;
-}
-
static int ax88179_get_link_ksettings(struct net_device *net,
struct ethtool_link_ksettings *cmd)
{
@@ -864,125 +403,6 @@ static const struct ethtool_ops ax88179_ethtool_ops = {
.get_ts_info = ethtool_op_get_ts_info,
};
-static void ax88179_set_multicast(struct net_device *net)
-{
- struct usbnet *dev = netdev_priv(net);
- struct ax88179_data *data = dev->driver_priv;
- u8 *m_filter = ((u8 *)dev->data);
-
- data->rxctl = (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_IPE);
-
- if (net->flags & IFF_PROMISC) {
- data->rxctl |= AX_RX_CTL_PRO;
- } else if (net->flags & IFF_ALLMULTI ||
- netdev_mc_count(net) > AX_MAX_MCAST) {
- data->rxctl |= AX_RX_CTL_AMALL;
- } else if (netdev_mc_empty(net)) {
- /* just broadcast and directed */
- } else {
- /* We use dev->data for our 8 byte filter buffer
- * to avoid allocating memory that is tricky to free later
- */
- u32 crc_bits;
- struct netdev_hw_addr *ha;
-
- memset(m_filter, 0, AX_MCAST_FLTSIZE);
-
- netdev_for_each_mc_addr(ha, net) {
- crc_bits = ether_crc(ETH_ALEN, ha->addr) >> 26;
- *(m_filter + (crc_bits >> 3)) |= (1 << (crc_bits & 7));
- }
-
- ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_MULFLTARY,
- AX_MCAST_FLTSIZE, AX_MCAST_FLTSIZE,
- m_filter);
-
- data->rxctl |= AX_RX_CTL_AM;
- }
-
- ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_RX_CTL,
- 2, 2, &data->rxctl);
-}
-
-static int
-ax88179_set_features(struct net_device *net, netdev_features_t features)
-{
- u8 tmp;
- struct usbnet *dev = netdev_priv(net);
- netdev_features_t changed = net->features ^ features;
-
- if (changed & NETIF_F_IP_CSUM) {
- ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
- tmp ^= AX_TXCOE_TCP | AX_TXCOE_UDP;
- ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
- }
-
- if (changed & NETIF_F_IPV6_CSUM) {
- ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
- tmp ^= AX_TXCOE_TCPV6 | AX_TXCOE_UDPV6;
- ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
- }
-
- if (changed & NETIF_F_RXCSUM) {
- ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp);
- tmp ^= AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP |
- AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6;
- ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp);
- }
-
- return 0;
-}
-
-static int ax88179_change_mtu(struct net_device *net, int new_mtu)
-{
- struct usbnet *dev = netdev_priv(net);
- u16 tmp16;
-
- WRITE_ONCE(net->mtu, new_mtu);
- dev->hard_mtu = net->mtu + net->hard_header_len;
-
- if (net->mtu > 1500) {
- ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
- 2, 2, &tmp16);
- tmp16 |= AX_MEDIUM_JUMBO_EN;
- ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
- 2, 2, &tmp16);
- } else {
- ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
- 2, 2, &tmp16);
- tmp16 &= ~AX_MEDIUM_JUMBO_EN;
- ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
- 2, 2, &tmp16);
- }
-
- /* max qlen depend on hard_mtu and rx_urb_size */
- usbnet_update_max_qlen(dev);
-
- return 0;
-}
-
-static int ax88179_set_mac_addr(struct net_device *net, void *p)
-{
- struct usbnet *dev = netdev_priv(net);
- struct sockaddr *addr = p;
- int ret;
-
- if (netif_running(net))
- return -EBUSY;
- if (!is_valid_ether_addr(addr->sa_data))
- return -EADDRNOTAVAIL;
-
- eth_hw_addr_set(net, addr->sa_data);
-
- /* Set the MAC address */
- ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN,
- ETH_ALEN, net->dev_addr);
- if (ret < 0)
- return ret;
-
- return 0;
-}
-
static const struct net_device_ops ax88179_netdev_ops = {
.ndo_open = usbnet_open,
.ndo_stop = usbnet_stop,
@@ -1249,35 +669,6 @@ static int ax88179_led_setting(struct usbnet *dev)
return 0;
}
-static void ax88179_get_mac_addr(struct usbnet *dev)
-{
- u8 mac[ETH_ALEN];
-
- memset(mac, 0, sizeof(mac));
-
- /* Maybe the boot loader passed the MAC address via device tree */
- if (!eth_platform_get_mac_address(&dev->udev->dev, mac)) {
- netif_dbg(dev, ifup, dev->net,
- "MAC address read from device tree");
- } else {
- ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN,
- ETH_ALEN, mac);
- netif_dbg(dev, ifup, dev->net,
- "MAC address read from ASIX chip");
- }
-
- if (is_valid_ether_addr(mac)) {
- eth_hw_addr_set(dev->net, mac);
- if (!is_local_ether_addr(mac))
- dev->net->addr_assign_type = NET_ADDR_PERM;
- } else {
- netdev_info(dev->net, "invalid MAC address, using random\n");
- }
-
- ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN,
- dev->net->dev_addr);
-}
-
static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
{
struct ax88179_data *ax179_data;
@@ -1292,6 +683,7 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
return -ENOMEM;
dev->driver_priv = ax179_data;
+ mutex_init(&ax179_data->medium_status_mutex);
dev->net->netdev_ops = &ax88179_netdev_ops;
dev->net->ethtool_ops = &ax88179_ethtool_ops;
@@ -1951,3 +1343,4 @@ module_usb_driver(ax88179_178a_driver);
MODULE_DESCRIPTION("ASIX AX88179/178A based USB 3.0/2.0 Gigabit Ethernet Devices");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("ax88179_178a");
diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
new file mode 100644
index 0000000000000000000000000000000000000000..063427ff55e42e38be1acb66806c0cdbe8e84347
--- /dev/null
+++ b/drivers/net/usb/ax88179_lib.c
@@ -0,0 +1,461 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * ASIX AX88179/178A USB 3.0/2.0 to Gigabit Ethernet Devices
+ *
+ * Copyright (C) 2011-2013 ASIX
+ */
+
+#include <linux/etherdevice.h>
+#include <linux/rtnetlink.h>
+#include "ax88179_lib.h"
+
+void ax88179_set_pm_mode(struct usbnet *dev, bool pm_mode)
+{
+ struct ax88179_data *ax179_data = dev->driver_priv;
+
+ ax179_data->in_pm = pm_mode;
+}
+
+static int ax88179_in_pm(struct usbnet *dev)
+{
+ struct ax88179_data *ax179_data = dev->driver_priv;
+
+ return ax179_data->in_pm;
+}
+
+int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
+ u16 size, void *data)
+{
+ int (*fn)(struct usbnet *dev, u8 cmd, u8 rtype, u16 val, u16 i, void *d, u16 size);
+ struct ax88179_data *ax179_data = dev->driver_priv;
+ int ret;
+
+ if (!ax88179_in_pm(dev))
+ fn = usbnet_read_cmd;
+ else
+ fn = usbnet_read_cmd_nopm;
+
+ ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
+ value, index, data, size);
+
+ if (unlikely(ret < 0 && !(ret == -ENODEV && ax179_data->disconnecting)))
+ netdev_warn(dev->net, "Failed to read reg index 0x%04x: %d\n",
+ index, ret);
+
+ return ret;
+}
+
+static int __ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value,
+ u16 index, u16 size, const void *data)
+{
+ int (*fn)(struct usbnet *dev, u8 cmd, u8 rtype, u16 val, u16 i, const void *d, u16 size);
+ struct ax88179_data *ax179_data = dev->driver_priv;
+ int ret;
+
+ if (!ax88179_in_pm(dev))
+ fn = usbnet_write_cmd;
+ else
+ fn = usbnet_write_cmd_nopm;
+
+ ret = fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
+ value, index, data, size);
+
+ if (unlikely(ret < 0 && !(ret == -ENODEV && ax179_data->disconnecting)))
+ netdev_warn(dev->net, "Failed to write reg index 0x%04x: %d\n",
+ index, ret);
+
+ return ret;
+}
+
+void ax88179_write_cmd_async(struct usbnet *dev, u8 cmd, u16 value,
+ u16 index, u16 size, void *data)
+{
+ u16 buf;
+
+ if (size == 2) {
+ buf = *((u16 *)data);
+ cpu_to_le16s(&buf);
+ usbnet_write_cmd_async(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR |
+ USB_RECIP_DEVICE, value, index, &buf,
+ size);
+ } else {
+ usbnet_write_cmd_async(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR |
+ USB_RECIP_DEVICE, value, index, data,
+ size);
+ }
+}
+
+int ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
+ u16 size, void *data)
+{
+ int ret;
+
+ if (size == 2) {
+ u16 buf = 0;
+
+ ret = __ax88179_read_cmd(dev, cmd, value, index, size, &buf);
+ le16_to_cpus(&buf);
+ *((u16 *)data) = buf;
+ } else if (size == 4) {
+ u32 buf = 0;
+
+ ret = __ax88179_read_cmd(dev, cmd, value, index, size, &buf);
+ le32_to_cpus(&buf);
+ *((u32 *)data) = buf;
+ } else {
+ ret = __ax88179_read_cmd(dev, cmd, value, index, size, data);
+ }
+
+ return ret;
+}
+
+int ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
+ u16 size, const void *data)
+{
+ int ret;
+
+ if (size == 2) {
+ u16 buf;
+
+ buf = *((u16 *)data);
+ cpu_to_le16s(&buf);
+ ret = __ax88179_write_cmd(dev, cmd, value, index,
+ size, &buf);
+ } else {
+ ret = __ax88179_write_cmd(dev, cmd, value, index,
+ size, data);
+ }
+
+ return ret;
+}
+
+void ax88179_status(struct usbnet *dev, struct urb *urb)
+{
+ struct ax88179_int_data *event;
+ u32 link;
+
+ if (urb->actual_length < 8)
+ return;
+
+ event = urb->transfer_buffer;
+ le32_to_cpus((void *)&event->intdata1);
+
+ link = (((__force u32)event->intdata1) & AX_INT_PPLS_LINK) >> 16;
+
+ if (netif_carrier_ok(dev->net) != link) {
+ usbnet_link_change(dev, link, 1);
+ if (!link)
+ netdev_info(dev->net, "ax88179 - Link status is: 0\n");
+ }
+}
+
+int ax88179_mdio_read(struct net_device *netdev, int phy_id, int loc)
+{
+ struct usbnet *dev = netdev_priv(netdev);
+ u16 res;
+
+ ax88179_read_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)loc, 2, &res);
+ return res;
+}
+
+void ax88179_mdio_write(struct net_device *netdev, int phy_id, int loc, int val)
+{
+ struct usbnet *dev = netdev_priv(netdev);
+ u16 res = (u16)val;
+
+ ax88179_write_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)loc, 2, &res);
+}
+
+void ax88179_get_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
+{
+ struct usbnet *dev = netdev_priv(net);
+ struct ax88179_data *priv = dev->driver_priv;
+
+ wolinfo->supported = priv->wol_supported;
+ wolinfo->wolopts = priv->wolopts;
+}
+
+int ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
+{
+ struct usbnet *dev = netdev_priv(net);
+ struct ax88179_data *priv = dev->driver_priv;
+
+ if (wolinfo->wolopts & ~(priv->wol_supported))
+ return -EINVAL;
+
+ priv->wolopts = wolinfo->wolopts;
+
+ return 0;
+}
+
+int ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8 *data)
+{
+ struct usbnet *dev = netdev_priv(net);
+ u16 *eeprom_buff;
+ int first_word, last_word;
+ int i, ret;
+
+ if (eeprom->len == 0)
+ return -EINVAL;
+
+ eeprom->magic = AX88179_EEPROM_MAGIC;
+
+ first_word = eeprom->offset >> 1;
+ last_word = (eeprom->offset + eeprom->len - 1) >> 1;
+ eeprom_buff = kmalloc_array(last_word - first_word + 1, sizeof(u16),
+ GFP_KERNEL);
+ if (!eeprom_buff)
+ return -ENOMEM;
+
+ /* ax88179/178A returns 2 bytes from eeprom on read */
+ for (i = first_word; i <= last_word; i++) {
+ ret = __ax88179_read_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2,
+ &eeprom_buff[i - first_word]);
+ if (ret < 0) {
+ kfree(eeprom_buff);
+ return -EIO;
+ }
+ }
+
+ memcpy(data, (u8 *)eeprom_buff + (eeprom->offset & 1), eeprom->len);
+ kfree(eeprom_buff);
+ return 0;
+}
+
+int ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8 *data)
+{
+ struct usbnet *dev = netdev_priv(net);
+ u16 *eeprom_buff;
+ int first_word;
+ int last_word;
+ int ret;
+ int i;
+
+ netdev_dbg(net, "write EEPROM len %d, offset %d, magic 0x%x\n",
+ eeprom->len, eeprom->offset, eeprom->magic);
+
+ if (eeprom->len == 0)
+ return -EINVAL;
+
+ if (eeprom->magic != AX88179_EEPROM_MAGIC)
+ return -EINVAL;
+
+ first_word = eeprom->offset >> 1;
+ last_word = (eeprom->offset + eeprom->len - 1) >> 1;
+
+ eeprom_buff = kmalloc_array(last_word - first_word + 1, sizeof(u16),
+ GFP_KERNEL);
+ if (!eeprom_buff)
+ return -ENOMEM;
+
+ /* align data to 16 bit boundaries, read the missing data from
+ * the EEPROM
+ */
+ if (eeprom->offset & 1) {
+ ret = ax88179_read_cmd(dev, AX_ACCESS_EEPROM, first_word, 1, 2,
+ &eeprom_buff[0]);
+ if (ret < 0) {
+ netdev_err(net, "Failed to read EEPROM at offset 0x%02x.\n", first_word);
+ goto free;
+ }
+ }
+
+ if ((eeprom->offset + eeprom->len) & 1) {
+ ret = ax88179_read_cmd(dev, AX_ACCESS_EEPROM, last_word, 1, 2,
+ &eeprom_buff[last_word - first_word]);
+ if (ret < 0) {
+ netdev_err(net, "Failed to read EEPROM at offset 0x%02x.\n", last_word);
+ goto free;
+ }
+ }
+
+ memcpy((u8 *)eeprom_buff + (eeprom->offset & 1), data, eeprom->len);
+
+ for (i = first_word; i <= last_word; i++) {
+ netdev_dbg(net, "write to EEPROM at offset 0x%02x, data 0x%04x\n",
+ i, eeprom_buff[i - first_word]);
+ ret = ax88179_write_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2,
+ &eeprom_buff[i - first_word]);
+ if (ret < 0) {
+ netdev_err(net, "Failed to write EEPROM at offset 0x%02x.\n", i);
+ goto free;
+ }
+ msleep(20);
+ }
+
+ /* reload EEPROM data */
+ ret = ax88179_write_cmd(dev, AX_RELOAD_EEPROM_EFUSE, 0x0000, 0, 0, NULL);
+ if (ret < 0) {
+ netdev_err(net, "Failed to reload EEPROM data\n");
+ goto free;
+ }
+
+ ret = 0;
+free:
+ kfree(eeprom_buff);
+ return ret;
+}
+
+void ax88179_set_multicast(struct net_device *net)
+{
+ struct usbnet *dev = netdev_priv(net);
+ struct ax88179_data *data = dev->driver_priv;
+ u8 *m_filter = ((u8 *)dev->data);
+
+ data->rxctl = (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_IPE);
+
+ if (net->flags & IFF_PROMISC) {
+ data->rxctl |= AX_RX_CTL_PRO;
+ } else if (net->flags & IFF_ALLMULTI ||
+ netdev_mc_count(net) > AX_MAX_MCAST) {
+ data->rxctl |= AX_RX_CTL_AMALL;
+ } else if (netdev_mc_empty(net)) {
+ /* just broadcast and directed */
+ } else {
+ /* We use dev->data for our 8 byte filter buffer
+ * to avoid allocating memory that is tricky to free later
+ */
+ u32 crc_bits;
+ struct netdev_hw_addr *ha;
+
+ memset(m_filter, 0, AX_MCAST_FLTSIZE);
+
+ netdev_for_each_mc_addr(ha, net) {
+ crc_bits = ether_crc(ETH_ALEN, ha->addr) >> 26;
+ *(m_filter + (crc_bits >> 3)) |= (1 << (crc_bits & 7));
+ }
+
+ ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_MULFLTARY,
+ AX_MCAST_FLTSIZE, AX_MCAST_FLTSIZE,
+ m_filter);
+
+ data->rxctl |= AX_RX_CTL_AM;
+ }
+
+ ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_RX_CTL,
+ 2, 2, &data->rxctl);
+}
+
+int ax88179_set_features(struct net_device *net, netdev_features_t features)
+{
+ u8 tmp;
+ struct usbnet *dev = netdev_priv(net);
+ netdev_features_t changed = net->features ^ features;
+
+ if (changed & NETIF_F_IP_CSUM) {
+ ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
+ tmp ^= AX_TXCOE_TCP | AX_TXCOE_UDP;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
+ }
+
+ if (changed & NETIF_F_IPV6_CSUM) {
+ ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
+ tmp ^= AX_TXCOE_TCPV6 | AX_TXCOE_UDPV6;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
+ }
+
+ if (changed & NETIF_F_RXCSUM) {
+ ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp);
+ tmp ^= AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP |
+ AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp);
+ }
+
+ return 0;
+}
+
+void ax88179_get_mac_addr(struct usbnet *dev)
+{
+ u8 mac[ETH_ALEN];
+
+ memset(mac, 0, sizeof(mac));
+
+ /* Maybe the boot loader passed the MAC address via device tree */
+ if (!eth_platform_get_mac_address(&dev->udev->dev, mac)) {
+ netif_dbg(dev, ifup, dev->net,
+ "MAC address read from device tree");
+ } else {
+ ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN,
+ ETH_ALEN, mac);
+ netif_dbg(dev, ifup, dev->net,
+ "MAC address read from ASIX chip");
+ }
+
+ if (is_valid_ether_addr(mac)) {
+ eth_hw_addr_set(dev->net, mac);
+ if (!is_local_ether_addr(mac))
+ dev->net->addr_assign_type = NET_ADDR_PERM;
+ } else {
+ netdev_info(dev->net, "invalid MAC address, using random\n");
+ }
+
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN,
+ dev->net->dev_addr);
+}
+
+int ax88179_change_mtu(struct net_device *net, int new_mtu)
+{
+ struct usbnet *dev = netdev_priv(net);
+ struct ax88179_data *data;
+ u16 tmp16;
+ int err;
+
+ data = dev->driver_priv;
+ mutex_lock(&data->medium_status_mutex);
+ WRITE_ONCE(net->mtu, new_mtu);
+ dev->hard_mtu = net->mtu + net->hard_header_len;
+ if (net->mtu > 1500) {
+ err = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
+ 2, 2, &tmp16);
+ if (err < 0)
+ goto err_out;
+ tmp16 |= AX_MEDIUM_JUMBO_EN;
+ err = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
+ 2, 2, &tmp16);
+ if (err < 0)
+ goto err_out;
+ } else {
+ err = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
+ 2, 2, &tmp16);
+ if (err < 0)
+ goto err_out;
+ tmp16 &= ~AX_MEDIUM_JUMBO_EN;
+ err = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
+ 2, 2, &tmp16);
+ if (err < 0)
+ goto err_out;
+ }
+ mutex_unlock(&data->medium_status_mutex);
+
+ /* max qlen depend on hard_mtu and rx_urb_size */
+ usbnet_update_max_qlen(dev);
+
+ return 0;
+
+err_out:
+ mutex_unlock(&data->medium_status_mutex);
+ return err;
+}
+
+int ax88179_set_mac_addr(struct net_device *net, void *p)
+{
+ struct usbnet *dev = netdev_priv(net);
+ struct sockaddr *addr = p;
+ int ret;
+
+ if (netif_running(net))
+ return -EBUSY;
+ if (!is_valid_ether_addr(addr->sa_data))
+ return -EADDRNOTAVAIL;
+
+ eth_hw_addr_set(net, addr->sa_data);
+
+ /* Set the MAC address */
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN,
+ ETH_ALEN, net->dev_addr);
+ if (ret < 0)
+ return ret;
+
+ return 0;
+}
+
diff --git a/drivers/net/usb/ax88179_lib.h b/drivers/net/usb/ax88179_lib.h
new file mode 100644
index 0000000000000000000000000000000000000000..9111a1395eb2f7208c7e90c93027845423bbda00
--- /dev/null
+++ b/drivers/net/usb/ax88179_lib.h
@@ -0,0 +1,195 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <linux/usb.h>
+#include <linux/crc32.h>
+#include <linux/usb/usbnet.h>
+
+#ifndef __LINUX_USBNET_AX88179_H
+#define __LINUX_USBNET_AX88179_H
+
+#define AX88179_PHY_ID 0x03
+#define AX_EEPROM_LEN 0x100
+#define AX88179_EEPROM_MAGIC 0x17900b95
+#define AX_MCAST_FLTSIZE 8
+#define AX_MAX_MCAST 64
+#define AX_INT_PPLS_LINK ((u32)BIT(16))
+#define AX_RXHDR_L4_TYPE_MASK 0x1c
+#define AX_RXHDR_L4_TYPE_UDP 4
+#define AX_RXHDR_L4_TYPE_TCP 16
+#define AX_RXHDR_L3CSUM_ERR 2
+#define AX_RXHDR_L4CSUM_ERR 1
+#define AX_RXHDR_CRC_ERR ((u32)BIT(29))
+#define AX_RXHDR_DROP_ERR ((u32)BIT(31))
+#define AX_ACCESS_MAC 0x01
+#define AX_ACCESS_PHY 0x02
+#define AX_ACCESS_EEPROM 0x04
+#define AX_ACCESS_EFUS 0x05
+#define AX_RELOAD_EEPROM_EFUSE 0x06
+#define AX_PAUSE_WATERLVL_LOW 0x54
+#define AX_PAUSE_WATERLVL_HIGH 0x55
+
+#define PHYSICAL_LINK_STATUS 0x02
+ #define AX_USB_SS 0x04
+ #define AX_USB_HS 0x02
+
+#define GENERAL_STATUS 0x03
+/* Check AX88179 version. UA1:Bit2 = 0, UA2:Bit2 = 1 */
+ #define AX_SECLD 0x04
+
+#define AX_SROM_ADDR 0x07
+#define AX_SROM_CMD 0x0a
+ #define EEP_RD 0x04
+ #define EEP_BUSY 0x10
+
+#define AX_SROM_DATA_LOW 0x08
+#define AX_SROM_DATA_HIGH 0x09
+
+#define AX_RX_CTL 0x0b
+ #define AX_RX_CTL_DROPCRCERR 0x0100
+ #define AX_RX_CTL_IPE 0x0200
+ #define AX_RX_CTL_START 0x0080
+ #define AX_RX_CTL_AP 0x0020
+ #define AX_RX_CTL_AM 0x0010
+ #define AX_RX_CTL_AB 0x0008
+ #define AX_RX_CTL_AMALL 0x0002
+ #define AX_RX_CTL_PRO 0x0001
+ #define AX_RX_CTL_STOP 0x0000
+
+#define AX_NODE_ID 0x10
+#define AX_MULFLTARY 0x16
+
+#define AX_MEDIUM_STATUS_MODE 0x22
+ #define AX_MEDIUM_GIGAMODE 0x01
+ #define AX_MEDIUM_FULL_DUPLEX 0x02
+ #define AX_MEDIUM_EN_125MHZ 0x08
+ #define AX_MEDIUM_RXFLOW_CTRLEN 0x10
+ #define AX_MEDIUM_TXFLOW_CTRLEN 0x20
+ #define AX_MEDIUM_RECEIVE_EN 0x100
+ #define AX_MEDIUM_PS 0x200
+ #define AX_MEDIUM_JUMBO_EN 0x8040
+
+#define AX_MONITOR_MOD 0x24
+ #define AX_MONITOR_MODE_RWLC 0x02
+ #define AX_MONITOR_MODE_RWMP 0x04
+ #define AX_MONITOR_MODE_PMEPOL 0x20
+ #define AX_MONITOR_MODE_PMETYPE 0x40
+
+#define AX_GPIO_CTRL 0x25
+ #define AX_GPIO_CTRL_GPIO3EN 0x80
+ #define AX_GPIO_CTRL_GPIO2EN 0x40
+ #define AX_GPIO_CTRL_GPIO1EN 0x20
+
+#define AX_PHYPWR_RSTCTL 0x26
+ #define AX_PHYPWR_RSTCTL_BZ 0x0010
+ #define AX_PHYPWR_RSTCTL_IPRL 0x0020
+ #define AX_PHYPWR_RSTCTL_AT 0x1000
+
+#define AX_RX_BULKIN_QCTRL 0x2e
+#define AX_CLK_SELECT 0x33
+ #define AX_CLK_SELECT_BCS 0x01
+ #define AX_CLK_SELECT_ACS 0x02
+ #define AX_CLK_SELECT_ULR 0x08
+
+#define AX_RXCOE_CTL 0x34
+ #define AX_RXCOE_IP 0x01
+ #define AX_RXCOE_TCP 0x02
+ #define AX_RXCOE_UDP 0x04
+ #define AX_RXCOE_TCPV6 0x20
+ #define AX_RXCOE_UDPV6 0x40
+
+#define AX_TXCOE_CTL 0x35
+ #define AX_TXCOE_IP 0x01
+ #define AX_TXCOE_TCP 0x02
+ #define AX_TXCOE_UDP 0x04
+ #define AX_TXCOE_TCPV6 0x20
+ #define AX_TXCOE_UDPV6 0x40
+
+#define AX_LEDCTRL 0x73
+
+#define GMII_PHY_PHYSR 0x11
+ #define GMII_PHY_PHYSR_SMASK 0xc000
+ #define GMII_PHY_PHYSR_GIGA 0x8000
+ #define GMII_PHY_PHYSR_100 0x4000
+ #define GMII_PHY_PHYSR_FULL 0x2000
+ #define GMII_PHY_PHYSR_LINK 0x400
+
+#define GMII_LED_ACT 0x1a
+ #define GMII_LED_ACTIVE_MASK 0xff8f
+ #define GMII_LED0_ACTIVE BIT(4)
+ #define GMII_LED1_ACTIVE BIT(5)
+ #define GMII_LED2_ACTIVE BIT(6)
+
+#define GMII_LED_LINK 0x1c
+ #define GMII_LED_LINK_MASK 0xf888
+ #define GMII_LED0_LINK_10 BIT(0)
+ #define GMII_LED0_LINK_100 BIT(1)
+ #define GMII_LED0_LINK_1000 BIT(2)
+ #define GMII_LED1_LINK_10 BIT(4)
+ #define GMII_LED1_LINK_100 BIT(5)
+ #define GMII_LED1_LINK_1000 BIT(6)
+ #define GMII_LED2_LINK_10 BIT(8)
+ #define GMII_LED2_LINK_100 BIT(9)
+ #define GMII_LED2_LINK_1000 BIT(10)
+ #define LED0_ACTIVE BIT(0)
+ #define LED0_LINK_10 BIT(1)
+ #define LED0_LINK_100 BIT(2)
+ #define LED0_LINK_1000 BIT(3)
+ #define LED0_FD BIT(4)
+ #define LED0_USB3_MASK 0x001f
+ #define LED1_ACTIVE BIT(5)
+ #define LED1_LINK_10 BIT(6)
+ #define LED1_LINK_100 BIT(7)
+ #define LED1_LINK_1000 BIT(8)
+ #define LED1_FD BIT(9)
+ #define LED1_USB3_MASK 0x03e0
+ #define LED2_ACTIVE BIT(10)
+ #define LED2_LINK_1000 BIT(13)
+ #define LED2_LINK_100 BIT(12)
+ #define LED2_LINK_10 BIT(11)
+ #define LED2_FD BIT(14)
+ #define LED_VALID BIT(15)
+ #define LED2_USB3_MASK 0x7c00
+
+#define GMII_PHYPAGE 0x1e
+#define GMII_PHY_PAGE_SELECT 0x1f
+ #define GMII_PHY_PGSEL_EXT 0x0007
+ #define GMII_PHY_PGSEL_PAGE0 0x0000
+ #define GMII_PHY_PGSEL_PAGE3 0x0003
+ #define GMII_PHY_PGSEL_PAGE5 0x0005
+
+struct ax88179_data {
+ struct mutex medium_status_mutex; /* protect AX_MEDIUM_STATUS_MODE */
+ u8 eee_enabled;
+ u8 eee_active;
+ u16 rxctl;
+ u8 in_pm;
+ u32 wol_supported;
+ u32 wolopts;
+ u8 disconnecting;
+};
+
+struct ax88179_int_data {
+ __le32 intdata1;
+ __le32 intdata2;
+};
+
+void ax88179_set_pm_mode(struct usbnet *dev, bool pm_mode);
+int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 size, void *data);
+int ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 size, void *data);
+int ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 size,
+ const void *data);
+void ax88179_write_cmd_async(struct usbnet *dev, u8 cmd, u16 value, u16 index,
+ u16 size, void *data);
+int ax88179_mdio_read(struct net_device *netdev, int phy_id, int loc);
+void ax88179_mdio_write(struct net_device *netdev, int phy_id, int loc, int val);
+void ax88179_status(struct usbnet *dev, struct urb *urb);
+void ax88179_get_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo);
+int ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo);
+int ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8 *data);
+int ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8 *data);
+void ax88179_set_multicast(struct net_device *net);
+int ax88179_set_features(struct net_device *net, netdev_features_t features);
+void ax88179_get_mac_addr(struct usbnet *dev);
+int ax88179_change_mtu(struct net_device *net, int new_mtu);
+int ax88179_set_mac_addr(struct net_device *net, void *p);
+#endif /*__LINUX_USBNET_AX88179_H */
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 04/13] ax88179_178a: Add HW support for AX179A-based chips
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (2 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 03/13] ax88179_178a: Split driver into library and device specific code Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 05/13] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
` (8 subsequent siblings)
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz
This adds bindings and HW support for AX179A-based USB-Ethernet
controllers. The AX179A-family of chips consists of the
AX88279 (2.5GBit PHY)
AX88179A/B (1GBit PHY, B variant has wider temperature range)
AX772D/E (100Mbit PHY)
The controllers all have the same vendor and device ID
(0x0b95, 0x1790) and are distinguished by their BCD device versions,
which are
2.00 AX88179A/B
3.00 AX88772D/E
4.00 AX88279
For all chips, the driver calls the same ax88179a_bind() function
and the chips are then distinguished by the chip version and
BCD device ID. The AX179A-based chips all provide both a CDC-NCM
compatible USB interface, and a proprietary vendor interface. By default,
the proprietary vendor interface is not active and Linux will load the
CDC-NCM driver to support the devices. If the ax88179_178a module is
configured by the OS to have precedence over CDC-NCM, then this driver
will switch the device to use the vendor interface, and the device will
be controlled by the ax88179_178a driver when the device is probed again
after an automatic reset by the device.
Also add a convenience function for the ethtool ops that use
phylink and need to retrieve the ax88179_data structure from
net_device: netdev2data().
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
MAINTAINERS | 6 +
drivers/net/usb/Kconfig | 2 +-
drivers/net/usb/Makefile | 2 +-
drivers/net/usb/ax88179_178a.c | 31 ++
drivers/net/usb/ax88179_lib.c | 30 ++
drivers/net/usb/ax88179_lib.h | 161 ++++++
drivers/net/usb/ax88179a_devices.c | 983 +++++++++++++++++++++++++++++++++++++
7 files changed, 1213 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index fe23913b1e4329b2c4e6f518f12945e286b01058..c22f8ed0880834083b056760160c8ca3393870a9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4114,6 +4114,12 @@ S: Maintained
F: Documentation/devicetree/bindings/net/asix,ax88796c.yaml
F: drivers/net/ethernet/asix/ax88796c_*
+ASIX AX88179 USB ETHERNET DRIVER
+M: Birger Koblitz <mail@birger-koblitz.de>
+L: netdev@vger.kernel.org
+S: Maintained
+F: drivers/net/usb/ax88179*
+
ASIX PHY DRIVER [RUST]
M: FUJITA Tomonori <fujita.tomonori@gmail.com>
R: Trevor Gross <tmgross@umich.edu>
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 52a5c0922c79fc52906d4d4040ec2b3411ff0984..115990b0d9537aea2776544c9768b034f32aa7a4 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -199,7 +199,7 @@ config USB_NET_AX88179_178A
tristate "ASIX AX88179/178A USB 3.0/2.0 to Gigabit Ethernet"
depends on USB_USBNET
select CRC32
- select PHYLIB
+ select PHYLINK
default y
help
This option adds support for ASIX AX88179 based USB 3.0/2.0
diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile
index ddd76fa71e2ee670888df1c9715632e5c04a8149..2ecead0181eaf8d66fb6f5dbd6f2905b22b6eb57 100644
--- a/drivers/net/usb/Makefile
+++ b/drivers/net/usb/Makefile
@@ -13,7 +13,7 @@ obj-$(CONFIG_USB_LAN78XX) += lan78xx.o
obj-$(CONFIG_USB_NET_AX8817X) += asix.o
asix-y := asix_devices.o asix_common.o ax88172a.o
obj-$(CONFIG_USB_NET_AX88179_178A) += ax88179.o
-ax88179-y := ax88179_178a.o ax88179_lib.o
+ax88179-y := ax88179_178a.o ax88179a_devices.o ax88179_lib.o
obj-$(CONFIG_USB_NET_CDCETHER) += cdc_ether.o
obj-$(CONFIG_USB_NET_CDC_EEM) += cdc_eem.o
obj-$(CONFIG_USB_NET_DM9601) += dm9601.o
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 55268d0890d1200be07b87f2dc9e62d2d7b69fc1..f78ad344c1c4f1f057164728e4f21f875e6cdc1a 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -685,6 +685,19 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
dev->driver_priv = ax179_data;
mutex_init(&ax179_data->medium_status_mutex);
+ ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_CHIP_STATUS,
+ 1, 1, &ax179_data->chip_version);
+ if (ret < 0)
+ goto err_nodev;
+
+ ax179_data->chip_version = (ax179_data->chip_version & 0xf0) >> 4;
+ ax179_data->is_ax88772d = 0;
+ ax179_data->ip_align = 1;
+ ax179_data->eeprom_read_cmd = AX_ACCESS_EEPROM;
+ ax179_data->eeprom_write_cmd = AX_ACCESS_EEPROM;
+ ax179_data->eeprom_block = 2;
+ ax179_data->eeprom_wen = 0;
+
dev->net->netdev_ops = &ax88179_netdev_ops;
dev->net->ethtool_ops = &ax88179_ethtool_ops;
dev->net->needed_headroom = 8;
@@ -709,6 +722,12 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
ax88179_reset(dev);
return 0;
+
+err_nodev:
+ kfree(ax179_data);
+ ax179_data = NULL;
+
+ return ret;
}
static void ax88179_unbind(struct usbnet *dev, struct usb_interface *intf)
@@ -1271,6 +1290,18 @@ static const struct driver_info at_umc2000sp_info = {
static const struct usb_device_id products[] = {
{
+ /* ASIX AX88179A USB 3.2 1000Mbit Ethernet */
+ USB_DEVICE_VER(0x0b95, 0x1790, 0x0200, 0x0200),
+ .driver_info = (unsigned long)&ax88179a_info,
+}, {
+ /* ASIX AX88772D USB 2.0 100Mbit Ethernet */
+ USB_DEVICE_VER(0x0b95, 0x1790, 0x0300, 0x0300),
+ .driver_info = (unsigned long)&ax88772d_info,
+}, {
+ /* ASIX AX88279 USB 3.2 2500Mbit Ethernet */
+ USB_DEVICE_VER(0x0b95, 0x1790, 0x0400, 0x0400),
+ .driver_info = (unsigned long)&ax88279_info,
+}, {
/* ASIX AX88179 10/100/1000 */
USB_DEVICE_AND_INTERFACE_INFO(0x0b95, 0x1790, 0xff, 0xff, 0),
.driver_info = (unsigned long)&ax88179_info,
diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
index 063427ff55e42e38be1acb66806c0cdbe8e84347..a314db4c9766679568a036f98acf868784835865 100644
--- a/drivers/net/usb/ax88179_lib.c
+++ b/drivers/net/usb/ax88179_lib.c
@@ -129,6 +129,28 @@ int ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
return ret;
}
+int ax88179_write_u16(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 data)
+{
+ u16 buf = data;
+
+ cpu_to_le16s(&buf);
+ return __ax88179_write_cmd(dev, cmd, value, index, 2, &buf);
+}
+
+int ax88179_write_u8(struct usbnet *dev, u8 cmd, u16 value, u16 index, u8 data)
+{
+ u8 buf = data;
+
+ return __ax88179_write_cmd(dev, cmd, value, index, 1, &buf);
+}
+
+struct ax88179_data *netdev2data(struct net_device *net)
+{
+ struct usbnet *dev = netdev_priv(net);
+
+ return dev->driver_priv;
+}
+
void ax88179_status(struct usbnet *dev, struct urb *urb)
{
struct ax88179_int_data *event;
@@ -340,6 +362,7 @@ int ax88179_set_features(struct net_device *net, netdev_features_t features)
{
u8 tmp;
struct usbnet *dev = netdev_priv(net);
+ struct ax88179_data *data = dev->driver_priv;
netdev_features_t changed = net->features ^ features;
if (changed & NETIF_F_IP_CSUM) {
@@ -355,10 +378,17 @@ int ax88179_set_features(struct net_device *net, netdev_features_t features)
}
if (changed & NETIF_F_RXCSUM) {
+ /* When we disable rx-checksumming, we need to clear the rx_checksum
+ * flag before disabling the engine
+ */
+ if (!(features & NETIF_F_RXCSUM))
+ data->rx_checksum = 0;
+
ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp);
tmp ^= AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP |
AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6;
ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp);
+ data->rx_checksum = !!(features & NETIF_F_RXCSUM);
}
return 0;
diff --git a/drivers/net/usb/ax88179_lib.h b/drivers/net/usb/ax88179_lib.h
index 9111a1395eb2f7208c7e90c93027845423bbda00..adc2b4598bb52d80c18a6e2cc467144d3bd57a88 100644
--- a/drivers/net/usb/ax88179_lib.h
+++ b/drivers/net/usb/ax88179_lib.h
@@ -2,6 +2,7 @@
#include <linux/usb.h>
#include <linux/crc32.h>
+#include <linux/phylink.h>
#include <linux/usb/usbnet.h>
#ifndef __LINUX_USBNET_AX88179_H
@@ -25,17 +26,34 @@
#define AX_ACCESS_EEPROM 0x04
#define AX_ACCESS_EFUS 0x05
#define AX_RELOAD_EEPROM_EFUSE 0x06
+#define AX88179A_WAKEUP_SETTING 0x07
+#define AX_FW_MODE 0x08
+#define AX_GPHY_CTL 0x0F
+#define AX88179A_FLASH_READ 0x21
+#define AX88179A_FLASH_WEN 0x22
+#define AX88179A_FLASH_WDIS 0x23
+#define AX88179A_FLASH_WRITE 0x24
+#define AX88179A_PHY_CLAUSE45 0x27
+#define AX88179A_FLASH_ERASE_SECTION 0x28
+#define AX88179A_ACCESS_BL 0x2A
+#define AX88179A_PHY_POWER 0x31
+#define AX88179A_AUTODETACH 0xC0
+
#define AX_PAUSE_WATERLVL_LOW 0x54
#define AX_PAUSE_WATERLVL_HIGH 0x55
+#define AX_FW_MODE_179A 0x01
#define PHYSICAL_LINK_STATUS 0x02
#define AX_USB_SS 0x04
#define AX_USB_HS 0x02
+ #define AX_USB_FS 0x01
#define GENERAL_STATUS 0x03
/* Check AX88179 version. UA1:Bit2 = 0, UA2:Bit2 = 1 */
#define AX_SECLD 0x04
+#define AX_CHIP_STATUS 0x05
+
#define AX_SROM_ADDR 0x07
#define AX_SROM_CMD 0x0a
#define EEP_RD 0x04
@@ -55,6 +73,15 @@
#define AX_RX_CTL_PRO 0x0001
#define AX_RX_CTL_STOP 0x0000
+#define AX88179A_ETH_TX_GAP 0x0D
+
+#define AX88179A_BFM_DATA 0x0E
+ #define AX_TX_QUEUE_CFG 0x02
+ #define AX_TX_QUEUE_SET 0x08
+ #define AX_TX_Q1_AHB_FC_EN 0x10
+ #define AX_TX_Q2_AHB_FC_EN 0x20
+ #define AX_XGMII_EN 0x80
+
#define AX_NODE_ID 0x10
#define AX_MULFLTARY 0x16
@@ -84,7 +111,20 @@
#define AX_PHYPWR_RSTCTL_IPRL 0x0020
#define AX_PHYPWR_RSTCTL_AT 0x1000
+#define AX88179A_VLAN_ID_ADDRESS 0x2A
+
+#define AX88179A_VLAN_ID_CONTROL 0x2B
+ #define AX_VLAN_CONTROL_WE 0x0001
+ #define AX_VLAN_CONTROL_RD 0x0002
+ #define AX_VLAN_CONTROL_VSO 0x0010
+ #define AX_VLAN_CONTROL_VFE 0x0020
+
+#define AX88179A_VLAN_ID_DATA0 0x2C
+#define AX88179A_VLAN_ID_DATA1 0x2D
+
#define AX_RX_BULKIN_QCTRL 0x2e
+#define AX_GPHY_EEE_CTRL 0x01
+
#define AX_CLK_SELECT 0x33
#define AX_CLK_SELECT_BCS 0x01
#define AX_CLK_SELECT_ACS 0x02
@@ -104,7 +144,51 @@
#define AX_TXCOE_TCPV6 0x20
#define AX_TXCOE_UDPV6 0x40
+#define AX88179A_MAC_BM_INT_MASK 0x41
+#define AX88179A_MAC_BM_RX_DMA_CTL 0x43
+#define AX88179A_MAC_BM_TX_DMA_CTL 0x46
+
+#define AX88179A_MAC_RX_STATUS_CDC 0x6D
+ #define AX_LSOFC_WCNT_7_ACCESS 0x03
+ #define AX_GMII_CRC_APPEND 0x10
+
#define AX_LEDCTRL 0x73
+#define AX88179A_MAC_ARC_CTRL 0x9E
+#define AX88179A_MAC_SWP_CTRL 0xB1
+
+#define AX88179A_MAC_TX_PAUSE 0xB2
+
+#define AX88179A_MAC_CDC_DELAY_TX 0xB5
+
+#define AX88179A_MAC_PATH 0xB7
+ #define AX_MAC_RX_PATH_READY 0x01
+ #define AX_MAC_TX_PATH_READY 0x02
+
+#define AX88179A_NEW_PAUSE_CTRL 0xB8
+ #define AX_NEW_PAUSE_EN 0x01
+
+#define AX88179A_MAC_BULK_OUT_CTRL 0xB9
+ #define AX_MAC_EFF_EN 0x02
+
+#define AX88179A_MAC_RX_DATA_CDC_CNT 0xC0
+ #define AX_MAC_LSO_ERR_EN 0x04
+ #define AX_MAC_MIQFFCTRL_FORMAT 0x10
+ #define AX_MAC_MIQFFCTRL_DROP_CRC 0x20
+
+#define AX88179A_AUTODETACH_DELAY (5UL << 8)
+#define AX88179A_AUTODETACH_EN 1
+
+#define AX88179A_MAC_LSO_ENHANCE_CTRL 0xC3
+ #define AX_LSO_ENHANCE_EN 0x01
+
+#define AX88179A_MAC_TX_HDR_CKSUM 0xCC
+#define AX88179A_EP5_EHR 0xF9
+
+#define AX_PHY_POWER 0x02
+
+#define EPHY_LOW_POWER_EN 0x01
+#define S5_WOL_EN 0x04
+#define S5_WOL_LOW_POWER 0x20
#define GMII_PHY_PHYSR 0x11
#define GMII_PHY_PHYSR_SMASK 0xc000
@@ -157,6 +241,55 @@
#define GMII_PHY_PGSEL_PAGE3 0x0003
#define GMII_PHY_PGSEL_PAGE5 0x0005
+#define AX88179A_SW_REVISION 0xFC
+#define AX88179A_SW_VERSION 0xFD
+
+/* TX Descriptor */
+#define AX179A_TX_DESC_LEN_MASK 0x1FFFFF
+#define AX179A_TX_DESC_DROP_PADD BIT(28)
+#define AX179A_TX_DESC_VLAN BIT(29)
+#define AX179A_TX_DESC_MSS GENMASK_U64(46, 32)
+#define AX179A_TX_DESC_VLAN_ID GENMASK_U64(63, 48)
+
+/* RX Packet Descriptor */
+#define AX179A_RX_PD_L4_ERR BIT(0)
+#define AX179A_RX_PD_L3_ERR BIT(1)
+#define AX179A_RX_PD_L4_TYPE_MASK 0x1C
+#define AX179A_RX_PD_L4_UDP 0x04
+#define AX179A_RX_PD_L4_TCP 0x10
+#define AX179A_RX_PD_L3_TYPE_MASK 0x60
+#define AX179A_RX_PD_L3_IP 0x20
+#define AX179A_RX_PD_L3_IP6 0x40
+
+#define AX179A_RX_PD_VLAN BIT(10)
+#define AX179A_RX_PD_RX_OK BIT(11)
+#define AX179A_RX_PD_DROP BIT(31)
+#define AX179A_RX_PD_LEN GENMASK(30, 16)
+#define AX179A_RX_PD_VLAN_SHIFT 0x20
+
+/* RX Descriptor header */
+#define AX179A_RX_DH_PKT_CNT_MASK 0x1FFF
+#define AX179A_RX_DH_DESC_OFFSET GENMASK(31, 13)
+
+#define AX179A_RX_HW_PAD 0x02
+
+#define AX_ADVERTISE_2500 0x1000
+
+enum ax_ether_link_speed {
+ ETHER_LINK_NONE = 0,
+ ETHER_LINK_10 = 1,
+ ETHER_LINK_100 = 2,
+ ETHER_LINK_1000 = 3,
+ ETHER_LINK_2500 = 4,
+};
+
+enum ax_chip_version {
+ AX_VERSION_INVALID = 0x0,
+ AX_VERSION_AX88179 = 0x4,
+ AX_VERSION_AX88179A = 0x6, /* Also AX88772D */
+ AX_VERSION_AX88279 = 0x7,
+};
+
struct ax88179_data {
struct mutex medium_status_mutex; /* protect AX_MEDIUM_STATUS_MODE */
u8 eee_enabled;
@@ -166,6 +299,22 @@ struct ax88179_data {
u32 wol_supported;
u32 wolopts;
u8 disconnecting;
+ u8 chip_version;
+ u8 fw_version[4];
+ u8 is_ax88772d;
+ u8 ip_align;
+ u8 link;
+ u8 speed;
+ u8 full_duplex;
+ u8 rx_checksum;
+ u8 eeprom_read_cmd;
+ u8 eeprom_write_cmd;
+ u8 eeprom_wen;
+ u16 eeprom_block;
+ struct mii_bus *mdio;
+ struct phy_device *phydev;
+ struct phylink *phylink;
+ struct phylink_config phylink_config;
};
struct ax88179_int_data {
@@ -173,6 +322,10 @@ struct ax88179_int_data {
__le32 intdata2;
};
+struct ax_bulkin_settings {
+ unsigned char ctrl, timer_l, timer_h, size, ifg;
+};
+
void ax88179_set_pm_mode(struct usbnet *dev, bool pm_mode);
int __ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 size, void *data);
int ax88179_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 size, void *data);
@@ -180,8 +333,11 @@ int ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 size
const void *data);
void ax88179_write_cmd_async(struct usbnet *dev, u8 cmd, u16 value, u16 index,
u16 size, void *data);
+int ax88179_write_u16(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 data);
+int ax88179_write_u8(struct usbnet *dev, u8 cmd, u16 value, u16 index, u8 data);
int ax88179_mdio_read(struct net_device *netdev, int phy_id, int loc);
void ax88179_mdio_write(struct net_device *netdev, int phy_id, int loc, int val);
+struct ax88179_data *netdev2data(struct net_device *net);
void ax88179_status(struct usbnet *dev, struct urb *urb);
void ax88179_get_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo);
int ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo);
@@ -192,4 +348,9 @@ int ax88179_set_features(struct net_device *net, netdev_features_t features);
void ax88179_get_mac_addr(struct usbnet *dev);
int ax88179_change_mtu(struct net_device *net, int new_mtu);
int ax88179_set_mac_addr(struct net_device *net, void *p);
+
+extern const struct driver_info ax88179a_info;
+extern const struct driver_info ax88772d_info;
+extern const struct driver_info ax88279_info;
+
#endif /*__LINUX_USBNET_AX88179_H */
diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
new file mode 100644
index 0000000000000000000000000000000000000000..1aa8479422517bff6758c884c5e47258c5d3ed3a
--- /dev/null
+++ b/drivers/net/usb/ax88179a_devices.c
@@ -0,0 +1,983 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#include <linux/module.h>
+#include <linux/phylink.h>
+#include <linux/if_vlan.h>
+#include "ax88179_lib.h"
+
+#define AX88279_EEPROM_LEN 0x4000
+#define AX88179A_EEPROM_LEN (32 * 20)
+
+enum ax_bulk_in_speeds {
+ BULK_IN_SPEED_2G5 = 0,
+ BULK_IN_SPEED_1G_SS = 1,
+ BULK_IN_SPEED_1G_HS = 2,
+ BULK_IN_SPEED_100_FULL_SS = 3,
+ BULK_IN_SPEED_100_HALF_SS = 4,
+ BULK_IN_SPEED_100_FULL_HS = 5,
+ BULK_IN_SPEED_100_HALF_HS = 6,
+ BULK_IN_SPEED_FS = 7,
+};
+
+static const struct ax_bulkin_settings AX88179A_BULKIN_SIZE[] = {
+ [BULK_IN_SPEED_1G_SS] = {5, 0x7B, 0x00, 0x17, 0x0F},
+ [BULK_IN_SPEED_1G_HS] = {5, 0xC0, 0x02, 0x06, 0x0F},
+ [BULK_IN_SPEED_100_FULL_SS] = {7, 0xF0, 0x00, 0x0C, 0x0F},
+ [BULK_IN_SPEED_100_HALF_SS] = {6, 0x00, 0x00, 0x06, 0x0F},
+ [BULK_IN_SPEED_100_FULL_HS] = {5, 0xC0, 0x04, 0x06, 0x0F},
+ [BULK_IN_SPEED_100_HALF_HS] = {7, 0xC0, 0x04, 0x06, 0x0F},
+ [BULK_IN_SPEED_FS] = {7, 0x00, 0x00, 0x03, 0x3F},
+};
+
+static const struct ax_bulkin_settings AX88772D_BULKIN_SIZE[] = {
+ [BULK_IN_SPEED_100_FULL_HS] = {5, 0xC0, 0x04, 0x06, 0x0F},
+ [BULK_IN_SPEED_100_HALF_HS] = {7, 0xC0, 0x04, 0x06, 0x0F},
+ [BULK_IN_SPEED_FS] = {7, 0x00, 0x00, 0x03, 0x3F},
+};
+
+static const struct ax_bulkin_settings AX88279_BULKIN_SIZE[] = {
+ [BULK_IN_SPEED_2G5] = {5, 0x10, 0x01, 0x11, 0x0F},
+ [BULK_IN_SPEED_1G_SS] = {7, 0xB3, 0x01, 0x11, 0x0F},
+ [BULK_IN_SPEED_1G_HS] = {7, 0xC0, 0x02, 0x06, 0x0F},
+ [BULK_IN_SPEED_100_FULL_SS] = {7, 0x80, 0x01, 0x03, 0x0F},
+ [BULK_IN_SPEED_100_HALF_SS] = {7, 0x80, 0x01, 0x03, 0x0F},
+ [BULK_IN_SPEED_100_FULL_HS] = {7, 0x80, 0x01, 0x03, 0x0F},
+ [BULK_IN_SPEED_100_HALF_HS] = {7, 0x80, 0x01, 0x03, 0x0F},
+ [BULK_IN_SPEED_FS] = {7, 0x00, 0x00, 0x03, 0x3F},
+};
+
+static int ax88179_mdiobus_read(struct mii_bus *bus, int phy_id, int regnum)
+{
+ struct usbnet *dev = bus->priv;
+ struct ax88179_data *priv;
+ u16 res;
+ int ret;
+
+ priv = dev->driver_priv;
+ /* When reading PHYSID, return unused PHY-IDs from the ASIX vendor range */
+ if (phy_id == AX88179_PHY_ID && regnum == MII_PHYSID1)
+ return 0x003b;
+ if (phy_id == AX88179_PHY_ID && regnum == MII_PHYSID2) {
+ if (priv->chip_version == AX_VERSION_AX88179A && priv->is_ax88772d)
+ return 0x772d;
+ else if (priv->chip_version == AX_VERSION_AX88179A)
+ return 0x179a;
+ else if (priv->chip_version == AX_VERSION_AX88279)
+ return 0x2790;
+ }
+
+ ret = ax88179_read_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)regnum, 2, &res);
+ if (ret < 0)
+ return ret;
+ return res;
+}
+
+static int ax88179_mdiobus_write(struct mii_bus *bus, int phy_id, int regnum, u16 val)
+{
+ struct usbnet *dev = bus->priv;
+
+ return ax88179_write_u16(dev, AX_ACCESS_PHY, phy_id, (__u16)regnum, val);
+}
+
+static int ax179a_read_mmd(struct usbnet *dev, u16 dev_addr, u16 reg)
+{
+ u16 res;
+ int ret;
+
+ ret = ax88179_read_cmd(dev, AX88179A_PHY_CLAUSE45, dev_addr, reg, 2, &res);
+ if (ret < 0)
+ return ret;
+ return res;
+}
+
+static int ax179a_write_mmd(struct usbnet *dev, u16 dev_addr, u16 reg, u16 data)
+{
+ return ax88179_write_cmd(dev, AX88179A_PHY_CLAUSE45, dev_addr, reg, 2, &data);
+}
+
+static int ax88179_mdiobus_read_c45(struct mii_bus *bus, int addr, int devnum, int regnum)
+{
+ struct usbnet *dev = bus->priv;
+
+ if (addr != AX88179_PHY_ID)
+ return -EINVAL;
+
+ return ax179a_read_mmd(dev, devnum, regnum);
+}
+
+static int ax88179_mdiobus_write_c45(struct mii_bus *bus, int addr, int devnum,
+ int regnum, u16 val)
+{
+ struct usbnet *dev = bus->priv;
+
+ if (addr != AX88179_PHY_ID)
+ return -EINVAL;
+
+ return ax179a_write_mmd(dev, devnum, regnum, val);
+}
+
+static void ax88179a_status(struct usbnet *dev, struct urb *urb)
+{
+ struct ax88179_data *data = dev->driver_priv;
+
+ if (urb->actual_length < 8)
+ return;
+
+ phylink_mac_interrupt(data->phylink);
+}
+
+static int ax88179a_auto_detach(struct usbnet *dev)
+{
+ u16 tmp16;
+
+ tmp16 = AX88179A_AUTODETACH_DELAY;
+ ax88179_write_cmd(dev, AX88179A_AUTODETACH, tmp16, 0, 0, NULL);
+ return 0;
+}
+
+static void ax88179a_bulkin_config(struct usbnet *dev, u8 link_sts, u8 speed, bool full_duplex)
+{
+ struct ax88179_data *ax179_data = dev->driver_priv;
+ const struct ax_bulkin_settings *bulkin_data;
+ int index = 0;
+
+ switch (speed) {
+ case ETHER_LINK_2500: /* AX88279 only */
+ index = BULK_IN_SPEED_2G5;
+ break;
+
+ case ETHER_LINK_1000: /* AX88279 & AX88178A */
+ if (link_sts & AX_USB_SS)
+ index = BULK_IN_SPEED_1G_SS;
+ else if (link_sts & AX_USB_HS)
+ index = BULK_IN_SPEED_1G_HS;
+ break;
+
+ case ETHER_LINK_100:
+ if (link_sts & AX_USB_SS)
+ index = BULK_IN_SPEED_100_FULL_SS;
+ else if (link_sts & AX_USB_HS)
+ index = BULK_IN_SPEED_100_FULL_HS;
+ if (!full_duplex)
+ index++;
+ break;
+
+ case ETHER_LINK_10:
+ index = BULK_IN_SPEED_FS;
+ break;
+
+ default: /* No link */
+ index = BULK_IN_SPEED_FS;
+ }
+
+ if (link_sts & AX_USB_FS)
+ index = BULK_IN_SPEED_FS;
+
+ if (ax179_data->chip_version == AX_VERSION_AX88279) {
+ bulkin_data = AX88279_BULKIN_SIZE;
+ } else {
+ if (ax179_data->is_ax88772d)
+ bulkin_data = AX88772D_BULKIN_SIZE;
+ else
+ bulkin_data = AX88179A_BULKIN_SIZE;
+ }
+
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_BULKIN_QCTRL, 5, 5, &bulkin_data[index]);
+}
+
+static void ax88179a_get_pauseparam(struct net_device *net, struct ethtool_pauseparam *pause)
+{
+ struct ax88179_data *data = netdev2data(net);
+
+ phylink_ethtool_get_pauseparam(data->phylink, pause);
+}
+
+static int ax88179a_set_pauseparam(struct net_device *net, struct ethtool_pauseparam *pause)
+{
+ struct ax88179_data *data = netdev2data(net);
+
+ return phylink_ethtool_set_pauseparam(data->phylink, pause);
+}
+
+static int ax88179a_get_link_ksettings(struct net_device *net,
+ struct ethtool_link_ksettings *cmd)
+{
+ struct ax88179_data *data = netdev2data(net);
+
+ return phylink_ethtool_ksettings_get(data->phylink, cmd);
+}
+
+static int ax88179a_set_link_ksettings(struct net_device *net,
+ const struct ethtool_link_ksettings *cmd)
+{
+ struct ax88179_data *data = netdev2data(net);
+
+ return phylink_ethtool_ksettings_set(data->phylink, cmd);
+}
+
+static int ax88179a_get_eeprom_len(struct net_device *net)
+{
+ struct ax88179_data *ax179_data = netdev2data(net);
+
+ if (ax179_data->chip_version >= AX_VERSION_AX88279)
+ return AX88279_EEPROM_LEN;
+ else
+ return AX88179A_EEPROM_LEN;
+}
+
+static const struct ethtool_ops ax88179a_ethtool_ops = {
+ .get_link = ethtool_op_get_link,
+ .get_msglevel = usbnet_get_msglevel,
+ .set_msglevel = usbnet_set_msglevel,
+ .get_wol = ax88179_get_wol,
+ .set_wol = ax88179_set_wol,
+ .get_eeprom_len = ax88179a_get_eeprom_len,
+ .get_eeprom = ax88179_get_eeprom,
+ .set_eeprom = ax88179_set_eeprom,
+ .nway_reset = phy_ethtool_nway_reset,
+ .get_link_ksettings = ax88179a_get_link_ksettings,
+ .set_link_ksettings = ax88179a_set_link_ksettings,
+ .get_pauseparam = ax88179a_get_pauseparam,
+ .set_pauseparam = ax88179a_set_pauseparam,
+ .get_ts_info = ethtool_op_get_ts_info,
+};
+
+static void ax88179a_mdio_unregister(struct ax88179_data *data)
+{
+ mdiobus_unregister(data->mdio);
+ mdiobus_free(data->mdio);
+}
+
+static int ax88179a_init_phy(struct usbnet *dev)
+{
+ struct ax88179_data *data = dev->driver_priv;
+ int ret;
+
+ data->phydev = mdiobus_get_phy(data->mdio, AX88179_PHY_ID);
+ if (!data->phydev) {
+ netdev_err(dev->net, "Could not find PHY\n");
+ return -ENODEV;
+ }
+
+ data->phydev->irq = PHY_MAC_INTERRUPT;
+ ret = phylink_connect_phy(data->phylink, data->phydev);
+ if (ret) {
+ netdev_err(dev->net, "Could not connect PHY\n");
+ return ret;
+ }
+
+ phy_suspend(data->phydev);
+ data->phydev->mac_managed_pm = true;
+
+ phy_attached_info(data->phydev);
+
+ return 0;
+}
+
+static void ax88179a_mac_config(struct phylink_config *config, unsigned int mode,
+ const struct phylink_link_state *state)
+{
+ /* Nothing to do */
+}
+
+static void ax88179a_mac_link_down(struct phylink_config *config,
+ unsigned int mode, phy_interface_t interface)
+{
+ /* Nothing to do */
+}
+
+static void ax88179a_mac_link_up(struct phylink_config *config,
+ struct phy_device *phy,
+ unsigned int phy_mode, phy_interface_t interface,
+ int speed, int duplex,
+ bool tx_pause, bool rx_pause)
+{
+ struct usbnet *dev = netdev_priv(to_net_dev(config->dev));
+ struct ax88179_data *ax179_data = dev->driver_priv;
+ u8 link_sts = 0, reg8[3];
+ u8 bulk_config_speed = 0;
+ u16 mode;
+
+ /* Stop RX/TX for link configuration */
+ ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, AX_RX_CTL_STOP);
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_PATH, 1, 0);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_CDC_DELAY_TX, 1, 0xa5);
+
+ ax88179_write_u16(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 2, 0x0410);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_ETH_TX_GAP, 1, 0);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_EP5_EHR, 1, 0x07);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_NEW_PAUSE_CTRL, 1,
+ 0x28 | AX_NEW_PAUSE_EN);
+
+ mode = AX_MEDIUM_RECEIVE_EN;
+ if (tx_pause)
+ mode |= AX_MEDIUM_TXFLOW_CTRLEN;
+ if (rx_pause)
+ mode |= AX_MEDIUM_RXFLOW_CTRLEN;
+
+ switch (speed) {
+ case SPEED_2500:
+ reg8[0] = 0x00;
+ reg8[1] = 0xF8;
+ reg8[2] = 0x07;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_TX_PAUSE, 3, 3, reg8);
+
+ reg8[0] = 0x78;
+ reg8[1] = (AX_LSOFC_WCNT_7_ACCESS << 5);
+ reg8[2] = 0;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, reg8);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 1, 0x40);
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT + 1, 1,
+ AX_MAC_MIQFFCTRL_FORMAT | AX_MAC_MIQFFCTRL_DROP_CRC |
+ AX_MAC_LSO_ERR_EN);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_BFM_DATA, 1, AX_XGMII_EN);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_LSO_ENHANCE_CTRL, 1,
+ 0x1C | AX_LSO_ENHANCE_EN);
+
+ mode |= AX_MEDIUM_GIGAMODE | AX_MEDIUM_FULL_DUPLEX;
+ bulk_config_speed = ETHER_LINK_2500;
+
+ break;
+
+ case SPEED_1000:
+ mode |= AX_MEDIUM_GIGAMODE;
+ bulk_config_speed = ETHER_LINK_1000;
+ fallthrough;
+
+ case SPEED_100:
+ reg8[0] = 0x78;
+ reg8[1] = (AX_LSOFC_WCNT_7_ACCESS << 5) | AX_GMII_CRC_APPEND;
+ reg8[2] = 0;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, reg8);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 1, 0x40);
+ if (!bulk_config_speed)
+ bulk_config_speed = ETHER_LINK_100;
+ break;
+
+ case SPEED_10:
+ reg8[0] = 0xFA;
+ reg8[1] = (AX_LSOFC_WCNT_7_ACCESS << 5) | AX_GMII_CRC_APPEND;
+ reg8[2] = 0xFF;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, reg8);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 1, 0xFA);
+
+ bulk_config_speed = ETHER_LINK_10;
+ break;
+ }
+
+ ax88179_read_cmd(dev, AX_ACCESS_MAC, PHYSICAL_LINK_STATUS, 1, 1, &link_sts);
+ ax88179a_bulkin_config(dev, link_sts, bulk_config_speed, !!duplex);
+
+ if (speed != SPEED_2500)
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_BFM_DATA, 1, 0);
+
+ if (duplex)
+ mode |= AX_MEDIUM_FULL_DUPLEX;
+
+ mutex_lock(&ax179_data->medium_status_mutex);
+ if (dev->net->mtu > 1500)
+ mode |= AX_MEDIUM_JUMBO_EN;
+ ax88179_write_u16(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, mode);
+
+ ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, READ_ONCE(ax179_data->rxctl));
+ mutex_unlock(&ax179_data->medium_status_mutex);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_PATH, 1,
+ AX_MAC_RX_PATH_READY | AX_MAC_TX_PATH_READY);
+}
+
+static const struct phylink_mac_ops ax88179a_phylink_mac_ops = {
+ .mac_config = ax88179a_mac_config,
+ .mac_link_down = ax88179a_mac_link_down,
+ .mac_link_up = ax88179a_mac_link_up,
+};
+
+static int ax88179a_phylink_setup(struct usbnet *dev)
+{
+ struct ax88179_data *data = dev->driver_priv;
+ phy_interface_t phy_if_mode;
+ struct phylink *phylink;
+
+ data->phylink_config.dev = &dev->net->dev;
+ data->phylink_config.type = PHYLINK_NETDEV;
+ data->phylink_config.mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_100;
+ if (data->is_ax88772d)
+ data->phylink_config.mac_capabilities |= MAC_10;
+ else if (data->chip_version < AX_VERSION_AX88279)
+ data->phylink_config.mac_capabilities |= MAC_10 | MAC_1000;
+ else
+ data->phylink_config.mac_capabilities |= MAC_1000 | MAC_2500FD;
+
+ if (!data->is_ax88772d) {
+ data->phylink_config.lpi_capabilities = MAC_100FD | MAC_1000FD;
+ data->phylink_config.eee_enabled_default = false;
+ }
+
+ if (data->chip_version == AX_VERSION_AX88279) {
+ __set_bit(PHY_INTERFACE_MODE_2500BASEX,
+ data->phylink_config.supported_interfaces);
+ __set_bit(PHY_INTERFACE_MODE_SGMII,
+ data->phylink_config.supported_interfaces);
+ phy_if_mode = PHY_INTERFACE_MODE_2500BASEX;
+ } else {
+ __set_bit(PHY_INTERFACE_MODE_SGMII,
+ data->phylink_config.supported_interfaces);
+ phy_if_mode = PHY_INTERFACE_MODE_SGMII;
+ }
+
+ phylink = phylink_create(&data->phylink_config, dev->net->dev.fwnode,
+ phy_if_mode, &ax88179a_phylink_mac_ops);
+ if (IS_ERR(phylink))
+ return PTR_ERR(phylink);
+
+ data->phylink = phylink;
+ return 0;
+}
+
+static int ax88179a_init_mdio(struct usbnet *dev)
+{
+ struct ax88179_data *data = dev->driver_priv;
+ int ret;
+
+ data->mdio = mdiobus_alloc();
+ if (!data->mdio)
+ return -ENOMEM;
+
+ data->mdio->priv = dev;
+ data->mdio->read = ax88179_mdiobus_read;
+ data->mdio->write = ax88179_mdiobus_write;
+ data->mdio->read_c45 = ax88179_mdiobus_read_c45;
+ data->mdio->write_c45 = ax88179_mdiobus_write_c45;
+ data->mdio->name = "AX88179A MDIO Bus";
+ data->mdio->phy_mask = ~(1 << AX88179_PHY_ID);
+ /* mii bus name is usb-<usb bus number>-<usb device number> */
+ snprintf(data->mdio->id, MII_BUS_ID_SIZE, "usb-%03d:%03d",
+ dev->udev->bus->busnum, dev->udev->devnum);
+
+ ret = mdiobus_register(data->mdio);
+ if (ret) {
+ netdev_err(dev->net, "Could not register MDIO bus (err %d)\n", ret);
+ mdiobus_free(data->mdio);
+ data->mdio = NULL;
+ }
+
+ return ret;
+}
+
+static int ax88179a_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd)
+{
+ struct ax88179_data *data = netdev2data(net);
+
+ return phylink_mii_ioctl(data->phylink, rq, cmd);
+}
+
+static const struct net_device_ops ax88179a_netdev_ops = {
+ .ndo_open = usbnet_open,
+ .ndo_stop = usbnet_stop,
+ .ndo_start_xmit = usbnet_start_xmit,
+ .ndo_tx_timeout = usbnet_tx_timeout,
+ .ndo_get_stats64 = dev_get_tstats64,
+ .ndo_change_mtu = ax88179_change_mtu,
+ .ndo_set_mac_address = ax88179_set_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
+ .ndo_eth_ioctl = ax88179a_mii_ioctl,
+};
+
+static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf)
+{
+ struct usb_device *udev = interface_to_usbdev(intf);
+ struct ax88179_data *ax179_data;
+ int ret;
+
+ /* Check if vendor configuration */
+ if (udev->actconfig->desc.bConfigurationValue != 1) {
+ netdev_info(dev->net, "Switching to vendor mode\n");
+ usb_driver_set_configuration(udev, 1);
+ return -ENODEV;
+ }
+
+ ret = usbnet_get_endpoints(dev, intf);
+ if (ret < 0)
+ return ret;
+
+ ax179_data = kzalloc_obj(*ax179_data);
+ if (!ax179_data)
+ return -ENOMEM;
+
+ dev->driver_priv = ax179_data;
+ mutex_init(&ax179_data->medium_status_mutex);
+
+ ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_CHIP_STATUS,
+ 1, 1, &ax179_data->chip_version);
+ if (ret < 0)
+ goto err_nodev;
+
+ ax179_data->chip_version = (ax179_data->chip_version & 0xf0) >> 4;
+ ax179_data->is_ax88772d = 0;
+ if (ax179_data->chip_version == AX_VERSION_AX88179A) {
+ if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x300)
+ ax179_data->is_ax88772d = 1;
+ }
+
+ for (int i = 0; i < 3; i++) {
+ ret = ax88179_read_cmd(dev, AX88179A_ACCESS_BL, AX88179A_SW_VERSION + i,
+ 1, 1, &ax179_data->fw_version[i]);
+ if (ret < 0)
+ ax179_data->fw_version[i] = 0xff;
+ }
+ ret = ax88179_read_cmd(dev, AX88179A_ACCESS_BL, AX88179A_SW_REVISION,
+ 1, 1, &ax179_data->fw_version[3]);
+ if (ret < 0)
+ ax179_data->fw_version[3] = 0xff;
+
+ netdev_info(dev->net, "AX88179A/279/772D Chip Version: %x, FW: %d.%d.%d.%d\n",
+ ax179_data->chip_version,
+ ax179_data->fw_version[0], ax179_data->fw_version[1],
+ ax179_data->fw_version[2], ax179_data->fw_version[3]);
+
+ /* The AX88279 requires both the AX_RX_CTL_IPE and AX_RX_CTL_DROPCRCERR
+ * bits set in AX_RX_CTL for creating correct RX-URBs. AX_RX_CTL_DROPCRCERR
+ * is anyway set for all chips, make sure AX_RX_CTL_IPE is set via ip_align.
+ * Also configure eeprom access parameters.
+ */
+ if (ax179_data->chip_version == AX_VERSION_AX88279) {
+ ax179_data->ip_align = 1;
+ ax179_data->eeprom_read_cmd = AX88179A_FLASH_READ;
+ ax179_data->eeprom_write_cmd = AX88179A_FLASH_WRITE;
+ ax179_data->eeprom_block = 256;
+ ax179_data->eeprom_wen = 1;
+ } else {
+ ax179_data->ip_align = 0;
+ ax179_data->eeprom_read_cmd = AX_ACCESS_EFUS;
+ ax179_data->eeprom_write_cmd = AX_ACCESS_EFUS;
+ ax179_data->eeprom_block = 20;
+ ax179_data->eeprom_wen = 0;
+ }
+
+ dev->net->netdev_ops = &ax88179a_netdev_ops;
+ dev->net->ethtool_ops = &ax88179a_ethtool_ops;
+ dev->net->needed_headroom = 8;
+ dev->net->needed_tailroom = 8;
+ dev->net->min_mtu = ETH_MIN_MTU;
+ dev->hard_mtu = 9 * 1024;
+ dev->net->max_mtu = dev->hard_mtu - dev->net->hard_header_len;
+
+ if (!ax179_data->is_ax88772d)
+ dev->mii.supports_gmii = 1;
+
+ dev->net->features |= NETIF_F_SG | NETIF_F_IP_CSUM |
+ NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO;
+
+ dev->net->hw_features |= dev->net->features;
+
+ dev->net->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM |
+ NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO;
+
+ netif_set_tso_max_size(dev->net, 16384);
+
+ /* Enable Transmission of Link Speed byte in interrupt URB */
+ ax88179_write_cmd(dev, AX_FW_MODE, AX_FW_MODE_179A, 0, 0, NULL);
+ ax88179_write_cmd(dev, AX_RELOAD_EEPROM_EFUSE, 0, 0, 0, NULL);
+
+ /* Read MAC address from DTB or ASIX chip */
+ ax88179_get_mac_addr(dev);
+ memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
+
+ /* Power PHY for probing */
+ ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, AX_PHY_POWER);
+ msleep(250);
+
+ ret = ax88179a_init_mdio(dev);
+ if (ret)
+ goto err_nodev;
+
+ ret = ax88179a_phylink_setup(dev);
+ if (ret)
+ goto phylink_err;
+
+ ret = ax88179a_init_phy(dev);
+ if (ret)
+ goto initphy_err;
+
+ return 0;
+
+initphy_err:
+ phylink_destroy(ax179_data->phylink);
+phylink_err:
+ ax88179a_mdio_unregister(ax179_data);
+err_nodev:
+ kfree(ax179_data);
+ ax179_data = NULL;
+
+ return ret;
+}
+
+static void ax88179a_unbind(struct usbnet *dev, struct usb_interface *intf)
+{
+ struct ax88179_data *ax179_data = dev->driver_priv;
+
+ /* Configure RX control register => stop operation */
+ ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, AX_RX_CTL_STOP);
+
+ rtnl_lock();
+ phylink_disconnect_phy(ax179_data->phylink);
+ rtnl_unlock();
+ phylink_destroy(ax179_data->phylink);
+ ax88179a_mdio_unregister(ax179_data);
+
+ ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, 0);
+
+ kfree(ax179_data);
+}
+
+static void ax88179a_rx_checksum(struct sk_buff *skb, u64 pkt_desc)
+{
+ u32 pkt_type;
+
+ skb->ip_summed = CHECKSUM_NONE;
+ /* checksum error bit is set */
+ if (pkt_desc & AX179A_RX_PD_L4_ERR || pkt_desc & AX179A_RX_PD_L3_ERR)
+ return;
+
+ pkt_type = pkt_desc & AX179A_RX_PD_L4_TYPE_MASK;
+ /* It must be a TCP or UDP packet with a valid checksum */
+ if (pkt_type == AX179A_RX_PD_L4_TCP || pkt_type == AX179A_RX_PD_L4_UDP)
+ skb->ip_summed = CHECKSUM_UNNECESSARY;
+}
+
+static int ax88179a_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
+{
+ struct ax88179_data *ax179_data = dev->driver_priv;
+ struct sk_buff *ax_skb;
+ u32 hdr_off, pkt_end;
+ __le64 *pkt_desc_ptr;
+ u16 vlan_tag;
+ u16 pkt_cnt;
+ u64 rx_hdr;
+
+ /* SKB contents for AX179A-based chips:
+ * <packet 1>
+ * ...
+ * <packet N>
+ * <per-packet metadata entry 1>
+ * ...
+ * <per-packet metadata entry N>
+ * <rx_hdr>
+ *
+ * where:
+ * <packet N> contains pkt_len data bytes and padding:
+ * 2 bytes of IP alignment (optional, depends on AX_RX_CTL_IPE flag)
+ * packet data received
+ * optional padding to 8-bytes boundary
+ * <per-packet metadata entry N> contains 8 bytes:
+ * pkt_len and fields AX_RXHDR_*
+ * <rx-hdr> contains 8 bytes:
+ * pkt_cnt and hdr_off (offset of <per-packet metadata entry 1>)
+ *
+ * pkt_cnt is number of entries in the per-packet metadata array.
+ */
+
+ if (!skb || skb->len < sizeof(rx_hdr))
+ goto err;
+
+ /* RX Descriptor Header */
+ skb_trim(skb, skb->len - sizeof(rx_hdr));
+ rx_hdr = get_unaligned_le64((__le64 *)skb_tail_pointer(skb));
+
+ /* Check these packets */
+ hdr_off = FIELD_GET(AX179A_RX_DH_DESC_OFFSET, rx_hdr);
+ pkt_cnt = rx_hdr & AX179A_RX_DH_PKT_CNT_MASK;
+
+ /* Consistency check header position */
+ if (hdr_off != skb->len - (pkt_cnt * sizeof(rx_hdr)))
+ goto err;
+
+ /* Make sure that the bounds of the metadata array are inside the SKB
+ * (and in front of the counter at the end).
+ */
+ if (pkt_cnt * 8 + hdr_off > skb->len)
+ goto err;
+
+ /* Packets must not overlap the metadata array */
+ skb_trim(skb, hdr_off);
+
+ if (!pkt_cnt)
+ goto err;
+
+ /* Get the first RX packet descriptor */
+ pkt_desc_ptr = (__le64 *)(skb->data + hdr_off);
+
+ pkt_end = 0;
+ while (pkt_cnt--) {
+ u64 pkt_desc = get_unaligned_le64(pkt_desc_ptr);
+ u32 pkt_len_plus_padd;
+ u32 pkt_len;
+
+ pkt_len = FIELD_GET(AX179A_RX_PD_LEN, pkt_desc);
+ pkt_len -= (ax179_data->ip_align ? 2 : 0);
+ pkt_len_plus_padd = ((pkt_len + 7 + (ax179_data->ip_align ? 2 : 0)) & 0x7FFF8);
+
+ pkt_end += pkt_len_plus_padd;
+ if (pkt_end > hdr_off || (pkt_cnt == 0 && pkt_end != hdr_off))
+ goto err;
+
+ if (pkt_desc & AX179A_RX_PD_DROP || !(pkt_desc & AX179A_RX_PD_RX_OK) ||
+ pkt_len > (dev->hard_mtu + AX179A_RX_HW_PAD) || pkt_len < 2 + ETH_HLEN) {
+ skb_pull(skb, pkt_len_plus_padd);
+
+ /* Next RX Packet Descriptor */
+ pkt_desc_ptr++;
+ continue;
+ }
+
+ ax_skb = netdev_alloc_skb_ip_align(dev->net, pkt_len);
+ if (!ax_skb)
+ goto err;
+
+ skb_put(ax_skb, pkt_len);
+ memcpy(ax_skb->data, skb->data + (ax179_data->ip_align ? AX179A_RX_HW_PAD : 0),
+ pkt_len);
+
+ if (ax179_data->rx_checksum)
+ ax88179a_rx_checksum(ax_skb, pkt_desc);
+
+ if (pkt_desc & AX179A_RX_PD_VLAN) {
+ vlan_tag = pkt_desc >> AX179A_RX_PD_VLAN_SHIFT;
+ __vlan_hwaccel_put_tag(ax_skb, htons(ETH_P_8021Q), vlan_tag);
+ }
+
+ usbnet_skb_return(dev, ax_skb);
+ skb_pull(skb, pkt_len_plus_padd);
+
+ /* Next RX Packet Header */
+ pkt_desc_ptr++;
+ }
+
+ return 1;
+
+err:
+ return 0;
+}
+
+static struct sk_buff *ax88179a_tx_fixup(struct usbnet *dev, struct sk_buff *skb, gfp_t flags)
+{
+ u64 tx_desc = skb->len & AX179A_TX_DESC_LEN_MASK;
+ int frame_size = dev->maxpacket;
+ struct sk_buff *ax_skb;
+ u64 *tx_desc_ptr;
+ int padding_size;
+ int headroom;
+ int tailroom;
+ u16 tci = 0;
+
+ /* TSO MSS */
+ tx_desc |= FIELD_PREP(AX179A_TX_DESC_MSS, (u64)skb_shinfo(skb)->gso_size);
+
+ headroom = (skb->len + sizeof(tx_desc)) % 8;
+ padding_size = headroom ? 8 - headroom : 0;
+
+ if (((skb->len + sizeof(tx_desc) + padding_size) % frame_size) == 0) {
+ padding_size += 8;
+ tx_desc |= AX179A_TX_DESC_DROP_PADD;
+ }
+
+ if ((dev->net->features & NETIF_F_HW_VLAN_CTAG_TX) && (vlan_get_tag(skb, &tci) >= 0)) {
+ tx_desc |= AX179A_TX_DESC_VLAN;
+ tx_desc |= FIELD_PREP(AX179A_TX_DESC_VLAN_ID, (u64)tci);
+ }
+
+ if (!dev->can_dma_sg && (dev->net->features & NETIF_F_SG) && skb_linearize(skb)) {
+ dev_kfree_skb_any(skb);
+ return NULL;
+ }
+
+ headroom = skb_headroom(skb);
+ tailroom = skb_tailroom(skb);
+
+ if (skb_cloned(skb) || !(headroom >= sizeof(tx_desc) && tailroom >= padding_size)) {
+ ax_skb = skb_copy_expand(skb, sizeof(tx_desc), padding_size, flags);
+ dev_kfree_skb_any(skb);
+ skb = ax_skb;
+ if (!skb)
+ return NULL;
+ }
+ if (padding_size != 0)
+ skb_put_zero(skb, padding_size);
+ /* Copy TX header */
+ tx_desc_ptr = skb_push(skb, sizeof(tx_desc));
+ put_unaligned_le64(tx_desc, tx_desc_ptr);
+
+ usbnet_set_skb_tx_stats(skb, 1, 0);
+
+ return skb;
+}
+
+static int ax88179a_reset(struct usbnet *dev)
+{
+ struct ax88179_data *ax179_data = dev->driver_priv;
+ u16 *tmp16;
+ u8 buf[5];
+ u16 rxctl;
+ u8 *tmp;
+
+ tmp16 = (u16 *)buf;
+ tmp = (u8 *)buf;
+
+ /* Power up ethernet PHY */
+ ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, AX_PHY_POWER);
+ msleep(250);
+
+ /* Ethernet PHY Auto Detach*/
+ ax88179a_auto_detach(dev);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_BULK_OUT_CTRL, 1, AX_MAC_EFF_EN);
+
+ ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 0);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 0x04);
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, 1, 0x10);
+
+ *tmp = 0;
+ if (dev->net->features & NETIF_F_HW_VLAN_CTAG_FILTER)
+ *tmp |= AX_VLAN_CONTROL_VFE;
+ if (dev->net->features & NETIF_F_HW_VLAN_CTAG_RX)
+ *tmp |= AX_VLAN_CONTROL_VSO;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, tmp);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_BM_INT_MASK, 1, 0xff);
+
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_BM_RX_DMA_CTL, 1, 0);
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_BM_TX_DMA_CTL, 1, 0);
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_ARC_CTRL, 1, 0);
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_SWP_CTRL, 1, 0);
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_TX_HDR_CKSUM, 1, 0);
+
+ /* Read MAC address from DTB or asix chip */
+ ax88179_get_mac_addr(dev);
+ memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
+
+ /* The Bulk-Register configuration for the AX88179A is done in
+ * ax88179a_mac_link_up(), once the link is up for a given link and USB-speed.
+ */
+ if (ax179_data->is_ax88772d)
+ dev->rx_urb_size = 1024 * 24;
+ else
+ dev->rx_urb_size = 1024 * 48;
+
+ /* Enable checksum offload */
+ if (dev->net->features & NETIF_F_RXCSUM) {
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1,
+ AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP |
+ AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6);
+ ax179_data->rx_checksum = 1;
+ } else {
+ ax179_data->rx_checksum = 0;
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 0);
+ }
+
+ *tmp = 0;
+ if (dev->net->features & NETIF_F_IP_CSUM)
+ *tmp = AX_TXCOE_IP | AX_TXCOE_TCP | AX_TXCOE_UDP;
+ if (dev->net->features & NETIF_F_IPV6_CSUM)
+ *tmp |= AX_TXCOE_IP | AX_TXCOE_TCPV6 | AX_TXCOE_UDPV6;
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, *tmp);
+
+ /* Configure RX control register => start operation */
+ rxctl = AX_RX_CTL_DROPCRCERR | AX_RX_CTL_START | AX_RX_CTL_AP |
+ AX_RX_CTL_AMALL | AX_RX_CTL_AB;
+ if (ax179_data->ip_align)
+ rxctl |= AX_RX_CTL_IPE;
+ if (dev->net->flags & IFF_PROMISC)
+ rxctl |= AX_RX_CTL_PRO;
+ WRITE_ONCE(ax179_data->rxctl, rxctl);
+ ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, rxctl);
+
+ if (ax179_data->chip_version < AX_VERSION_AX88179A)
+ *tmp = AX_MONITOR_MODE_PMETYPE | AX_MONITOR_MODE_PMEPOL | AX_MONITOR_MODE_RWMP;
+ else
+ *tmp = AX_MONITOR_MODE_RWMP;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, tmp);
+
+ /* Configure default medium type => giga */
+ *tmp16 = AX_MEDIUM_RECEIVE_EN | AX_MEDIUM_TXFLOW_CTRLEN |
+ AX_MEDIUM_RXFLOW_CTRLEN | AX_MEDIUM_FULL_DUPLEX;
+ if (!ax179_data->is_ax88772d)
+ *tmp16 |= AX_MEDIUM_GIGAMODE;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, tmp16);
+
+ /* Check if WoL is supported */
+ ax179_data->wol_supported = 0;
+ if (ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD,
+ 1, 1, tmp) > 0)
+ ax179_data->wol_supported = WAKE_MAGIC | WAKE_PHY;
+
+ /* Ensure EEE state is off, consistent with phylink setup */
+ ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, false, 0, NULL);
+
+ phylink_start(ax179_data->phylink);
+
+ return 0;
+}
+
+static int ax88179a_stop(struct usbnet *dev)
+{
+ struct ax88179_data *ax179_data = dev->driver_priv;
+ u16 reg16 = 0;
+
+ phylink_stop(ax179_data->phylink);
+
+ ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, ®16);
+ reg16 &= ~AX_MEDIUM_RECEIVE_EN;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, ®16);
+
+ ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 0);
+
+ ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, 0);
+
+ return 0;
+}
+
+const struct driver_info ax88179a_info = {
+ .description = "ASIX AX88179A USB 3.2 Gigabit Ethernet",
+ .bind = ax88179a_bind,
+ .unbind = ax88179a_unbind,
+ .status = ax88179a_status,
+ .reset = ax88179a_reset,
+ .stop = ax88179a_stop,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET | FLAG_AVOID_UNLINK_URBS,
+ .rx_fixup = ax88179a_rx_fixup,
+ .tx_fixup = ax88179a_tx_fixup,
+};
+
+const struct driver_info ax88772d_info = {
+ .description = "ASIX AX88772D/E USB 2.0 Fast Ethernet",
+ .bind = ax88179a_bind,
+ .unbind = ax88179a_unbind,
+ .status = ax88179a_status,
+ .reset = ax88179a_reset,
+ .stop = ax88179a_stop,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET | FLAG_AVOID_UNLINK_URBS,
+ .rx_fixup = ax88179a_rx_fixup,
+ .tx_fixup = ax88179a_tx_fixup,
+};
+
+const struct driver_info ax88279_info = {
+ .description = "ASIX AX88279 USB 3.2 2.5Gigabit Ethernet",
+ .bind = ax88179a_bind,
+ .unbind = ax88179a_unbind,
+ .status = ax88179a_status,
+ .reset = ax88179a_reset,
+ .stop = ax88179a_stop,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET | FLAG_AVOID_UNLINK_URBS,
+ .rx_fixup = ax88179a_rx_fixup,
+ .tx_fixup = ax88179a_tx_fixup,
+};
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 05/13] ax88179_178a: Add EEE configuration support for AX88179A MACs
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (3 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 04/13] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 06/13] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
` (7 subsequent siblings)
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz
The AX88179A uses a simple HW configuration for EEE
via a single EEE configuration register without LPI timer support
Add support for setting this EEE enable/disable register in implementations
of mac_enable_tx_lpi/mac_disable_tx_lpi.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/usb/ax88179a_devices.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
index 1aa8479422517bff6758c884c5e47258c5d3ed3a..62619fd68c408f453e48c94020bce2254da9a1f9 100644
--- a/drivers/net/usb/ax88179a_devices.c
+++ b/drivers/net/usb/ax88179a_devices.c
@@ -395,10 +395,27 @@ static void ax88179a_mac_link_up(struct phylink_config *config,
AX_MAC_RX_PATH_READY | AX_MAC_TX_PATH_READY);
}
+static void ax88179a_mac_disable_tx_lpi(struct phylink_config *config)
+{
+ struct usbnet *dev = netdev_priv(to_net_dev(config->dev));
+
+ ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, false, 0, NULL);
+}
+
+static int ax88179a_mac_enable_tx_lpi(struct phylink_config *config, u32 timer, bool tx_clk_stop)
+{
+ struct usbnet *dev = netdev_priv(to_net_dev(config->dev));
+
+ /* AX88179A does not provide LPI timer registers */
+ return ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, true, 0, NULL);
+}
+
static const struct phylink_mac_ops ax88179a_phylink_mac_ops = {
.mac_config = ax88179a_mac_config,
.mac_link_down = ax88179a_mac_link_down,
.mac_link_up = ax88179a_mac_link_up,
+ .mac_disable_tx_lpi = ax88179a_mac_disable_tx_lpi,
+ .mac_enable_tx_lpi = ax88179a_mac_enable_tx_lpi,
};
static int ax88179a_phylink_setup(struct usbnet *dev)
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 06/13] ax88179_178a: Add EEE configuration support for AX88179A PHYs
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (4 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 05/13] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 07/13] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
` (6 subsequent siblings)
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz, Nicolai Buchwitz
Configure phylink to work with the PHYs in the AX88179A controllers
and provide ethtool get/set eee operations calling into phylink.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
---
drivers/net/usb/ax88179a_devices.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
index 62619fd68c408f453e48c94020bce2254da9a1f9..272e92365683247b42a5fd25013c728a9c1af711 100644
--- a/drivers/net/usb/ax88179a_devices.c
+++ b/drivers/net/usb/ax88179a_devices.c
@@ -225,6 +225,20 @@ static int ax88179a_get_eeprom_len(struct net_device *net)
return AX88179A_EEPROM_LEN;
}
+static int ax88179a_get_eee(struct net_device *net, struct ethtool_keee *edata)
+{
+ struct ax88179_data *ax179_data = netdev2data(net);
+
+ return phylink_ethtool_get_eee(ax179_data->phylink, edata);
+}
+
+static int ax88179a_set_eee(struct net_device *net, struct ethtool_keee *edata)
+{
+ struct ax88179_data *ax179_data = netdev2data(net);
+
+ return phylink_ethtool_set_eee(ax179_data->phylink, edata);
+}
+
static const struct ethtool_ops ax88179a_ethtool_ops = {
.get_link = ethtool_op_get_link,
.get_msglevel = usbnet_get_msglevel,
@@ -234,6 +248,8 @@ static const struct ethtool_ops ax88179a_ethtool_ops = {
.get_eeprom_len = ax88179a_get_eeprom_len,
.get_eeprom = ax88179_get_eeprom,
.set_eeprom = ax88179_set_eeprom,
+ .get_eee = ax88179a_get_eee,
+ .set_eee = ax88179a_set_eee,
.nway_reset = phy_ethtool_nway_reset,
.get_link_ksettings = ax88179a_get_link_ksettings,
.set_link_ksettings = ax88179a_set_link_ksettings,
@@ -451,6 +467,10 @@ static int ax88179a_phylink_setup(struct usbnet *dev)
phy_if_mode = PHY_INTERFACE_MODE_SGMII;
}
+ memcpy(data->phylink_config.lpi_interfaces,
+ data->phylink_config.supported_interfaces,
+ sizeof(data->phylink_config.lpi_interfaces));
+
phylink = phylink_create(&data->phylink_config, dev->net->dev.fwnode,
phy_if_mode, &ax88179a_phylink_mac_ops);
if (IS_ERR(phylink))
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 07/13] ax88179_178a: Add VLAN offload support for AX88179A
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (5 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 06/13] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 08/13] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
` (5 subsequent siblings)
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz
The AX88179A-based chips support VLAN offload. Add configuration
support in netdev_ops. Features supported are:
NETIF_F_HW_VLAN_CTAG_TX, NETIF_F_HW_VLAN_CTAG_RX
and NETIF_F_HW_VLAN_CTAG_FILTER.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Error-checking fixes Suggested-by: Jianhui Xu <neuromoments@gmail.com>
---
drivers/net/usb/ax88179a_devices.c | 158 ++++++++++++++++++++++++++++++++++++-
1 file changed, 157 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
index 272e92365683247b42a5fd25013c728a9c1af711..4207d2cc2b865e5780b3c7f5ba2645a6242df477 100644
--- a/drivers/net/usb/ax88179a_devices.c
+++ b/drivers/net/usb/ax88179a_devices.c
@@ -258,6 +258,88 @@ static const struct ethtool_ops ax88179a_ethtool_ops = {
.get_ts_info = ethtool_op_get_ts_info,
};
+static int ax88179a_vlan_rx_kill_vid(struct net_device *net, __be16 proto, u16 vid)
+{
+ struct usbnet *dev = netdev_priv(net);
+ u16 reg16 = 0;
+ u8 vlan_ctrl;
+ int ret = 0;
+ u8 reg8 = 0;
+
+ ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, ®8);
+ if (ret < 0)
+ return ret;
+ vlan_ctrl = reg8;
+
+ /* Address */
+ reg8 = (vid / 16);
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_ADDRESS, 1, 1, ®8);
+ if (ret < 0)
+ return ret;
+
+ /* Data */
+ reg8 = vlan_ctrl | AX_VLAN_CONTROL_RD;
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, ®8);
+ if (ret < 0)
+ return ret;
+
+ ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®16);
+ if (ret < 0)
+ return ret;
+ reg16 &= ~(1 << (vid % 16));
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®16);
+ if (ret < 0)
+ return ret;
+
+ reg8 = vlan_ctrl | AX_VLAN_CONTROL_WE;
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, ®8);
+ if (ret < 0)
+ return ret;
+
+ return 0;
+}
+
+static int ax88179a_vlan_rx_add_vid(struct net_device *net, __be16 proto, u16 vid)
+{
+ struct usbnet *dev = netdev_priv(net);
+ u8 vlan_ctrl;
+ int ret = 0;
+ u16 reg16;
+ u8 reg8;
+
+ ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, ®8);
+ if (ret < 0)
+ return ret;
+ vlan_ctrl = reg8;
+
+ /* Address */
+ reg8 = (vid / 16);
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_ADDRESS, 1, 1, ®8);
+ if (ret < 0)
+ return ret;
+
+ /* Data */
+ reg8 = vlan_ctrl | AX_VLAN_CONTROL_RD;
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, ®8);
+ if (ret < 0)
+ return ret;
+
+ ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®16);
+ if (ret < 0)
+ return ret;
+ reg16 |= (1 << (vid % 16));
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®16);
+ if (ret < 0)
+ return ret;
+
+ reg8 = vlan_ctrl | AX_VLAN_CONTROL_WE;
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, ®8);
+ if (ret < 0)
+ return ret;
+
+ return 0;
+}
+
static void ax88179a_mdio_unregister(struct ax88179_data *data)
{
mdiobus_unregister(data->mdio);
@@ -517,6 +599,75 @@ static int ax88179a_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd)
return phylink_mii_ioctl(data->phylink, rq, cmd);
}
+static int ax88179a_set_features(struct net_device *net, netdev_features_t features)
+{
+ struct usbnet *dev = netdev_priv(net);
+ netdev_features_t changed;
+ int ret;
+ u8 tmp;
+
+ changed = net->features ^ features;
+
+ ret = ax88179_set_features(net, features);
+ if (ret)
+ return ret;
+
+ if (changed & NETIF_F_HW_VLAN_CTAG_FILTER) {
+ if (features & NETIF_F_HW_VLAN_CTAG_FILTER) {
+ u8 vlan_state = 0;
+
+ ret = ax88179_read_cmd(dev, AX_ACCESS_MAC,
+ AX88179A_VLAN_ID_CONTROL, 1, 1, &vlan_state);
+ if (ret < 0)
+ return ret;
+
+ for (int i = 0; i < 256; i++) {
+ /* Address */
+ tmp = i;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_ADDRESS,
+ 1, 1, &tmp);
+ /* Data */
+ ax88179_write_u16(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0,
+ 2, 0);
+ /* Write-Execute */
+ ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL,
+ 1, vlan_state | AX_VLAN_CONTROL_WE);
+ }
+ vlan_state |= AX_VLAN_CONTROL_VFE;
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC,
+ AX88179A_VLAN_ID_CONTROL, 1, 1, &vlan_state);
+ if (ret < 0)
+ return ret;
+ } else {
+ ret = ax88179_read_cmd(dev, AX_ACCESS_MAC,
+ AX88179A_VLAN_ID_CONTROL, 1, 1, &tmp);
+ if (ret < 0)
+ return ret;
+ tmp &= ~AX_VLAN_CONTROL_VFE;
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC,
+ AX88179A_VLAN_ID_CONTROL, 1, 1, &tmp);
+ if (ret < 0)
+ return ret;
+ }
+ }
+
+ if (changed & NETIF_F_HW_VLAN_CTAG_RX) {
+ ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL,
+ 1, 1, &tmp);
+ if (ret < 0)
+ return ret;
+ if (features & NETIF_F_HW_VLAN_CTAG_RX)
+ tmp |= AX_VLAN_CONTROL_VSO;
+ else
+ tmp &= ~AX_VLAN_CONTROL_VSO;
+ ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL,
+ 1, 1, &tmp);
+ if (ret < 0)
+ return ret;
+ }
+ return 0;
+}
+
static const struct net_device_ops ax88179a_netdev_ops = {
.ndo_open = usbnet_open,
.ndo_stop = usbnet_stop,
@@ -527,6 +678,9 @@ static const struct net_device_ops ax88179a_netdev_ops = {
.ndo_set_mac_address = ax88179_set_mac_addr,
.ndo_validate_addr = eth_validate_addr,
.ndo_eth_ioctl = ax88179a_mii_ioctl,
+ .ndo_set_features = ax88179a_set_features,
+ .ndo_vlan_rx_add_vid = ax88179a_vlan_rx_add_vid,
+ .ndo_vlan_rx_kill_vid = ax88179a_vlan_rx_kill_vid,
};
static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf)
@@ -612,9 +766,11 @@ static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf)
dev->mii.supports_gmii = 1;
dev->net->features |= NETIF_F_SG | NETIF_F_IP_CSUM |
- NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO;
+ NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO |
+ NETIF_F_HW_VLAN_CTAG_TX;
dev->net->hw_features |= dev->net->features;
+ dev->net->hw_features |= NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_CTAG_FILTER;
dev->net->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM |
NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO;
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 08/13] ax88179_178a: Add AX179A/AX279 multicast configuration
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (6 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 07/13] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 09/13] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
` (4 subsequent siblings)
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz
Add support for conditionally setting the ip_alignement flag
AX_RX_CTL_IPE in AX_RX_CTL and make sure that AX_RX_CTL_DROPCRCERR
is also set to be consistent with the initial configuration in
ax88179_reset()
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/usb/ax88179_lib.c | 16 +++++++++++-----
drivers/net/usb/ax88179a_devices.c | 1 +
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
index a314db4c9766679568a036f98acf868784835865..b4b00c8b4b62320471e13ae34a1fed5d02e80441 100644
--- a/drivers/net/usb/ax88179_lib.c
+++ b/drivers/net/usb/ax88179_lib.c
@@ -321,16 +321,21 @@ int ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8
void ax88179_set_multicast(struct net_device *net)
{
struct usbnet *dev = netdev_priv(net);
- struct ax88179_data *data = dev->driver_priv;
u8 *m_filter = ((u8 *)dev->data);
+ struct ax88179_data *data;
+ u16 rxctl = 0;
+
+ data = dev->driver_priv;
- data->rxctl = (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_IPE);
+ rxctl = (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_DROPCRCERR);
+ if (data->ip_align)
+ rxctl |= AX_RX_CTL_IPE;
if (net->flags & IFF_PROMISC) {
- data->rxctl |= AX_RX_CTL_PRO;
+ rxctl |= AX_RX_CTL_PRO;
} else if (net->flags & IFF_ALLMULTI ||
netdev_mc_count(net) > AX_MAX_MCAST) {
- data->rxctl |= AX_RX_CTL_AMALL;
+ rxctl |= AX_RX_CTL_AMALL;
} else if (netdev_mc_empty(net)) {
/* just broadcast and directed */
} else {
@@ -351,9 +356,10 @@ void ax88179_set_multicast(struct net_device *net)
AX_MCAST_FLTSIZE, AX_MCAST_FLTSIZE,
m_filter);
- data->rxctl |= AX_RX_CTL_AM;
+ rxctl |= AX_RX_CTL_AM;
}
+ WRITE_ONCE(data->rxctl, rxctl);
ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_RX_CTL,
2, 2, &data->rxctl);
}
diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
index 4207d2cc2b865e5780b3c7f5ba2645a6242df477..a6b0a3f47118c46db38d483792c083510aa2641a 100644
--- a/drivers/net/usb/ax88179a_devices.c
+++ b/drivers/net/usb/ax88179a_devices.c
@@ -678,6 +678,7 @@ static const struct net_device_ops ax88179a_netdev_ops = {
.ndo_set_mac_address = ax88179_set_mac_addr,
.ndo_validate_addr = eth_validate_addr,
.ndo_eth_ioctl = ax88179a_mii_ioctl,
+ .ndo_set_rx_mode = ax88179_set_multicast,
.ndo_set_features = ax88179a_set_features,
.ndo_vlan_rx_add_vid = ax88179a_vlan_rx_add_vid,
.ndo_vlan_rx_kill_vid = ax88179a_vlan_rx_kill_vid,
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 09/13] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (7 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 08/13] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 10/13] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
` (3 subsequent siblings)
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz
The suspend and resume functions are called via the usb_driver structure,
for which the driver has only a single instance. Add wrapper functions
for the different implementations for the AX88179 and AX179A architecutres
in ax88179_lib which calls the 2 implementations in ax88179_178a and
ax88179a_devices, respectively.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Suggested-by: Jianhui Xu <neuromoments@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/usb/ax88179_178a.c | 9 ++-
drivers/net/usb/ax88179_lib.c | 19 ++++++
drivers/net/usb/ax88179_lib.h | 4 ++
drivers/net/usb/ax88179a_devices.c | 129 +++++++++++++++++++++++++++++++++++--
4 files changed, 153 insertions(+), 8 deletions(-)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index f78ad344c1c4f1f057164728e4f21f875e6cdc1a..b077b7153f0c07676aafd5dfd13a2c0d9a826719 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -685,6 +685,9 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
dev->driver_priv = ax179_data;
mutex_init(&ax179_data->medium_status_mutex);
+ ax179_data->resume = ax88179_resume;
+ ax179_data->suspend = ax88179_suspend;
+
ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_CHIP_STATUS,
1, 1, &ax179_data->chip_version);
if (ret < 0)
@@ -1362,9 +1365,9 @@ static struct usb_driver ax88179_178a_driver = {
.name = "ax88179_178a",
.id_table = products,
.probe = usbnet_probe,
- .suspend = ax88179_suspend,
- .resume = ax88179_resume,
- .reset_resume = ax88179_resume,
+ .suspend = ax88179_suspend_wrapper,
+ .resume = ax88179_resume_wrapper,
+ .reset_resume = ax88179_resume_wrapper,
.disconnect = ax88179_disconnect,
.supports_autosuspend = 1,
.disable_hub_initiated_lpm = 1,
diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
index b4b00c8b4b62320471e13ae34a1fed5d02e80441..b54e98e781f334c5aeff0b3d2861a5565934454c 100644
--- a/drivers/net/usb/ax88179_lib.c
+++ b/drivers/net/usb/ax88179_lib.c
@@ -495,3 +495,22 @@ int ax88179_set_mac_addr(struct net_device *net, void *p)
return 0;
}
+int ax88179_suspend_wrapper(struct usb_interface *intf, pm_message_t message)
+{
+ struct usbnet *dev = usb_get_intfdata(intf);
+ struct ax88179_data *priv;
+
+ priv = dev->driver_priv;
+
+ return priv->suspend(intf, message);
+}
+
+int ax88179_resume_wrapper(struct usb_interface *intf)
+{
+ struct usbnet *dev = usb_get_intfdata(intf);
+ struct ax88179_data *priv;
+
+ priv = dev->driver_priv;
+ return priv->resume(intf);
+}
+
diff --git a/drivers/net/usb/ax88179_lib.h b/drivers/net/usb/ax88179_lib.h
index adc2b4598bb52d80c18a6e2cc467144d3bd57a88..401c0bed3d28b4b94f0a0cad7509cd7087ef0639 100644
--- a/drivers/net/usb/ax88179_lib.h
+++ b/drivers/net/usb/ax88179_lib.h
@@ -315,6 +315,8 @@ struct ax88179_data {
struct phy_device *phydev;
struct phylink *phylink;
struct phylink_config phylink_config;
+ int (*resume)(struct usb_interface *intf);
+ int (*suspend)(struct usb_interface *intf, pm_message_t message);
};
struct ax88179_int_data {
@@ -348,6 +350,8 @@ int ax88179_set_features(struct net_device *net, netdev_features_t features);
void ax88179_get_mac_addr(struct usbnet *dev);
int ax88179_change_mtu(struct net_device *net, int new_mtu);
int ax88179_set_mac_addr(struct net_device *net, void *p);
+int ax88179_suspend_wrapper(struct usb_interface *intf, pm_message_t message);
+int ax88179_resume_wrapper(struct usb_interface *intf);
extern const struct driver_info ax88179a_info;
extern const struct driver_info ax88772d_info;
diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
index a6b0a3f47118c46db38d483792c083510aa2641a..01d6a35f68b2c56f79acbe2875ce8e99ccdfb197 100644
--- a/drivers/net/usb/ax88179a_devices.c
+++ b/drivers/net/usb/ax88179a_devices.c
@@ -5,6 +5,8 @@
#include <linux/if_vlan.h>
#include "ax88179_lib.h"
+static int ax88179a_reset(struct usbnet *dev);
+
#define AX88279_EEPROM_LEN 0x4000
#define AX88179A_EEPROM_LEN (32 * 20)
@@ -126,6 +128,63 @@ static void ax88179a_status(struct usbnet *dev, struct urb *urb)
phylink_mac_interrupt(data->phylink);
}
+static int ax88179a_suspend(struct usb_interface *intf, pm_message_t message)
+{
+ struct usbnet *dev = usb_get_intfdata(intf);
+ struct ax88179_data *priv;
+ u8 tmp8 = 0;
+ u16 tmp16;
+ int ret;
+
+ priv = dev->driver_priv;
+ ax88179_set_pm_mode(dev, true);
+
+ if (netif_running(dev->net)) {
+ rtnl_lock();
+ phylink_suspend(priv->phylink, !!priv->wolopts);
+ rtnl_unlock();
+ }
+
+ ret = usbnet_suspend(intf, message);
+ if (ret && netif_running(dev->net)) {
+ rtnl_lock();
+ phylink_resume(priv->phylink);
+ rtnl_unlock();
+ ax88179_set_pm_mode(dev, false);
+ return ret;
+ }
+
+ /* Enable WoL */
+ if (priv->wolopts) {
+ ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, &tmp8);
+ tmp8 &= ~(AX_MONITOR_MODE_RWLC | AX_MONITOR_MODE_RWMP);
+ if (priv->wolopts & WAKE_PHY)
+ tmp8 |= AX_MONITOR_MODE_RWLC;
+ if (priv->wolopts & WAKE_MAGIC)
+ tmp8 |= AX_MONITOR_MODE_RWMP;
+
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, &tmp8);
+
+ ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, &tmp16);
+ tmp16 |= AX_MEDIUM_RECEIVE_EN;
+ ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, &tmp16);
+
+ if (priv->chip_version == AX_VERSION_AX88279)
+ ax88179_write_cmd(dev, AX88179A_WAKEUP_SETTING, 8,
+ EPHY_LOW_POWER_EN | S5_WOL_EN
+ | S5_WOL_LOW_POWER | 0x8000, 0, NULL);
+ else
+ ax88179_write_cmd(dev, AX88179A_WAKEUP_SETTING, 0,
+ EPHY_LOW_POWER_EN, 0, NULL);
+
+ } else if (priv->chip_version == AX_VERSION_AX88279) {
+ ax88179_write_cmd(dev, AX88179A_WAKEUP_SETTING, 8, 0x8000, 0, NULL);
+ }
+
+ ax88179_set_pm_mode(dev, false);
+ return 0;
+}
+
static int ax88179a_auto_detach(struct usbnet *dev)
{
u16 tmp16;
@@ -135,6 +194,47 @@ static int ax88179a_auto_detach(struct usbnet *dev)
return 0;
}
+static int ax88179a_resume(struct usb_interface *intf)
+{
+ struct usbnet *dev = usb_get_intfdata(intf);
+ struct ax88179_data *ax179_data;
+ u8 reg8 = 0;
+ int ret;
+
+ ax179_data = dev->driver_priv;
+ ax88179_set_pm_mode(dev, true);
+
+ ret = ax88179_read_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, ®8);
+ if (ret < 0)
+ goto err_out;
+
+ if (!(reg8 & AX_PHY_POWER)) {
+ reg8 = AX_PHY_POWER;
+ ax88179_write_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, ®8);
+ msleep(250);
+ }
+ ax88179_write_cmd(dev, AX_FW_MODE, AX_FW_MODE_179A, 0, 0, NULL);
+
+ /* Now, that AX_FW_MODE_179A is enabled, the PHY needs a power-cycle.
+ * PHY-power is re-enabled in ax88179a_reset()
+ */
+ ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, 0);
+ msleep(250);
+
+ ax88179a_reset(dev);
+
+err_out:
+ if (netif_running(dev->net)) {
+ rtnl_lock();
+ phylink_resume(ax179_data->phylink);
+ rtnl_unlock();
+ }
+
+ ax88179_set_pm_mode(dev, false);
+
+ return usbnet_resume(intf);
+}
+
static void ax88179a_bulkin_config(struct usbnet *dev, u8 link_sts, u8 speed, bool full_duplex)
{
struct ax88179_data *ax179_data = dev->driver_priv;
@@ -755,6 +855,9 @@ static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf)
ax179_data->eeprom_wen = 0;
}
+ ax179_data->resume = ax88179a_resume;
+ ax179_data->suspend = ax88179a_suspend;
+
dev->net->netdev_ops = &ax88179a_netdev_ops;
dev->net->ethtool_ops = &ax88179a_ethtool_ops;
dev->net->needed_headroom = 8;
@@ -802,6 +905,13 @@ static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf)
if (ret)
goto initphy_err;
+ /* Keep this interface runtime-PM active by taking a usage ref.
+ * Prevents runtime suspend while bound and avoids resume paths
+ * that could deadlock (autoresume under RTNL while USB PM lock
+ * is held, phylink/MDIO wants RTNL).
+ */
+ pm_runtime_get_noresume(&intf->dev);
+
return 0;
initphy_err:
@@ -829,7 +939,8 @@ static void ax88179a_unbind(struct usbnet *dev, struct usb_interface *intf)
ax88179a_mdio_unregister(ax179_data);
ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, 0);
-
+ /* Drop the PM usage ref taken in bind() */
+ pm_runtime_put_noidle(&intf->dev);
kfree(ax179_data);
}
@@ -1055,9 +1166,13 @@ static int ax88179a_reset(struct usbnet *dev)
ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_SWP_CTRL, 1, 0);
ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_TX_HDR_CKSUM, 1, 0);
- /* Read MAC address from DTB or asix chip */
- ax88179_get_mac_addr(dev);
- memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
+ /* Read MAC address from DTB or asix chip, except when called
+ * from resume context.
+ */
+ if (!ax179_data->in_pm) {
+ ax88179_get_mac_addr(dev);
+ memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
+ }
/* The Bulk-Register configuration for the AX88179A is done in
* ax88179a_mac_link_up(), once the link is up for a given link and USB-speed.
@@ -1117,7 +1232,11 @@ static int ax88179a_reset(struct usbnet *dev)
/* Ensure EEE state is off, consistent with phylink setup */
ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, false, 0, NULL);
- phylink_start(ax179_data->phylink);
+ /* ax88179a_reset() may also be called from resume context,
+ * phylink_resume() will start phylink, then.
+ */
+ if (!ax179_data->in_pm)
+ phylink_start(ax179_data->phylink);
return 0;
}
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 10/13] ax88179_178a: Add ethtool get_drvinfo
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (8 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 09/13] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 11/13] ax88179_178a: Update driver name and information Birger Koblitz
` (2 subsequent siblings)
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz, Nicolai Buchwitz
Add ax88179a_get_drvinfo() as implementation of get_drvinfo, in order
to provide information about the device firmware.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
---
drivers/net/usb/ax88179a_devices.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
index 01d6a35f68b2c56f79acbe2875ce8e99ccdfb197..69095110e70435806a99274c50d79e86016ec9a0 100644
--- a/drivers/net/usb/ax88179a_devices.c
+++ b/drivers/net/usb/ax88179a_devices.c
@@ -235,6 +235,20 @@ static int ax88179a_resume(struct usb_interface *intf)
return usbnet_resume(intf);
}
+static void ax88179a_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *info)
+{
+ struct ax88179_data *priv = netdev2data(net);
+
+ /* Inherit standard device info */
+ usbnet_get_drvinfo(net, info);
+ if (priv->chip_version < AX_VERSION_AX88179A)
+ return;
+
+ snprintf(info->fw_version, sizeof(info->fw_version), "%d.%d.%d.%d",
+ priv->fw_version[0], priv->fw_version[1],
+ priv->fw_version[2], priv->fw_version[3]);
+}
+
static void ax88179a_bulkin_config(struct usbnet *dev, u8 link_sts, u8 speed, bool full_duplex)
{
struct ax88179_data *ax179_data = dev->driver_priv;
@@ -340,6 +354,7 @@ static int ax88179a_set_eee(struct net_device *net, struct ethtool_keee *edata)
}
static const struct ethtool_ops ax88179a_ethtool_ops = {
+ .get_drvinfo = ax88179a_get_drvinfo,
.get_link = ethtool_op_get_link,
.get_msglevel = usbnet_get_msglevel,
.set_msglevel = usbnet_set_msglevel,
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 11/13] ax88179_178a: Update driver name and information
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (9 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 10/13] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 12/13] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
2026-11-06 7:21 ` [PATCH net-next v20 13/13] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz, Nicolai Buchwitz
Add additionally supported devices to Kconfig description, add
further requirements such as PHYLINK.
Update driver name in usb_driver and update MODULE_DESCRIPTION
to include the additionally supported chips.
Change Kconfig symbol name from USB_NET_AX88179_178A to USB_NET_AX88179
and update loongson32_defconfig/loongson64_defconfig to use that
symbol.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
---
arch/loongarch/configs/loongson32_defconfig | 2 +-
arch/loongarch/configs/loongson64_defconfig | 2 +-
drivers/net/usb/Kconfig | 10 +++++++---
drivers/net/usb/Makefile | 2 +-
drivers/net/usb/ax88179_178a.c | 8 ++++----
5 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/arch/loongarch/configs/loongson32_defconfig b/arch/loongarch/configs/loongson32_defconfig
index dbef879935f322e6167b4ed878ad4cb20048c6db..a039b8e8d242073c16ea281cf8734068a1a9b29f 100644
--- a/arch/loongarch/configs/loongson32_defconfig
+++ b/arch/loongarch/configs/loongson32_defconfig
@@ -641,7 +641,7 @@ CONFIG_USB_RTL8150=m
CONFIG_USB_RTL8152=m
CONFIG_USB_USBNET=m
# CONFIG_USB_NET_AX8817X is not set
-# CONFIG_USB_NET_AX88179_178A is not set
+# CONFIG_USB_NET_AX88179 is not set
CONFIG_USB_NET_CDC_EEM=m
CONFIG_USB_NET_HUAWEI_CDC_NCM=m
CONFIG_USB_NET_CDC_MBIM=m
diff --git a/arch/loongarch/configs/loongson64_defconfig b/arch/loongarch/configs/loongson64_defconfig
index 4f8bb77b8a1e6e30bcbd6e96d7e38b5054630ea0..b30415c03fa185cae77e81ded929c743ef22ee40 100644
--- a/arch/loongarch/configs/loongson64_defconfig
+++ b/arch/loongarch/configs/loongson64_defconfig
@@ -657,7 +657,7 @@ CONFIG_USB_RTL8150=m
CONFIG_USB_RTL8152=m
CONFIG_USB_USBNET=m
# CONFIG_USB_NET_AX8817X is not set
-# CONFIG_USB_NET_AX88179_178A is not set
+# CONFIG_USB_NET_AX88179 is not set
CONFIG_USB_NET_CDC_EEM=m
CONFIG_USB_NET_HUAWEI_CDC_NCM=m
CONFIG_USB_NET_CDC_MBIM=m
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 115990b0d9537aea2776544c9768b034f32aa7a4..27862e380bdb4a54d184fa8618e4c9b348354e84 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -195,11 +195,12 @@ config USB_NET_AX8817X
This driver creates an interface named "ethX", where X depends on
what other networking devices you have in use.
-config USB_NET_AX88179_178A
- tristate "ASIX AX88179/178A USB 3.0/2.0 to Gigabit Ethernet"
+config USB_NET_AX88179
+ tristate "ASIX AX88179/179A/178A USB 2.0/3.0 to 100M/1G/2.5GbE Adapters"
depends on USB_USBNET
- select CRC32
select PHYLINK
+ select AX88796B_PHY
+ select CRC32
default y
help
This option adds support for ASIX AX88179 based USB 3.0/2.0
@@ -207,6 +208,9 @@ config USB_NET_AX88179_178A
This driver should work with at least the following devices:
* ASIX AX88179
+ * ASIX AX88179A/B
+ * ASIX AX88279
+ * ASIX AX88772D/E
* ASIX AX88178A
* Sitcomm LN-032
diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile
index 2ecead0181eaf8d66fb6f5dbd6f2905b22b6eb57..4026f19ecb826a6465de38f1d9bb0e4c0af80421 100644
--- a/drivers/net/usb/Makefile
+++ b/drivers/net/usb/Makefile
@@ -12,7 +12,7 @@ obj-$(CONFIG_USB_HSO) += hso.o
obj-$(CONFIG_USB_LAN78XX) += lan78xx.o
obj-$(CONFIG_USB_NET_AX8817X) += asix.o
asix-y := asix_devices.o asix_common.o ax88172a.o
-obj-$(CONFIG_USB_NET_AX88179_178A) += ax88179.o
+obj-$(CONFIG_USB_NET_AX88179) += ax88179.o
ax88179-y := ax88179_178a.o ax88179a_devices.o ax88179_lib.o
obj-$(CONFIG_USB_NET_CDCETHER) += cdc_ether.o
obj-$(CONFIG_USB_NET_CDC_EEM) += cdc_eem.o
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index b077b7153f0c07676aafd5dfd13a2c0d9a826719..88dce368eacfeee5df4062ff277041427f6ff475 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1361,8 +1361,8 @@ static const struct usb_device_id products[] = {
};
MODULE_DEVICE_TABLE(usb, products);
-static struct usb_driver ax88179_178a_driver = {
- .name = "ax88179_178a",
+static struct usb_driver ax88179_driver = {
+ .name = "ax88179",
.id_table = products,
.probe = usbnet_probe,
.suspend = ax88179_suspend_wrapper,
@@ -1373,8 +1373,8 @@ static struct usb_driver ax88179_178a_driver = {
.disable_hub_initiated_lpm = 1,
};
-module_usb_driver(ax88179_178a_driver);
+module_usb_driver(ax88179_driver);
-MODULE_DESCRIPTION("ASIX AX88179/178A based USB 3.0/2.0 Gigabit Ethernet Devices");
+MODULE_DESCRIPTION("ASIX AX88179/179A/178A/279 based USB 3.0/2.0 100M/1G/2.5GbE Controllers");
MODULE_LICENSE("GPL");
MODULE_ALIAS("ax88179_178a");
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 12/13] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (10 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 11/13] ax88179_178a: Update driver name and information Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 13/13] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz
The AX88179A/772D devices have 32 efuses with 20 bytes each,
which can be randomly programmed. The AX88279 has 16K FLASH.
Provide ethtool read capability for these devices. However,
no write access is provided.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/usb/ax88179_lib.c | 56 +++++++++++++++++++++++++++++++++----------
1 file changed, 43 insertions(+), 13 deletions(-)
diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
index b54e98e781f334c5aeff0b3d2861a5565934454c..d5bbaa0c4e4c6f978722a6ec4461bb1d45679e15 100644
--- a/drivers/net/usb/ax88179_lib.c
+++ b/drivers/net/usb/ax88179_lib.c
@@ -210,36 +210,61 @@ int ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
return 0;
}
+static void
+ax88179_eeprom_access_params(struct ax88179_data *ax179_data, int i, u16 *value, u16 *idx)
+{
+ /* AX88179 has a word-addressable EEPROM
+ * AX88179A uses EFUSES with 20 bytes length
+ * AX88279 has an EEPROM addressable in 256 byte blocks
+ */
+ if (ax179_data->chip_version < AX_VERSION_AX88179A) {
+ *value = i;
+ *idx = 1;
+ } else if (ax179_data->chip_version == AX_VERSION_AX88279) {
+ *value = (i * ax179_data->eeprom_block) >> 16;
+ *idx = (i * ax179_data->eeprom_block) & 0xffff;
+ } else {
+ *value = i << 4;
+ *idx = 0;
+ }
+}
+
int ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8 *data)
{
struct usbnet *dev = netdev_priv(net);
- u16 *eeprom_buff;
- int first_word, last_word;
- int i, ret;
+ struct ax88179_data *ax179_data;
+ int first, last, i, ret;
+ u8 *eeprom_buff;
+
+ ax179_data = dev->driver_priv;
if (eeprom->len == 0)
return -EINVAL;
eeprom->magic = AX88179_EEPROM_MAGIC;
- first_word = eeprom->offset >> 1;
- last_word = (eeprom->offset + eeprom->len - 1) >> 1;
- eeprom_buff = kmalloc_array(last_word - first_word + 1, sizeof(u16),
- GFP_KERNEL);
+ first = eeprom->offset / ax179_data->eeprom_block;
+ last = (eeprom->offset + eeprom->len - 1) / ax179_data->eeprom_block;
+
+ eeprom_buff = kzalloc((last - first + 1) * ax179_data->eeprom_block, GFP_KERNEL);
if (!eeprom_buff)
return -ENOMEM;
- /* ax88179/178A returns 2 bytes from eeprom on read */
- for (i = first_word; i <= last_word; i++) {
- ret = __ax88179_read_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2,
- &eeprom_buff[i - first_word]);
- if (ret < 0) {
+ for (i = first; i <= last; i++) {
+ u16 value, idx;
+
+ ax88179_eeprom_access_params(ax179_data, i, &value, &idx);
+ ret = __ax88179_read_cmd(dev, ax179_data->eeprom_read_cmd,
+ value, idx, ax179_data->eeprom_block,
+ eeprom_buff + (i - first) * ax179_data->eeprom_block);
+
+ if (ret != ax179_data->eeprom_block) {
kfree(eeprom_buff);
return -EIO;
}
}
- memcpy(data, (u8 *)eeprom_buff + (eeprom->offset & 1), eeprom->len);
+ memcpy(data, eeprom_buff + eeprom->offset % ax179_data->eeprom_block, eeprom->len);
kfree(eeprom_buff);
return 0;
}
@@ -247,12 +272,17 @@ int ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8
int ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8 *data)
{
struct usbnet *dev = netdev_priv(net);
+ struct ax88179_data *ax179_data;
u16 *eeprom_buff;
int first_word;
int last_word;
int ret;
int i;
+ ax179_data = dev->driver_priv;
+ if (ax179_data->chip_version >= AX_VERSION_AX88179A)
+ return -EOPNOTSUPP;
+
netdev_dbg(net, "write EEPROM len %d, offset %d, magic 0x%x\n",
eeprom->len, eeprom->offset, eeprom->magic);
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH net-next v20 13/13] ax88796b: Add support for AX88772D, AX88179A and AX88279
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
` (11 preceding siblings ...)
2026-11-06 7:21 ` [PATCH net-next v20 12/13] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
@ 2026-11-06 7:21 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
12 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 7:21 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Jakub Kicinski, Paolo Abeni,
Russell King, Andrew Lunn, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Birger Koblitz
The AX88772D, AX88179A and AX88279 are 100MBit, 1GBit and respectively
2.5 GBit PHYs that are found in ASIX USB-Ethernet controllers of the
same name.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/phy/ax88796b.c | 165 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 165 insertions(+)
diff --git a/drivers/net/phy/ax88796b.c b/drivers/net/phy/ax88796b.c
index f20ddf64914993f7097070d1f56c1103ec1e40e8..0df44e0e236abb02e16cb7885d0c743f0a2c501d 100644
--- a/drivers/net/phy/ax88796b.c
+++ b/drivers/net/phy/ax88796b.c
@@ -13,6 +13,19 @@
#define PHY_ID_ASIX_AX88772A 0x003b1861
#define PHY_ID_ASIX_AX88772C 0x003b1881
#define PHY_ID_ASIX_AX88796B 0x003b1841
+#define PHY_ID_ASIX_AX88772D 0x003b772d
+#define PHY_ID_ASIX_AX88179A 0x003b179a
+#define PHY_ID_ASIX_AX88279 0x003b2790
+
+#define AX_ADVERTISE_2500 0x1000
+
+/* MII Vendor registers */
+#define AX_CTRL_STATUS 0x1d
+#define AX_CTRL_STATUS_SPEED_MASK 0x0c
+#define AX_CTRL_STATUS_SPEED_10 0x0
+#define AX_CTRL_STATUS_SPEED_100 0x4
+#define AX_CTRL_STATUS_SPEED_1000 0x8
+#define AX_CTRL_STATUS_SPEED_2500 0xc
MODULE_DESCRIPTION("Asix PHY driver");
MODULE_AUTHOR("Michael Schmitz <schmitzmic@gmail.com>");
@@ -83,6 +96,107 @@ static int asix_ax88772a_read_status(struct phy_device *phydev)
return 0;
}
+static int asix_ax88279_read_status(struct phy_device *phydev)
+{
+ int ret, val;
+
+ ret = genphy_read_status(phydev);
+ if (ret)
+ return ret;
+
+ if (!phydev->link)
+ return 0;
+
+ /* Read actual speed from vendor register */
+ val = phy_read(phydev, AX_CTRL_STATUS);
+ if (val < 0)
+ return val;
+
+ switch (val & AX_CTRL_STATUS_SPEED_MASK) {
+ case AX_CTRL_STATUS_SPEED_2500:
+ phydev->speed = SPEED_2500;
+ break;
+ case AX_CTRL_STATUS_SPEED_1000:
+ phydev->speed = SPEED_1000;
+ break;
+ case AX_CTRL_STATUS_SPEED_100:
+ phydev->speed = SPEED_100;
+ break;
+ case AX_CTRL_STATUS_SPEED_10:
+ phydev->speed = SPEED_10;
+ }
+
+ /* MDIO_AN_10GBT_STAT_LP2_5G is broken, but we can deduce that
+ * the link-partner advertised 2500M if remotely AN succceded
+ * for link speed > 1000M and we locally have a link speed of
+ * 2500M
+ */
+ linkmode_clear_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, phydev->lp_advertising);
+ val = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_AN_10GBT_STAT);
+ if (val >= 0 && val & MDIO_AN_10GBT_STAT_REMOK) {
+ linkmode_mod_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT,
+ phydev->lp_advertising,
+ phydev->speed == SPEED_2500);
+ }
+ /* Only supports full duplex */
+ phydev->duplex = DUPLEX_FULL;
+
+ /* PHY switches interface between 2.5GBit and slower modes */
+ if (phydev->speed == SPEED_2500)
+ phydev->interface = PHY_INTERFACE_MODE_2500BASEX;
+ else
+ phydev->interface = PHY_INTERFACE_MODE_SGMII;
+
+ return 0;
+}
+
+static int asix_ax88279_config_aneg(struct phy_device *phydev)
+{
+ bool adv_2500;
+ int ret;
+
+ if (phydev->autoneg == AUTONEG_DISABLE) {
+ phydev_warn(phydev, "Disabling autoneg is not supported\n");
+ return -EOPNOTSUPP;
+ }
+
+ adv_2500 = linkmode_test_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, phydev->advertising);
+ ret = phy_modify_changed(phydev, MII_ADVERTISE, AX_ADVERTISE_2500,
+ adv_2500 ? AX_ADVERTISE_2500 : 0);
+ if (ret < 0)
+ return ret;
+
+ return __genphy_config_aneg(phydev, (ret == 1));
+}
+
+static int asix_ax88279_get_features(struct phy_device *phydev)
+{
+ int ret;
+
+ /* MDIO_DEVS1/2 empty, so set mmds_present bits to allow reading abilities */
+ phydev->c45_ids.mmds_present |= MDIO_DEVS_PMAPMD | MDIO_DEVS_AN;
+
+ linkmode_set_bit_array(phy_basic_ports_array, ARRAY_SIZE(phy_basic_ports_array),
+ phydev->supported);
+
+ ret = genphy_c45_pma_read_abilities(phydev);
+ if (ret < 0)
+ return ret;
+
+ /* AX88279 does not support reported 100baseT-half duplex mode */
+ linkmode_clear_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, phydev->supported);
+
+ return 0;
+}
+
+static int asix_ax88279_config_init(struct phy_device *phydev)
+{
+ __set_bit(PHY_INTERFACE_MODE_2500BASEX, phydev->possible_interfaces);
+ __set_bit(PHY_INTERFACE_MODE_SGMII, phydev->possible_interfaces);
+
+ return 0;
+}
+
static void asix_ax88772a_link_change_notify(struct phy_device *phydev)
{
/* Reset PHY, otherwise MII_LPA will provide outdated information.
@@ -94,6 +208,25 @@ static void asix_ax88772a_link_change_notify(struct phy_device *phydev)
}
}
+static int asix_ax88772D_get_features(struct phy_device *phydev)
+{
+ int ret;
+
+ /* MDIO_DEVS1/2 empty, so set mmds_present bits to allow reading abilities */
+ phydev->c45_ids.mmds_present |= MDIO_DEVS_PMAPMD | MDIO_DEVS_AN;
+
+ ret = genphy_read_abilities(phydev);
+ if (ret < 0)
+ return ret;
+
+ /* AX88772D does not support (possibly) reported 1000baseT modes */
+ linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, phydev->supported);
+ linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT, phydev->supported);
+ linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT, phydev->supported);
+
+ return 0;
+}
+
static struct phy_driver asix_driver[] = {
{
PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772A),
@@ -111,6 +244,35 @@ static struct phy_driver asix_driver[] = {
.suspend = genphy_suspend,
.resume = genphy_resume,
.soft_reset = asix_soft_reset,
+}, {
+ PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772D),
+ .name = "Asix Electronics AX88772D",
+ .flags = PHY_IS_INTERNAL,
+ .get_features = asix_ax88772D_get_features,
+ .read_mmd = genphy_read_mmd_c45,
+ .write_mmd = genphy_write_mmd_c45,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+}, {
+ PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88179A),
+ .name = "Asix Electronics AX88179A",
+ .flags = PHY_IS_INTERNAL,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
+ .read_mmd = genphy_read_mmd_c45,
+ .write_mmd = genphy_write_mmd_c45,
+}, {
+ PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88279),
+ .name = "Asix Electronics AX88279",
+ .flags = PHY_IS_INTERNAL | PHY_BROKEN_FORCED,
+ .get_features = asix_ax88279_get_features,
+ .read_status = asix_ax88279_read_status,
+ .config_aneg = asix_ax88279_config_aneg,
+ .config_init = asix_ax88279_config_init,
+ .read_mmd = genphy_read_mmd_c45,
+ .write_mmd = genphy_write_mmd_c45,
+ .suspend = genphy_suspend,
+ .resume = genphy_resume,
}, {
PHY_ID_MATCH_MODEL(PHY_ID_ASIX_AX88796B),
.name = "Asix Electronics AX88796B",
@@ -124,6 +286,9 @@ static const struct mdio_device_id __maybe_unused asix_tbl[] = {
{ PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772A) },
{ PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772C) },
{ PHY_ID_MATCH_MODEL(PHY_ID_ASIX_AX88796B) },
+ { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772D) },
+ { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88179A) },
+ { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88279) },
{ }
};
--
2.47.3
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt
2026-11-06 7:21 ` [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt Birger Koblitz
@ 2026-11-06 10:11 ` Maxime Chevallier
2026-11-06 15:32 ` Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
1 sibling, 1 reply; 29+ messages in thread
From: Maxime Chevallier @ 2026-11-06 10:11 UTC (permalink / raw)
To: Birger Koblitz, Andrew Lunn, David S. Miller, Jakub Kicinski,
Paolo Abeni, Russell King, Andrew Lunn, Heiner Kallweit,
Huacai Chen, WANG Xuerui, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Nicolai Buchwitz
Hi,
On 11/6/26 08:21, Birger Koblitz wrote:
> Add the phylink_mac_interrupt() function to phylink, which
> passes a link-change interrupt received by the MAC to phylib.
> This function can be used by drivers which want to avoid
> polling the PHY and instead rely on an interrupt received by
> the MAC when a link-change happens.
>
> Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
> ---
> drivers/net/phy/phylink.c | 20 ++++++++++++++++++++
> include/linux/phylink.h | 1 +
> 2 files changed, 21 insertions(+)
>
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index e885da1c28311a12a869e29ceb3c96886f31adc6..a87eaa2f3db5bef8fe56e12b90375bdb7f9c52e7 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -1616,6 +1616,26 @@ static bool phylink_link_is_up(struct phylink *pl)
> return pl->netdev ? netif_carrier_ok(pl->netdev) : pl->old_link_state;
> }
>
> +/**
> + * phylink_mac_interrupt() - wrapper for phy_mac_interrupt()
> + * @pl: a pointer to a &struct phylink returned from phylink_create()
> + *
> + * Passes a link-change interrupt received by the MAC to phylib.
> + * This function may be called in interrupt context, and therefore cannot take
> + * a mutex. However, it is safe to assume that the reference to phy does not
> + * disappear during the call, as only an SFP module may be unplugged to make a
> + * PHY disappear. SFP modules however do not support interrupts.
I don't see the relevance of PHY SFP supporting interrupts or not here,
this just re-triggers the PHY state machine. Looks like a comment to
make sashiko happy.
Anyways, I'm OK with the approach, maybe reword that comment if you need
to respin,
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Maxime
> + */
> +void phylink_mac_interrupt(struct phylink *pl)
> +{
> + struct phy_device *phy;
> +
> + phy = pl->phydev;
> + if (phy)
> + phy_mac_interrupt(phy);
> +}
> +EXPORT_SYMBOL_GPL(phylink_mac_interrupt);
> +
> static void phylink_resolve(struct work_struct *w)
> {
> struct phylink *pl = container_of(w, struct phylink, resolve);
> diff --git a/include/linux/phylink.h b/include/linux/phylink.h
> index 3a88a69882a610afb868b55df6f6e77aea918649..a7b6294cc4a075bd2aaa43ed6484de17a6cb88b1 100644
> --- a/include/linux/phylink.h
> +++ b/include/linux/phylink.h
> @@ -768,6 +768,7 @@ int phylink_ethtool_set_eee(struct phylink *link, struct ethtool_keee *eee);
> int phylink_mii_ioctl(struct phylink *, struct ifreq *, int);
> int phylink_speed_down(struct phylink *pl, bool sync);
> int phylink_speed_up(struct phylink *pl);
> +void phylink_mac_interrupt(struct phylink *pl);
>
> #define phylink_zero(bm) \
> bitmap_zero(bm, __ETHTOOL_LINK_MODE_MASK_NBITS)
>
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt
2026-11-06 10:11 ` Maxime Chevallier
@ 2026-11-06 15:32 ` Birger Koblitz
2026-11-06 15:55 ` Andrew Lunn
0 siblings, 1 reply; 29+ messages in thread
From: Birger Koblitz @ 2026-11-06 15:32 UTC (permalink / raw)
To: Maxime Chevallier, Andrew Lunn, David S. Miller, Jakub Kicinski,
Paolo Abeni, Russell King, Andrew Lunn, Heiner Kallweit,
Huacai Chen, WANG Xuerui, Eric Dumazet
Cc: linux-usb, netdev, linux-kernel, loongarch, Jianhui Xu,
Emir Beganovic, Nicolai Buchwitz
Thanks Maxime for reviewing!
On 06/11/2026 11:11 am, Maxime Chevallier wrote:
>>
>> +/**
>> + * phylink_mac_interrupt() - wrapper for phy_mac_interrupt()
>> + * @pl: a pointer to a &struct phylink returned from phylink_create()
>> + *
>> + * Passes a link-change interrupt received by the MAC to phylib.
>> + * This function may be called in interrupt context, and therefore cannot take
>> + * a mutex. However, it is safe to assume that the reference to phy does not
>> + * disappear during the call, as only an SFP module may be unplugged to make a
>> + * PHY disappear. SFP modules however do not support interrupts.
>
> I don't see the relevance of PHY SFP supporting interrupts or not here,
> this just re-triggers the PHY state machine. Looks like a comment to
> make sashiko happy.
Indeed, this is for sashiko. Unfortunately it followed up with: "The
function comment notes that SFP modules do not support interrupts.
However, when an SFP module is physically unplugged, the electrical link
drops. Could this link drop trigger the MAC interrupt being handled
here?", which is equally irrelevant, I believe.
>
> Anyways, I'm OK with the approach, maybe reword that comment if you need
> to respin,
>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Thanks, will add.
Birger
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt
2026-11-06 15:32 ` Birger Koblitz
@ 2026-11-06 15:55 ` Andrew Lunn
0 siblings, 0 replies; 29+ messages in thread
From: Andrew Lunn @ 2026-11-06 15:55 UTC (permalink / raw)
To: Birger Koblitz
Cc: Maxime Chevallier, Andrew Lunn, David S. Miller, Jakub Kicinski,
Paolo Abeni, Russell King, Heiner Kallweit, Huacai Chen,
WANG Xuerui, Eric Dumazet, linux-usb, netdev, linux-kernel,
loongarch, Jianhui Xu, Emir Beganovic, Nicolai Buchwitz
On Fri, Nov 06, 2026 at 04:32:30PM +0100, Birger Koblitz wrote:
> Thanks Maxime for reviewing!
>
> On 06/11/2026 11:11 am, Maxime Chevallier wrote:
>
> > > +/**
> > > + * phylink_mac_interrupt() - wrapper for phy_mac_interrupt()
> > > + * @pl: a pointer to a &struct phylink returned from phylink_create()
> > > + *
> > > + * Passes a link-change interrupt received by the MAC to phylib.
> > > + * This function may be called in interrupt context, and therefore cannot take
> > > + * a mutex. However, it is safe to assume that the reference to phy does not
> > > + * disappear during the call, as only an SFP module may be unplugged to make a
> > > + * PHY disappear. SFP modules however do not support interrupts.
> >
> > I don't see the relevance of PHY SFP supporting interrupts or not here,
> > this just re-triggers the PHY state machine. Looks like a comment to
> > make sashiko happy.
> Indeed, this is for sashiko. Unfortunately it followed up with: "The
> function comment notes that SFP modules do not support interrupts. However,
> when an SFP module is physically unplugged, the electrical link drops. Could
> this link drop trigger the MAC interrupt being handled here?", which is
> equally irrelevant, I believe.
It does appear the LLM does not understand what an SFP is and how it
operates.
We should just accept the LLM is wrong, and don't add too many
comments to try to correct it.
The danger is, this code gets merged, and LLM kiddies come along,
there LLM thinks it is broken, they try to fix it and submit
patches. But lets see if that actually happens.
Andrew
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt
2026-11-06 7:21 ` [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt Birger Koblitz
2026-11-06 10:11 ` Maxime Chevallier
@ 2026-11-10 1:38 ` netdev-bot+sashiko
1 sibling, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] phylink_mac_interrupt() (drivers/net/phy/phylink.c:1629-1637)
loads pl->phydev with no lock, no RCU and no reference, then calls…
- [Low] phylink_mac_interrupt() reads pl->phydev with a plain load (`phy
= pl->phydev;`) and no lock.
--
phylink: Add phylink_mac_interrupt
This commit adds phylink_mac_interrupt(), an exported wrapper that passes a
link-change interrupt received by the MAC to phylib by calling
phy_mac_interrupt() on the PHY attached to the phylink instance. It is meant
for drivers that want to stop polling the PHY.
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index e885da1c28311..a87eaa2f3db5b 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -1616,6 +1616,26 @@ static bool phylink_link_is_up(struct phylink *pl)
> return pl->netdev ? netif_carrier_ok(pl->netdev) : pl->old_link_state;
> }
>
> +/**
> + * phylink_mac_interrupt() - wrapper for phy_mac_interrupt()
> + * @pl: a pointer to a &struct phylink returned from phylink_create()
> + *
> + * Passes a link-change interrupt received by the MAC to phylib.
> + * This function may be called in interrupt context, and therefore cannot take
> + * a mutex. However, it is safe to assume that the reference to phy does not
> + * disappear during the call, as only an SFP module may be unplugged to make a
> + * PHY disappear. SFP modules however do not support interrupts.
> + */
> +void phylink_mac_interrupt(struct phylink *pl)
> +{
> + struct phy_device *phy;
> +
> + phy = pl->phydev;
> + if (phy)
> + phy_mac_interrupt(phy);
[Severity: Medium]
Is the lifetime argument in the kernel-doc above accurate? It says:
"it is safe to assume that the reference to phy does not disappear
during the call, as only an SFP module may be unplugged to make a PHY
disappear. SFP modules however do not support interrupts."
phylink_disconnect_phy() is not specific to SFP. Any MAC driver can call it
under RTNL at runtime, for example from ndo_stop or on unbind.
Also, the interrupt here comes from the MAC, not the PHY. Whether an SFP PHY
supports interrupts doesn't seem to matter, and phylink_mac_interrupt() has
no check on phy->is_on_sfp_module or phy->irq.
phylink_disconnect_phy() clears pl->phydev under locks that this IRQ path
never takes. It then stops the PHY without waiting for lockless readers:
drivers/net/phy/phylink.c:phylink_disconnect_phy() {
...
mutex_lock(&phy->lock);
mutex_lock(&pl->state_mutex);
pl->phydev = NULL;
...
if (phy) {
flush_work(&pl->resolve);
phy_disconnect(phy);
}
}
Could this interleaving happen?
CPU0 (MAC IRQ) CPU1
phylink_mac_interrupt()
phy = pl->phydev;
phylink_disconnect_phy()
pl->phydev = NULL;
phy_disconnect(phy)
phy_stop_machine()
cancel_delayed_work_sync(
&phydev->state_queue);
phy_mac_interrupt(phy)
phy_trigger_machine()
phy_queue_state_machine()
mod_delayed_work(..., &phydev->state_queue, ...);
If so, state_queue gets re-armed after the cancel has already finished.
On SFP module removal, sfp_sm_phy_detach() frees the phy_device right after
the disconnect:
drivers/net/phy/sfp.c:sfp_sm_phy_detach() {
sfp_remove_phy(sfp->sfp_bus);
phy_device_remove(sfp->mod_phy);
phy_device_free(sfp->mod_phy);
...
}
sfp_remove_phy() reaches phylink_disconnect_phy() through
phylink_sfp_disconnect_phy(), and phy_device_remove() does not cancel
state_queue. Would this leave a delayed work queued inside a freed
phy_device? On the non-SFP paths, it would restart the state machine on a
stopped, detached PHY.
The only caller in this series, ax88179a_status(), does not seem to hit
this today. usbnet_stop()->usbnet_status_stop() kills the interrupt URB
before ax88179a_unbind() disconnects the PHY.
This is an exported, generic API, though. Should the kernel-doc tell
callers to quiesce their interrupt source before calling
phylink_disconnect_phy()? Or should phylink synchronize this itself, for
example with RCU and a grace period before phy_disconnect()?
[Severity: Low]
pl->phydev is read here with a plain load and no lock held.
phylink_bringup_phy() and phylink_disconnect_phy() write it with plain
stores under phydev_mutex and state_mutex. Will KCSAN report this as a data
race?
Without READ_ONCE(), the compiler may also reload pl->phydev after the NULL
check. The pointer passed to phy_mac_interrupt() could then differ from the
one that was tested. If a writer stored NULL in between, could
mod_delayed_work() end up called on &NULL->state_queue?
The current caller, ax88179a_status(), does not race with connect or
disconnect. Even so, would READ_ONCE() (or rcu_dereference()) here, paired
with WRITE_ONCE() (or rcu_assign_pointer()) in the writers, be appropriate?
> +}
> +EXPORT_SYMBOL_GPL(phylink_mac_interrupt);
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 03/13] ax88179_178a: Split driver into library and device specific code
2026-11-06 7:21 ` [PATCH net-next v20 03/13] ax88179_178a: Split driver into library and device specific code Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 4 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 4 (2) · Low: 0
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] The commit message describes a pure code move plus a module
rename ('Split the ax88179_178a module code into code common to ...…
- [Medium] The new `medium_status_mutex` is documented as protecting
AX_MEDIUM_STATUS_MODE (ax88179_lib.h:161), but in this commit only…
- [Medium] `ax88179_change_mtu()` (ax88179_lib.c:396-438) now returns an
error from the new `err_out` path, but only after it has already done…
- [Medium] The patch renames the kernel module from ax88179_178a.ko to
ax88179.ko (Makefile lines 15-16: `obj-$(CONFIG_USB_NET_AX88179_178A)…
Pre-existing issues:
- [Medium] In the moved `ax88179_get_eeprom()` (ax88179_lib.c:191-223),
`eeprom_buff` comes from `kmalloc_array()` (line 205, not zeroed).
- [Medium] `ax88179_set_features()` (ax88179_lib.c:339-366, moved
unchanged) toggles the checksum-offload registers by XOR on the…
--
ax88179_178a: Split driver into library and device specific code
This commit moves the register definitions, the USB command helpers and
the common ethtool/netdev callbacks of the ax88179_178a driver into a new
ax88179_lib.c and ax88179_lib.h. It also renames the module to ax88179 and
adds MODULE_ALIAS("ax88179_178a") for the old name.
> diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile
> index 4964f7b326fbc..ddd76fa71e2ee 100644
> --- a/drivers/net/usb/Makefile
> +++ b/drivers/net/usb/Makefile
> @@ -12,7 +12,8 @@ obj-$(CONFIG_USB_HSO) += hso.o
> obj-$(CONFIG_USB_LAN78XX) += lan78xx.o
> obj-$(CONFIG_USB_NET_AX8817X) += asix.o
> asix-y := asix_devices.o asix_common.o ax88172a.o
> -obj-$(CONFIG_USB_NET_AX88179_178A) += ax88179_178a.o
> +obj-$(CONFIG_USB_NET_AX88179_178A) += ax88179.o
> +ax88179-y := ax88179_178a.o ax88179_lib.o
[Severity: Medium]
This renames ax88179_178a.ko to ax88179.ko. The only compatibility added
is MODULE_ALIAS("ax88179_178a") in ax88179_178a.c.
The alias keeps "modprobe ax88179_178a" working. Will configuration that
matches on the real module name still take effect? For example:
- "blacklist ax88179_178a" in modprobe.d. kmod compares the blacklist
against the resolved module name, and the usb:v0B95p1790... modalias
now resolves directly to ax88179.
- module_blacklist=ax88179_178a on the kernel command line, which is
compared against mod->name.
- Anything that checks /sys/module/ax88179_178a.
Users of this device family often blacklist the vendor driver so that
cdc_ncm binds instead. The later patch "ax88179_178a: Add HW support for
AX179A-based chips" also relies on OS configuration to choose between this
module and cdc_ncm.
After an upgrade, could such systems quietly end up with this driver bound
again?
The rename is still there at the end of the series, which also renames the
Kconfig symbol and the usb_driver name to ax88179. Could the commit message
mention this limitation of the alias?
[ ... ]
> diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
> new file mode 100644
> index 0000000000000..063427ff55e42
> --- /dev/null
> +++ b/drivers/net/usb/ax88179_lib.c
> @@ -0,0 +1,461 @@
[ ... ]
> +int ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8 *data)
> +{
[ ... ]
> + first_word = eeprom->offset >> 1;
> + last_word = (eeprom->offset + eeprom->len - 1) >> 1;
> + eeprom_buff = kmalloc_array(last_word - first_word + 1, sizeof(u16),
> + GFP_KERNEL);
> + if (!eeprom_buff)
> + return -ENOMEM;
> +
> + /* ax88179/178A returns 2 bytes from eeprom on read */
> + for (i = first_word; i <= last_word; i++) {
> + ret = __ax88179_read_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2,
> + &eeprom_buff[i - first_word]);
> + if (ret < 0) {
> + kfree(eeprom_buff);
> + return -EIO;
> + }
> + }
> +
> + memcpy(data, (u8 *)eeprom_buff + (eeprom->offset & 1), eeprom->len);
[Severity: Medium]
This is a pre-existing issue that this patch moves without changes. Can
this memcpy() hand stale heap bytes from eeprom_buff to userspace?
eeprom_buff comes from kmalloc_array() and is not zeroed. Only ret < 0
counts as a failure. __usbnet_read_cmd() copies only the bytes that were
actually transferred and returns that short count:
drivers/net/usb/usbnet.c:__usbnet_read_cmd() {
...
if (err > 0 && err <= size) {
if (data)
memcpy(data, buf, err);
...
}
If a device answers a 2-byte read with 0 or 1 bytes, eeprom_buff keeps
uninitialised bytes, and ETHTOOL_GEEPROM returns them to the caller.
ax88179_set_features() has a similar problem. Its u8 tmp is never
initialised, so a failed 1-byte read leads to a stack byte being XORed and
written to the COE register.
A later patch in the series, "ax88179_178a: Add support for
AX88179A/772D/279 EEPROM access", fixes the get_eeprom part. It switches to
kzalloc() and checks ret != ax179_data->eeprom_block. The set_features part
is still present at the end of the series.
[ ... ]
> +int ax88179_set_features(struct net_device *net, netdev_features_t features)
> +{
> + u8 tmp;
> + struct usbnet *dev = netdev_priv(net);
> + netdev_features_t changed = net->features ^ features;
> +
> + if (changed & NETIF_F_IP_CSUM) {
> + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
> + tmp ^= AX_TXCOE_TCP | AX_TXCOE_UDP;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, &tmp);
> + }
[Severity: Medium]
This isn't a bug introduced by this patch, since the function moves
unchanged. Can the XOR toggle leave the hardware checksum offload out of
sync with net->features?
ax88179_reset() always turns on every COE bit, whatever net->features says:
drivers/net/usb/ax88179_178a.c:ax88179_reset() {
...
*tmp = AX_TXCOE_IP | AX_TXCOE_TCP | AX_TXCOE_UDP |
AX_TXCOE_TCPV6 | AX_TXCOE_UDPV6;
ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, tmp);
...
}
ax88179_reset() runs from ax88179_resume() and from ax88179_net_reset().
Consider this sequence:
ethtool -K tx off -> TXCOE TCP/UDP cleared
suspend/resume -> ax88179_reset() sets all TXCOE bits again
ethtool -K tx on -> tmp ^= AX_TXCOE_TCP | AX_TXCOE_UDP clears them
NETIF_F_IP_CSUM ends up set while the MAC no longer fills in IPv4 TCP/UDP
checksums. Would CHECKSUM_PARTIAL frames then go out with bad L4 checksums?
Writing the absolute state derived from features, instead of toggling,
would avoid this. The code is still the same at the end of the series.
[ ... ]
> +int ax88179_change_mtu(struct net_device *net, int new_mtu)
> +{
> + struct usbnet *dev = netdev_priv(net);
> + struct ax88179_data *data;
> + u16 tmp16;
> + int err;
> +
> + data = dev->driver_priv;
> + mutex_lock(&data->medium_status_mutex);
[Severity: Medium]
The commit message describes this as a split of existing code plus a module
rename, but some of it is not a straight move. Compared with the code
removed from ax88179_178a.c:
- struct ax88179_data gains medium_status_mutex, which ax88179_bind()
initialises.
- ax88179_change_mtu() now takes that mutex, checks every register
access and can return an error. The old version had no lock and always
returned 0.
- The BUG_ON(!dev) checks in __ax88179_read_cmd() and
__ax88179_write_cmd() are dropped.
Should these behaviour changes go in a separate patch with their own
justification, or at least be described in the commit message?
> + WRITE_ONCE(net->mtu, new_mtu);
> + dev->hard_mtu = net->mtu + net->hard_header_len;
> + if (net->mtu > 1500) {
> + err = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE,
> + 2, 2, &tmp16);
> + if (err < 0)
> + goto err_out;
[ ... ]
> + mutex_unlock(&data->medium_status_mutex);
> +
> + /* max qlen depend on hard_mtu and rx_urb_size */
> + usbnet_update_max_qlen(dev);
> +
> + return 0;
> +
> +err_out:
> + mutex_unlock(&data->medium_status_mutex);
> + return err;
> +}
[Severity: Medium]
On this error path, do net->mtu and dev->hard_mtu keep the new value even
though the MTU change is reported as failed?
Both are updated before any AX_MEDIUM_STATUS_MODE access. err_out does not
restore them and does not call usbnet_update_max_qlen(). The core does not
roll back on error either:
net/core/dev.c:netif_set_mtu_ext() {
...
orig_mtu = dev->mtu;
err = __netif_set_mtu(dev, new_mtu);
if (!err) {
...
return err;
}
So after a failed USB transfer:
- userspace gets an error, but dev->mtu shows the new value
- the NETDEV_CHANGEMTU notifiers are skipped
- rx_qlen/tx_qlen no longer match hard_mtu
A retry with the same MTU then hits this check in netif_set_mtu_ext():
if (new_mtu == dev->mtu)
return 0;
It succeeds without touching the hardware, so AX_MEDIUM_JUMBO_EN stays
wrong for that MTU.
The old code always returned 0, so this inconsistency is new in this patch.
The function is the same at the end of the series.
[ ... ]
> diff --git a/drivers/net/usb/ax88179_lib.h b/drivers/net/usb/ax88179_lib.h
> new file mode 100644
> index 0000000000000..9111a1395eb2f
> --- /dev/null
> +++ b/drivers/net/usb/ax88179_lib.h
> @@ -0,0 +1,195 @@
[ ... ]
> +struct ax88179_data {
> + struct mutex medium_status_mutex; /* protect AX_MEDIUM_STATUS_MODE */
[Severity: Medium]
The comment says this mutex protects AX_MEDIUM_STATUS_MODE, but
ax88179_change_mtu() is the only function that takes it. Is that enough to
protect the register?
None of the other accessors in ax88179_178a.c take the mutex:
ax88179_suspend(), ax88179_link_reset(), ax88179_reset(),
ax88179_net_reset() and ax88179_stop().
ax88179_link_reset() runs from the kevent work without RTNL:
usbnet_deferred_kevent()
info->link_reset(dev)
ax88179_link_reset()
That means it can run at the same time as ax88179_change_mtu(), which runs
under RTNL. One possible interleaving:
ax88179_change_mtu() ax88179_link_reset()
read AX_MEDIUM_STATUS_MODE
write new speed/duplex mode
write stale mode | JUMBO_EN
The MAC speed and duplex would then disagree with the PHY until the next
link event.
It can also go the other way. ax88179_link_reset() reads
dev->net->mtu <= 1500, then ax88179_change_mtu() sets JUMBO_EN, then
ax88179_link_reset() overwrites the register without JUMBO_EN. Would jumbo
frames then be dropped?
By the end of the series the AX88179A mac_link_up path in
ax88179a_devices.c also takes the mutex. The legacy accessors in
ax88179_178a.c and several accessors in ax88179a_devices.c still do not.
Should the other accessors take the mutex too, or should the comment say
what the mutex actually serialises?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 04/13] ax88179_178a: Add HW support for AX179A-based chips
2026-11-06 7:21 ` [PATCH net-next v20 04/13] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 13 potential
issue(s) to consider.
Critical: 0 · High: 1 · Medium: 7 · Low: 5
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [High] net: usb: ax88179: UAF on unbind when down due to
FLAG_AVOID_UNLINK_URBS
- [Medium] The three new `products[]` entries, `USB_DEVICE_VER(0x0b95,
0x1790, 0x0200/0x0300/0x0400, ...)`, match on VID, PID and bcdDevice…
- [Medium] `ax88179a_rx_fixup()` silently drops any frame with `pkt_len >
dev->hard_mtu + AX179A_RX_HW_PAD` (+2).
- [Medium] `ax88179a_mac_link_up()` programs the MAC but never calls
`usbnet_link_change(dev, true, false)`, and `ax88179a_status()` only…
- [Medium] `ax88179a_reset()`, used as `driver_info->reset`, ends with
`phylink_start()`, which also calls `phy_start()` on the attached PHY.
- [Medium] In `ax88179a_mac_link_up()`, three AX88279 MAC registers are
written only in the `SPEED_2500` branch: `AX88179A_MAC_TX_PAUSE` (3…
- [Medium] net: usb: ax88179a: ax88179a_reset() clobbers custom MAC and
perm_addr on open
- [Medium] net: usb: ax88179_178a: positive return from
ax88179_mdiobus_write()
- [Low] The commit message leaves out several changes this commit makes.
- [Low] In `ax88179a_mac_link_up()`, `link_sts` starts at 0 and the
return value of `ax88179_read_cmd(..., PHYSICAL_LINK_STATUS, ...)` is…
- [Low] `ax88179_data::rx_checksum` is written with plain stores in
process context: in `ax88179_set_features()` under RTNL (cleared…
- [Low] The two code paths program the pause water levels byte-swapped
relative to each other.
- [Low] `ax88179a_bind()` switches firmware mode (`AX_FW_MODE`), reloads
eFuse/EEPROM and powers the Ethernet PHY (`ax88179_write_u8(dev,…
--
ax88179_178a: Add HW support for AX179A-based chips
This adds support for the AX179A family (AX88179A/B, AX88772D/E and
AX88279). All of them share VID/PID 0b95:1790 and are told apart by
bcdDevice. The new ax88179a_bind() switches the device from its CDC-NCM
configuration to the vendor configuration, and ax88179a_devices.c drives
the chips through phylink.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe23913b1e432..c22f8ed088083 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4114,6 +4114,12 @@ S: Maintained
> F: Documentation/devicetree/bindings/net/asix,ax88796c.yaml
> F: drivers/net/ethernet/asix/ax88796c_*
>
> +ASIX AX88179 USB ETHERNET DRIVER
> +M: Birger Koblitz <mail@birger-koblitz.de>
> +L: netdev@vger.kernel.org
> +S: Maintained
> +F: drivers/net/usb/ax88179*
> +
[Severity: Low]
This isn't a bug, but the commit message leaves out several changes
made here.
The new MAINTAINERS entry covers all of drivers/net/usb/ax88179*. That
includes the existing AX88179/178A driver.
The legacy ax88179_bind() now reads AX_CHIP_STATUS and fails the bind
if that read fails. Existing devices did not have that failure mode
before.
Kconfig changes from select PHYLIB to select PHYLINK, and
ax88179_set_features() changes as well.
Could the commit message describe these, or could they go into separate
patches?
[ ... ]
> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index 55268d0890d12..f78ad344c1c4f 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
[ ... ]
> @@ -1271,6 +1290,18 @@ static const struct driver_info at_umc2000sp_info = {
>
> static const struct usb_device_id products[] = {
> {
> + /* ASIX AX88179A USB 3.2 1000Mbit Ethernet */
> + USB_DEVICE_VER(0x0b95, 0x1790, 0x0200, 0x0200),
> + .driver_info = (unsigned long)&ax88179a_info,
> +}, {
> + /* ASIX AX88772D USB 2.0 100Mbit Ethernet */
> + USB_DEVICE_VER(0x0b95, 0x1790, 0x0300, 0x0300),
> + .driver_info = (unsigned long)&ax88772d_info,
> +}, {
> + /* ASIX AX88279 USB 3.2 2500Mbit Ethernet */
> + USB_DEVICE_VER(0x0b95, 0x1790, 0x0400, 0x0400),
> + .driver_info = (unsigned long)&ax88279_info,
> +}, {
> /* ASIX AX88179 10/100/1000 */
> USB_DEVICE_AND_INTERFACE_INFO(0x0b95, 0x1790, 0xff, 0xff, 0),
> .driver_info = (unsigned long)&ax88179_info,
[Severity: Medium]
These entries match only on VID, PID and bcdDevice, with no interface
class check. They also come before the vendor-interface-only 0b95:1790
entry. Won't they match the CDC-NCM comm and data interfaces as well?
Commit c67cc4315a8e ("net: usb: ax88179_178a: Bind only to
vendor-specific interface") limited 0b95:1790 to the vendor interface.
By default the device then stays in CDC mode under the class driver,
and users can switch it through sysfs.
With these entries, ax88179a_bind() runs this whenever it probes a CDC
interface:
if (udev->actconfig->desc.bConfigurationValue != 1) {
netdev_info(dev->net, "Switching to vendor mode\n");
usb_driver_set_configuration(udev, 1);
return -ENODEV;
}
When both drivers are built in, drivers/net/usb/Makefile links
ax88179.o ahead of cdc_ncm.o. ax88179 is then always tried first, so
the adapter is always forced out of CDC mode. With modules, the result
depends on load order.
This seems to contradict the commit message:
"By default, the proprietary vendor interface is not active and Linux
will load the CDC-NCM driver to support the devices. If the
ax88179_178a module is configured by the OS to have precedence over
CDC-NCM, then this driver will switch the device ..."
Is reversing c67cc4315a8e intended? If so, could the commit message say
so?
Could it also mention that AX88179A-family devices already in vendor
mode used to be driven by ax88179_info and now go through the new code?
> diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
> index 063427ff55e42..a314db4c97666 100644
> --- a/drivers/net/usb/ax88179_lib.c
> +++ b/drivers/net/usb/ax88179_lib.c
[ ... ]
> @@ -355,10 +378,17 @@ int ax88179_set_features(struct net_device *net, netdev_features_t features)
> }
>
> if (changed & NETIF_F_RXCSUM) {
> + /* When we disable rx-checksumming, we need to clear the rx_checksum
> + * flag before disabling the engine
> + */
> + if (!(features & NETIF_F_RXCSUM))
> + data->rx_checksum = 0;
> +
> ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp);
> tmp ^= AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP |
> AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6;
> ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 1, &tmp);
> + data->rx_checksum = !!(features & NETIF_F_RXCSUM);
> }
[Severity: Low]
rx_checksum is written here with plain stores under RTNL. It is read
without a lock for every packet in ax88179a_rx_fixup(), which runs from
the usbnet BH workqueue:
if (ax179_data->rx_checksum)
ax88179a_rx_checksum(ax_skb, pkt_desc);
Should these accesses use WRITE_ONCE() and READ_ONCE(), as the
neighbouring rxctl field does? The ordering described in the new
comment isn't enforced by any memory-ordering primitive.
At this commit nothing calls this writer for the new chips. Later in
the series ax88179a_set_features() calls ax88179_set_features(), and the
race becomes reachable then.
[ ... ]
> diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
> new file mode 100644
> index 0000000000000..1aa8479422517
> --- /dev/null
> +++ b/drivers/net/usb/ax88179a_devices.c
[ ... ]
> +static void ax88179a_mac_link_up(struct phylink_config *config,
> + struct phy_device *phy,
> + unsigned int phy_mode, phy_interface_t interface,
> + int speed, int duplex,
> + bool tx_pause, bool rx_pause)
> +{
[ ... ]
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 2, 0x0410);
[Severity: Low]
After cpu_to_le16s(), this write sets AX_PAUSE_WATERLVL_LOW to 0x10 and
AX_PAUSE_WATERLVL_HIGH to 0x04. ax88179a_reset() writes the reverse:
ax88179_write_u8(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 0x04);
ax88179_write_u8(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, 1, 0x10);
Which ordering is intended? The legacy AX88179 path uses LOW > HIGH
(0x52/0x34), which matches the link-up values. If that is the right
ordering, the reset values are misleading.
[ ... ]
> + switch (speed) {
> + case SPEED_2500:
> + reg8[0] = 0x00;
> + reg8[1] = 0xF8;
> + reg8[2] = 0x07;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_TX_PAUSE, 3, 3, reg8);
> +
> + reg8[0] = 0x78;
> + reg8[1] = (AX_LSOFC_WCNT_7_ACCESS << 5);
> + reg8[2] = 0;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, reg8);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 1, 0x40);
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT + 1, 1,
> + AX_MAC_MIQFFCTRL_FORMAT | AX_MAC_MIQFFCTRL_DROP_CRC |
> + AX_MAC_LSO_ERR_EN);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_BFM_DATA, 1, AX_XGMII_EN);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_LSO_ENHANCE_CTRL, 1,
> + 0x1C | AX_LSO_ENHANCE_EN);
[Severity: Medium]
Three registers are written only on the 2.5G path:
AX88179A_MAC_TX_PAUSE, AX88179A_MAC_RX_DATA_CDC_CNT + 1 and
AX88179A_MAC_LSO_ENHANCE_CTRL. For other speeds only AX88179A_BFM_DATA
is cleared, and ax88179a_reset() doesn't restore the three either.
Say an AX88279 links at 2500 and then renegotiates to 1000 or 100
without an ifdown/ifup. Won't the MAC keep the 2.5G pause thresholds,
the MIQFFCTRL_DROP_CRC/FORMAT bits and the LSO enhance setting? The
lower-speed branch would also add AX_GMII_CRC_APPEND in
AX88179A_MAC_RX_STATUS_CDC on top of them.
A fresh 1G link-up never produces that register combination. Later in
the series the AX88279 PHY driver reports both 2500BASEX and SGMII, so
the speed change looks reachable.
[ ... ]
> + ax88179_read_cmd(dev, AX_ACCESS_MAC, PHYSICAL_LINK_STATUS, 1, 1, &link_sts);
> + ax88179a_bulkin_config(dev, link_sts, bulk_config_speed, !!duplex);
[Severity: Low]
The return value of this read is ignored, and link_sts starts at 0. If
the control transfer fails or returns no data, ax88179a_bulkin_config()
sees none of AX_USB_SS, AX_USB_HS or AX_USB_FS set.
The index then stays at 0 (BULK_IN_SPEED_2G5) at 1000 Mb/s, and is 0
or 1 at 100 Mb/s. AX88179A_BULKIN_SIZE has no entry at index 0, and
AX88772D_BULKIN_SIZE only fills in indices 5 to 7:
static const struct ax_bulkin_settings AX88772D_BULKIN_SIZE[] = {
[BULK_IN_SPEED_100_FULL_HS] = {5, 0xC0, 0x04, 0x06, 0x0F},
[BULK_IN_SPEED_100_HALF_HS] = {7, 0xC0, 0x04, 0x06, 0x0F},
[BULK_IN_SPEED_FS] = {7, 0x00, 0x00, 0x03, 0x3F},
};
Wouldn't an all-zero ax_bulkin_settings get written to
AX_RX_BULKIN_QCTRL? For AX88179A at 100M half duplex, the 1G_SS entry
would be written instead.
Could the read be checked, with a fallback such as BULK_IN_SPEED_FS
when it fails?
[ ... ]
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_PATH, 1,
> + AX_MAC_RX_PATH_READY | AX_MAC_TX_PATH_READY);
> +}
[Severity: Medium]
Is a usbnet_link_change() call missing here, and in
ax88179a_mac_link_down()?
usbnet only submits RX URBs from usbnet_bh(), and only when
netif_carrier_ok() is true. On link up, bh_work is queued from
__handle_link_change(). The only way to reach that is through
usbnet_link_change().
The open sequence looks like this:
usbnet_open()
ax88179a_reset()
phylink_start() <- netif_carrier_off()
queue bh_work <- carrier off, no RX URBs submitted
...
phylink_resolve()
ax88179a_mac_link_up()
netif_carrier_on() <- nothing requeues bh_work
Doesn't RX stay stalled until some TX completion happens to queue
bh_work? The same would happen after every link down/up, and RX URBs
are never unlinked on link down.
ax88772_mac_link_up() and ax88772_mac_link_down() in asix_devices.c
call usbnet_link_change() for exactly this reason.
[ ... ]
> +static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf)
> +{
[ ... ]
> + /* Power PHY for probing */
> + ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, AX_PHY_POWER);
> + msleep(250);
> +
> + ret = ax88179a_init_mdio(dev);
> + if (ret)
> + goto err_nodev;
> +
> + ret = ax88179a_phylink_setup(dev);
> + if (ret)
> + goto phylink_err;
> +
> + ret = ax88179a_init_phy(dev);
> + if (ret)
> + goto initphy_err;
> +
> + return 0;
> +
> +initphy_err:
> + phylink_destroy(ax179_data->phylink);
> +phylink_err:
> + ax88179a_mdio_unregister(ax179_data);
> +err_nodev:
> + kfree(ax179_data);
> + ax179_data = NULL;
> +
> + return ret;
> +}
[Severity: Low]
If ax88179a_init_mdio(), ax88179a_phylink_setup() or ax88179a_init_phy()
fails, the PHY powered on above is never powered off. Should the error
path write AX88179A_PHY_POWER = 0, as ax88179a_unbind() does?
Otherwise the device is left in vendor mode with no driver bound and the
PHY still powered, so it can bring up a link with the partner.
At this commit, this path looks reachable for every AX88279, because
phylink validation against genphy fails.
[ ... ]
> +static int ax88179a_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
> +{
[ ... ]
> + if (pkt_desc & AX179A_RX_PD_DROP || !(pkt_desc & AX179A_RX_PD_RX_OK) ||
> + pkt_len > (dev->hard_mtu + AX179A_RX_HW_PAD) || pkt_len < 2 + ETH_HLEN) {
> + skb_pull(skb, pkt_len_plus_padd);
> +
> + /* Next RX Packet Descriptor */
> + pkt_desc_ptr++;
> + continue;
> + }
[Severity: Medium]
Can this silently drop full-size VLAN-tagged frames after an MTU change?
ax88179a_bind() sets dev->hard_mtu to 9 * 1024. The shared
ax88179_change_mtu() then resets it with no room for an 802.1Q tag:
dev->hard_mtu = net->mtu + net->hard_header_len;
HW VLAN stripping is not enabled, so received frames keep their tags
inline. A full-size tagged frame is mtu + 18 bytes, which is more than
mtu + 14 + AX179A_RX_HW_PAD.
So after any MTU change, for example 9000 to 1500, max-size traffic on
VLAN sub-interfaces would be dropped here with no counters. Before the
MTU is first changed, the same traffic is accepted.
[ ... ]
> +static int ax88179a_reset(struct usbnet *dev)
> +{
[ ... ]
> + /* Ensure EEE state is off, consistent with phylink setup */
> + ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, false, 0, NULL);
> +
> + phylink_start(ax179_data->phylink);
> +
> + return 0;
> +}
[Severity: Medium]
ax88179a_reset() is the driver_info->reset hook, and usbnet_open() calls
it before usbnet_status_start(). If usbnet_status_start() fails,
usbnet_open() jumps to done without calling info->stop(). ndo_stop is
never called either, because the open failed.
Won't phylink and the PHY state machine keep running with the interface
down? They could still issue USB register writes through mac_link_up().
On the next ifup, phylink_start() calls phy_start() again on a PHY that
is already started, which would hit:
WARN(1, "called from state %s\n", phy_state_to_str(phydev->state));
[ ... ]
> @@ -0,0 +1,983 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +
> +#include <linux/module.h>
> +#include <linux/phylink.h>
> +#include <linux/if_vlan.h>
> +#include "ax88179_lib.h"
> +
> +#define AX88279_EEPROM_LEN 0x4000
> +#define AX88179A_EEPROM_LEN (32 * 20)
> +
> +enum ax_bulk_in_speeds {
> + BULK_IN_SPEED_2G5 = 0,
> + BULK_IN_SPEED_1G_SS = 1,
> + BULK_IN_SPEED_1G_HS = 2,
> + BULK_IN_SPEED_100_FULL_SS = 3,
> + BULK_IN_SPEED_100_HALF_SS = 4,
> + BULK_IN_SPEED_100_FULL_HS = 5,
> + BULK_IN_SPEED_100_HALF_HS = 6,
> + BULK_IN_SPEED_FS = 7,
> +};
> +
> +static const struct ax_bulkin_settings AX88179A_BULKIN_SIZE[] = {
> + [BULK_IN_SPEED_1G_SS] = {5, 0x7B, 0x00, 0x17, 0x0F},
> + [BULK_IN_SPEED_1G_HS] = {5, 0xC0, 0x02, 0x06, 0x0F},
> + [BULK_IN_SPEED_100_FULL_SS] = {7, 0xF0, 0x00, 0x0C, 0x0F},
> + [BULK_IN_SPEED_100_HALF_SS] = {6, 0x00, 0x00, 0x06, 0x0F},
> + [BULK_IN_SPEED_100_FULL_HS] = {5, 0xC0, 0x04, 0x06, 0x0F},
> + [BULK_IN_SPEED_100_HALF_HS] = {7, 0xC0, 0x04, 0x06, 0x0F},
> + [BULK_IN_SPEED_FS] = {7, 0x00, 0x00, 0x03, 0x3F},
> +};
> +
> +static const struct ax_bulkin_settings AX88772D_BULKIN_SIZE[] = {
> + [BULK_IN_SPEED_100_FULL_HS] = {5, 0xC0, 0x04, 0x06, 0x0F},
> + [BULK_IN_SPEED_100_HALF_HS] = {7, 0xC0, 0x04, 0x06, 0x0F},
> + [BULK_IN_SPEED_FS] = {7, 0x00, 0x00, 0x03, 0x3F},
> +};
> +
> +static const struct ax_bulkin_settings AX88279_BULKIN_SIZE[] = {
> + [BULK_IN_SPEED_2G5] = {5, 0x10, 0x01, 0x11, 0x0F},
> + [BULK_IN_SPEED_1G_SS] = {7, 0xB3, 0x01, 0x11, 0x0F},
> + [BULK_IN_SPEED_1G_HS] = {7, 0xC0, 0x02, 0x06, 0x0F},
> + [BULK_IN_SPEED_100_FULL_SS] = {7, 0x80, 0x01, 0x03, 0x0F},
> + [BULK_IN_SPEED_100_HALF_SS] = {7, 0x80, 0x01, 0x03, 0x0F},
> + [BULK_IN_SPEED_100_FULL_HS] = {7, 0x80, 0x01, 0x03, 0x0F},
> + [BULK_IN_SPEED_100_HALF_HS] = {7, 0x80, 0x01, 0x03, 0x0F},
> + [BULK_IN_SPEED_FS] = {7, 0x00, 0x00, 0x03, 0x3F},
> +};
> +
> +static int ax88179_mdiobus_read(struct mii_bus *bus, int phy_id, int regnum)
> +{
> + struct usbnet *dev = bus->priv;
> + struct ax88179_data *priv;
> + u16 res;
> + int ret;
> +
> + priv = dev->driver_priv;
> + /* When reading PHYSID, return unused PHY-IDs from the ASIX vendor range */
> + if (phy_id == AX88179_PHY_ID && regnum == MII_PHYSID1)
> + return 0x003b;
> + if (phy_id == AX88179_PHY_ID && regnum == MII_PHYSID2) {
> + if (priv->chip_version == AX_VERSION_AX88179A && priv->is_ax88772d)
> + return 0x772d;
> + else if (priv->chip_version == AX_VERSION_AX88179A)
> + return 0x179a;
> + else if (priv->chip_version == AX_VERSION_AX88279)
> + return 0x2790;
> + }
> +
> + ret = ax88179_read_cmd(dev, AX_ACCESS_PHY, phy_id, (__u16)regnum, 2, &res);
> + if (ret < 0)
> + return ret;
> + return res;
> +}
> +
> +static int ax88179_mdiobus_write(struct mii_bus *bus, int phy_id, int regnum, u16 val)
> +{
> + struct usbnet *dev = bus->priv;
> +
> + return ax88179_write_u16(dev, AX_ACCESS_PHY, phy_id, (__u16)regnum, val);
[Severity: Medium]
The mii_bus ->write and ->write_c45 callbacks are expected to return 0
on success or a negative errno.
ax88179_mdiobus_write() returns ax88179_write_u16() directly.
ax88179_mdiobus_write_c45() returns ax179a_write_mmd(), which in turn
returns ax88179_write_cmd().
Both end up in __ax88179_write_cmd() and usbnet_write_cmd(). These pass
back the usb_control_msg() byte count. Won't every successful 2-byte
write therefore return 2 instead of 0?
For SIOCSMIIREG, phylink_mii_ioctl() passes that value straight back to
userspace through ax88179a_mii_ioctl(). Some phylib or PHY driver code
checks if (ret) after phy_write() or phy_write_mmd(), rather than
if (ret < 0). That code would treat a successful write as a failure.
Could both write callbacks map a non-negative result to 0?
> +}
> +
> +static int ax179a_read_mmd(struct usbnet *dev, u16 dev_addr, u16 reg)
> +{
> + u16 res;
> + int ret;
> +
> + ret = ax88179_read_cmd(dev, AX88179A_PHY_CLAUSE45, dev_addr, reg, 2, &res);
> + if (ret < 0)
> + return ret;
> + return res;
> +}
> +
> +static int ax179a_write_mmd(struct usbnet *dev, u16 dev_addr, u16 reg, u16 data)
> +{
> + return ax88179_write_cmd(dev, AX88179A_PHY_CLAUSE45, dev_addr, reg, 2, &data);
> +}
> +
> +static int ax88179_mdiobus_read_c45(struct mii_bus *bus, int addr, int devnum, int regnum)
> +{
> + struct usbnet *dev = bus->priv;
> +
> + if (addr != AX88179_PHY_ID)
> + return -EINVAL;
> +
> + return ax179a_read_mmd(dev, devnum, regnum);
> +}
> +
> +static int ax88179_mdiobus_write_c45(struct mii_bus *bus, int addr, int devnum,
> + int regnum, u16 val)
> +{
> + struct usbnet *dev = bus->priv;
> +
> + if (addr != AX88179_PHY_ID)
> + return -EINVAL;
> +
> + return ax179a_write_mmd(dev, devnum, regnum, val);
> +}
> +
> +static void ax88179a_status(struct usbnet *dev, struct urb *urb)
> +{
> + struct ax88179_data *data = dev->driver_priv;
> +
> + if (urb->actual_length < 8)
> + return;
> +
> + phylink_mac_interrupt(data->phylink);
> +}
> +
> +static int ax88179a_auto_detach(struct usbnet *dev)
> +{
> + u16 tmp16;
> +
> + tmp16 = AX88179A_AUTODETACH_DELAY;
> + ax88179_write_cmd(dev, AX88179A_AUTODETACH, tmp16, 0, 0, NULL);
> + return 0;
> +}
> +
> +static void ax88179a_bulkin_config(struct usbnet *dev, u8 link_sts, u8 speed, bool full_duplex)
> +{
> + struct ax88179_data *ax179_data = dev->driver_priv;
> + const struct ax_bulkin_settings *bulkin_data;
> + int index = 0;
> +
> + switch (speed) {
> + case ETHER_LINK_2500: /* AX88279 only */
> + index = BULK_IN_SPEED_2G5;
> + break;
> +
> + case ETHER_LINK_1000: /* AX88279 & AX88178A */
> + if (link_sts & AX_USB_SS)
> + index = BULK_IN_SPEED_1G_SS;
> + else if (link_sts & AX_USB_HS)
> + index = BULK_IN_SPEED_1G_HS;
> + break;
> +
> + case ETHER_LINK_100:
> + if (link_sts & AX_USB_SS)
> + index = BULK_IN_SPEED_100_FULL_SS;
> + else if (link_sts & AX_USB_HS)
> + index = BULK_IN_SPEED_100_FULL_HS;
> + if (!full_duplex)
> + index++;
> + break;
> +
> + case ETHER_LINK_10:
> + index = BULK_IN_SPEED_FS;
> + break;
> +
> + default: /* No link */
> + index = BULK_IN_SPEED_FS;
> + }
> +
> + if (link_sts & AX_USB_FS)
> + index = BULK_IN_SPEED_FS;
> +
> + if (ax179_data->chip_version == AX_VERSION_AX88279) {
> + bulkin_data = AX88279_BULKIN_SIZE;
> + } else {
> + if (ax179_data->is_ax88772d)
> + bulkin_data = AX88772D_BULKIN_SIZE;
> + else
> + bulkin_data = AX88179A_BULKIN_SIZE;
> + }
> +
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_BULKIN_QCTRL, 5, 5, &bulkin_data[index]);
> +}
> +
> +static void ax88179a_get_pauseparam(struct net_device *net, struct ethtool_pauseparam *pause)
> +{
> + struct ax88179_data *data = netdev2data(net);
> +
> + phylink_ethtool_get_pauseparam(data->phylink, pause);
> +}
> +
> +static int ax88179a_set_pauseparam(struct net_device *net, struct ethtool_pauseparam *pause)
> +{
> + struct ax88179_data *data = netdev2data(net);
> +
> + return phylink_ethtool_set_pauseparam(data->phylink, pause);
> +}
> +
> +static int ax88179a_get_link_ksettings(struct net_device *net,
> + struct ethtool_link_ksettings *cmd)
> +{
> + struct ax88179_data *data = netdev2data(net);
> +
> + return phylink_ethtool_ksettings_get(data->phylink, cmd);
> +}
> +
> +static int ax88179a_set_link_ksettings(struct net_device *net,
> + const struct ethtool_link_ksettings *cmd)
> +{
> + struct ax88179_data *data = netdev2data(net);
> +
> + return phylink_ethtool_ksettings_set(data->phylink, cmd);
> +}
> +
> +static int ax88179a_get_eeprom_len(struct net_device *net)
> +{
> + struct ax88179_data *ax179_data = netdev2data(net);
> +
> + if (ax179_data->chip_version >= AX_VERSION_AX88279)
> + return AX88279_EEPROM_LEN;
> + else
> + return AX88179A_EEPROM_LEN;
> +}
> +
> +static const struct ethtool_ops ax88179a_ethtool_ops = {
> + .get_link = ethtool_op_get_link,
> + .get_msglevel = usbnet_get_msglevel,
> + .set_msglevel = usbnet_set_msglevel,
> + .get_wol = ax88179_get_wol,
> + .set_wol = ax88179_set_wol,
> + .get_eeprom_len = ax88179a_get_eeprom_len,
> + .get_eeprom = ax88179_get_eeprom,
> + .set_eeprom = ax88179_set_eeprom,
> + .nway_reset = phy_ethtool_nway_reset,
> + .get_link_ksettings = ax88179a_get_link_ksettings,
> + .set_link_ksettings = ax88179a_set_link_ksettings,
> + .get_pauseparam = ax88179a_get_pauseparam,
> + .set_pauseparam = ax88179a_set_pauseparam,
> + .get_ts_info = ethtool_op_get_ts_info,
> +};
> +
> +static void ax88179a_mdio_unregister(struct ax88179_data *data)
> +{
> + mdiobus_unregister(data->mdio);
> + mdiobus_free(data->mdio);
> +}
> +
> +static int ax88179a_init_phy(struct usbnet *dev)
> +{
> + struct ax88179_data *data = dev->driver_priv;
> + int ret;
> +
> + data->phydev = mdiobus_get_phy(data->mdio, AX88179_PHY_ID);
> + if (!data->phydev) {
> + netdev_err(dev->net, "Could not find PHY\n");
> + return -ENODEV;
> + }
> +
> + data->phydev->irq = PHY_MAC_INTERRUPT;
> + ret = phylink_connect_phy(data->phylink, data->phydev);
> + if (ret) {
> + netdev_err(dev->net, "Could not connect PHY\n");
> + return ret;
> + }
> +
> + phy_suspend(data->phydev);
> + data->phydev->mac_managed_pm = true;
> +
> + phy_attached_info(data->phydev);
> +
> + return 0;
> +}
> +
> +static void ax88179a_mac_config(struct phylink_config *config, unsigned int mode,
> + const struct phylink_link_state *state)
> +{
> + /* Nothing to do */
> +}
> +
> +static void ax88179a_mac_link_down(struct phylink_config *config,
> + unsigned int mode, phy_interface_t interface)
> +{
> + /* Nothing to do */
> +}
> +
> +static void ax88179a_mac_link_up(struct phylink_config *config,
> + struct phy_device *phy,
> + unsigned int phy_mode, phy_interface_t interface,
> + int speed, int duplex,
> + bool tx_pause, bool rx_pause)
> +{
> + struct usbnet *dev = netdev_priv(to_net_dev(config->dev));
> + struct ax88179_data *ax179_data = dev->driver_priv;
> + u8 link_sts = 0, reg8[3];
> + u8 bulk_config_speed = 0;
> + u16 mode;
> +
> + /* Stop RX/TX for link configuration */
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, AX_RX_CTL_STOP);
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_PATH, 1, 0);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_CDC_DELAY_TX, 1, 0xa5);
> +
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 2, 0x0410);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_ETH_TX_GAP, 1, 0);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_EP5_EHR, 1, 0x07);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_NEW_PAUSE_CTRL, 1,
> + 0x28 | AX_NEW_PAUSE_EN);
> +
> + mode = AX_MEDIUM_RECEIVE_EN;
> + if (tx_pause)
> + mode |= AX_MEDIUM_TXFLOW_CTRLEN;
> + if (rx_pause)
> + mode |= AX_MEDIUM_RXFLOW_CTRLEN;
> +
> + switch (speed) {
> + case SPEED_2500:
> + reg8[0] = 0x00;
> + reg8[1] = 0xF8;
> + reg8[2] = 0x07;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_TX_PAUSE, 3, 3, reg8);
> +
> + reg8[0] = 0x78;
> + reg8[1] = (AX_LSOFC_WCNT_7_ACCESS << 5);
> + reg8[2] = 0;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, reg8);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 1, 0x40);
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT + 1, 1,
> + AX_MAC_MIQFFCTRL_FORMAT | AX_MAC_MIQFFCTRL_DROP_CRC |
> + AX_MAC_LSO_ERR_EN);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_BFM_DATA, 1, AX_XGMII_EN);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_LSO_ENHANCE_CTRL, 1,
> + 0x1C | AX_LSO_ENHANCE_EN);
> +
> + mode |= AX_MEDIUM_GIGAMODE | AX_MEDIUM_FULL_DUPLEX;
> + bulk_config_speed = ETHER_LINK_2500;
> +
> + break;
> +
> + case SPEED_1000:
> + mode |= AX_MEDIUM_GIGAMODE;
> + bulk_config_speed = ETHER_LINK_1000;
> + fallthrough;
> +
> + case SPEED_100:
> + reg8[0] = 0x78;
> + reg8[1] = (AX_LSOFC_WCNT_7_ACCESS << 5) | AX_GMII_CRC_APPEND;
> + reg8[2] = 0;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, reg8);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 1, 0x40);
> + if (!bulk_config_speed)
> + bulk_config_speed = ETHER_LINK_100;
> + break;
> +
> + case SPEED_10:
> + reg8[0] = 0xFA;
> + reg8[1] = (AX_LSOFC_WCNT_7_ACCESS << 5) | AX_GMII_CRC_APPEND;
> + reg8[2] = 0xFF;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_STATUS_CDC, 3, 3, reg8);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_RX_DATA_CDC_CNT, 1, 0xFA);
> +
> + bulk_config_speed = ETHER_LINK_10;
> + break;
> + }
> +
> + ax88179_read_cmd(dev, AX_ACCESS_MAC, PHYSICAL_LINK_STATUS, 1, 1, &link_sts);
> + ax88179a_bulkin_config(dev, link_sts, bulk_config_speed, !!duplex);
> +
> + if (speed != SPEED_2500)
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_BFM_DATA, 1, 0);
> +
> + if (duplex)
> + mode |= AX_MEDIUM_FULL_DUPLEX;
> +
> + mutex_lock(&ax179_data->medium_status_mutex);
> + if (dev->net->mtu > 1500)
> + mode |= AX_MEDIUM_JUMBO_EN;
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, mode);
> +
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, READ_ONCE(ax179_data->rxctl));
> + mutex_unlock(&ax179_data->medium_status_mutex);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_PATH, 1,
> + AX_MAC_RX_PATH_READY | AX_MAC_TX_PATH_READY);
> +}
> +
> +static const struct phylink_mac_ops ax88179a_phylink_mac_ops = {
> + .mac_config = ax88179a_mac_config,
> + .mac_link_down = ax88179a_mac_link_down,
> + .mac_link_up = ax88179a_mac_link_up,
> +};
> +
> +static int ax88179a_phylink_setup(struct usbnet *dev)
> +{
> + struct ax88179_data *data = dev->driver_priv;
> + phy_interface_t phy_if_mode;
> + struct phylink *phylink;
> +
> + data->phylink_config.dev = &dev->net->dev;
> + data->phylink_config.type = PHYLINK_NETDEV;
> + data->phylink_config.mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_100;
> + if (data->is_ax88772d)
> + data->phylink_config.mac_capabilities |= MAC_10;
> + else if (data->chip_version < AX_VERSION_AX88279)
> + data->phylink_config.mac_capabilities |= MAC_10 | MAC_1000;
> + else
> + data->phylink_config.mac_capabilities |= MAC_1000 | MAC_2500FD;
> +
> + if (!data->is_ax88772d) {
> + data->phylink_config.lpi_capabilities = MAC_100FD | MAC_1000FD;
> + data->phylink_config.eee_enabled_default = false;
> + }
> +
> + if (data->chip_version == AX_VERSION_AX88279) {
> + __set_bit(PHY_INTERFACE_MODE_2500BASEX,
> + data->phylink_config.supported_interfaces);
> + __set_bit(PHY_INTERFACE_MODE_SGMII,
> + data->phylink_config.supported_interfaces);
> + phy_if_mode = PHY_INTERFACE_MODE_2500BASEX;
> + } else {
> + __set_bit(PHY_INTERFACE_MODE_SGMII,
> + data->phylink_config.supported_interfaces);
> + phy_if_mode = PHY_INTERFACE_MODE_SGMII;
> + }
> +
> + phylink = phylink_create(&data->phylink_config, dev->net->dev.fwnode,
> + phy_if_mode, &ax88179a_phylink_mac_ops);
> + if (IS_ERR(phylink))
> + return PTR_ERR(phylink);
> +
> + data->phylink = phylink;
> + return 0;
> +}
> +
> +static int ax88179a_init_mdio(struct usbnet *dev)
> +{
> + struct ax88179_data *data = dev->driver_priv;
> + int ret;
> +
> + data->mdio = mdiobus_alloc();
> + if (!data->mdio)
> + return -ENOMEM;
> +
> + data->mdio->priv = dev;
> + data->mdio->read = ax88179_mdiobus_read;
> + data->mdio->write = ax88179_mdiobus_write;
> + data->mdio->read_c45 = ax88179_mdiobus_read_c45;
> + data->mdio->write_c45 = ax88179_mdiobus_write_c45;
> + data->mdio->name = "AX88179A MDIO Bus";
> + data->mdio->phy_mask = ~(1 << AX88179_PHY_ID);
> + /* mii bus name is usb-<usb bus number>-<usb device number> */
> + snprintf(data->mdio->id, MII_BUS_ID_SIZE, "usb-%03d:%03d",
> + dev->udev->bus->busnum, dev->udev->devnum);
> +
> + ret = mdiobus_register(data->mdio);
> + if (ret) {
> + netdev_err(dev->net, "Could not register MDIO bus (err %d)\n", ret);
> + mdiobus_free(data->mdio);
> + data->mdio = NULL;
> + }
> +
> + return ret;
> +}
> +
> +static int ax88179a_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd)
> +{
> + struct ax88179_data *data = netdev2data(net);
> +
> + return phylink_mii_ioctl(data->phylink, rq, cmd);
> +}
> +
> +static const struct net_device_ops ax88179a_netdev_ops = {
> + .ndo_open = usbnet_open,
> + .ndo_stop = usbnet_stop,
> + .ndo_start_xmit = usbnet_start_xmit,
> + .ndo_tx_timeout = usbnet_tx_timeout,
> + .ndo_get_stats64 = dev_get_tstats64,
> + .ndo_change_mtu = ax88179_change_mtu,
> + .ndo_set_mac_address = ax88179_set_mac_addr,
> + .ndo_validate_addr = eth_validate_addr,
> + .ndo_eth_ioctl = ax88179a_mii_ioctl,
> +};
> +
> +static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf)
> +{
> + struct usb_device *udev = interface_to_usbdev(intf);
> + struct ax88179_data *ax179_data;
> + int ret;
> +
> + /* Check if vendor configuration */
> + if (udev->actconfig->desc.bConfigurationValue != 1) {
> + netdev_info(dev->net, "Switching to vendor mode\n");
> + usb_driver_set_configuration(udev, 1);
> + return -ENODEV;
> + }
> +
> + ret = usbnet_get_endpoints(dev, intf);
> + if (ret < 0)
> + return ret;
> +
> + ax179_data = kzalloc_obj(*ax179_data);
> + if (!ax179_data)
> + return -ENOMEM;
> +
> + dev->driver_priv = ax179_data;
> + mutex_init(&ax179_data->medium_status_mutex);
> +
> + ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_CHIP_STATUS,
> + 1, 1, &ax179_data->chip_version);
> + if (ret < 0)
> + goto err_nodev;
> +
> + ax179_data->chip_version = (ax179_data->chip_version & 0xf0) >> 4;
> + ax179_data->is_ax88772d = 0;
> + if (ax179_data->chip_version == AX_VERSION_AX88179A) {
> + if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x300)
> + ax179_data->is_ax88772d = 1;
> + }
> +
> + for (int i = 0; i < 3; i++) {
> + ret = ax88179_read_cmd(dev, AX88179A_ACCESS_BL, AX88179A_SW_VERSION + i,
> + 1, 1, &ax179_data->fw_version[i]);
> + if (ret < 0)
> + ax179_data->fw_version[i] = 0xff;
> + }
> + ret = ax88179_read_cmd(dev, AX88179A_ACCESS_BL, AX88179A_SW_REVISION,
> + 1, 1, &ax179_data->fw_version[3]);
> + if (ret < 0)
> + ax179_data->fw_version[3] = 0xff;
> +
> + netdev_info(dev->net, "AX88179A/279/772D Chip Version: %x, FW: %d.%d.%d.%d\n",
> + ax179_data->chip_version,
> + ax179_data->fw_version[0], ax179_data->fw_version[1],
> + ax179_data->fw_version[2], ax179_data->fw_version[3]);
> +
> + /* The AX88279 requires both the AX_RX_CTL_IPE and AX_RX_CTL_DROPCRCERR
> + * bits set in AX_RX_CTL for creating correct RX-URBs. AX_RX_CTL_DROPCRCERR
> + * is anyway set for all chips, make sure AX_RX_CTL_IPE is set via ip_align.
> + * Also configure eeprom access parameters.
> + */
> + if (ax179_data->chip_version == AX_VERSION_AX88279) {
> + ax179_data->ip_align = 1;
> + ax179_data->eeprom_read_cmd = AX88179A_FLASH_READ;
> + ax179_data->eeprom_write_cmd = AX88179A_FLASH_WRITE;
> + ax179_data->eeprom_block = 256;
> + ax179_data->eeprom_wen = 1;
> + } else {
> + ax179_data->ip_align = 0;
> + ax179_data->eeprom_read_cmd = AX_ACCESS_EFUS;
> + ax179_data->eeprom_write_cmd = AX_ACCESS_EFUS;
> + ax179_data->eeprom_block = 20;
> + ax179_data->eeprom_wen = 0;
> + }
> +
> + dev->net->netdev_ops = &ax88179a_netdev_ops;
> + dev->net->ethtool_ops = &ax88179a_ethtool_ops;
> + dev->net->needed_headroom = 8;
> + dev->net->needed_tailroom = 8;
> + dev->net->min_mtu = ETH_MIN_MTU;
> + dev->hard_mtu = 9 * 1024;
> + dev->net->max_mtu = dev->hard_mtu - dev->net->hard_header_len;
> +
> + if (!ax179_data->is_ax88772d)
> + dev->mii.supports_gmii = 1;
> +
> + dev->net->features |= NETIF_F_SG | NETIF_F_IP_CSUM |
> + NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO;
> +
> + dev->net->hw_features |= dev->net->features;
> +
> + dev->net->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM |
> + NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO;
> +
> + netif_set_tso_max_size(dev->net, 16384);
> +
> + /* Enable Transmission of Link Speed byte in interrupt URB */
> + ax88179_write_cmd(dev, AX_FW_MODE, AX_FW_MODE_179A, 0, 0, NULL);
> + ax88179_write_cmd(dev, AX_RELOAD_EEPROM_EFUSE, 0, 0, 0, NULL);
> +
> + /* Read MAC address from DTB or ASIX chip */
> + ax88179_get_mac_addr(dev);
> + memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
> +
> + /* Power PHY for probing */
> + ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, AX_PHY_POWER);
> + msleep(250);
> +
> + ret = ax88179a_init_mdio(dev);
> + if (ret)
> + goto err_nodev;
> +
> + ret = ax88179a_phylink_setup(dev);
> + if (ret)
> + goto phylink_err;
> +
> + ret = ax88179a_init_phy(dev);
> + if (ret)
> + goto initphy_err;
> +
> + return 0;
> +
> +initphy_err:
> + phylink_destroy(ax179_data->phylink);
> +phylink_err:
> + ax88179a_mdio_unregister(ax179_data);
> +err_nodev:
> + kfree(ax179_data);
> + ax179_data = NULL;
> +
> + return ret;
> +}
> +
> +static void ax88179a_unbind(struct usbnet *dev, struct usb_interface *intf)
> +{
> + struct ax88179_data *ax179_data = dev->driver_priv;
> +
> + /* Configure RX control register => stop operation */
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, AX_RX_CTL_STOP);
> +
> + rtnl_lock();
> + phylink_disconnect_phy(ax179_data->phylink);
> + rtnl_unlock();
> + phylink_destroy(ax179_data->phylink);
> + ax88179a_mdio_unregister(ax179_data);
> +
> + ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, 0);
> +
> + kfree(ax179_data);
> +}
> +
> +static void ax88179a_rx_checksum(struct sk_buff *skb, u64 pkt_desc)
> +{
> + u32 pkt_type;
> +
> + skb->ip_summed = CHECKSUM_NONE;
> + /* checksum error bit is set */
> + if (pkt_desc & AX179A_RX_PD_L4_ERR || pkt_desc & AX179A_RX_PD_L3_ERR)
> + return;
> +
> + pkt_type = pkt_desc & AX179A_RX_PD_L4_TYPE_MASK;
> + /* It must be a TCP or UDP packet with a valid checksum */
> + if (pkt_type == AX179A_RX_PD_L4_TCP || pkt_type == AX179A_RX_PD_L4_UDP)
> + skb->ip_summed = CHECKSUM_UNNECESSARY;
> +}
> +
> +static int ax88179a_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
> +{
> + struct ax88179_data *ax179_data = dev->driver_priv;
> + struct sk_buff *ax_skb;
> + u32 hdr_off, pkt_end;
> + __le64 *pkt_desc_ptr;
> + u16 vlan_tag;
> + u16 pkt_cnt;
> + u64 rx_hdr;
> +
> + /* SKB contents for AX179A-based chips:
> + * <packet 1>
> + * ...
> + * <packet N>
> + * <per-packet metadata entry 1>
> + * ...
> + * <per-packet metadata entry N>
> + * <rx_hdr>
> + *
> + * where:
> + * <packet N> contains pkt_len data bytes and padding:
> + * 2 bytes of IP alignment (optional, depends on AX_RX_CTL_IPE flag)
> + * packet data received
> + * optional padding to 8-bytes boundary
> + * <per-packet metadata entry N> contains 8 bytes:
> + * pkt_len and fields AX_RXHDR_*
> + * <rx-hdr> contains 8 bytes:
> + * pkt_cnt and hdr_off (offset of <per-packet metadata entry 1>)
> + *
> + * pkt_cnt is number of entries in the per-packet metadata array.
> + */
> +
> + if (!skb || skb->len < sizeof(rx_hdr))
> + goto err;
> +
> + /* RX Descriptor Header */
> + skb_trim(skb, skb->len - sizeof(rx_hdr));
> + rx_hdr = get_unaligned_le64((__le64 *)skb_tail_pointer(skb));
> +
> + /* Check these packets */
> + hdr_off = FIELD_GET(AX179A_RX_DH_DESC_OFFSET, rx_hdr);
> + pkt_cnt = rx_hdr & AX179A_RX_DH_PKT_CNT_MASK;
> +
> + /* Consistency check header position */
> + if (hdr_off != skb->len - (pkt_cnt * sizeof(rx_hdr)))
> + goto err;
> +
> + /* Make sure that the bounds of the metadata array are inside the SKB
> + * (and in front of the counter at the end).
> + */
> + if (pkt_cnt * 8 + hdr_off > skb->len)
> + goto err;
> +
> + /* Packets must not overlap the metadata array */
> + skb_trim(skb, hdr_off);
> +
> + if (!pkt_cnt)
> + goto err;
> +
> + /* Get the first RX packet descriptor */
> + pkt_desc_ptr = (__le64 *)(skb->data + hdr_off);
> +
> + pkt_end = 0;
> + while (pkt_cnt--) {
> + u64 pkt_desc = get_unaligned_le64(pkt_desc_ptr);
> + u32 pkt_len_plus_padd;
> + u32 pkt_len;
> +
> + pkt_len = FIELD_GET(AX179A_RX_PD_LEN, pkt_desc);
> + pkt_len -= (ax179_data->ip_align ? 2 : 0);
> + pkt_len_plus_padd = ((pkt_len + 7 + (ax179_data->ip_align ? 2 : 0)) & 0x7FFF8);
> +
> + pkt_end += pkt_len_plus_padd;
> + if (pkt_end > hdr_off || (pkt_cnt == 0 && pkt_end != hdr_off))
> + goto err;
> +
> + if (pkt_desc & AX179A_RX_PD_DROP || !(pkt_desc & AX179A_RX_PD_RX_OK) ||
> + pkt_len > (dev->hard_mtu + AX179A_RX_HW_PAD) || pkt_len < 2 + ETH_HLEN) {
> + skb_pull(skb, pkt_len_plus_padd);
> +
> + /* Next RX Packet Descriptor */
> + pkt_desc_ptr++;
> + continue;
> + }
> +
> + ax_skb = netdev_alloc_skb_ip_align(dev->net, pkt_len);
> + if (!ax_skb)
> + goto err;
> +
> + skb_put(ax_skb, pkt_len);
> + memcpy(ax_skb->data, skb->data + (ax179_data->ip_align ? AX179A_RX_HW_PAD : 0),
> + pkt_len);
> +
> + if (ax179_data->rx_checksum)
> + ax88179a_rx_checksum(ax_skb, pkt_desc);
> +
> + if (pkt_desc & AX179A_RX_PD_VLAN) {
> + vlan_tag = pkt_desc >> AX179A_RX_PD_VLAN_SHIFT;
> + __vlan_hwaccel_put_tag(ax_skb, htons(ETH_P_8021Q), vlan_tag);
> + }
> +
> + usbnet_skb_return(dev, ax_skb);
> + skb_pull(skb, pkt_len_plus_padd);
> +
> + /* Next RX Packet Header */
> + pkt_desc_ptr++;
> + }
> +
> + return 1;
> +
> +err:
> + return 0;
> +}
> +
> +static struct sk_buff *ax88179a_tx_fixup(struct usbnet *dev, struct sk_buff *skb, gfp_t flags)
> +{
> + u64 tx_desc = skb->len & AX179A_TX_DESC_LEN_MASK;
> + int frame_size = dev->maxpacket;
> + struct sk_buff *ax_skb;
> + u64 *tx_desc_ptr;
> + int padding_size;
> + int headroom;
> + int tailroom;
> + u16 tci = 0;
> +
> + /* TSO MSS */
> + tx_desc |= FIELD_PREP(AX179A_TX_DESC_MSS, (u64)skb_shinfo(skb)->gso_size);
> +
> + headroom = (skb->len + sizeof(tx_desc)) % 8;
> + padding_size = headroom ? 8 - headroom : 0;
> +
> + if (((skb->len + sizeof(tx_desc) + padding_size) % frame_size) == 0) {
> + padding_size += 8;
> + tx_desc |= AX179A_TX_DESC_DROP_PADD;
> + }
> +
> + if ((dev->net->features & NETIF_F_HW_VLAN_CTAG_TX) && (vlan_get_tag(skb, &tci) >= 0)) {
> + tx_desc |= AX179A_TX_DESC_VLAN;
> + tx_desc |= FIELD_PREP(AX179A_TX_DESC_VLAN_ID, (u64)tci);
> + }
> +
> + if (!dev->can_dma_sg && (dev->net->features & NETIF_F_SG) && skb_linearize(skb)) {
> + dev_kfree_skb_any(skb);
> + return NULL;
> + }
> +
> + headroom = skb_headroom(skb);
> + tailroom = skb_tailroom(skb);
> +
> + if (skb_cloned(skb) || !(headroom >= sizeof(tx_desc) && tailroom >= padding_size)) {
> + ax_skb = skb_copy_expand(skb, sizeof(tx_desc), padding_size, flags);
> + dev_kfree_skb_any(skb);
> + skb = ax_skb;
> + if (!skb)
> + return NULL;
> + }
> + if (padding_size != 0)
> + skb_put_zero(skb, padding_size);
> + /* Copy TX header */
> + tx_desc_ptr = skb_push(skb, sizeof(tx_desc));
> + put_unaligned_le64(tx_desc, tx_desc_ptr);
> +
> + usbnet_set_skb_tx_stats(skb, 1, 0);
> +
> + return skb;
> +}
> +
> +static int ax88179a_reset(struct usbnet *dev)
> +{
> + struct ax88179_data *ax179_data = dev->driver_priv;
> + u16 *tmp16;
> + u8 buf[5];
> + u16 rxctl;
> + u8 *tmp;
> +
> + tmp16 = (u16 *)buf;
> + tmp = (u8 *)buf;
> +
> + /* Power up ethernet PHY */
> + ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, AX_PHY_POWER);
> + msleep(250);
> +
> + /* Ethernet PHY Auto Detach*/
> + ax88179a_auto_detach(dev);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_BULK_OUT_CTRL, 1, AX_MAC_EFF_EN);
> +
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 0);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_LOW, 1, 0x04);
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX_PAUSE_WATERLVL_HIGH, 1, 0x10);
> +
> + *tmp = 0;
> + if (dev->net->features & NETIF_F_HW_VLAN_CTAG_FILTER)
> + *tmp |= AX_VLAN_CONTROL_VFE;
> + if (dev->net->features & NETIF_F_HW_VLAN_CTAG_RX)
> + *tmp |= AX_VLAN_CONTROL_VSO;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, tmp);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_BM_INT_MASK, 1, 0xff);
> +
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_BM_RX_DMA_CTL, 1, 0);
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_BM_TX_DMA_CTL, 1, 0);
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_ARC_CTRL, 1, 0);
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_SWP_CTRL, 1, 0);
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_TX_HDR_CKSUM, 1, 0);
> +
> + /* Read MAC address from DTB or asix chip */
> + ax88179_get_mac_addr(dev);
> + memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
> +
> + /* The Bulk-Register configuration for the AX88179A is done in
> + * ax88179a_mac_link_up(), once the link is up for a given link and USB-speed.
> + */
> + if (ax179_data->is_ax88772d)
> + dev->rx_urb_size = 1024 * 24;
> + else
> + dev->rx_urb_size = 1024 * 48;
> +
> + /* Enable checksum offload */
> + if (dev->net->features & NETIF_F_RXCSUM) {
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1,
> + AX_RXCOE_IP | AX_RXCOE_TCP | AX_RXCOE_UDP |
> + AX_RXCOE_TCPV6 | AX_RXCOE_UDPV6);
> + ax179_data->rx_checksum = 1;
> + } else {
> + ax179_data->rx_checksum = 0;
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX_RXCOE_CTL, 1, 0);
> + }
> +
> + *tmp = 0;
> + if (dev->net->features & NETIF_F_IP_CSUM)
> + *tmp = AX_TXCOE_IP | AX_TXCOE_TCP | AX_TXCOE_UDP;
> + if (dev->net->features & NETIF_F_IPV6_CSUM)
> + *tmp |= AX_TXCOE_IP | AX_TXCOE_TCPV6 | AX_TXCOE_UDPV6;
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, *tmp);
> +
> + /* Configure RX control register => start operation */
> + rxctl = AX_RX_CTL_DROPCRCERR | AX_RX_CTL_START | AX_RX_CTL_AP |
> + AX_RX_CTL_AMALL | AX_RX_CTL_AB;
> + if (ax179_data->ip_align)
> + rxctl |= AX_RX_CTL_IPE;
> + if (dev->net->flags & IFF_PROMISC)
> + rxctl |= AX_RX_CTL_PRO;
> + WRITE_ONCE(ax179_data->rxctl, rxctl);
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, rxctl);
> +
> + if (ax179_data->chip_version < AX_VERSION_AX88179A)
> + *tmp = AX_MONITOR_MODE_PMETYPE | AX_MONITOR_MODE_PMEPOL | AX_MONITOR_MODE_RWMP;
> + else
> + *tmp = AX_MONITOR_MODE_RWMP;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, tmp);
> +
> + /* Configure default medium type => giga */
> + *tmp16 = AX_MEDIUM_RECEIVE_EN | AX_MEDIUM_TXFLOW_CTRLEN |
> + AX_MEDIUM_RXFLOW_CTRLEN | AX_MEDIUM_FULL_DUPLEX;
> + if (!ax179_data->is_ax88772d)
> + *tmp16 |= AX_MEDIUM_GIGAMODE;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, tmp16);
> +
> + /* Check if WoL is supported */
> + ax179_data->wol_supported = 0;
> + if (ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD,
> + 1, 1, tmp) > 0)
> + ax179_data->wol_supported = WAKE_MAGIC | WAKE_PHY;
> +
> + /* Ensure EEE state is off, consistent with phylink setup */
> + ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, false, 0, NULL);
> +
> + phylink_start(ax179_data->phylink);
> +
> + return 0;
> +}
> +
> +static int ax88179a_stop(struct usbnet *dev)
> +{
> + struct ax88179_data *ax179_data = dev->driver_priv;
> + u16 reg16 = 0;
> +
> + phylink_stop(ax179_data->phylink);
> +
> + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, ®16);
> + reg16 &= ~AX_MEDIUM_RECEIVE_EN;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, ®16);
> +
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 0);
> +
> + ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, 0);
> +
> + return 0;
> +}
> +
> +const struct driver_info ax88179a_info = {
> + .description = "ASIX AX88179A USB 3.2 Gigabit Ethernet",
> + .bind = ax88179a_bind,
> + .unbind = ax88179a_unbind,
> + .status = ax88179a_status,
> + .reset = ax88179a_reset,
> + .stop = ax88179a_stop,
> + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET | FLAG_AVOID_UNLINK_URBS,
> + .rx_fixup = ax88179a_rx_fixup,
> + .tx_fixup = ax88179a_tx_fixup,
> +};
> +
> +const struct driver_info ax88772d_info = {
> + .description = "ASIX AX88772D/E USB 2.0 Fast Ethernet",
> + .bind = ax88179a_bind,
> + .unbind = ax88179a_unbind,
> + .status = ax88179a_status,
> + .reset = ax88179a_reset,
> + .stop = ax88179a_stop,
> + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET | FLAG_AVOID_UNLINK_URBS,
> + .rx_fixup = ax88179a_rx_fixup,
> + .tx_fixup = ax88179a_tx_fixup,
> +};
> +
> +const struct driver_info ax88279_info = {
> + .description = "ASIX AX88279 USB 3.2 2.5Gigabit Ethernet",
> + .bind = ax88179a_bind,
> + .unbind = ax88179a_unbind,
> + .status = ax88179a_status,
> + .reset = ax88179a_reset,
> + .stop = ax88179a_stop,
> + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET | FLAG_AVOID_UNLINK_URBS,
> + .rx_fixup = ax88179a_rx_fixup,
> + .tx_fixup = ax88179a_tx_fixup,
> +};
>
[Severity: High]
All three new driver_info entries set FLAG_AVOID_UNLINK_URBS. None of
the existing ax88179 entries do.
With that flag, usbnet_stop() skips usbnet_terminate_urbs().
ax88179a_stop() only clears AX_MEDIUM_RECEIVE_EN and AX_RX_CTL and
powers down the PHY. The RX URBs stay submitted, and stay on dev->rxq,
after ifdown.
What happens if the device is then unplugged or unbound while the
interface is still down?
usb_unbind_interface()
usb_disable_interface() <- kills the leftover RX URBs
rx_complete()
defer_bh() <- queues dev->bh_work
usbnet_disconnect()
unregister_netdev() <- not running, no usbnet_stop()
cancel_work_sync(&dev->kevent)
free_netdev() <- bh_work still pending
usbnet_bh_work() would then run on the freed struct usbnet and
net_device.
On a physical unplug, rx_complete() can also arm dev->delay on
-EPROTO, -ETIME or -EILSEQ. On this path nothing deletes that timer
before free_netdev().
Why do these chips need FLAG_AVOID_UNLINK_URBS? If there is no
hardware reason, could the flag be dropped? If there is one, how are
the outstanding RX URBs, bh_work and the delay timer meant to be
cleaned up before free_netdev()?
[Severity: Medium]
ax88179a_reset() is the driver_info->reset hook, so usbnet_open() runs
it on every ifup. It re-reads the MAC with ax88179_get_mac_addr() and
then copies dev->net->dev_addr into dev->net->perm_addr.
What happens if the address was changed while the interface was down?
ax88179_set_mac_addr() only allows a change when !netif_running(). It
writes the new address into dev_addr and AX_NODE_ID. On the next ifup:
- With a platform/DT MAC, eth_platform_get_mac_address() succeeds and
the user-configured address is silently replaced in both dev_addr
and AX_NODE_ID.
- Without one, the user's address is read back from AX_NODE_ID. For a
non-local address, addr_assign_type is set back to NET_ADDR_PERM.
The memcpy() then overwrites perm_addr with the user's address. The
real permanent address is lost until the device is rebound, and
ethtool -P reports the wrong value.
The in_pm check added later in the series doesn't cover this. in_pm is
false when ax88179a_reset() is called from usbnet_open().
ax88179a_bind() already reads the MAC and sets perm_addr. Does the
reset path need to do more than program dev->net->dev_addr into
AX_NODE_ID?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 05/13] ax88179_178a: Add EEE configuration support for AX88179A MACs
2026-11-06 7:21 ` [PATCH net-next v20 05/13] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] Baseline decision: false positive, because the next patch in the
series fixes it.
- [Low] Baseline decision: false positive, because the next patch in the
series fixes it.
--
ax88179_178a: Add EEE configuration support for AX88179A MACs
This commit adds mac_enable_tx_lpi and mac_disable_tx_lpi phylink callbacks
for the AX88179A. They toggle the single AX_GPHY_EEE_CTRL register through
ax88179_write_cmd(). The hardware has no LPI timer registers.
> diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
> index 1aa8479422517..62619fd68c408 100644
> --- a/drivers/net/usb/ax88179a_devices.c
> +++ b/drivers/net/usb/ax88179a_devices.c
[ ... ]
> static const struct phylink_mac_ops ax88179a_phylink_mac_ops = {
> .mac_config = ax88179a_mac_config,
> .mac_link_down = ax88179a_mac_link_down,
> .mac_link_up = ax88179a_mac_link_up,
> + .mac_disable_tx_lpi = ax88179a_mac_disable_tx_lpi,
> + .mac_enable_tx_lpi = ax88179a_mac_enable_tx_lpi,
> };
[Severity: Low]
With both LPI ops present, phylink_create() sets pl->mac_supports_eee_ops
to true. At this commit, ax88179a_phylink_setup() sets lpi_capabilities but
does not fill phylink_config.lpi_interfaces:
if (!data->is_ax88772d) {
data->phylink_config.lpi_capabilities = MAC_100FD | MAC_1000FD;
data->phylink_config.eee_enabled_default = false;
}
phylink_create() requires a non-empty lpi_interfaces:
pl->mac_supports_eee = pl->mac_supports_eee_ops &&
pl->config->lpi_capabilities &&
!phy_interface_empty(pl->config->lpi_interfaces);
So mac_supports_eee comes out false. Does phylink_bringup_phy() then take
this branch for every AX88179A/AX88279 device?
} else if (pl->mac_supports_eee_ops) {
/* MAC supports phylink EEE, but wants EEE always disabled. */
phy_disable_eee(phy);
ax88179a_mac_enable_tx_lpi() also looks unreachable here.
phylink_link_up() does not call phylink_activate_lpi() when
mac_supports_eee is false, and phylink_activate_lpi() returns early in any
case:
if (!test_bit(pl->cur_interface, pl->config->lpi_interfaces)) {
phylink_ethtool_get_eee() and phylink_ethtool_set_eee() would return
-EOPNOTSUPP in this state as well.
The next patch in the series, "ax88179_178a: Add EEE configuration support
for AX88179A PHYs", copies supported_interfaces into lpi_interfaces before
phylink_create(), so this gap only exists at this one commit. The default
behaviour seen by users is unchanged, because the driver already defaults
to EEE off with eee_enabled_default = false.
Would it make sense to fill lpi_interfaces in this patch, so the new
callbacks can be reached at this commit?
[Severity: Low]
At this commit ax88179a_ethtool_ops has no .get_eee or .set_eee entries:
static const struct ethtool_ops ax88179a_ethtool_ops = {
...
.set_eeprom = ax88179_set_eeprom,
.nway_reset = phy_ethtool_nway_reset,
...
};
So ethtool --set-eee on an AX88179A returns -EOPNOTSUPP. Userspace has no
way to enable EEE through the new mac_enable_tx_lpi/mac_disable_tx_lpi
callbacks. EEE stays off, which matches eee_enabled_default = false.
The next patch, "ax88179_178a: Add EEE configuration support for AX88179A
PHYs", adds ax88179a_get_eee() and ax88179a_set_eee(). These wrap
phylink_ethtool_get_eee() and phylink_ethtool_set_eee() and are wired into
ax88179a_ethtool_ops.
Is splitting the MAC side and the ethtool side across these two patches
intended?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 06/13] ax88179_178a: Add EEE configuration support for AX88179A PHYs
2026-11-06 7:21 ` [PATCH net-next v20 06/13] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] This patch fills phylink_config.lpi_interfaces in
ax88179a_phylink_setup() (drivers/net/usb/ax88179a_devices.c).
- [Low] The new ax88179a_set_eee()
(drivers/net/usb/ax88179a_devices.c:235-240) passes the user's struct…
--
ax88179_178a: Add EEE configuration support for AX88179A PHYs
This commit copies supported_interfaces into phylink_config.lpi_interfaces
in ax88179a_phylink_setup(), so phylink now treats the MAC as supporting
EEE. It also adds get_eee/set_eee ethtool ops that forward to
phylink_ethtool_get_eee() and phylink_ethtool_set_eee().
> diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
> index 62619fd68c408..272e923656832 100644
> --- a/drivers/net/usb/ax88179a_devices.c
> +++ b/drivers/net/usb/ax88179a_devices.c
> @@ -225,6 +225,20 @@ static int ax88179a_get_eeprom_len(struct net_device *net)
> return AX88179A_EEPROM_LEN;
> }
>
> +static int ax88179a_get_eee(struct net_device *net, struct ethtool_keee *edata)
> +{
> + struct ax88179_data *ax179_data = netdev2data(net);
> +
> + return phylink_ethtool_get_eee(ax179_data->phylink, edata);
> +}
> +
> +static int ax88179a_set_eee(struct net_device *net, struct ethtool_keee *edata)
> +{
> + struct ax88179_data *ax179_data = netdev2data(net);
> +
> + return phylink_ethtool_set_eee(ax179_data->phylink, edata);
> +}
[Severity: Low]
Should ax88179a_set_eee() reject a tx_lpi_timer that the hardware cannot
apply?
Neither ax88179a_set_eee() nor phylink_ethtool_set_eee() checks
edata->tx_lpi_timer. The value is stored in pl->eee_cfg and
phydev->eee_cfg, and get_eee reports it back. The MAC callback ignores
the timer, though:
drivers/net/usb/ax88179a_devices.c:ax88179a_mac_enable_tx_lpi() {
...
/* AX88179A does not provide LPI timer registers */
return ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, true, 0, NULL);
}
The phylink_mac_ops documentation for mac_enable_tx_lpi() says
"Configure the LPI timeout accordingly".
As a result, "ethtool --set-eee ethX tx-timer N" succeeds and
"--show-eee" reports N, but the hardware never uses it.
phylink_config.lpi_timer_default is never set either, so the reported
default timer is 0.
Other drivers whose LPI timer cannot be changed reject this request.
e1000e_set_eee() and ixgbe_validate_keee() both return an error when
tx_lpi_timer differs from the fixed value.
Could the wrapper do the same here? Another option is to set
lpi_timer_default to the real hardware value and refuse changes. The
last commit in the series still has this code unchanged.
> +
> static const struct ethtool_ops ax88179a_ethtool_ops = {
[ ... ]
> @@ -451,6 +467,10 @@ static int ax88179a_phylink_setup(struct usbnet *dev)
> phy_if_mode = PHY_INTERFACE_MODE_SGMII;
> }
>
> + memcpy(data->phylink_config.lpi_interfaces,
> + data->phylink_config.supported_interfaces,
> + sizeof(data->phylink_config.lpi_interfaces));
> +
[Severity: Medium]
Does this change the default EEE advertisement on the wire for every
non-AX88772D chip, including AX88279?
Before this patch lpi_interfaces was empty. phylink_create() therefore
set mac_supports_eee to false while mac_supports_eee_ops was true, and
phylink_bringup_phy() called phy_disable_eee().
With lpi_interfaces filled in, mac_supports_eee becomes true. This
earlier setup also applies:
if (!data->is_ax88772d) {
data->phylink_config.lpi_capabilities = MAC_100FD | MAC_1000FD;
data->phylink_config.eee_enabled_default = false;
}
So pl->eee_cfg.eee_enabled is false, and phylink_bringup_phy() takes
neither branch that changes the PHY's EEE enable:
drivers/net/phy/phylink.c:phylink_bringup_phy() {
...
if (pl->mac_supports_eee) {
...
if (pl->eee_cfg.eee_enabled)
phy_support_eee(phy);
...
} else if (pl->mac_supports_eee_ops) {
/* MAC supports phylink EEE, but wants EEE always disabled. */
phy_disable_eee(phy);
}
...
}
phydev->eee_cfg.eee_enabled keeps the value phy_probe() derived from the
PHY's power-on advertisement:
phydev->eee_cfg.eee_enabled = !linkmode_empty(phydev->advertising_eee);
If the internal GPHY advertises EEE at reset, genphy_c45_an_config_eee_aneg()
will keep advertising the 100FD/1000FD EEE modes on every autoneg. That
includes after the PHY power-cycle in resume and reset. The link partner
then negotiates EEE while MAC TX LPI stays off.
The legacy ax88179_178a.c reset path explicitly disables EEE and clears
the EEE advertisement. That suggests this family does advertise EEE by
default, but this was not confirmed for the AX88179A/AX88279 PHYs.
This also seems to conflict with the comment in ax88179a_reset():
/* Ensure EEE state is off, consistent with phylink setup */
ax88179_write_cmd(dev, AX_GPHY_CTL, AX_GPHY_EEE_CTRL, false, 0, NULL);
That only clears the MAC-side LPI control. phylink_ethtool_get_eee()
would then report the PHY's eee_enabled as true together with
tx_lpi_enabled as false, which does not match phylink's own eee_cfg.
Was this default change intended? If not, should the PHY's EEE
advertisement be disabled explicitly when eee_enabled_default is false?
The commit message also does not mention that AX88279 gets
phylink-managed EEE (lpi_capabilities is set for all !is_ax88772d chips).
Nor does it mention that AX88772D now has get_eee/set_eee ops that always
return -EOPNOTSUPP. The final commit in the series has the same code, so
nothing later in the series changes this.
> phylink = phylink_create(&data->phylink_config, dev->net->dev.fwnode,
> phy_if_mode, &ax88179a_phylink_mac_ops);
> if (IS_ERR(phylink))
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 07/13] ax88179_178a: Add VLAN offload support for AX88179A
2026-11-06 7:21 ` [PATCH net-next v20 07/13] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 7 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 5 · Low: 2
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] ax88179a_set_features() calls ax88179_set_features() first.
- [Medium] The patch makes NETIF_F_HW_VLAN_CTAG_RX user-toggleable and
off by default: it is added to hw_features only…
- [Medium] ax88179a_reset() rebuilds AX88179A_VLAN_ID_CONTROL from
dev->features: VFE if CTAG_FILTER is set, VSO if CTAG_RX is set…
- [Medium] When CTAG_FILTER is enabled, ax88179a_set_features() clears
the VLAN table with 256 iterations of…
- [Medium] The new VLAN code treats any non-negative return from
ax88179_read_cmd() as success.
- [Low] The last line of the commit message, "Error-checking fixes
Suggested-by: Jianhui Xu <neuromoments@gmail.com>", is not a valid…
- [Low] The patch turns on NETIF_F_HW_VLAN_CTAG_TX by default and makes
it toggleable (`hw_features |= features`, ax88179a_devices.c:768-772).
--
ax88179_178a: Add VLAN offload support for AX88179A
This adds VLAN offload support for the AX88179A-based chips by wiring up
ndo_set_features, ndo_vlan_rx_add_vid and ndo_vlan_rx_kill_vid. It enables
NETIF_F_HW_VLAN_CTAG_TX by default. It also exposes NETIF_F_HW_VLAN_CTAG_RX
and NETIF_F_HW_VLAN_CTAG_FILTER as toggleable hw_features.
> Error-checking fixes Suggested-by: Jianhui Xu <neuromoments@gmail.com>
[Severity: Low]
This isn't a bug, but is this meant to be a Suggested-by: trailer? With
"Error-checking fixes" in front of it, git interpret-trailers, b4 and
checkpatch won't parse it as a tag. A per-version change note would
normally go below the '---' line.
The note also claims more error checking than the code has. The
256-iteration table clear loop in ax88179a_set_features() doesn't check
any of its ax88179_write_cmd(), ax88179_write_u16() or ax88179_write_u8()
return values (see the comment on that loop below).
> diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
> index 272e923656832..4207d2cc2b865 100644
> --- a/drivers/net/usb/ax88179a_devices.c
> +++ b/drivers/net/usb/ax88179a_devices.c
> @@ -258,6 +258,88 @@ static const struct ethtool_ops ax88179a_ethtool_ops = {
[ ... ]
> +static int ax88179a_vlan_rx_add_vid(struct net_device *net, __be16 proto, u16 vid)
> +{
> + struct usbnet *dev = netdev_priv(net);
> + u8 vlan_ctrl;
> + int ret = 0;
> + u16 reg16;
> + u8 reg8;
> +
> + ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, ®8);
> + if (ret < 0)
> + return ret;
> + vlan_ctrl = reg8;
[Severity: Medium]
Can vlan_ctrl end up holding uninitialized stack data here?
__usbnet_read_cmd() only copies into the caller's buffer when the
transfer returned a positive length:
drivers/net/usb/usbnet.c:__usbnet_read_cmd() {
...
if (err > 0 && err <= size) {
if (data)
memcpy(data, buf, err);
...
}
For size == 1, ax88179_read_cmd() passes ®8 straight through. A
zero-length reply from the device returns 0. That passes the ret < 0
check while reg8 is still uninitialized.
The value is then ORed with AX_VLAN_CONTROL_RD and AX_VLAN_CONTROL_WE and
written back to AX88179A_VLAN_ID_CONTROL twice. That sends a stack byte
to the device and programs arbitrary VFE/VSO bits.
This also doesn't match the rest of the patch.
ax88179a_vlan_rx_kill_vid() zero-initializes reg8 and reg16, and
ax88179a_reset() checks its reads with > 0.
The same pattern applies to u8 tmp in ax88179a_set_features(). It is
uninitialized on the VFE-disable branch and on the CTAG_RX branch. If the
filter-enable loop ran first, tmp is left at 255, so a short read would
write 0xff | AX_VLAN_CONTROL_VSO.
Both add_vid and kill_vid read AX88179A_VLAN_ID_DATA0 with a 2-byte read.
A short reply there leaves reg16 at 0, because ax88179_read_cmd() uses a
zeroed bounce buffer. Wouldn't the write-back then clear the other 15
VIDs in that 16-VID group?
Should these checks treat anything shorter than a full-length read as an
error?
[ ... ]
> + ret = ax88179_read_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®16);
> + if (ret < 0)
> + return ret;
> + reg16 |= (1 << (vid % 16));
> + ret = ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0, 2, 2, ®16);
[Severity: Medium]
The VID bitmap only lives in device SRAM here, and the driver keeps no
software copy. What restores it after the device loses power?
ax88179a_reset() rebuilds AX88179A_VLAN_ID_CONTROL from dev->features
but doesn't touch the table:
drivers/net/usb/ax88179a_devices.c:ax88179a_reset() {
...
*tmp = 0;
if (dev->net->features & NETIF_F_HW_VLAN_CTAG_FILTER)
*tmp |= AX_VLAN_CONTROL_VFE;
if (dev->net->features & NETIF_F_HW_VLAN_CTAG_RX)
*tmp |= AX_VLAN_CONTROL_VSO;
ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL, 1, 1, tmp);
...
}
Later in this series, "ax88179_178a: Add Suspend/resume support for
AX88179A/772D/279" wires .resume and .reset_resume to ax88179a_resume().
That function power-cycles the PHY and calls ax88179a_reset(). The vlan
core doesn't push existing VIDs to the driver again on open or resume.
After a power-losing suspend or a reset_resume with rx-vlan-filter on,
VFE would be set again on top of the power-on table contents.
ax88179a_set_features() clears all 256 entries before enabling VFE, which
suggests those power-on contents can't be trusted.
Wouldn't traffic for the configured VLANs then be dropped until
rx-vlan-filter is toggled?
> @@ -517,6 +599,75 @@ static int ax88179a_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd)
> return phylink_mii_ioctl(data->phylink, rq, cmd);
> }
>
> +static int ax88179a_set_features(struct net_device *net, netdev_features_t features)
> +{
> + struct usbnet *dev = netdev_priv(net);
> + netdev_features_t changed;
> + int ret;
> + u8 tmp;
> +
> + changed = net->features ^ features;
> +
> + ret = ax88179_set_features(net, features);
> + if (ret)
> + return ret;
[Severity: Medium]
What happens to the checksum offload state if one of the VLAN register
accesses below fails?
By the time we get here, ax88179_set_features() has already XOR-toggled
AX_TXCOE_CTL and AX_RXCOE_CTL in hardware and updated
data->rx_checksum. It also always returns 0:
drivers/net/usb/ax88179_lib.c:ax88179_set_features() {
...
tmp ^= AX_TXCOE_TCP | AX_TXCOE_UDP;
...
}
If the VLAN FILTER or CTAG_RX sequence then returns a negative error,
__netdev_update_features() returns early. dev->features keeps its old
value, and nothing rolls back the hardware.
Take ethtool -K ethX tx on rxvlan on as an example. TXCOE gets toggled
on, then the VSO read fails, so NETIF_F_IP_CSUM stays off in
dev->features. On retry, changed still contains IP_CSUM, so the XOR turns
TXCOE back off, and this time the call succeeds.
Wouldn't CHECKSUM_PARTIAL frames then go out without hardware checksums?
RXCSUM can get out of sync the same way.
The VLAN-only case has a similar problem. Suppose the FILTER-on block
clears the table and sets VFE, and then the CTAG_RX block fails. Hardware
filtering is now on with an empty table. dev->features still has FILTER
off, so ndo_vlan_rx_add_vid is never called.
Would all tagged traffic be dropped in that state?
> +
> + if (changed & NETIF_F_HW_VLAN_CTAG_FILTER) {
> + if (features & NETIF_F_HW_VLAN_CTAG_FILTER) {
> + u8 vlan_state = 0;
> +
> + ret = ax88179_read_cmd(dev, AX_ACCESS_MAC,
> + AX88179A_VLAN_ID_CONTROL, 1, 1, &vlan_state);
> + if (ret < 0)
> + return ret;
> +
> + for (int i = 0; i < 256; i++) {
> + /* Address */
> + tmp = i;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_ADDRESS,
> + 1, 1, &tmp);
> + /* Data */
> + ax88179_write_u16(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_DATA0,
> + 2, 0);
> + /* Write-Execute */
> + ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_VLAN_ID_CONTROL,
> + 1, vlan_state | AX_VLAN_CONTROL_WE);
> + }
> + vlan_state |= AX_VLAN_CONTROL_VFE;
> + ret = ax88179_write_cmd(dev, AX_ACCESS_MAC,
> + AX88179A_VLAN_ID_CONTROL, 1, 1, &vlan_state);
[Severity: Medium]
Should the return values in this loop be checked? The read before the
loop and the VFE write after it are checked. None of the 768 synchronous
control transfers inside the loop are.
If the device stops responding, each transfer can block for
USB_CTRL_SET_TIMEOUT (5 seconds). This runs under RTNL from
__netdev_update_features(). Wouldn't RTNL be held for about an hour?
Errors that come back quickly, such as -EPIPE, would leave some 16-VID
groups with stale bits. VFE is still enabled and 0 is returned, so could
the hardware filter accept VIDs the stack never registered?
[ ... ]
> @@ -612,9 +766,11 @@ static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf)
> dev->mii.supports_gmii = 1;
>
> dev->net->features |= NETIF_F_SG | NETIF_F_IP_CSUM |
> - NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO;
> + NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM | NETIF_F_TSO |
> + NETIF_F_HW_VLAN_CTAG_TX;
[Severity: Low]
Enabling NETIF_F_HW_VLAN_CTAG_TX here, and making it toggleable through
hw_features, makes the existing tag insertion in ax88179a_tx_fixup()
reachable:
drivers/net/usb/ax88179a_devices.c:ax88179a_tx_fixup() {
...
if ((dev->net->features & NETIF_F_HW_VLAN_CTAG_TX) && (vlan_get_tag(skb, &tci) >= 0)) {
tx_desc |= AX179A_TX_DESC_VLAN;
tx_desc |= FIELD_PREP(AX179A_TX_DESC_VLAN_ID, (u64)tci);
}
...
}
This checks dev->net->features again at transmit time, and vlan_get_tag()
also looks at skb->dev->features. By then validate_xmit_vlan() has
already decided to keep the tag in skb->vlan_tci.
__netdev_update_features() doesn't quiesce the TX queue, and
ax88179a_set_features() doesn't stop it either. If txvlan is switched off
while a tagged skb is between validate_xmit_skb() and tx_fixup, can the
frame go out untagged on the native VLAN?
The lan78xx TX path only checks skb_vlan_tag_present() and
skb_vlan_tag_get().
>
> dev->net->hw_features |= dev->net->features;
> + dev->net->hw_features |= NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_CTAG_FILTER;
[Severity: Medium]
Since NETIF_F_HW_VLAN_CTAG_RX is only added to hw_features, it is off by
default and can be toggled. Its only hardware effect is the
AX_VLAN_CONTROL_VSO strip bit. The RX path, however, tags frames based
only on the descriptor bit:
drivers/net/usb/ax88179a_devices.c:ax88179a_rx_fixup() {
...
if (pkt_desc & AX179A_RX_PD_VLAN) {
vlan_tag = pkt_desc >> AX179A_RX_PD_VLAN_SHIFT;
__vlan_hwaccel_put_tag(ax_skb, htons(ETH_P_8021Q), vlan_tag);
}
...
}
The chip may set AX179A_RX_PD_VLAN for tagged frames even when VSO is
clear. In that case the frame would keep its in-band 802.1Q header and
also get a hwaccel tag. Would the stack then treat it as double tagged?
Should this be gated on dev->net->features & NETIF_F_HW_VLAN_CTAG_RX, as
lan78xx_rx_vlan_offload() does? aqc111 can skip that check only because
aqc111_reset() always sets VSO.
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 08/13] ax88179_178a: Add AX179A/AX279 multicast configuration
2026-11-06 7:21 ` [PATCH net-next v20 08/13] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 4 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 2 · Low: 2
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] The patch also changes RX behaviour on the existing
AX88179/AX88178A devices, and the commit message does not say so.
- [Medium] Adding `.ndo_set_rx_mode = ax88179_set_multicast` to
ax88179a_netdev_ops (ax88179a_devices.c:681) gives…
- [Low] This patch adds `.ndo_set_rx_mode = ax88179_set_multicast` to
ax88179a_netdev_ops (ax88179a_devices.c:681).
- [Low] ax88179_set_multicast() (ax88179_lib.c:362-364) builds the value
in a local `rxctl` and publishes it with `WRITE_ONCE(data->rxctl,…
--
ax88179_178a: Add AX179A/AX279 multicast configuration
This patch changes ax88179_set_multicast() to build the RX_CTL value in a
local variable. AX_RX_CTL_IPE is now set only when ip_align is set, and
AX_RX_CTL_DROPCRCERR is always set. The patch also installs
ax88179_set_multicast() as ndo_set_rx_mode for the AX88179A family of
devices.
> diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
> index a314db4c97666..b4b00c8b4b623 100644
> --- a/drivers/net/usb/ax88179_lib.c
> +++ b/drivers/net/usb/ax88179_lib.c
> @@ -321,16 +321,21 @@ int ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8
> void ax88179_set_multicast(struct net_device *net)
> {
> struct usbnet *dev = netdev_priv(net);
> - struct ax88179_data *data = dev->driver_priv;
> u8 *m_filter = ((u8 *)dev->data);
> + struct ax88179_data *data;
> + u16 rxctl = 0;
> +
> + data = dev->driver_priv;
>
> - data->rxctl = (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_IPE);
> + rxctl = (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_DROPCRCERR);
> + if (data->ip_align)
> + rxctl |= AX_RX_CTL_IPE;
[Severity: Medium]
Does this also change RX behaviour on the existing AX88179/AX88178A
devices? The legacy driver uses this helper as its rx_mode handler:
drivers/net/usb/ax88179_178a.c:
.ndo_set_rx_mode = ax88179_set_multicast,
Before this patch the helper wrote AX_RX_CTL_START | AX_RX_CTL_AB |
AX_RX_CTL_IPE, without AX_RX_CTL_DROPCRCERR.
The value set in ax88179_reset() only goes into a temporary. It is never
stored in data->rxctl:
drivers/net/usb/ax88179_178a.c:ax88179_reset() {
...
*tmp16 = AX_RX_CTL_DROPCRCERR | AX_RX_CTL_IPE | AX_RX_CTL_START |
AX_RX_CTL_AP | AX_RX_CTL_AMALL | AX_RX_CTL_AB;
ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, tmp16);
...
}
On open, usbnet_open() runs the reset first. Then
dev_open()->dev_set_rx_mode()->ax88179_set_multicast() overwrites that
value, and ax88179_link_reset() keeps writing data->rxctl back. So legacy
adapters have been running with AX_RX_CTL_DROPCRCERR cleared. Frames with
a bad CRC were then counted in ax88179_rx_fixup():
if ((*pkt_hdr & (AX_RXHDR_CRC_ERR | AX_RXHDR_DROP_ERR)) ||
pkt_len < 2 + ETH_HLEN) {
dev->net->stats.rx_errors++;
This patch sets AX_RX_CTL_DROPCRCERR for every chip. If the hardware then
drops those frames itself, as the bit name suggests, would legacy users
stop seeing CRC errors in rx_errors?
The commit message says:
"make sure that AX_RX_CTL_DROPCRCERR is also set to be consistent with
the initial configuration in ax88179_reset()"
That reset value never survived on legacy devices, so this is a real
behaviour change rather than a consistency cleanup.
The message also leaves out the reason given in the ax88179a_bind()
comment, which says the AX88279 needs both AX_RX_CTL_IPE and
AX_RX_CTL_DROPCRCERR to produce correct RX URBs.
Could the commit message describe the change to legacy devices, or could
that change go in its own patch?
[Severity: Low]
This might not be a bug, but is AX_RX_CTL_AP left out on purpose here?
ax88179a_reset() stores a different baseline in data->rxctl:
drivers/net/usb/ax88179a_devices.c:ax88179a_reset() {
...
rxctl = AX_RX_CTL_DROPCRCERR | AX_RX_CTL_START | AX_RX_CTL_AP |
AX_RX_CTL_AMALL | AX_RX_CTL_AB;
...
}
Now that ndo_set_rx_mode is set for ax88179a,
dev_open()->dev_set_rx_mode()->ax88179_set_multicast() replaces that value
with one that has AX_RX_CTL_AP cleared. ax88179a_mac_link_up() then writes
READ_ONCE(ax179_data->rxctl) back on every link-up. Before this patch
these chips kept AX_RX_CTL_AP set.
The intent is to match the reset-time configuration. Should
ax88179a_reset() drop AX_RX_CTL_AP, or should ax88179_set_multicast() keep
it? The legacy AX88179 has run without AX_RX_CTL_AP after open, but it is
not clear that the same is safe on AX88179A/AX88279 silicon.
[ ... ]
> @@ -351,9 +356,10 @@ void ax88179_set_multicast(struct net_device *net)
> AX_MCAST_FLTSIZE, AX_MCAST_FLTSIZE,
> m_filter);
>
> - data->rxctl |= AX_RX_CTL_AM;
> + rxctl |= AX_RX_CTL_AM;
> }
>
> + WRITE_ONCE(data->rxctl, rxctl);
> ax88179_write_cmd_async(dev, AX_ACCESS_MAC, AX_RX_CTL,
> 2, 2, &data->rxctl);
[Severity: Low]
Minor, but the value is already in the local rxctl. Could this pass &rxctl
instead of &data->rxctl? ax88179_write_cmd_async() reads the shared field
back with a plain load:
drivers/net/usb/ax88179_lib.c:ax88179_write_cmd_async() {
...
buf = *((u16 *)data);
...
}
Elsewhere, data->rxctl is accessed with WRITE_ONCE()/READ_ONCE()
(ax88179a_reset(), ax88179a_mac_link_up()). If another writer changes the
field between the WRITE_ONCE() and this load, the URB carries a value this
call did not compute, and KCSAN may flag the unmarked access.
ax88179_write_cmd_async() copies into a stack buffer and
usbnet_write_cmd_async() duplicates it, so a pointer to the local should
be safe.
> }
> diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
> index 4207d2cc2b865..a6b0a3f47118c 100644
> --- a/drivers/net/usb/ax88179a_devices.c
> +++ b/drivers/net/usb/ax88179a_devices.c
> @@ -678,6 +678,7 @@ static const struct net_device_ops ax88179a_netdev_ops = {
> .ndo_set_mac_address = ax88179_set_mac_addr,
> .ndo_validate_addr = eth_validate_addr,
> .ndo_eth_ioctl = ax88179a_mii_ioctl,
> + .ndo_set_rx_mode = ax88179_set_multicast,
[Severity: Medium]
Can this new writer of data->rxctl and AX_RX_CTL race with
ax88179a_mac_link_up()?
ax88179a_netdev_ops has no ndo_set_rx_mode_async. So __dev_set_rx_mode()
calls ax88179_set_multicast() directly, in atomic context under
netif_addr_lock_bh(), where it cannot take medium_status_mutex.
ax88179a_mac_link_up() runs from the phylink resolve work and holds
neither rtnl nor the addr lock. It stops RX, then reprograms the RX
framing and bulk-in registers with many synchronous control transfers.
It only takes medium_status_mutex around the final write:
drivers/net/usb/ax88179a_devices.c:ax88179a_mac_link_up() {
...
/* Stop RX/TX for link configuration */
ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, AX_RX_CTL_STOP);
ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_PATH, 1, 0);
...
ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, READ_ONCE(ax179_data->rxctl));
mutex_unlock(&ax179_data->medium_status_mutex);
...
}
Two orderings look possible. The first loses an update:
phylink resolve work rx_mode change (e.g. promisc on)
ax88179a_mac_link_up()
READ_ONCE(rxctl) -> old
ax88179_set_multicast()
WRITE_ONCE(data->rxctl, new)
async AX_RX_CTL = new
sync AX_RX_CTL = old
The hardware ends up with the old filter while software holds the new
one. Promiscuous, allmulti or multicast reception would then be missing
until the next rx_mode event.
In the second, the async write includes AX_RX_CTL_START. If it lands
between the AX_RX_CTL_STOP write and the final AX_RX_CTL write, does it
turn the receiver back on while the RX framing and bulk-in settings are
only partly applied? ax88179a_rx_fixup() would then parse URBs built with
those half-applied settings.
Before this patch ax88179a had no ndo_set_rx_mode, so neither ordering
could happen.
Could the rx-mode programming be deferred to process context, for example
through usbnet's EVENT_SET_RX_MODE kevent or ndo_set_rx_mode_async? It
could then be serialized with ax88179a_mac_link_up() under
medium_status_mutex.
> .ndo_set_features = ax88179a_set_features,
> .ndo_vlan_rx_add_vid = ax88179a_vlan_rx_add_vid,
> .ndo_vlan_rx_kill_vid = ax88179a_vlan_rx_kill_vid,
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 09/13] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279
2026-11-06 7:21 ` [PATCH net-next v20 09/13] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 9 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 5 · Low: 4
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] In ax88179a_reset(), the new `if (!ax179_data->in_pm)` guard
(ax88179a_devices.c:1172-1175) skips the whole ax88179_get_mac_addr()…
- [Medium] On resume, ax88179a_reset() re-enables the hardware VLAN
filter (AX_VLAN_CONTROL_VFE written to AX88179A_VLAN_ID_CONTROL,…
- [Medium] The series is not bisectable.
- [Medium] ax88179a_resume() calls ax88179a_reset() whether or not the
interface is running (ax88179a_devices.c:207-224).
- [Medium] On every resume, ax88179a_resume() power-cycles the PHY
through AX88179A_PHY_POWER: it writes 0 at line 221, sleeps 250 ms,…
- [Low] The patch turns off USB runtime PM (autosuspend) for every
AX88179A/AX88772D/AX88279 device and the commit message does not say…
- [Low] In ax88179a_resume(), if the first control read of
AX88179A_PHY_POWER fails (lines 207-209), the code jumps to err_out.
- [Low] ax88179a_reset() always arms magic-packet wake (AX_MONITOR_MOD =
AX_MONITOR_MODE_RWMP, lines 1213-1217).
- [Low] In the WoL branch of ax88179a_suspend() (lines 168-170), the
return value of ax88179_read_cmd(dev, AX_ACCESS_MAC,…
--
ax88179_178a: Add Suspend/resume support for AX88179A/772D/279
This patch adds per-chip suspend/resume function pointers to struct
ax88179_data and sends the usb_driver suspend/resume/reset_resume
callbacks through new wrappers in ax88179_lib.c. It implements
ax88179a_suspend() and ax88179a_resume() for the AX179A family. When
called from resume, ax88179a_reset() now skips the MAC address read and
phylink_start().
> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index f78ad344c1c4f..b077b7153f0c0 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
[ ... ]
> @@ -1362,9 +1365,9 @@ static struct usb_driver ax88179_178a_driver = {
> .name = "ax88179_178a",
> .id_table = products,
> .probe = usbnet_probe,
> - .suspend = ax88179_suspend,
> - .resume = ax88179_resume,
> - .reset_resume = ax88179_resume,
> + .suspend = ax88179_suspend_wrapper,
> + .resume = ax88179_resume_wrapper,
> + .reset_resume = ax88179_resume_wrapper,
[Severity: Medium]
Is the series bisectable at this point? From "ax88179_178a: Add HW support
for AX179A-based chips" through "ax88179_178a: Add AX179A/AX279 multicast
configuration", the AX179A-family products entries are bound to this
usb_driver. In those commits .suspend/.resume/.reset_resume still point
at the classic ax88179_suspend()/ax88179_resume().
In those intermediate commits, a system resume runs:
ax88179_resume()
ax88179_reset()
mii_nway_restart(&dev->mii)
mii->mdio_read(...)
ax88179a_bind() never sets dev->mii.mdio_read. Wouldn't the first resume
of an AX88179A/772D/279 device then call a NULL function pointer?
This patch fixes that by sending AX179A devices to ax88179a_resume(), but
the commit message presents the patch only as a new feature. Could the
patches be reordered or merged so that no intermediate commit registers
these callbacks for the new chips? Could the changelog also mention the
fix?
> .disconnect = ax88179_disconnect,
> .supports_autosuspend = 1,
[ ... ]
> diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
> index a6b0a3f47118c..01d6a35f68b2c 100644
> --- a/drivers/net/usb/ax88179a_devices.c
> +++ b/drivers/net/usb/ax88179a_devices.c
[ ... ]
> @@ -126,6 +128,63 @@ static void ax88179a_status(struct usbnet *dev, struct urb *urb)
> phylink_mac_interrupt(data->phylink);
> }
>
> +static int ax88179a_suspend(struct usb_interface *intf, pm_message_t message)
> +{
[ ... ]
> + /* Enable WoL */
> + if (priv->wolopts) {
> + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, &tmp8);
> + tmp8 &= ~(AX_MONITOR_MODE_RWLC | AX_MONITOR_MODE_RWMP);
> + if (priv->wolopts & WAKE_PHY)
> + tmp8 |= AX_MONITOR_MODE_RWLC;
> + if (priv->wolopts & WAKE_MAGIC)
> + tmp8 |= AX_MONITOR_MODE_RWMP;
> +
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, &tmp8);
> +
> + ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, &tmp16);
> + tmp16 |= AX_MEDIUM_RECEIVE_EN;
> + ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, &tmp16);
[Severity: Low]
What happens if this AX_MEDIUM_STATUS_MODE read fails? For size 2,
ax88179_read_cmd() starts with u16 buf = 0 and copies buf into *data even
on error, so tmp16 ends up as just AX_MEDIUM_RECEIVE_EN.
Writing that value back clears AX_MEDIUM_GIGAMODE, AX_MEDIUM_FULL_DUPLEX,
the flow control enables and AX_MEDIUM_JUMBO_EN. Meanwhile the PHY keeps
its link up for WoL.
Could the MAC medium mode then disagree with the link, so that wake frames
are not received? Should the return value be checked here?
> +
> + if (priv->chip_version == AX_VERSION_AX88279)
> + ax88179_write_cmd(dev, AX88179A_WAKEUP_SETTING, 8,
> + EPHY_LOW_POWER_EN | S5_WOL_EN
> + | S5_WOL_LOW_POWER | 0x8000, 0, NULL);
> + else
> + ax88179_write_cmd(dev, AX88179A_WAKEUP_SETTING, 0,
> + EPHY_LOW_POWER_EN, 0, NULL);
> +
> + } else if (priv->chip_version == AX_VERSION_AX88279) {
> + ax88179_write_cmd(dev, AX88179A_WAKEUP_SETTING, 8, 0x8000, 0, NULL);
> + }
[Severity: Low]
Is magic packet wake really turned off when WoL is disabled?
ax88179a_reset() always arms it:
if (ax179_data->chip_version < AX_VERSION_AX88179A)
*tmp = AX_MONITOR_MODE_PMETYPE | AX_MONITOR_MODE_PMEPOL | AX_MONITOR_MODE_RWMP;
else
*tmp = AX_MONITOR_MODE_RWMP;
ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_MONITOR_MOD, 1, 1, tmp);
AX_MONITOR_MOD is only rewritten here, inside if (priv->wolopts). The
chip therefore suspends with RWMP still set, even when ethtool reports
WoL as off.
For AX88179A/AX88772D, a WoL suspend also writes AX88179A_WAKEUP_SETTING
with EPHY_LOW_POWER_EN. The else branch only covers AX88279, and nothing
on resume clears the register.
For a running interface, phy_suspend() powers the PHY down, which hides
this. The PHY can still have link during a WoL-off suspend, for example
in the down-interface resume case below. If USB wakeup is enabled in
sysfs in that case, could a magic packet wake the host?
> +
> + ax88179_set_pm_mode(dev, false);
> + return 0;
> +}
[ ... ]
> @@ -135,6 +194,47 @@ static int ax88179a_auto_detach(struct usbnet *dev)
> return 0;
> }
>
> +static int ax88179a_resume(struct usb_interface *intf)
> +{
> + struct usbnet *dev = usb_get_intfdata(intf);
> + struct ax88179_data *ax179_data;
> + u8 reg8 = 0;
> + int ret;
> +
> + ax179_data = dev->driver_priv;
> + ax88179_set_pm_mode(dev, true);
> +
> + ret = ax88179_read_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, ®8);
> + if (ret < 0)
> + goto err_out;
[Severity: Low]
If this first read fails, the goto skips the AX_FW_MODE_179A write, the
PHY power cycle and all of ax88179a_reset(). err_out still calls
phylink_resume(), which in the non-WoL case starts phylink on hardware
that was never re-initialised. It then does:
return usbnet_resume(intf);
usbnet_resume() always returns 0, so ret is lost. Would the interface then
look resumed but pass no traffic until it is brought down and up again?
Should the error be propagated here?
> +
> + if (!(reg8 & AX_PHY_POWER)) {
> + reg8 = AX_PHY_POWER;
> + ax88179_write_cmd(dev, AX88179A_PHY_POWER, 0, 0, 1, ®8);
> + msleep(250);
> + }
> + ax88179_write_cmd(dev, AX_FW_MODE, AX_FW_MODE_179A, 0, 0, NULL);
> +
> + /* Now, that AX_FW_MODE_179A is enabled, the PHY needs a power-cycle.
> + * PHY-power is re-enabled in ax88179a_reset()
> + */
> + ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, 0);
> + msleep(250);
[Severity: Medium]
Does this unconditional power cycle lose the PHY configuration when WoL is
enabled? The comment suggests it resets the PHY registers to their
defaults: BMCR, MII_ADVERTISE (including AX_ADVERTISE_2500 on AX88279) and
the EEE advertisement.
With wolopts set, ax88179a_suspend() calls phylink_suspend(pl, true). That
takes the MAC WoL branch, which sets PHYLINK_DISABLE_MAC_WOL and does not
call phylink_stop(). On resume, phylink_resume() then only does:
phylink_mac_initial_config(pl, true);
phylink_enable_and_run_resolve(pl, PHYLINK_DISABLE_MAC_WOL);
It never reaches phylink_start()/phy_start(). ax88179a_init_phy() sets
phydev->mac_managed_pm, so MDIO bus PM does not call phy_init_hw() either.
Would the PHY then negotiate using its power-on defaults, while
phydev->advertising and the phylink EEE state still reflect what was set
with ethtool?
> +
> + ax88179a_reset(dev);
[Severity: Medium]
Should this also be gated on netif_running()? Only phylink_resume() below
checks it. ax88179a_reset() powers the PHY, writes AX_RX_CTL_START, sets
AX_MEDIUM_RECEIVE_EN and arms AX_MONITOR_MODE_RWMP whether or not the
interface is up.
If the interface was down at suspend, ax88179a_stop() had left the
hardware like this:
phylink_stop(ax179_data->phylink);
...
reg16 &= ~AX_MEDIUM_RECEIVE_EN;
...
ax88179_write_u16(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 0);
ax88179_write_u8(dev, AX88179A_PHY_POWER, 0, 0, 0);
After resume, the PHY is powered and can bring up a link with the peer,
and MAC RX is enabled, but phylink is not started. The new comment in
ax88179a_reset(), "phylink_resume() will start phylink, then", does not
hold for down interfaces.
A later suspend of the still-down interface does not power the PHY off
again. With USB wakeup enabled, could RWMP then wake the host while WoL
is off?
[Severity: Medium]
Is the VLAN filter table restored on this path? ax88179a_reset() turns
VFE back on whenever the feature is set:
if (dev->net->features & NETIF_F_HW_VLAN_CTAG_FILTER)
*tmp |= AX_VLAN_CONTROL_VFE;
The per-VID bitmap, though, is only written by
ax88179a_vlan_rx_add_vid() and ax88179a_vlan_rx_kill_vid(), and the
driver keeps no software copy of it. ax88179a_set_features() also clears
all 256 entries when it enables the filter, which suggests the table
contents can't be relied on.
The chip can lose its registers across suspend, for example on
reset_resume or when VBUS is cut in S3. Would the hardware filter then
drop frames on the configured VLANs until the VIDs are added again?
> +
> +err_out:
> + if (netif_running(dev->net)) {
> + rtnl_lock();
> + phylink_resume(ax179_data->phylink);
> + rtnl_unlock();
> + }
> +
> + ax88179_set_pm_mode(dev, false);
> +
> + return usbnet_resume(intf);
> +}
[ ... ]
> @@ -802,6 +905,13 @@ static int ax88179a_bind(struct usbnet *dev, struct usb_interface *intf)
> if (ret)
> goto initphy_err;
>
> + /* Keep this interface runtime-PM active by taking a usage ref.
> + * Prevents runtime suspend while bound and avoids resume paths
> + * that could deadlock (autoresume under RTNL while USB PM lock
> + * is held, phylink/MDIO wants RTNL).
> + */
> + pm_runtime_get_noresume(&intf->dev);
[Severity: Low]
This turns off USB autosuspend for every AX88179A/772D/279 device while it
is bound. The usage count only drops when ax88179a_unbind() calls
pm_runtime_put_noidle().
As the comment says, the new ax88179a_suspend()/ax88179a_resume() take
rtnl_lock() around the phylink calls. An autoresume under RTNL, such as
usbnet_open() -> usb_autopm_get_interface(), would therefore deadlock, so
the new callbacks only work for system sleep.
The commit message only talks about adding the suspend/resume wrappers.
Could it mention that runtime PM is disabled for the AX179A family, and
why? The shared ax88179_178a_driver also still sets
.supports_autosuspend = 1 without any note about this exception.
> +
> return 0;
[ ... ]
> @@ -1055,9 +1166,13 @@ static int ax88179a_reset(struct usbnet *dev)
> ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_SWP_CTRL, 1, 0);
> ax88179_write_u8(dev, AX_ACCESS_MAC, AX88179A_MAC_TX_HDR_CKSUM, 1, 0);
>
> - /* Read MAC address from DTB or asix chip */
> - ax88179_get_mac_addr(dev);
> - memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
> + /* Read MAC address from DTB or asix chip, except when called
> + * from resume context.
> + */
> + if (!ax179_data->in_pm) {
> + ax88179_get_mac_addr(dev);
> + memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
> + }
[Severity: Medium]
Does skipping ax88179_get_mac_addr() on resume also skip programming the
unicast address into the chip? ax88179_get_mac_addr() ends with:
ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN,
dev->net->dev_addr);
That is the only AX_NODE_ID write on the reset path.
ax88179a_resume() rewrites AX_FW_MODE_179A and power-cycles the PHY, so
the driver seems to expect chip state to be lost, for example on
.reset_resume. In that case AX_NODE_ID would go back to the efuse
default. dev_addr, however, still holds a user-set address (from
ax88179_set_mac_addr()), a DT-provided address or the random fallback.
RX_CTL is programmed with AX_RX_CTL_AP and without AX_RX_CTL_PRO. Would
unicast frames to the interface's own MAC then be filtered out after
resume?
Could the AX_NODE_ID write of dev_addr be kept for the in_pm case, with
only the read/selection step skipped?
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 10/13] ax88179_178a: Add ethtool get_drvinfo
2026-11-06 7:21 ` [PATCH net-next v20 10/13] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] ax88179a_get_drvinfo() (drivers/net/usb/ax88179a_devices.c)
always overwrites info->fw_version with the cached…
--
ax88179_178a: Add ethtool get_drvinfo
This commit adds ax88179a_get_drvinfo() as the get_drvinfo ethtool
callback. It uses the usbnet defaults and then, for AX88179A and newer
chips, overwrites fw_version with the four firmware bytes cached at
bind time.
> diff --git a/drivers/net/usb/ax88179a_devices.c b/drivers/net/usb/ax88179a_devices.c
> index 01d6a35f68b2c..69095110e7043 100644
> --- a/drivers/net/usb/ax88179a_devices.c
> +++ b/drivers/net/usb/ax88179a_devices.c
> @@ -235,6 +235,20 @@ static int ax88179a_resume(struct usb_interface *intf)
> return usbnet_resume(intf);
> }
>
> +static void ax88179a_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *info)
> +{
> + struct ax88179_data *priv = netdev2data(net);
> +
> + /* Inherit standard device info */
> + usbnet_get_drvinfo(net, info);
> + if (priv->chip_version < AX_VERSION_AX88179A)
> + return;
> +
> + snprintf(info->fw_version, sizeof(info->fw_version), "%d.%d.%d.%d",
> + priv->fw_version[0], priv->fw_version[1],
> + priv->fw_version[2], priv->fw_version[3]);
[Severity: Low]
Could this report a firmware version that the device never returned?
In ax88179a_bind(), a failed firmware read is replaced with 0xff and
bind keeps going:
drivers/net/usb/ax88179a_devices.c:ax88179a_bind() {
...
for (int i = 0; i < 3; i++) {
ret = ax88179_read_cmd(dev, AX88179A_ACCESS_BL, AX88179A_SW_VERSION + i,
1, 1, &ax179_data->fw_version[i]);
if (ret < 0)
ax179_data->fw_version[i] = 0xff;
}
ret = ax88179_read_cmd(dev, AX88179A_ACCESS_BL, AX88179A_SW_REVISION,
1, 1, &ax179_data->fw_version[3]);
if (ret < 0)
ax179_data->fw_version[3] = 0xff;
...
}
If any of these USB control transfers fail, ethtool -i would show
"255.255.255.255", or something mixed like "1.2.255.3" when only some
reads fail. That string also replaces the driver_info->description
default that usbnet_get_drvinfo() has just written.
Before this patch the 0xff sentinel only appeared in the netdev_info()
line printed by bind.
Would it make sense to record whether the reads succeeded and, when
they did not, skip the overwrite (keeping the usbnet default) or report
something like "unknown"?
aqc111_get_drvinfo() in the same directory also reports firmware bytes
without checking for read errors.
> +}
> +
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 11/13] ax88179_178a: Update driver name and information
2026-11-06 7:21 ` [PATCH net-next v20 11/13] ax88179_178a: Update driver name and information Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 4 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 3 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] This patch renames the USB driver from "ax88179_178a" to
"ax88179" (`struct usb_driver ax88179_driver`, `.name = "ax88179"`,…
- [Medium] The patch renames the Kconfig symbol
CONFIG_USB_NET_AX88179_178A to CONFIG_USB_NET_AX88179…
- [Medium] The patch adds `select AX88796B_PHY` to USB_NET_AX88179
(drivers/net/usb/Kconfig:202) so that the internal PHYs of the…
- [Low] After this patch, which exists to update these strings, the
descriptions of supported hardware disagree with each other and with…
--
ax88179_178a: Update driver name and information
This commit renames the Kconfig symbol USB_NET_AX88179_178A to
USB_NET_AX88179 and renames the usb_driver from ax88179_178a to ax88179.
It adds a select of AX88796B_PHY and updates the Kconfig help text and
MODULE_DESCRIPTION to list the AX88179A/B, AX88279 and AX88772D/E chips.
It also updates the two loongarch defconfigs to use the new symbol.
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 115990b0d9537..27862e380bdb4 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -195,11 +195,12 @@ config USB_NET_AX8817X
> This driver creates an interface named "ethX", where X depends on
> what other networking devices you have in use.
>
> -config USB_NET_AX88179_178A
> - tristate "ASIX AX88179/178A USB 3.0/2.0 to Gigabit Ethernet"
> +config USB_NET_AX88179
> + tristate "ASIX AX88179/179A/178A USB 2.0/3.0 to 100M/1G/2.5GbE Adapters"
> depends on USB_USBNET
> - select CRC32
> select PHYLINK
> + select AX88796B_PHY
[Severity: Medium]
The commit message says this will "add further requirements such as
PHYLINK", but select PHYLINK was already there and CRC32 has only moved.
The only new dependency is AX88796B_PHY, and the message does not name it.
Could the commit message mention it?
Does selecting AX88796B_PHY have any effect at this point in the series?
ax88179_mdiobus_read() in ax88179a_devices.c returns synthetic PHY IDs for
the new chips:
if (phy_id == AX88179_PHY_ID && regnum == MII_PHYSID2) {
if (priv->chip_version == AX_VERSION_AX88179A && priv->is_ax88772d)
return 0x772d;
else if (priv->chip_version == AX_VERSION_AX88179A)
return 0x179a;
else if (priv->chip_version == AX_VERSION_AX88279)
return 0x2790;
At this commit, no PHY driver matches 0x003b179a, 0x003b772d or
0x003b2790. The later commit "ax88796b: Add support for AX88772D, AX88179A
and AX88279" adds these IDs, but only to the C driver in
drivers/net/phy/ax88796b.c.
When CONFIG_AX88796B_RUST_PHY is set, drivers/net/phy/Makefile builds the
Rust driver for this symbol instead:
ifdef CONFIG_AX88796B_RUST_PHY
obj-$(CONFIG_AX88796B_PHY) += ax88796b_rust.o
else
obj-$(CONFIG_AX88796B_PHY) += ax88796b.o
endif
drivers/net/phy/ax88796b_rust.rs still registers only:
drivers: [PhyAX88772A, PhyAX88772C, PhyAX88796B],
With CONFIG_AX88796B_RUST_PHY=y, won't phylib fall back to genphy for the
AX88179A, AX88772D and AX88279 PHYs, even at the end of the series?
For the AX88279, the genphy fallback drops asix_ax88279_get_features(),
the custom config_aneg and read_status, PHY_BROKEN_FORCED, and the
2500BASEX/SGMII interface switching. genphy can't advertise or report
2500baseT. Can the 2.5G mode that the MAC advertises be negotiated at all
in that case? The AX88772D would also lose its 1000baseT capability
masking.
The Kconfig help for the Rust variant says "The features are equivalent".
Should ax88796b_rust.rs get matching entries for the new IDs?
> + select CRC32
> default y
[Severity: Medium]
What happens to existing .config files after this symbol is renamed?
A saved CONFIG_USB_NET_AX88179_178A=m, or "# CONFIG_USB_NET_AX88179_178A
is not set", no longer refers to any symbol. make olddefconfig then treats
USB_NET_AX88179 as a new symbol and gives it the default y, which is
limited to m when USB_USBNET=m.
Configs that deliberately disabled the driver get it re-enabled. That is
why the two loongarch defconfigs had to be fixed by hand in this patch.
Distro configs with =m and USB_USBNET=y end up with the driver built in.
The rename is cosmetic, so could the USB_NET_AX88179_178A symbol name be
kept? If the rename stays, should the commit message mention the effect on
out-of-tree and distro configs?
> help
> This option adds support for ASIX AX88179 based USB 3.0/2.0
> @@ -207,6 +208,9 @@ config USB_NET_AX88179_178A
>
> This driver should work with at least the following devices:
> * ASIX AX88179
> + * ASIX AX88179A/B
> + * ASIX AX88279
> + * ASIX AX88772D/E
> * ASIX AX88178A
> * Sitcomm LN-032
[Severity: Low]
This isn't a bug, but after this change the descriptions of supported
hardware don't agree with each other.
The new prompt mentions 100M and 2.5GbE but doesn't name the AX88279 or
the AX88772D, which are the chips that provide those speeds.
The help body still begins "This option adds support for ASIX AX88179
based USB 3.0/2.0 to Gigabit Ethernet adapters", but the list below it now
includes the AX88179A/B, AX88279 and AX88772D/E.
The new MODULE_DESCRIPTION in ax88179_178a.c leaves out the AX88772D/E:
"ASIX AX88179/179A/178A/279 based USB 3.0/2.0 100M/1G/2.5GbE Controllers"
products[] still binds that chip through ax88772d_info.
The help text also doesn't mention that the module is now called ax88179.
It still has the existing typo "Sitcomm LN-032" (should be Sitecom).
[ ... ]
> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index b077b7153f0c0..88dce368eacfe 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1361,8 +1361,8 @@ static const struct usb_device_id products[] = {
> };
> MODULE_DEVICE_TABLE(usb, products);
>
> -static struct usb_driver ax88179_178a_driver = {
> - .name = "ax88179_178a",
> +static struct usb_driver ax88179_driver = {
> + .name = "ax88179",
[Severity: Medium]
Doesn't this rename change what userspace sees for every existing
AX88179/AX88178A adapter, and for the OEM adapters built on them?
usbnet_probe() copies the usb_driver name into the usbnet state:
name = udev->dev.driver->name;
...
dev->driver_name = name;
usbnet_get_drvinfo() then reports that name:
strscpy(info->driver, dev->driver_name, sizeof(info->driver));
ax88179a_get_drvinfo() calls usbnet_get_drvinfo(). The legacy
ax88179_ethtool_ops has no get_drvinfo, so the ethtool core falls back to
the parent device's driver name, which is the same string.
After this patch, ethtool -i reports "driver: ax88179" instead of
"driver: ax88179_178a". /sys/bus/usb/drivers/ax88179_178a/ also becomes
/sys/bus/usb/drivers/ax88179/.
After a kernel upgrade, several kinds of existing config would stop
matching:
- systemd .link/.network files with Driver=ax88179_178a
- udev rules with DRIVERS=="ax88179_178a"
- NetworkManager matches on the driver name
- scripts that write to .../drivers/ax88179_178a/{bind,unbind,new_id}
MODULE_ALIAS("ax88179_178a") at the end of the file only keeps the old
module name loadable. It has no effect on the usb_driver name.
Could .name stay as "ax88179_178a"? The commit message only says "Update
driver name in usb_driver" and does not mention this compatibility impact.
> .id_table = products,
> .probe = usbnet_probe,
> .suspend = ax88179_suspend_wrapper,
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 12/13] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access
2026-11-06 7:21 ` [PATCH net-next v20 12/13] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] The EEPROM request encoding is split across two independent
sources that can disagree.
- [Low] struct ax88179_data has two fields, eeprom_write_cmd and
eeprom_wen, that both bind routines set and nothing ever reads.
--
ax88179_178a: Add support for AX88179A/772D/279 EEPROM access
This patch extends ax88179_get_eeprom() to read the efuses on the
AX88179A/772D and the FLASH on the AX88279. The opcode and block size
come from per-bind state, and a new helper computes wValue/wIndex.
ax88179_set_eeprom() now returns -EOPNOTSUPP for AX88179A and later
chips.
> diff --git a/drivers/net/usb/ax88179_lib.c b/drivers/net/usb/ax88179_lib.c
> index b54e98e781f33..d5bbaa0c4e4c6 100644
> --- a/drivers/net/usb/ax88179_lib.c
> +++ b/drivers/net/usb/ax88179_lib.c
> @@ -210,36 +210,61 @@ int ax88179_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
> return 0;
> }
>
> +static void
> +ax88179_eeprom_access_params(struct ax88179_data *ax179_data, int i, u16 *value, u16 *idx)
> +{
> + /* AX88179 has a word-addressable EEPROM
> + * AX88179A uses EFUSES with 20 bytes length
> + * AX88279 has an EEPROM addressable in 256 byte blocks
> + */
> + if (ax179_data->chip_version < AX_VERSION_AX88179A) {
> + *value = i;
> + *idx = 1;
> + } else if (ax179_data->chip_version == AX_VERSION_AX88279) {
> + *value = (i * ax179_data->eeprom_block) >> 16;
> + *idx = (i * ax179_data->eeprom_block) & 0xffff;
> + } else {
> + *value = i << 4;
> + *idx = 0;
> + }
> +}
[ ... ]
> + for (i = first; i <= last; i++) {
> + u16 value, idx;
> +
> + ax88179_eeprom_access_params(ax179_data, i, &value, &idx);
> + ret = __ax88179_read_cmd(dev, ax179_data->eeprom_read_cmd,
> + value, idx, ax179_data->eeprom_block,
> + eeprom_buff + (i - first) * ax179_data->eeprom_block);
[Severity: Medium]
Can the addressing mode and the rest of this request disagree?
ax88179_eeprom_access_params() picks value/idx from chip_version alone.
The opcode and transfer length passed to __ax88179_read_cmd() come from
eeprom_read_cmd and eeprom_block, which are set at bind time. chip_version
is the raw upper nibble of AX_CHIP_STATUS, and neither bind routine
validates it.
In ax88179_bind() in ax88179_178a.c:
ax179_data->chip_version = (ax179_data->chip_version & 0xf0) >> 4;
...
ax179_data->eeprom_read_cmd = AX_ACCESS_EEPROM;
ax179_data->eeprom_write_cmd = AX_ACCESS_EEPROM;
ax179_data->eeprom_block = 2;
Suppose a device bound by ax88179_bind() (generic 0b95:1790, AX88178A,
Cypress GX3, or one of the OEM IDs) reports a nibble >= 6. Would it then
get AX_ACCESS_EEPROM requests with efuse or FLASH style value/idx? Before
this patch the value=i, idx=1 encoding was always used.
The loop only checks ret == eeprom_block, so that data would go back to
userspace as EEPROM contents. ax88179_set_eeprom() would also start
returning -EOPNOTSUPP for a device that bind set up for word EEPROM
writes.
In ax88179a_bind() in ax88179a_devices.c, the geometry is chosen by
== AX_VERSION_AX88279 versus everything else:
if (ax179_data->chip_version == AX_VERSION_AX88279) {
...
ax179_data->eeprom_read_cmd = AX88179A_FLASH_READ;
...
ax179_data->eeprom_block = 256;
} else {
...
ax179_data->eeprom_read_cmd = AX_ACCESS_EFUS;
...
ax179_data->eeprom_block = 20;
ax88179a_get_eeprom_len() uses >= instead:
if (ax179_data->chip_version >= AX_VERSION_AX88279)
return AX88279_EEPROM_LEN;
With chip_version > 7, ethtool would see 16 KiB while the reads use the
20-byte efuse geometry. Couldn't that request efuse indices up to 819
when only 32 efuses exist?
ax88179a_get_drvinfo() and ax88179a_reset() both check for
chip_version < AX_VERSION_AX88179A. If that case happens under
ax88179a_bind(), this helper would send AX_ACCESS_EFUS with word EEPROM
value/idx and a 20-byte length.
ax88179_set_eeprom() doesn't block that case either. The legacy
AX_ACCESS_EEPROM word write loop and AX_RELOAD_EEPROM_EFUSE would then run
against the advertised 640-byte length.
Would it be more robust to store an explicit addressing mode in
ax88179_data at bind time, next to eeprom_read_cmd and eeprom_block?
ax88179_eeprom_access_params(), ax88179_set_eeprom() and the
get_eeprom_len callbacks could all use it. ax88179a_bind() could also
reject unknown chip versions, or default them consistently.
> +
> + if (ret != ax179_data->eeprom_block) {
> kfree(eeprom_buff);
> return -EIO;
> }
> }
[ ... ]
> @@ -247,12 +272,17 @@ int ax88179_get_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8
> int ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom *eeprom, u8 *data)
> {
> struct usbnet *dev = netdev_priv(net);
> + struct ax88179_data *ax179_data;
> u16 *eeprom_buff;
> int first_word;
> int last_word;
> int ret;
> int i;
>
> + ax179_data = dev->driver_priv;
> + if (ax179_data->chip_version >= AX_VERSION_AX88179A)
> + return -EOPNOTSUPP;
> +
[Severity: Low]
This isn't a bug, but with writes disabled here for AX88179A/AX88279, are
the eeprom_write_cmd and eeprom_wen fields in struct ax88179_data used
anywhere?
Both bind routines set them. For example, ax88179a_bind() does this for
the AX88279:
ax179_data->eeprom_write_cmd = AX88179A_FLASH_WRITE;
ax179_data->eeprom_block = 256;
ax179_data->eeprom_wen = 1;
There don't seem to be any readers, though. The only write path,
ax88179_set_eeprom(), still hard-codes AX_ACCESS_EEPROM:
ret = ax88179_write_cmd(dev, AX_ACCESS_EEPROM, i, 1, 2,
&eeprom_buff[i - first_word]);
The commit message says "no write access is provided". Should these
fields be dropped until a write implementation actually uses them?
> netdev_dbg(net, "write EEPROM len %d, offset %d, magic 0x%x\n",
> eeprom->len, eeprom->offset, eeprom->magic);
>
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH net-next v20 13/13] ax88796b: Add support for AX88772D, AX88179A and AX88279
2026-11-06 7:21 ` [PATCH net-next v20 13/13] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz
@ 2026-11-10 1:38 ` netdev-bot+sashiko
0 siblings, 0 replies; 29+ messages in thread
From: netdev-bot+sashiko @ 2026-11-10 1:38 UTC (permalink / raw)
To: mail
Cc: andrew+netdev, davem, kuba, pabeni, linux, andrew, hkallweit1,
chenhuacai, kernel, edumazet, linux-usb, netdev, linux-kernel,
loongarch, neuromoments, beganovic.emir
Thank you for your contribution! Sashiko AI review found 7 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 2 · Low: 5
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] The new AX88772D/AX88179A/AX88279 PHY support is added only to
the C driver, ax88796b.c.
- [Medium] asix_ax88279_read_status() returns early on `if
(!phydev->link) return 0;` before it reaches…
- [Low] Series ordering breaks bisection.
- [Low] The commit message only says the three PHYs exist.
- [Low] asix_ax88772D_get_features() sets phydev->c45_ids.mmds_present |=
MDIO_DEVS_PMAPMD | MDIO_DEVS_AN with the comment "to allow reading…
- [Low] The AX88796B_PHY Kconfig help still says it "Currently supports
the Asix Electronics PHY found in the X-Surf 100 AX88796B package."…
- [Low] The three new PHY IDs are synthetic.
--
ax88796b: Add support for AX88772D, AX88179A and AX88279
This patch adds PHY driver entries for the AX88772D (100M), AX88179A (1G)
and AX88279 (2.5G) PHYs found in ASIX USB-Ethernet controllers. The
AX88279 gets its own get_features, config_aneg, read_status and
config_init callbacks, and the AX88772D gets a get_features fixup.
> ax88796b: Add support for AX88772D, AX88179A and AX88279
>
> The AX88772D, AX88179A and AX88279 are 100MBit, 1GBit and respectively
> 2.5 GBit PHYs that are found in ASIX USB-Ethernet controllers of the
> same name.
[Severity: Low]
Could the commit message describe the restrictions and quirks this patch
adds? It only says the three PHYs exist, but the patch also:
- refuses AUTONEG_DISABLE with -EOPNOTSUPP in asix_ax88279_config_aneg()
and sets PHY_BROKEN_FORCED, so "ethtool -s <if> autoneg off" fails
- advertises 2.5G through vendor bit 0x1000 in MII_ADVERTISE
- infers the link partner's 2.5G ability in asix_ax88279_read_status()
because MDIO_AN_10GBT_STAT_LP2_5G is broken
- always reports DUPLEX_FULL and switches phydev->interface between
SGMII and 2500BASE-X
- removes 100baseT-Half from the AX88279 and 1000baseT/X from the
AX88772D
This isn't a bug, but the subject is missing the usual "net: phy:"
prefix.
> diff --git a/drivers/net/phy/ax88796b.c b/drivers/net/phy/ax88796b.c
> index f20ddf6491499..0df44e0e236ab 100644
> --- a/drivers/net/phy/ax88796b.c
> +++ b/drivers/net/phy/ax88796b.c
> @@ -13,6 +13,19 @@
> #define PHY_ID_ASIX_AX88772A 0x003b1861
> #define PHY_ID_ASIX_AX88772C 0x003b1881
> #define PHY_ID_ASIX_AX88796B 0x003b1841
> +#define PHY_ID_ASIX_AX88772D 0x003b772d
> +#define PHY_ID_ASIX_AX88179A 0x003b179a
> +#define PHY_ID_ASIX_AX88279 0x003b2790
[Severity: Low]
Are these IDs actually inside the ASIX identifier block? The MAC side
fakes them in ax88179_mdiobus_read() in drivers/net/usb/ax88179a_devices.c
(added earlier in the series), with this comment:
/* When reading PHYSID, return unused PHY-IDs from the ASIX vendor range */
In the C22 identifier layout, bits [31:10] carry the OUI. The existing
ASIX IDs 0x003b1861, 0x003b1881 and 0x003b1841 all give phy_id >> 10 ==
0xec6, which means PHYSID2 values in the 0x1800-0x1bff range.
The new IDs give:
0x003b772d >> 10 == 0xedd
0x003b179a >> 10 == 0xec5
0x003b2790 >> 10 == 0xec9
so all three fall outside that block.
asix_tbl is a MODULE_DEVICE_TABLE. A PHY from another vendor that reports
one of these exact IDs would autoload this module and bind to callbacks
that assume MII_ADVERTISE bit 12, vendor register 0x1d and full duplex
only.
Would model values inside 0x18xx-0x1bxx be a better choice?
[ ... ]
> @@ -83,6 +96,107 @@ static int asix_ax88772a_read_status(struct phy_device *phydev)
> return 0;
> }
>
> +static int asix_ax88279_read_status(struct phy_device *phydev)
> +{
> + int ret, val;
> +
> + ret = genphy_read_status(phydev);
> + if (ret)
> + return ret;
> +
> + if (!phydev->link)
> + return 0;
[Severity: Medium]
Does this early return leave a stale 2500baseT_Full bit in
phydev->lp_advertising after a 2.5G link goes down?
The bit is only cleared further down in this function:
linkmode_clear_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, phydev->lp_advertising);
On link down with autoneg enabled, genphy_read_status()->genphy_read_lpa()
only clears the C22 derived bits:
if (!phydev->autoneg_complete) {
mii_stat1000_mod_linkmode_lpa_t(phydev->lp_advertising,
0);
mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, 0);
return 0;
}
Neither phy_check_link_status() nor phy_link_down() clears lp_advertising.
phy_ethtool_ksettings_get() then copies the stale bit to userspace, so
ethtool would show the partner advertising 2500baseT/Full while the link
is down.
On the next link-up, phy_resolve_aneg_linkmode() also runs with the stale
bit set, before the AX_CTRL_STATUS read overwrites phydev->speed.
Would clearing the bit before the !phydev->link return fix this?
[ ... ]
> @@ -94,6 +208,25 @@ static void asix_ax88772a_link_change_notify(struct phy_device *phydev)
> }
> }
>
> +static int asix_ax88772D_get_features(struct phy_device *phydev)
> +{
> + int ret;
> +
> + /* MDIO_DEVS1/2 empty, so set mmds_present bits to allow reading abilities */
> + phydev->c45_ids.mmds_present |= MDIO_DEVS_PMAPMD | MDIO_DEVS_AN;
> +
> + ret = genphy_read_abilities(phydev);
> + if (ret < 0)
> + return ret;
> +
> + /* AX88772D does not support (possibly) reported 1000baseT modes */
> + linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, phydev->supported);
> + linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT, phydev->supported);
> + linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT, phydev->supported);
[Severity: Low]
Does the mmds_present assignment do anything here? genphy_read_abilities()
only reads MII_BMSR and MII_ESTATUS and never looks at
c45_ids.mmds_present.
In drivers/net/phy, only genphy_c45_read_link(),
genphy_c45_pma_read_abilities() and the phylink C45 MII emulation check
mmds_present, and none of them run for this C22 PHY. The line and its
comment look like they were copied from asix_ax88279_get_features().
There is also an ordering question for EEE. genphy_read_abilities() ends
with genphy_c45_read_eee_abilities()->genphy_c45_read_eee_cap1(), which
masks supported_eee against supported:
linkmode_and(phydev->supported_eee, phydev->supported_eee,
phydev->supported);
At that point 1000baseT_Full can still be set in supported, and it is
only cleared here afterwards.
If ESTATUS reports 1000T and MDIO_PCS_EEE_ABLE reports 1000T EEE, can
supported_eee keep 1000baseT_Full after it has been removed from
supported?
With the in-tree MAC, lpi_capabilities is 0 for the AX88772D, so phylink
disables EEE and users don't see this today.
[ ... ]
> @@ -111,6 +244,35 @@ static struct phy_driver asix_driver[] = {
> .suspend = genphy_suspend,
> .resume = genphy_resume,
> .soft_reset = asix_soft_reset,
[ ... ]
> +}, {
> + PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88279),
> + .name = "Asix Electronics AX88279",
> + .flags = PHY_IS_INTERNAL | PHY_BROKEN_FORCED,
> + .get_features = asix_ax88279_get_features,
> + .read_status = asix_ax88279_read_status,
> + .config_aneg = asix_ax88279_config_aneg,
> + .config_init = asix_ax88279_config_init,
[Severity: Low]
Can a bisect stop on a commit where the AX88279 doesn't work? This patch
is the last one in the series. The earlier patch "ax88179_178a: Add HW
support for AX179A-based chips" already returns PHYSID1/2 of
0x003b/0x2790 (and 0x179a/0x772d) from ax88179_mdiobus_read().
That patch also sets up phylink for the AX88279 in
ax88179a_phylink_setup() with only 2500BASEX and SGMII in
supported_interfaces, and an initial interface of 2500BASEX.
Between that patch and this one, nothing matches these IDs, so genphy
binds. It fills supported with C22 10/100/1000 modes only and leaves
possible_interfaces empty.
phylink_validate_phy() then validates against 2500BASEX, because is_c45
is false and it does not fall back to PHY_INTERFACE_MODE_NA. The only
capability for 2500BASEX is 2500 full duplex, so no mode is left and the
PHY fails to attach once ax88179 binds instead of cdc_ncm.
The AX88179A and AX88772D also run on genphy without the quirks added
here.
Could this patch be moved ahead of the MAC patch that depends on it?
[ ... ]
> @@ -124,6 +286,9 @@ static const struct mdio_device_id __maybe_unused asix_tbl[] = {
> { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772A) },
> { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772C) },
> { PHY_ID_MATCH_MODEL(PHY_ID_ASIX_AX88796B) },
> + { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88772D) },
> + { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88179A) },
> + { PHY_ID_MATCH_EXACT(PHY_ID_ASIX_AX88279) },
> { }
> };
[Severity: Medium]
What happens to these PHYs when CONFIG_AX88796B_RUST_PHY=y?
drivers/net/phy/Makefile builds only one of the two drivers:
ifdef CONFIG_AX88796B_RUST_PHY
obj-$(CONFIG_AX88796B_PHY) += ax88796b_rust.o
else
obj-$(CONFIG_AX88796B_PHY) += ax88796b.o
endif
drivers/net/phy/ax88796b_rust.rs still registers only the old three:
drivers: [PhyAX88772A, PhyAX88772C, PhyAX88796B],
USB_NET_AX88179 selects AX88796B_PHY so that this module provides the
PHY driver for the new chips. With the Rust variant, genphy binds to
0x003b2790, and the AX88279 fails phylink_validate_phy() against
2500BASEX as described above.
The AX88179A and AX88772D also lose the read_mmd/write_mmd hooks, and the
AX88772D loses its feature fixup.
The AX88796B_RUST_PHY help text also still says "The features are
equivalent", which is no longer the case.
Does the Rust driver need the same entries? Alternatively, could the
Kconfig dependencies reflect that it doesn't cover these PHYs?
[Severity: Low]
This isn't a bug, but the AX88796B_PHY help text in
drivers/net/phy/Kconfig still says:
Currently supports the Asix Electronics PHY found in the X-Surf 100
AX88796B package.
It already left out the AX88772A/C. Now it also leaves out the AX88772D,
AX88179A and AX88279 used by USB adapters, and USB_NET_AX88179 selects
this symbol. Could the help text be updated?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-ax88179a-v20-0-37b5a1189983%40birger-koblitz.de
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2026-11-10 1:38 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-06 7:21 [PATCH net-next v20 00/13] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-11-06 7:21 ` [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt Birger Koblitz
2026-11-06 10:11 ` Maxime Chevallier
2026-11-06 15:32 ` Birger Koblitz
2026-11-06 15:55 ` Andrew Lunn
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 02/13] phylib: Add support for PHYs with broken forced mode Birger Koblitz
2026-11-06 7:21 ` [PATCH net-next v20 03/13] ax88179_178a: Split driver into library and device specific code Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 04/13] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 05/13] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 06/13] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 07/13] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 08/13] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 09/13] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 10/13] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 11/13] ax88179_178a: Update driver name and information Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 12/13] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
2026-11-06 7:21 ` [PATCH net-next v20 13/13] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz
2026-11-10 1:38 ` netdev-bot+sashiko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®