mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next v2] net: sfp: add quirk for OEM SFP+ONU-XGSPON
@ 2026-11-06 22:18 Romit Sagu
  2026-11-11  0:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Romit Sagu @ 2026-11-06 22:18 UTC (permalink / raw)
  To: netdev
  Cc: linux, andrew, hkallweit1, davem, edumazet, kuba, pabeni,
	linux-kernel, Romit Sagu


This XGS-PON ONU stick (vendor OEM, part SFP+ONU-XGSPON)
needs the same handling as other Potron-based modules. Without it,
the module fails to connect and the kernal shows these errors:
sfp sfp1: module transmit fault indicated
sfp sfp1: module persistently indicates fault, disabling

This module requires TX_FAULT/LOS behaviour and boot delay tuning.
Add a quirk using the existing sfp_fixup_potron.

Signed-off-by: Romit Sagu <romit@romitsagu.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
v2:
- Move the new quirk to be better sorted alphabetically within the
  OEM section and next to another XGS-PON ONT (requested by Jakub Kicinski)
- Added LOS in the quirk comment (recommended by Sashiko)

v1: https://lore.kernel.org/all/20261103011849.181392-1-romit@romitsagu.com/

---
 drivers/net/phy/sfp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 85e57a16bb52..915156743701 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -638,6 +638,10 @@ static const struct sfp_quirk sfp_quirks[] = {
 	SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
 	SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc),
 
+	// OEM SFP+ONU-XGSPON is a XGS-PON ONT stick with broken TX_FAULT and
+	// LOS indicators and slow startup, just like potron.
+	SFP_QUIRK_F("OEM", "SFP+ONU-XGSPON", sfp_fixup_potron),
+
 	// OEM XGSPONST2001 is an XGS-PON ONT stick with broken TX_FAULT and
 	// LOS indicators and slow startup, just like potron. On cold
 	// power-up the EEPROM vendor PN field reads back with non-printable
-- 
2.43.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next v2] net: sfp: add quirk for OEM SFP+ONU-XGSPON
  2026-11-06 22:18 [PATCH net-next v2] net: sfp: add quirk for OEM SFP+ONU-XGSPON Romit Sagu
@ 2026-11-11  0:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-11-11  0:40 UTC (permalink / raw)
  To: Romit Sagu
  Cc: netdev, linux, andrew, hkallweit1, davem, edumazet, kuba, pabeni,
	linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri,  6 Nov 2026 22:18:29 +0000 you wrote:
> This XGS-PON ONU stick (vendor OEM, part SFP+ONU-XGSPON)
> needs the same handling as other Potron-based modules. Without it,
> the module fails to connect and the kernal shows these errors:
> sfp sfp1: module transmit fault indicated
> sfp sfp1: module persistently indicates fault, disabling
> 
> This module requires TX_FAULT/LOS behaviour and boot delay tuning.
> Add a quirk using the existing sfp_fixup_potron.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: sfp: add quirk for OEM SFP+ONU-XGSPON
    https://git.kernel.org/netdev/net-next/c/ed04b2020272

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-11  0:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-06 22:18 [PATCH net-next v2] net: sfp: add quirk for OEM SFP+ONU-XGSPON Romit Sagu
2026-11-11  0:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®