[PATCH] phy: qcom: m31: propagate reset errors

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH] phy: qcom: m31: propagate reset errors
@ 2026-08-30 13:14 Pengpeng Hou
  2026-09-01  9:45 ` Konrad Dybcio
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Pengpeng Hou @ 2026-08-30 13:14 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Pengpeng Hou, Neil Armstrong, Manivannan Sadhasivam,
	Philipp Zabel, linux-arm-msm, linux-phy, linux-kernel

m31usb_phy_init() enables the regulator and clock, then performs an
unchecked
reset pulse before reporting that the PHY powered on.

Return reset-controller errors and release the clock and regulator that
were
enabled for the failed power-on attempt.

Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
 drivers/phy/qualcomm/phy-qcom-m31.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
index 168ea980fda03..f46c7ec87496a 100644
--- a/drivers/phy/qualcomm/phy-qcom-m31.c
+++ b/drivers/phy/qualcomm/phy-qcom-m31.c
@@ -228,9 +228,14 @@ static int m31usb_phy_init(struct phy *phy)
 	}
 
 	/* Perform phy reset */
-	reset_control_assert(qphy->reset);
+	ret = reset_control_assert(qphy->reset);
+	if (ret)
+		goto disable_clk;
+
 	udelay(5);
-	reset_control_deassert(qphy->reset);
+	ret = reset_control_deassert(qphy->reset);
+	if (ret)
+		goto disable_clk;
 
 	/* configure for ULPI mode if requested */
 	if (qphy->ulpi_mode)
@@ -247,6 +252,12 @@ static int m31usb_phy_init(struct phy *phy)
 	}
 
 	return 0;
+
+disable_clk:
+	clk_disable_unprepare(qphy->clk);
+	regulator_disable(qphy->vreg);
+
+	return ret;
 }
 
 static int m31usb_phy_shutdown(struct phy *phy)

base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72
-- 
2.50.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] phy: qcom: m31: propagate reset errors
  2026-08-30 13:14 [PATCH] phy: qcom: m31: propagate reset errors Pengpeng Hou
@ 2026-09-01  9:45 ` Konrad Dybcio
  2026-09-01 12:22 ` Abel Vesa
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2026-09-01  9:45 UTC (permalink / raw)
  To: Pengpeng Hou, Vinod Koul
  Cc: Neil Armstrong, Manivannan Sadhasivam, Philipp Zabel,
	linux-arm-msm, linux-phy, linux-kernel

On 8/30/26 3:14 PM, Pengpeng Hou wrote:
> m31usb_phy_init() enables the regulator and clock, then performs an
> unchecked
> reset pulse before reporting that the PHY powered on.
> 
> Return reset-controller errors and release the clock and regulator that
> were
> enabled for the failed power-on attempt.
> 
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] phy: qcom: m31: propagate reset errors
  2026-08-30 13:14 [PATCH] phy: qcom: m31: propagate reset errors Pengpeng Hou
  2026-09-01  9:45 ` Konrad Dybcio
@ 2026-09-01 12:22 ` Abel Vesa
  2026-09-01 15:43 ` Krishna Kurapati
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Abel Vesa @ 2026-09-01 12:22 UTC (permalink / raw)
  To: Pengpeng Hou
  Cc: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Philipp Zabel,
	linux-arm-msm, linux-phy, linux-kernel

On 26-08-30 21:14:42, Pengpeng Hou wrote:
> m31usb_phy_init() enables the regulator and clock, then performs an
> unchecked
> reset pulse before reporting that the PHY powered on.
> 
> Return reset-controller errors and release the clock and regulator that
> were
> enabled for the failed power-on attempt.
> 
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] phy: qcom: m31: propagate reset errors
  2026-08-30 13:14 [PATCH] phy: qcom: m31: propagate reset errors Pengpeng Hou
  2026-09-01  9:45 ` Konrad Dybcio
  2026-09-01 12:22 ` Abel Vesa
@ 2026-09-01 15:43 ` Krishna Kurapati
  2026-10-12  8:52 ` Manivannan Sadhasivam
  2026-11-12  9:04 ` (subset) " Vinod Koul
  4 siblings, 0 replies; 6+ messages in thread
From: Krishna Kurapati @ 2026-09-01 15:43 UTC (permalink / raw)
  To: Pengpeng Hou, Vinod Koul
  Cc: Neil Armstrong, Manivannan Sadhasivam, Philipp Zabel,
	linux-arm-msm, linux-phy, linux-kernel



On 8/30/2026 6:44 PM, Pengpeng Hou wrote:
> m31usb_phy_init() enables the regulator and clock, then performs an
> unchecked
> reset pulse before reporting that the PHY powered on.
> 
> Return reset-controller errors and release the clock and regulator that
> were
> enabled for the failed power-on attempt.
> 
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Incase you put a second version, please fix the commit message formatting.

Reviewed-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] phy: qcom: m31: propagate reset errors
  2026-08-30 13:14 [PATCH] phy: qcom: m31: propagate reset errors Pengpeng Hou
                   ` (2 preceding siblings ...)
  2026-09-01 15:43 ` Krishna Kurapati
@ 2026-10-12  8:52 ` Manivannan Sadhasivam
  2026-11-12  9:04 ` (subset) " Vinod Koul
  4 siblings, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2026-10-12  8:52 UTC (permalink / raw)
  To: Pengpeng Hou
  Cc: Vinod Koul, Neil Armstrong, Philipp Zabel, linux-arm-msm,
	linux-phy, linux-kernel

On Sun, Aug 30, 2026 at 09:14:42PM +0800, Pengpeng Hou wrote:
> m31usb_phy_init() enables the regulator and clock, then performs an
> unchecked
> reset pulse before reporting that the PHY powered on.
> 
> Return reset-controller errors and release the clock and regulator that
> were
> enabled for the failed power-on attempt.
> 
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

- Mani

-- 
மணிவண்ணன் சதாசிவம்

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: (subset) [PATCH] phy: qcom: m31: propagate reset errors
  2026-08-30 13:14 [PATCH] phy: qcom: m31: propagate reset errors Pengpeng Hou
                   ` (3 preceding siblings ...)
  2026-10-12  8:52 ` Manivannan Sadhasivam
@ 2026-11-12  9:04 ` Vinod Koul
  4 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2026-11-12  9:04 UTC (permalink / raw)
  To: Pengpeng Hou
  Cc: Neil Armstrong, Manivannan Sadhasivam, Philipp Zabel,
	linux-arm-msm, linux-phy, linux-kernel


On Sun, 30 Aug 2026 21:14:42 +0800, Pengpeng Hou wrote:
> m31usb_phy_init() enables the regulator and clock, then performs an
> unchecked
> reset pulse before reporting that the PHY powered on.
> 
> Return reset-controller errors and release the clock and regulator that
> were
> enabled for the failed power-on attempt.
> 
> [...]

Applied, thanks!

[1/1] phy: qcom: m31: propagate reset errors
      commit: ad2bf54fe7267f9e7cba90afdc8d91dfd17957f3

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-12  9:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-30 13:14 [PATCH] phy: qcom: m31: propagate reset errors Pengpeng Hou
2026-09-01  9:45 ` Konrad Dybcio
2026-09-01 12:22 ` Abel Vesa
2026-09-01 15:43 ` Krishna Kurapati
2026-10-12  8:52 ` Manivannan Sadhasivam
2026-11-12  9:04 ` (subset) " Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®