[PATCH net] iavf: Fix potential QoS capabilities leak on removal

[PATCH net] iavf: Fix potential QoS capabilities leak on removal

[Guangshuo Li]

Probe allocates qos_caps separately from the netdev. Remove frees the
netdev without releasing this allocation.

Free the capabilities after the workqueue is drained and before freeing
the netdev.

This issue was found by our static analysis tool under development.

Fixes: 4c1a457cb8b0 ("iavf: add support to exchange qos capabilities")
Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
---
 drivers/net/ethernet/intel/iavf/iavf_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 2f8a80a11336..a2e7bc4cba88 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -5680,6 +5680,7 @@ static void iavf_remove(struct pci_dev *pdev)
 
 	pci_set_drvdata(pdev, NULL);
 
+	kfree(adapter->qos_caps);
 	free_netdev(netdev);
 
 	pci_disable_device(pdev);

base-commit: 2e54b3e187300893688c2c7517894f5d96732e05

Re: [PATCH net] iavf: Fix potential QoS capabilities leak on removal

[netdev-bot+sinfo]

Hi!

This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:

 - What hardware the change was tested on. For driver fixes please
   mention the device (and if relevant firmware version) used for
   testing, or say that the change was not tested on real hardware.

Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account. If the series needs another revision for
other reasons, please include the information in the commit messages
then.

The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.