mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] net: fix uninitialized heap leak in multicast address dumps
@ 2026-11-16  2:40 Henry Martin
  2026-11-16  2:43 ` netdev-bot+sinfo
  0 siblings, 1 reply; 2+ messages in thread
From: Henry Martin @ 2026-11-16  2:40 UTC (permalink / raw)
  To: Paolo Abeni, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Simon Horman, Stanislav Fomichev, Nicolas Dichtel, Yuyang Huang,
	Aleksandr Loktionov
  Cc: netdev, linux-kernel, Henry Martin, stable

__hw_addr_create() allocates entries with kmalloc() and initializes
only addr_len bytes of ha->addr. Dump paths emit entries using the
current dev->addr_len, which can grow after the entry was created:
tun's TUNSETLINK changes a device from ARPHRD_NONE (addr_len 0) to
ARPHRD_IP6GRE (addr_len 16). Both the RTM_GETMULTICAST dump and
/proc/net/dev_mcast then emit up to 16 bytes of never-written slab
memory per entry.

This discloses leftover kernel heap contents to anyone reading those
interfaces.

Zero the tail of ha->addr at creation time, so dumps can only emit
initialized bytes.

Cc: stable@vger.kernel.org
Fixes: a748ee242681 ("net: move address list functions to a separate file")
Link: https://lists.openwall.net/linux-kernel/2026/09/10/320
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
---
 net/core/dev_addr_lists.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c
index d827cc21867b..53a2dfa2706c 100644
--- a/net/core/dev_addr_lists.c
+++ b/net/core/dev_addr_lists.c
@@ -100,6 +100,11 @@ __hw_addr_create(const unsigned char *addr, int addr_len,
 	if (!ha)
 		return NULL;
 	memcpy(ha->addr, addr, addr_len);
+	/* Entries are dumped with the current dev->addr_len, which can grow
+	 * after creation (e.g. tun TUNSETLINK), so never leave the tail
+	 * uninitialized.
+	 */
+	memset(ha->addr + addr_len, 0, MAX_ADDR_LEN - addr_len);
 	ha->type = addr_type;
 	ha->refcount = 1;
 	ha->global_use = global;
-- 
2.43.7


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-16  2:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16  2:40 [PATCH] net: fix uninitialized heap leak in multicast address dumps Henry Martin
2026-11-16  2:43 ` netdev-bot+sinfo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®