* [PATCH net] igb: Fix potential I2C adapter leak on probe failure
@ 2026-11-16 14:19 Guangshuo Li
2026-11-16 14:22 ` netdev-bot+sinfo
0 siblings, 1 reply; 2+ messages in thread
From: Guangshuo Li @ 2026-11-16 14:19 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: intel-wired-lan, netdev, linux-kernel
If netdev registration fails after I2C setup, err_register clears the
embedded adapter without unregistering it. I2C clients and the adapter
registration outlive the freed netdev.
Delete the registered adapter instead of clearing its storage.
This issue was found by our static analysis tool under development.
Fixes: 441fc6fdb47a ("igb: Add i2c interface to igb.")
Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
---
drivers/net/ethernet/intel/igb/igb_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index d4a897a8c82c..ffb696500d9c 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -3657,7 +3657,8 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
err_register:
igb_release_hw_control(adapter);
- memset(&adapter->i2c_adap, 0, sizeof(adapter->i2c_adap));
+ if (adapter->i2c_adap.dev.parent)
+ i2c_del_adapter(&adapter->i2c_adap);
err_eeprom:
if (!igb_check_reset_block(hw))
igb_reset_phy(hw);
base-commit: 2e54b3e187300893688c2c7517894f5d96732e05
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] igb: Fix potential I2C adapter leak on probe failure
2026-11-16 14:19 [PATCH net] igb: Fix potential I2C adapter leak on probe failure Guangshuo Li
@ 2026-11-16 14:22 ` netdev-bot+sinfo
0 siblings, 0 replies; 2+ messages in thread
From: netdev-bot+sinfo @ 2026-11-16 14:22 UTC (permalink / raw)
To: Guangshuo Li
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan,
netdev, linux-kernel
Hi!
This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:
- What hardware the change was tested on. For driver fixes please
mention the device (and if relevant firmware version) used for
testing, or say that the change was not tested on real hardware.
Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account.
*IMPORTANT*: If you do repost (for other reasons) - please include
the relevant info in the cover letter or commit messages.
--
The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-16 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 14:19 [PATCH net] igb: Fix potential I2C adapter leak on probe failure Guangshuo Li
2026-11-16 14:22 ` netdev-bot+sinfo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®