From: "Gregory Price (Meta)" <gourry@gourry.net>
To: Alistair Popple <apopple@nvidia.com>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
"Gregory Price (Meta)" <gourry@gourry.net>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, leon@kernel.org,
akpm@linux-foundation.org, kas@kernel.org,
dave.hansen@linux.intel.com, bp@alien8.de, rppt@kernel.org,
stable@vger.kernel.org, "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Subject: Re: [PATCH] mm/hmm: reject shadow-stack mappings
Date: Mon, 16 Nov 2026 11:09:42 -0500 [thread overview]
Message-ID: <179484538296.482102.4367398493158269026.b4-reply@b4> (raw)
In-Reply-To: <avpAQyLCpJPKSpT-@nvdebian.thelocal>
On 2026-11-16 10:48 +1100, Alistair Popple wrote:
> On 2026-11-14 at 22:11 +1100, "David Hildenbrand (Arm)" <david@kernel.org> wrote...
> > It's writable by the hardware, that's what matters to core-mm, for example, when
> > it comes to things like fork(), mproetect() etc.
>
> Except they're not universally writable by HW, after all _PAGE_RW = 0. So
> pte_write() is documented to return if it is logically writable, which of course
> is what hmm_range_fault() also needs for certain values of "logic" :-)
>
> So it's easy to see how this is confusing and got missed. Anyway this fix looks
> good:
>
> Reviewed-by: Alistair Popple <apopple@nvidia.com>
>
Thank's Alistair!
--
~Gregory
next prev parent reply other threads:[~2026-11-16 16:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 19:55 Gregory Price (Meta)
2026-11-13 19:57 ` Lorenzo Stoakes (ARM)
2026-11-13 20:15 ` Gregory Price (Meta)
2026-11-13 20:03 ` Jason Gunthorpe
2026-11-13 20:41 ` Gregory Price (Meta)
2026-11-14 0:20 ` Jason Gunthorpe
2026-11-14 2:10 ` Andrew Morton
2026-11-15 0:00 ` Jason Gunthorpe
2026-11-15 1:01 ` Andrew Morton
2026-11-15 23:27 ` Jason Gunthorpe
2026-11-14 7:25 ` Gregory Price (Meta)
2026-11-14 11:11 ` David Hildenbrand (Arm)
2026-11-15 23:48 ` Alistair Popple
2026-11-16 16:09 ` Gregory Price (Meta) [this message]
2026-11-13 20:03 ` David Hildenbrand (Arm)
2026-11-13 20:42 ` Gregory Price (Meta)
2026-11-13 21:19 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179484538296.482102.4367398493158269026.b4-reply@b4 \
--to=gourry@gourry.net \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=jgg@nvidia.com \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®