From: netdev-bot+sashiko@kernel.org
To: aiyengar1990@gmail.com
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
david.wu@rock-chips.com, dlemoal@kernel.org, cassel@kernel.org,
fancer.lancer@gmail.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, praan@google.com, will@kernel.org,
robin.murphy@arm.com, iommu@lists.linux.dev,
shawn.lin@rock-chips.com, sebastian.reichel@collabora.com
Subject: Re: [PATCH 2/9] dt-bindings: ata: rockchip,dwc-ahci: Allow iommus
Date: Tue, 17 Nov 2026 17:35:10 +0000 [thread overview]
Message-ID: <179493691098.3136.12498888747300831285@kernel.org> (raw)
In-Reply-To: <20261113-mmu600-php-v1-2-231196049a3b@gmail.com>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The patch adds `iommus: maxItems: 1` at the top level of
`Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml` (lines…
--
dt-bindings: ata: rockchip,dwc-ahci: Allow iommus
This adds an iommus property, limited to one item, to the Rockchip DWC
AHCI binding. The commit message says the RK3588 SATA controllers sit
behind the PHP SMMU.
> diff --git a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> index b5ecaabfe2e25..e33e8b5591ee5 100644
> --- a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> @@ -34,6 +34,9 @@ properties:
> - rockchip,rk3588-dwc-ahci
> - const: snps,dwc-ahci
>
> + iommus:
> + maxItems: 1
> +
[Severity: Low]
Should iommus be limited to rockchip,rk3588-dwc-ahci?
As added, the property is unconditional. That makes it valid for all
three compatibles in the select block: rockchip,rk3568-dwc-ahci,
rockchip,rk3576-dwc-ahci and rockchip,rk3588-dwc-ahci.
The commit message only gives a hardware reason for RK3588:
The RK3588 SATA controllers are behind the PHP SMMU.
The in-tree SoC descriptions match that. mmu600_php: iommu@fcb00000
(arm,smmu-v3) exists only in rk3588-base.dtsi. In rk356x-base.dtsi and
rk3576.dtsi, the only IOMMUs are for media blocks (vdpu, vepu, vicap,
vop, vdec), and none of them sit in front of the SATA nodes.
The binding already has a separate allOf entry for the older SoCs:
- if:
properties:
compatible:
contains:
enum:
- rockchip,rk3568-dwc-ahci
- rockchip,rk3576-dwc-ahci
then:
properties:
clocks:
maxItems: 3
With this patch, dtbs_check would no longer flag an iommus property
added by mistake to an RK3568 or RK3576 SATA node.
One option is to add iommus: false to the rk3568/rk3576 then: branch.
Another is to allow iommus only in the rk3588 branch.
snps,dwc-ahci.yaml, which the commit message cites, does allow iommus
unconditionally. This binding is per-SoC, though, and already has
per-compatible constraints.
> ports-implemented:
> const: 1
>
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-mmu600-php-v1-0-231196049a3b%40gmail.com
next prev parent reply other threads:[~2026-11-17 17:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 16:38 [PATCH 0/9] RK3588: Enable the PHP SMMU Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 1/9] dt-bindings: net: rockchip-dwmac: Allow iommus Arun Iyengar via B4 Relay
2026-11-17 17:35 ` netdev-bot+sashiko
2026-11-13 16:38 ` [PATCH 2/9] dt-bindings: ata: rockchip,dwc-ahci: " Arun Iyengar via B4 Relay
2026-11-17 17:35 ` netdev-bot+sashiko [this message]
2026-11-13 16:38 ` [PATCH 3/9] dt-bindings: soc: rockchip: grf: Allow a clock for the RK3588 PHP GRF Arun Iyengar via B4 Relay
2026-11-17 17:35 ` netdev-bot+sashiko
2026-11-13 16:38 ` [PATCH 4/9] soc: rockchip: grf: Assign the StreamIDs of the RK3588 PHP SMMU masters Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 5/9] arm64: dts: rockchip: Add the PHP GRF clock on RK3588 Arun Iyengar via B4 Relay
2026-11-17 17:35 ` netdev-bot+sashiko
2026-11-13 16:38 ` [PATCH 6/9] soc: rockchip: grf: Restore the RK3588 PHP StreamIDs after system suspend Arun Iyengar via B4 Relay
2026-11-17 17:35 ` netdev-bot+sashiko
2026-11-13 16:38 ` [PATCH 7/9] arm64: dts: rockchip: Add the clock and reset of the RK3588 PHP SMMU Arun Iyengar via B4 Relay
2026-11-17 17:35 ` netdev-bot+sashiko
2026-11-13 16:38 ` [PATCH 8/9] arm64: dts: rockchip: Attach the masters " Arun Iyengar via B4 Relay
2026-11-17 17:35 ` netdev-bot+sashiko
2026-11-13 16:38 ` [PATCH 9/9] arm64: dts: rockchip: Enable " Arun Iyengar via B4 Relay
2026-11-17 17:35 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179493691098.3136.12498888747300831285@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=aiyengar1990@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=edumazet@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praan@google.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®