mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: btintel: Don't log unsupported debug features as an error
@ 2026-11-13 22:20 Hex Lindqvist
  2026-11-17 18:50 ` patchwork-bot+bluetooth
  0 siblings, 1 reply; 2+ messages in thread
From: Hex Lindqvist @ 2026-11-13 22:20 UTC (permalink / raw)
  To: Marcel Holtmann, Luiz Augusto von Dentz
  Cc: Paul Menzel, Abhishek Pandit-Subedi, linux-bluetooth, linux-kernel

Since commit af395330abed ("Bluetooth: btintel: Add Intel devcoredump
support"), setup sends Read Supported Features (0xfca6) to decide
whether to register devcoredump. Older controllers such as the 8260
and 8265 reject it with Command Disallowed, so every probe logs:

  Bluetooth: hci0: Reading supported features failed (-16)
  Bluetooth: hci0: Error reading debug features

This is harmless: it happens after the firmware is loaded and only
means devcoredump is not registered.

Log the failure at debug level there, and keep the error in
btintel_set_quality_report(), where the user asked for the feature.

Tested on an 8265 (8087:0a2b): the messages are gone and Bluetooth
works as before.

AI was used to help write and test this patch.

Fixes: af395330abed ("Bluetooth: btintel: Add Intel devcoredump support")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219387
Signed-off-by: Hex Lindqvist <hex@freenixos.com>
---
 drivers/bluetooth/btintel.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index a0aa110f4cdd..31dec65d3327 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -1532,11 +1532,8 @@ static int btintel_read_debug_features(struct hci_dev *hdev,
 	 */
 	skb = __hci_cmd_sync(hdev, 0xfca6, sizeof(page_no), &page_no,
 			     HCI_INIT_TIMEOUT);
-	if (IS_ERR(skb)) {
-		bt_dev_err(hdev, "Reading supported features failed (%ld)",
-			   PTR_ERR(skb));
+	if (IS_ERR(skb))
 		return PTR_ERR(skb);
-	}
 
 	if (skb->len != (sizeof(features->page1) + 3)) {
 		bt_dev_err(hdev, "Supported features event size mismatch");
@@ -1653,8 +1650,10 @@ int btintel_set_quality_report(struct hci_dev *hdev, bool enable)
 	 * supported, need to load the additional DDC config to enable.
 	 */
 	err = btintel_read_debug_features(hdev, &features);
-	if (err)
+	if (err) {
+		bt_dev_err(hdev, "Reading supported features failed (%d)", err);
 		return err;
+	}
 
 	/* Set or reset the debug features. */
 	if (enable)
@@ -1705,7 +1704,7 @@ static int btintel_register_devcoredump_support(struct hci_dev *hdev)
 
 	err = btintel_read_debug_features(hdev, &features);
 	if (err) {
-		bt_dev_info(hdev, "Error reading debug features");
+		bt_dev_dbg(hdev, "Reading supported features failed (%d)", err);
 		return err;
 	}
 

base-commit: da3cc02587c629420603df4395179ec82955c941
-- 
2.56.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: btintel: Don't log unsupported debug features as an error
  2026-11-13 22:20 [PATCH] Bluetooth: btintel: Don't log unsupported debug features as an error Hex Lindqvist
@ 2026-11-17 18:50 ` patchwork-bot+bluetooth
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+bluetooth @ 2026-11-17 18:50 UTC (permalink / raw)
  To: Hex Lindqvist
  Cc: marcel, luiz.dentz, pmenzel, abhishekpandit, linux-bluetooth,
	linux-kernel

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 13 Nov 2026 14:20:24 -0800 you wrote:
> Since commit af395330abed ("Bluetooth: btintel: Add Intel devcoredump
> support"), setup sends Read Supported Features (0xfca6) to decide
> whether to register devcoredump. Older controllers such as the 8260
> and 8265 reject it with Command Disallowed, so every probe logs:
> 
>   Bluetooth: hci0: Reading supported features failed (-16)
>   Bluetooth: hci0: Error reading debug features
> 
> [...]

Here is the summary with links:
  - Bluetooth: btintel: Don't log unsupported debug features as an error
    https://git.kernel.org/bluetooth/bluetooth-next/c/b05fb50e255a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-17 18:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-13 22:20 [PATCH] Bluetooth: btintel: Don't log unsupported debug features as an error Hex Lindqvist
2026-11-17 18:50 ` patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®