mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: bod@kernel.org
To: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
Cc: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	 Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	 Abhinav Kumar <abhinav.kumar@linux.dev>,
	Bryan O'Donoghue <bod@kernel.org>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Vedang Nagar <quic_vnagar@quicinc.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	 Stefan Schmidt <stefan.schmidt@linaro.org>,
	 Hans Verkuil <hverkuil+cisco@kernel.org>,
	 Deepa Guthyappa Madivalara <deepa.madivalara@oss.qualcomm.com>,
	 linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 stable@vger.kernel.org
Subject: Re: [PATCH 3/3] media: iris: Use firmware reported count for output buffers
Date: Wed, 18 Nov 2026 16:00:32 +0000	[thread overview]
Message-ID: <179501763210.2846709.2834027862962422789.b4-reply@b4> (raw)
In-Reply-To: <20261031-fix_dec_seek-v1-3-cfedf0c267ee@oss.qualcomm.com>

On 2026-10-31 01:49 +0530, Vishnu Reddy wrote:
> Once the firmware reports its minimum output buffer count, the driver
> still caps it to 4 for VP9 and AV1 when split mode is enabled. After a
> seek, the output buffer count can be lower than the minimum required by
> the firmware for VP9 streams. This causes the firmware to report
> insufficient output buffers and the seek operation can fail.
> 
> Use the firmware reported minimum count as is. The driver calculated
> count is only used until the firmware reports its own requirement.
> 
> Fixes: e1f5d32608ec ("media: iris: Add internal buffer calculation for HEVC and VP9 decoders")
> Cc: stable@vger.kernel.org
> Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
> ---
>  drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c b/drivers/media/platform/qcom/iris/iris_vpu_buffer.c
> index a8170e5fa9e6..57467c952f42 100644
> --- a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c
> +++ b/drivers/media/platform/qcom/iris/iris_vpu_buffer.c
> @@ -2375,14 +2375,8 @@ static int output_min_count(struct iris_inst *inst)
>  	int output_min_count = 4;
>  
>  	/* fw_min_count > 0 indicates reconfig event has already arrived */
> -	if (inst->fw_min_count) {
> -		if (iris_split_mode_enabled(inst) &&
> -		    (inst->codec == V4L2_PIX_FMT_VP9 ||
> -		     inst->codec == V4L2_PIX_FMT_AV1))
> -			return min_t(u32, 4, inst->fw_min_count);
> -		else
> -			return inst->fw_min_count;
> -	}

Quite a few questions here. Why is the minimum count currently set to four
? Why do we use a hard-coded value of four more than once, why not define a
different minimum count ?
---
bod


      reply	other threads:[~2026-11-18 16:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 20:19 [PATCH 0/3] media: iris: Fix issues exposed during decoder seek Vishnu Reddy
2026-10-30 20:19 ` [PATCH 1/3] media: iris: Skip redundant decoder input config params Vishnu Reddy
2026-11-17 13:55   ` bod
2026-10-30 20:19 ` [PATCH 2/3] media: iris: Skip redundant HFI_PROP_TIER updates Vishnu Reddy
2026-11-18 16:07   ` bod
2026-10-30 20:19 ` [PATCH 3/3] media: iris: Use firmware reported count for output buffers Vishnu Reddy
2026-11-18 16:00   ` bod [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179501763210.2846709.2834027862962422789.b4-reply@b4 \
    --to=bod@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=bryan.odonoghue@linaro.org \
    --cc=busanna.reddy@oss.qualcomm.com \
    --cc=deepa.madivalara@oss.qualcomm.com \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=hverkuil@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_vnagar@quicinc.com \
    --cc=stable@vger.kernel.org \
    --cc=stefan.schmidt@linaro.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®