mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: bod@kernel.org
To: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
Cc: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	 Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	 Abhinav Kumar <abhinav.kumar@linux.dev>,
	Bryan O'Donoghue <bod@kernel.org>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Vedang Nagar <quic_vnagar@quicinc.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	 Stefan Schmidt <stefan.schmidt@linaro.org>,
	 Hans Verkuil <hverkuil+cisco@kernel.org>,
	 Deepa Guthyappa Madivalara <deepa.madivalara@oss.qualcomm.com>,
	 linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 stable@vger.kernel.org
Subject: Re: [PATCH 2/3] media: iris: Skip redundant HFI_PROP_TIER updates
Date: Wed, 18 Nov 2026 16:07:10 +0000	[thread overview]
Message-ID: <179501803041.2846709.479596500645471046.b4-reply@b4> (raw)
In-Reply-To: <20261031-fix_dec_seek-v1-2-cfedf0c267ee@oss.qualcomm.com>

On 2026-10-31 01:49 +0530, Vishnu Reddy wrote:
> HFI_PROP_TIER is already programmed by iris_hfi_gen2_set_tier(), which
> selects TIER or TIER_AV1 based on the active codec. The TIER and TIER_AV1
> caps also define a .set callback. As a result, iris_set_properties()
> programs HFI_PROP_TIER again through the generic cap path.
> 
> The generic property loop sets TIER first and TIER_AV1 last. For non AV1
> codecs, the TIER_AV1 property is programmed after the correct tier value
> and overrides it. Remove the .set callbacks from both caps. This ensures
> HFI_PROP_TIER is programmed only once with the value for the active codec.

I think this commit log should list where and how these settings can be
applied three times ? and what the sequence is exactly which leads to the
invalid setting.

It's not enomrously obvious reading the log and then the code how that
happens and which one is so obviously wrong.
---
bod


  reply	other threads:[~2026-11-18 16:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 20:19 [PATCH 0/3] media: iris: Fix issues exposed during decoder seek Vishnu Reddy
2026-10-30 20:19 ` [PATCH 1/3] media: iris: Skip redundant decoder input config params Vishnu Reddy
2026-11-17 13:55   ` bod
2026-10-30 20:19 ` [PATCH 2/3] media: iris: Skip redundant HFI_PROP_TIER updates Vishnu Reddy
2026-11-18 16:07   ` bod [this message]
2026-10-30 20:19 ` [PATCH 3/3] media: iris: Use firmware reported count for output buffers Vishnu Reddy
2026-11-18 16:00   ` bod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179501803041.2846709.479596500645471046.b4-reply@b4 \
    --to=bod@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=bryan.odonoghue@linaro.org \
    --cc=busanna.reddy@oss.qualcomm.com \
    --cc=deepa.madivalara@oss.qualcomm.com \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=hverkuil@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_vnagar@quicinc.com \
    --cc=stable@vger.kernel.org \
    --cc=stefan.schmidt@linaro.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®