* [PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin
@ 2026-11-13 21:45 Ingo A. Kubbilun
2026-11-15 10:26 ` Srinivas Kandagatla
2026-11-18 18:14 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Ingo A. Kubbilun @ 2026-11-13 21:45 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-sound, linux-arm-msm, linux-kernel, Ingo A. Kubbilun
The WCD MBHC classifies high-impedance loads (above linein_th, 5 kOhm
on wcd938x) such as active speakers as SND_JACK_LINEOUT. The
"Headphone Jack" pin only matched SND_JACK_HEADPHONE, so the jack
control stayed off and userspace (UCM JackControl) never switched to
the headphone output for those loads.
Seen on ASUS Vivobook S16 S3607QA (X1P42100, WCD9385): active
speakers measured at ~20 kOhm per channel were reported as LINEOUT only.
Developed with the help of an AI coding assistant (Anthropic Claude),
which drafted the changes from the Windows ACPI tables, existing device
trees and test logs; reviewed, built and tested on the device by the
submitter.
Signed-off-by: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>
---
sound/soc/qcom/common.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c
index 5dc954dc1cb2..af5cacddf67d 100644
--- a/sound/soc/qcom/common.c
+++ b/sound/soc/qcom/common.c
@@ -335,7 +335,11 @@ static struct snd_soc_jack_pin qcom_headset_jack_pins[] = {
},
{
.pin = "Headphone Jack",
- .mask = SND_JACK_HEADPHONE,
+ /*
+ * WCD MBHC reports loads above linein_th (5 kOhm) as LINEOUT,
+ * e.g. active speakers; treat them like headphones for routing.
+ */
+ .mask = SND_JACK_HEADPHONE | SND_JACK_LINEOUT,
},
};
--
2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin
2026-11-13 21:45 [PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin Ingo A. Kubbilun
@ 2026-11-15 10:26 ` Srinivas Kandagatla
2026-11-18 18:14 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2026-11-15 10:26 UTC (permalink / raw)
To: Ingo A. Kubbilun, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, linux-arm-msm, linux-kernel
On 11/13/26 9:45 PM, Ingo A. Kubbilun wrote:
> The WCD MBHC classifies high-impedance loads (above linein_th, 5 kOhm
> on wcd938x) such as active speakers as SND_JACK_LINEOUT. The
> "Headphone Jack" pin only matched SND_JACK_HEADPHONE, so the jack
> control stayed off and userspace (UCM JackControl) never switched to
> the headphone output for those loads.
>
> Seen on ASUS Vivobook S16 S3607QA (X1P42100, WCD9385): active
> speakers measured at ~20 kOhm per channel were reported as LINEOUT only.
>
> Developed with the help of an AI coding assistant (Anthropic Claude),
> which drafted the changes from the Windows ACPI tables, existing device
> trees and test logs; reviewed, built and tested on the device by the
> submitter.
>
> Signed-off-by: Ingo A. Kubbilun <ingo.kubbilun@gmail.com>
> ---
Reviewed-by: Srinivas Kandagatla<srinivas.kandagatla@oss.qualcomm.com>
--Srini
> sound/soc/qcom/common.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c
> index 5dc954dc1cb2..af5cacddf67d 100644
> --- a/sound/soc/qcom/common.c
> +++ b/sound/soc/qcom/common.c
> @@ -335,7 +335,11 @@ static struct snd_soc_jack_pin qcom_headset_jack_pins[] = {
> },
> {
> .pin = "Headphone Jack",
> - .mask = SND_JACK_HEADPHONE,
> + /*
> + * WCD MBHC reports loads above linein_th (5 kOhm) as LINEOUT,
> + * e.g. active speakers; treat them like headphones for routing.
> + */
> + .mask = SND_JACK_HEADPHONE | SND_JACK_LINEOUT,
> },
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin
2026-11-13 21:45 [PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin Ingo A. Kubbilun
2026-11-15 10:26 ` Srinivas Kandagatla
@ 2026-11-18 18:14 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2026-11-18 18:14 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Ingo A. Kubbilun
Cc: linux-sound, linux-arm-msm, linux-kernel
On Fri, 13 Nov 2026 22:45:35 +0100, Ingo A. Kubbilun wrote:
> ASoC: qcom: common: report line-out plugs on the Headphone Jack pin
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.5
Thanks!
[1/1] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin
https://git.kernel.org/broonie/sound/c/b610f9cd00f4
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-19 13:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-13 21:45 [PATCH] ASoC: qcom: common: report line-out plugs on the Headphone Jack pin Ingo A. Kubbilun
2026-11-15 10:26 ` Srinivas Kandagatla
2026-11-18 18:14 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®