* [syzbot] [x25?] inconsistent lock state in x25_kill_by_neigh (2)
@ 2026-10-11 0:03 syzbot
2026-10-14 11:14 ` Forwarded: " syzbot
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: syzbot @ 2026-10-11 0:03 UTC (permalink / raw)
To: davem, edumazet, horms, kuba, linux-kernel, linux-x25, ms,
netdev, pabeni, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: 602042bf29f6 Merge tag 'wq-for-7.3-rc6-fixes' of git://git..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13d66715580000
kernel config: https://syzkaller.appspot.com/x/.config?x=929e4854a828f434
dashboard link: https://syzkaller.appspot.com/bug?extid=300375dfd44665f063a6
compiler: gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=115d5f25580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=146adff5580000
Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/d900f083ada3/non_bootable_disk-602042bf.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/c804d2e9b640/vmlinux-602042bf.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d6cd162ae59e/bzImage-602042bf.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+300375dfd44665f063a6@syzkaller.appspotmail.com
================================
WARNING: inconsistent lock state
syzkaller #0 Not tainted
--------------------------------
inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
ksoftirqd/0/15 [HC0[0]:SC1[1]:HE1:SE0] takes:
ffff88802c938260 (sk_lock-AF_X25){+.?.}-{0:0}, at: lock_sock include/net/sock.h:1713 [inline]
ffff88802c938260 (sk_lock-AF_X25){+.?.}-{0:0}, at: x25_kill_by_neigh+0x168/0x280 net/x25/af_x25.c:1778
{SOFTIRQ-ON-W} state was registered at:
lock_acquire kernel/locking/lockdep.c:5942 [inline]
lock_acquire+0x1d1/0x380 kernel/locking/lockdep.c:5899
lock_sock_nested+0x41/0xf0 net/core/sock.c:3837
lock_sock include/net/sock.h:1713 [inline]
x25_bind+0x221/0x5c0 net/x25/af_x25.c:694
__sys_bind_socket net/socket.c:1945 [inline]
__sys_bind_socket net/socket.c:1937 [inline]
__sys_bind+0x1a9/0x260 net/socket.c:1976
__do_sys_bind net/socket.c:1981 [inline]
__se_sys_bind net/socket.c:1979 [inline]
__x64_sys_bind+0x72/0xb0 net/socket.c:1979
do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
do_syscall_64+0x123/0x790 arch/x86/entry/syscall_64.c:84
entry_SYSCALL_64_after_hwframe+0x77/0x7f
irq event stamp: 357794
hardirqs last enabled at (357794): [<ffffffff81ca5245>] __local_bh_enable_ip+0xa5/0x120 kernel/softirq.c:478
hardirqs last disabled at (357793): [<ffffffff81ca526e>] __local_bh_enable_ip+0xce/0x120 kernel/softirq.c:455
softirqs last enabled at (357466): [<ffffffff81ca4d98>] run_ksoftirqd kernel/softirq.c:1099 [inline]
softirqs last enabled at (357466): [<ffffffff81ca4d98>] run_ksoftirqd+0x38/0x60 kernel/softirq.c:1091
softirqs last disabled at (357471): [<ffffffff81ca4d98>] run_ksoftirqd kernel/softirq.c:1099 [inline]
softirqs last disabled at (357471): [<ffffffff81ca4d98>] run_ksoftirqd+0x38/0x60 kernel/softirq.c:1091
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
----
lock(sk_lock-AF_X25);
<Interrupt>
lock(sk_lock-AF_X25);
*** DEADLOCK ***
locks held by ksoftirqd/0/15: 1, last CPU#0:
#0: ffffffff8edec5a0 (rcu_read_lock){....}-{1:3}, at: rcu_lock_acquire include/linux/rcupdate.h:309 [inline]
#0: ffffffff8edec5a0 (rcu_read_lock){....}-{1:3}, at: rcu_read_lock include/linux/rcupdate.h:849 [inline]
#0: ffffffff8edec5a0 (rcu_read_lock){....}-{1:3}, at: netif_receive_skb_core+0x25/0x1a0 net/core/dev.c:6321
stack backtrace:
CPU: 0 UID: 0 PID: 15 Comm: ksoftirqd/0 Not tainted syzkaller #0 PREEMPT(full)
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x100/0x190 lib/dump_stack.c:120
print_usage_bug.part.0+0x258/0x340 kernel/locking/lockdep.c:4086
print_usage_bug kernel/locking/lockdep.c:4054 [inline]
valid_state kernel/locking/lockdep.c:4100 [inline]
mark_lock_irq kernel/locking/lockdep.c:4311 [inline]
mark_lock+0x956/0x1020 kernel/locking/lockdep.c:4797
mark_usage kernel/locking/lockdep.c:4686 [inline]
__lock_acquire+0x7f1/0x1f40 kernel/locking/lockdep.c:5242
lock_acquire kernel/locking/lockdep.c:5942 [inline]
lock_acquire+0x1d1/0x380 kernel/locking/lockdep.c:5899
lock_sock_nested+0x41/0xf0 net/core/sock.c:3837
lock_sock include/net/sock.h:1713 [inline]
x25_kill_by_neigh+0x168/0x280 net/x25/af_x25.c:1778
x25_lapb_receive_frame+0x4b1/0x1000 net/x25/x25_dev.c:138
__netif_receive_skb_one_core+0x1b2/0x1e0 net/core/dev.c:6297
netif_receive_skb_core+0x5a/0x1a0 net/core/dev.c:6322
lapbeth_napi_poll+0x42/0xc0 drivers/net/wan/lapbether.c:100
__napi_poll.constprop.0+0xaf/0x450 net/core/dev.c:7830
napi_poll net/core/dev.c:7893 [inline]
net_rx_action+0xa40/0xf20 net/core/dev.c:8050
handle_softirqs+0x1e6/0x9d0 kernel/softirq.c:645
run_ksoftirqd kernel/softirq.c:1099 [inline]
run_ksoftirqd+0x38/0x60 kernel/softirq.c:1091
smpboot_thread_fn+0x3d3/0xab0 kernel/smpboot.c:160
kthread+0x373/0x450 kernel/kthread.c:436
ret_from_fork+0x730/0xd60 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
</TASK>
BUG: sleeping function called from invalid context at net/core/sock.c:3839
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 15, name: ksoftirqd/0
preempt_count: 100, expected: 0
RCU nest depth: 1, expected: 0
INFO: lockdep is turned off.
Preemption disabled at:
[<ffffffff81ca41d3>] softirq_handle_begin kernel/softirq.c:486 [inline]
[<ffffffff81ca41d3>] handle_softirqs+0xf3/0x9d0 kernel/softirq.c:621
CPU: 0 UID: 0 PID: 15 Comm: ksoftirqd/0 Not tainted syzkaller #0 PREEMPT(full)
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x100/0x190 lib/dump_stack.c:120
__might_resched.cold+0x1dc/0x222 kernel/sched/core.c:9264
lock_sock_nested+0x52/0xf0 net/core/sock.c:3839
lock_sock include/net/sock.h:1713 [inline]
x25_kill_by_neigh+0x168/0x280 net/x25/af_x25.c:1778
x25_lapb_receive_frame+0x4b1/0x1000 net/x25/x25_dev.c:138
__netif_receive_skb_one_core+0x1b2/0x1e0 net/core/dev.c:6297
netif_receive_skb_core+0x5a/0x1a0 net/core/dev.c:6322
lapbeth_napi_poll+0x42/0xc0 drivers/net/wan/lapbether.c:100
__napi_poll.constprop.0+0xaf/0x450 net/core/dev.c:7830
napi_poll net/core/dev.c:7893 [inline]
net_rx_action+0xa40/0xf20 net/core/dev.c:8050
handle_softirqs+0x1e6/0x9d0 kernel/softirq.c:645
run_ksoftirqd kernel/softirq.c:1099 [inline]
run_ksoftirqd+0x38/0x60 kernel/softirq.c:1091
smpboot_thread_fn+0x3d3/0xab0 kernel/smpboot.c:160
kthread+0x373/0x450 kernel/kthread.c:436
ret_from_fork+0x730/0xd60 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 5+ messages in thread
* Forwarded: inconsistent lock state in x25_kill_by_neigh (2)
2026-10-11 0:03 [syzbot] [x25?] inconsistent lock state in x25_kill_by_neigh (2) syzbot
@ 2026-10-14 11:14 ` syzbot
2026-10-14 11:15 ` syzbot
2026-11-16 0:34 ` [PATCH] x25: defer socket cleanup on link termination to process context Shuai Liu
2 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2026-10-14 11:14 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: inconsistent lock state in x25_kill_by_neigh (2)
Author: neganhat@gmail.com
#syz test: upstream 24a19b953e2a
^ permalink raw reply [flat|nested] 5+ messages in thread
* Forwarded: inconsistent lock state in x25_kill_by_neigh (2)
2026-10-11 0:03 [syzbot] [x25?] inconsistent lock state in x25_kill_by_neigh (2) syzbot
2026-10-14 11:14 ` Forwarded: " syzbot
@ 2026-10-14 11:15 ` syzbot
2026-11-16 0:34 ` [PATCH] x25: defer socket cleanup on link termination to process context Shuai Liu
2 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2026-10-14 11:15 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: inconsistent lock state in x25_kill_by_neigh (2)
Author: neganhat@gmail.com
#syz test: upstream 24a19b953e2a
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] x25: defer socket cleanup on link termination to process context
2026-10-11 0:03 [syzbot] [x25?] inconsistent lock state in x25_kill_by_neigh (2) syzbot
2026-10-14 11:14 ` Forwarded: " syzbot
2026-10-14 11:15 ` syzbot
@ 2026-11-16 0:34 ` Shuai Liu
2026-11-18 18:35 ` netdev-bot+sashiko
2 siblings, 1 reply; 5+ messages in thread
From: Shuai Liu @ 2026-11-16 0:34 UTC (permalink / raw)
To: ms, linux-x25
Cc: netdev, davem, kuba, edumazet, pabeni, horms,
syzbot+300375dfd44665f063a6, linux-kernel, 847807867
x25_kill_by_neigh() walks all sockets bound to a neighbour and calls
lock_sock() and x25_disconnect() on each one. It is invoked from
x25_link_terminated() and x25_link_control(), which both run in softirq
context when the LAPB link goes down or a restart frame arrives, e.g.
from the lapbether NAPI poll path.
lock_sock() takes a mutex in its slow path, so calling it from softirq
sleeps in atomic context:
BUG: sleeping function called from invalid context at net/core/sock.c:3839
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 14, name: ksoftirqd/0
...
lock_sock_nested+0x66/0x70
x25_kill_by_neigh+0x90/0x110
x25_link_terminated+0x18/0x50
x25_lapb_receive_frame+0x1c2/0x1f0
and lockdep flags the sk_lock-AF_X25 usage violation because the same
lock is registered in process context by x25_bind():
WARNING: inconsistent lock state
inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
ksoftirqd/0/14 [HC0[0]:SC1[1]:HE1:SE0] takes:
...
x25_kill_by_neigh+0x90/0x110
x25_link_terminated+0x18/0x50
x25_lapb_receive_frame+0x1c2/0x1f0
Defer the neighbour socket cleanup to a per-neighbour work item so it
always runs in process context. The work holds a reference on the
neighbour so the deferred cleanup cannot race with neighbour teardown.
x25_kill_by_neigh() is idempotent, so repeated scheduling is harmless.
Reported-by: syzbot+300375dfd44665f063a6@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=300375dfd44665f063a6
Signed-off-by: Shuai Liu <847807867@qq.com>
---
include/net/x25.h | 2 ++
net/x25/x25_link.c | 18 +++++++++++++++---
2 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/include/net/x25.h b/include/net/x25.h
index 414f3fd993454..cb51be81351b8 100644
--- a/include/net/x25.h
+++ b/include/net/x25.h
@@ -13,6 +13,7 @@
#include <linux/x25.h>
#include <linux/slab.h>
#include <linux/refcount.h>
+#include <linux/workqueue.h>
#include <net/sock.h>
#define X25_ADDR_LEN 16
@@ -143,6 +144,7 @@ struct x25_neigh {
struct sk_buff_head queue;
unsigned long t20;
struct timer_list t20timer;
+ struct work_struct kill_work;
unsigned long global_facil_mask;
refcount_t refcnt;
};
diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c
index d1e8cd81c2143..150ccd78cba64 100644
--- a/net/x25/x25_link.c
+++ b/net/x25/x25_link.c
@@ -58,6 +58,14 @@ static inline void x25_stop_t20timer(struct x25_neigh *nb)
timer_delete(&nb->t20timer);
}
+static void x25_kill_by_neigh_work(struct work_struct *work)
+{
+ struct x25_neigh *nb = container_of(work, struct x25_neigh, kill_work);
+
+ x25_kill_by_neigh(nb);
+ x25_neigh_put(nb);
+}
+
/*
* This handles all restart and diagnostic frames.
*/
@@ -82,7 +90,8 @@ void x25_link_control(struct sk_buff *skb, struct x25_neigh *nb,
break;
case X25_LINK_STATE_3:
/* clear existing virtual calls */
- x25_kill_by_neigh(nb);
+ x25_neigh_hold(nb);
+ schedule_work(&nb->kill_work);
x25_transmit_restart_confirmation(nb);
break;
@@ -97,7 +106,8 @@ void x25_link_control(struct sk_buff *skb, struct x25_neigh *nb,
break;
case X25_LINK_STATE_3:
/* clear existing virtual calls */
- x25_kill_by_neigh(nb);
+ x25_neigh_hold(nb);
+ schedule_work(&nb->kill_work);
x25_transmit_restart_request(nb);
nb->state = X25_LINK_STATE_2;
@@ -254,7 +264,8 @@ void x25_link_terminated(struct x25_neigh *nb)
x25_stop_t20timer(nb);
/* Out of order: clear existing virtual calls (X.25 03/93 4.6.3) */
- x25_kill_by_neigh(nb);
+ x25_neigh_hold(nb);
+ schedule_work(&nb->kill_work);
}
/*
@@ -269,6 +280,7 @@ void x25_link_device_up(struct net_device *dev)
skb_queue_head_init(&nb->queue);
timer_setup(&nb->t20timer, x25_t20timer_expiry, 0);
+ INIT_WORK(&nb->kill_work, x25_kill_by_neigh_work);
dev_hold(dev);
nb->dev = dev;
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x25: defer socket cleanup on link termination to process context
2026-11-16 0:34 ` [PATCH] x25: defer socket cleanup on link termination to process context Shuai Liu
@ 2026-11-18 18:35 ` netdev-bot+sashiko
0 siblings, 0 replies; 5+ messages in thread
From: netdev-bot+sashiko @ 2026-11-18 18:35 UTC (permalink / raw)
To: 847807867
Cc: ms, linux-x25, netdev, davem, kuba, edumazet, pabeni, horms,
syzbot+300375dfd44665f063a6, linux-kernel
Thank you for your contribution! Sashiko AI review found 5 potential
issue(s) to consider.
Critical: 0 · High: 3 · Medium: 1 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [High] Each of the three new deferral sites calls x25_neigh_hold(nb)
and then schedule_work(&nb->kill_work) without checking what…
- [High] The patch adds nb->kill_work.
- [High] Device deletion now leaves a window in which X.25 sockets can
transmit on a freed net_device.
- [Medium] Moving x25_kill_by_neigh() into a worker changes the X.25
restart and out-of-order handling.
- [Low] The commit fixes a real bug reported by syzbot (sleeping in
atomic context and an inconsistent lockdep state in…
--
x25: defer socket cleanup on link termination to process context
This commit moves the x25_kill_by_neigh() calls in x25_link_control() and
x25_link_terminated() into a per-neighbour work item, so that lock_sock()
runs in process context. Each call site takes a reference on the
neighbour, and the work item drops it once it has run.
Closes: https://syzkaller.appspot.com/bug?extid=300375dfd44665f063a6
> Reported-by: syzbot+300375dfd44665f063a6@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=300375dfd44665f063a6
> Signed-off-by: Shuai Liu <847807867@qq.com>
[Severity: Low]
This isn't a bug, but should this have a Fixes: tag and a Cc: stable?
The lock_sock()/release_sock() calls in x25_kill_by_neigh() were added by
commit 7781607938c8 ("net/x25: Fix null-ptr-deref caused by
x25_disconnect").
The later commit 5499e0602d2f ("net/x25: fix use-after-free in
x25_kill_by_neigh()") has Fixes: 7781607938c8 and Cc: stable, so the
stable trees contain the sleeping code too.
> diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c
> index d1e8cd81c2143..150ccd78cba64 100644
> --- a/net/x25/x25_link.c
> +++ b/net/x25/x25_link.c
[ ... ]
> @@ -82,7 +90,8 @@ void x25_link_control(struct sk_buff *skb, struct x25_neigh *nb,
> break;
> case X25_LINK_STATE_3:
> /* clear existing virtual calls */
> - x25_kill_by_neigh(nb);
> + x25_neigh_hold(nb);
> + schedule_work(&nb->kill_work);
[Severity: High]
What happens to the reference from x25_neigh_hold() when kill_work is
already pending? In that case schedule_work() returns false and does not
queue the item again. x25_kill_by_neigh_work() still drops only one
reference per run:
static void x25_kill_by_neigh_work(struct work_struct *work)
{
...
x25_kill_by_neigh(nb);
x25_neigh_put(nb);
}
So each extra hold leaks a reference on nb. Once __x25_remove_neigh()
drops the list's reference, the refcount never reaches zero and nb is
never kfree()'d.
In X25_LINK_STATE_3, a RESTART_REQUEST leaves nb->state at STATE_3. A
remote peer that sends several restart requests before the worker runs
would therefore leak one reference per request.
Locally, the same happens when x25_link_terminated() runs twice before
the worker does. Examples are NETDEV_CHANGE with carrier off followed by
NETDEV_DOWN, or X25_IFACE_DISCONNECT followed by NETDEV_DOWN.
The commit message says "x25_kill_by_neigh() is idempotent, so repeated
scheduling is harmless". That holds for the cleanup itself, but does it
hold for the reference counting?
Would something like this work at all three call sites?
x25_neigh_hold(nb);
if (!schedule_work(&nb->kill_work))
x25_neigh_put(nb);
Every caller still holds its own reference from x25_get_neigh(), so that
put cannot free nb.
The RESTART_CONFIRMATION case and x25_link_terminated() below have the
same pattern.
>
> x25_transmit_restart_confirmation(nb);
> break;
[Severity: Medium]
Does deferring the clear change the restart semantics here? Before this
patch, the existing virtual calls were cleared before the restart
confirmation went out.
Now the confirmation goes out and nb->state stays at STATE_3. The stale
sockets are still in X25_STATE_3 with neighbour == nb.
x25_kill_by_neigh() matches only on the neighbour:
sk_for_each(s, &x25_list) {
if (x25_sk(s)->neighbour == nb) {
Calls set up after the restart, through x25_receive_data() ->
x25_rx_call_request() or a local x25_connect(), also have neighbour ==
nb. Would they get disconnected with ENETUNREACH when the worker finally
runs?
Until the worker runs, x25_find_socket(lci, nb) in x25_receive_data()
also keeps delivering post-restart frames to the stale sockets. That
includes a CALL_REQUEST that reuses a stale LCI, which would go to
x25_process_rx_frame() instead of x25_rx_call_request().
After x25_link_terminated() sets nb->state = X25_LINK_STATE_0, the stale
sockets can still transmit. This can happen through x25_sendmsg() ->
x25_kick(), or through the heartbeat and T2 timers via
x25_write_internal().
In STATE_0, x25_transmit_link() queues the skb on nb->queue and calls
x25_establish_link(). Could stale traffic bring a just-terminated link
back up? Those frames would then be flushed by the
nb->state == X25_LINK_STATE_3 loop at the end of x25_link_control().
The NETDEV_DOWN and NETDEV_CHANGE callers in x25_device_event() already
run in process context and didn't need deferral, but they lose their
synchronous cleanup too.
The "clear existing virtual calls" and "X.25 03/93 4.6.3" comments also
no longer match what the code does.
[ ... ]
> @@ -254,7 +264,8 @@ void x25_link_terminated(struct x25_neigh *nb)
> x25_stop_t20timer(nb);
>
> /* Out of order: clear existing virtual calls (X.25 03/93 4.6.3) */
> - x25_kill_by_neigh(nb);
> + x25_neigh_hold(nb);
> + schedule_work(&nb->kill_work);
> }
[Severity: High]
Can this lead to a use-after-free of the net_device when the device is
unregistered? unregister_netdevice() -> dev_close() sends NETDEV_DOWN,
and NETDEV_UNREGISTER follows under RTNL:
x25_device_event()
NETDEV_DOWN
x25_link_terminated(nb)
nb->state = X25_LINK_STATE_0
schedule_work(&nb->kill_work) <- sockets not cleared yet
NETDEV_UNREGISTER
x25_link_device_down(dev)
__x25_remove_neigh(nb)
dev_put(dev)
x25 sockets hold a reference on nb but not on nb->dev. Once the netdev
is freed, nb->dev dangles.
Before this patch, NETDEV_DOWN had already disconnected the sockets
(neighbour = NULL, state = X25_STATE_0). Now, until the worker runs, a
connected socket still has x25->state == X25_STATE_3 and
x25->neighbour == nb:
x25_sendmsg()
x25_kick()
x25_transmit_link(skb, nb) <- nb->state == STATE_0
x25_establish_link(nb)
switch (nb->dev->type)
...
skb->dev = nb->dev;
dev_queue_xmit(skb);
The heartbeat (x25_check_rbuf()) and the T2 timer
(x25_enquiry_response()) reach the same path through
x25_write_internal().
The worker also passes the stale nb->dev to x25_clear_forward_by_dev().
That function compares raw pointers, so it could match a new device
allocated at the same address.
Would it be better to keep the NETDEV_DOWN teardown synchronous, since it
runs in process context? Or at least flush or cancel kill_work and keep
the device pinned until the work has run?
>
> /*
> @@ -269,6 +280,7 @@ void x25_link_device_up(struct net_device *dev)
>
> skb_queue_head_init(&nb->queue);
> timer_setup(&nb->t20timer, x25_t20timer_expiry, 0);
> + INIT_WORK(&nb->kill_work, x25_kill_by_neigh_work);
[Severity: High]
Does anything cancel or flush kill_work on teardown? x25_exit(),
x25_link_free() and x25_link_device_down() never call cancel_work_sync()
or flush_work(). A pending work item does not pin the module.
With no X.25 sockets open, "ip link set <x25dev> down" (NETDEV_DOWN ->
x25_link_terminated() -> schedule_work()) followed right away by
"rmmod x25" is allowed.
x25_exit() -> x25_link_free() then drops the list references. nb stays
allocated because the work holds a reference. However, the module text
and data are freed before system_percpu_wq runs the item. That covers
x25_kill_by_neigh_work(), x25_list_lock, x25_list and x25_forward_list.
There is also an ordering question in x25_exit():
x25_proc_exit();
x25_link_free();
x25_route_free();
...
unregister_netdevice_notifier(&x25_dev_notifier);
dev_remove_pack(&x25_packet_type);
A receive or notifier call that is already in progress, holding an nb
from x25_get_neigh(), could still queue kill_work after x25_link_free().
Would a dedicated workqueue cover this, destroyed at the end of
x25_exit() after packet reception and the notifier have been shut down?
>
> dev_hold(dev);
> nb->dev = dev;
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/tencent_F7C2DC0FA42B5866E5C39A9E70D3C52C2609%40qq.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-18 18:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-11 0:03 [syzbot] [x25?] inconsistent lock state in x25_kill_by_neigh (2) syzbot
2026-10-14 11:14 ` Forwarded: " syzbot
2026-10-14 11:15 ` syzbot
2026-11-16 0:34 ` [PATCH] x25: defer socket cleanup on link termination to process context Shuai Liu
2026-11-18 18:35 ` netdev-bot+sashiko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®