From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: alim.akhtar@samsung.com, bhelgaas@google.com,
jingoohan1@gmail.com, krzk@kernel.org, kwilczynski@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, lpieralisi@kernel.org,
mani@kernel.org, peter.griffin@linaro.org, robh@kernel.org
Subject: Re: [PATCH v9] PCI: exynos: Handle PCIe PHY initialization errors
Date: Thu, 19 Nov 2026 11:52:53 +0100 [thread overview]
Message-ID: <179508557305.20612.514486261245057380.b4-reply@b4> (raw)
In-Reply-To: <20261031094911.3304-1-sreekuttan2156239@gmail.com>
On 2026-10-31 09:49 +0000, Sreeraj S Kurup wrote:
> Check the return values of phy_init() and phy_power_on() to avoid
> continuing PCIe host initialization when PHY setup fails.
>
> Track PHY initialization, PHY power, and regulator enable state
> across probe, remove, suspend, and resume to ensure cleanup is
> performed only when appropriate and to prevent unbalanced
> reference counts.
>
> Assert core reset on probe failure after PHY initialization has
> been reached, and handle cleanup errors during teardown and
> suspend.
>
> Also check the return value of exynos_pcie_host_init() during
> resume and abort the resume sequence if PHY initialization fails.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
NACK.
First of all, you are sending each version as a reply to the previous one, which
is not recommended.
Second, you just ended up fixing all Sashiko reported issues without cross
checking whether they are really valid or not and the patch just became noise
now. For instance, this phy_init() can never fail on the only platform supported
by this driver and there is no PHY power_on() callback (idk why phy_power_on()
exists in the first place). So all the error handling you added for these APIs
are dead code.
So please, do not blindly fix all the issues reported by Sashiko. Do your own
homework!
- Mani
prev parent reply other threads:[~2026-11-19 10:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 13:10 [PATCH] PCI: exynos: Handle " Sreeraj S Kurup
2026-10-29 17:54 ` [PATCH v2] PCI: exynos: Handle PCIe " Sreeraj S Kurup
2026-10-30 15:17 ` [PATCH v3] " Sreeraj S Kurup
2026-10-30 16:36 ` [PATCH v4] " Sreeraj S Kurup
2026-10-30 17:23 ` [PATCH v5] " Sreeraj S Kurup
2026-10-30 18:09 ` [PATCH v6] " Sreeraj S Kurup
2026-10-31 7:01 ` [PATCH v7] " Sreeraj S Kurup
2026-10-31 7:35 ` [PATCH v8] " Sreeraj S Kurup
2026-11-19 12:10 ` Krzysztof Kozlowski
2026-10-31 9:49 ` [PATCH v9] " Sreeraj S Kurup
2026-11-19 10:52 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179508557305.20612.514486261245057380.b4-reply@b4 \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=alim.akhtar@samsung.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=krzk@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=sreekuttan2156239@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®