* [PATCH] rtnetlink: fix NULL pointer dereference in rtnl_get_link()
@ 2026-11-20 13:45 mdshahid03
2026-11-20 13:49 ` netdev-bot+sinfo
0 siblings, 1 reply; 2+ messages in thread
From: mdshahid03 @ 2026-11-20 13:45 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni; +Cc: netdev, linux-kernel, Mohammad Shahid
From: Mohammad Shahid <mdshahid03@gmail.com>
The rtnl_get_link() function falls back to the PF_UNSPEC
handler table when no handler table is registered for the
requested protocol.
However, the fallback table can also be NULL,for example
after rtnl_unregister_all(PF_UNSPEC) clears it.
In that cass, dereferencing tab[msgtyp] results in a NULL
pointer dereference.
Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
---
net/core/rtnetlink.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index e141340172ce..b552cbf17d76 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -406,6 +406,9 @@ static struct rtnl_link *rtnl_get_link(int protocol, int msgtype)
if (!tab)
tab = rcu_dereference_rtnl(rtnl_msg_handlers[PF_UNSPEC]);
+ if (!tab)
+ return NULL;
+
return rcu_dereference_rtnl(tab[msgtype]);
}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rtnetlink: fix NULL pointer dereference in rtnl_get_link()
2026-11-20 13:45 [PATCH] rtnetlink: fix NULL pointer dereference in rtnl_get_link() mdshahid03
@ 2026-11-20 13:49 ` netdev-bot+sinfo
0 siblings, 0 replies; 2+ messages in thread
From: netdev-bot+sinfo @ 2026-11-20 13:49 UTC (permalink / raw)
To: mdshahid03; +Cc: davem, edumazet, kuba, pabeni, netdev, linux-kernel
Hi!
This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:
- How the issue was discovered, e.g. hit in production, hit during
development, syzbot report, manual code inspection, LLM or static
analysis tool scan.
- Whether the issue was actually triggered, or is only theoretical
(e.g. found by LLM and not proven at runtime). If it was triggered
please include the symptoms, like the stack trace or kernel messages.
Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account.
*IMPORTANT*: If you do repost (for other reasons) - please include
the relevant info in the cover letter or commit messages.
--
The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-20 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20 13:45 [PATCH] rtnetlink: fix NULL pointer dereference in rtnl_get_link() mdshahid03
2026-11-20 13:49 ` netdev-bot+sinfo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®