mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v6 0/3] nvme-multipath: requeue work fixes
@ 2026-11-20  1:25 Qiliang Yuan
  2026-11-20  1:25 ` [PATCH v6 1/3] nvme-multipath: keep a large delayed_removal_secs from wrapping around Qiliang Yuan
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Qiliang Yuan @ 2026-11-20  1:25 UTC (permalink / raw)
  To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
	Nilay Shroff, Hannes Reinecke
  Cc: linux-nvme, linux-kernel, Qiliang Yuan, Hannes Reinecke

Patch 1 keeps a large delayed_removal_secs from wrapping around into a
short delay when it is converted to jiffies.

Patch 2 applies a new delayed_removal_secs to a head removal that is
already pending, so that clearing it fails the I/O queued without a
usable path right away instead of when the old delay expires.

Patch 3 stops nvme_mpath_set_live() from waiting for an SRCU grace
period per namespace, which makes an ANA change with many namespaces
take tens to hundreds of milliseconds.

Signed-off-by: Qiliang Yuan <qiliang.yuan@linux.dev>
---
V5 -> V6:
- Add patch 1: compute the delayed head removal in 64 bits and cap it
  at MAX_JIFFY_OFFSET, so that a large delayed_removal_secs doesn't
  wrap around (Sashiko)
- Patch 2: kick requeue_work when delayed_removal_secs is cleared, so
  that queued bios also fail when paths remain but none is usable, and
  use the capped delay of patch 1 (Sashiko)
- Patch 2: keep Nilay's Reviewed-by, as only these two changes are new
- Update the numbers of patch 2 from a new run

V4 -> V5:
- Cancel the pending head removal under subsys->lock in
  nvme_init_ns_head() and drop the list_empty() check and module_put()
  from delayed_removal_secs_store() (Nilay Shroff)
- Rebase onto v7.4-rc3-230-g4405c18c95d2 and update the numbers of
  patch 1 from a new run

V3 -> V4:
- Don't requeue the head removal in patch 1 if a path came back before
  nvme_init_ns_head() cancelled it, drop the module reference it held
  instead (race reported by Sashiko)
- Rebase onto v7.4-rc3-178-g20eef29b7c84 and update the numbers of
  patch 1 from a new run

V2 -> V3:
- Requeue a pending head removal with the new delayed_removal_secs
  instead of only kicking the requeue work when it is cleared
- Rebase onto v7.4-rc2-470-g7e1392a42ea2 and update the numbers from a
  new run
- Don't carry Hannes's Reviewed-by on the v2 patch 1, which is rewritten

V1 -> V2:
- Add patch 1
- Take the SRCU cookie under head->lock in patch 2 (Sashiko)
- Rerun the tests

v5: https://lore.kernel.org/r/20261119-bug-nvme-mpath-set-live-srcu-v5-0-e1483e2e447f@linux.dev
v4: https://lore.kernel.org/r/20261118-bug-nvme-mpath-set-live-srcu-v4-0-21f368376c8c@linux.dev
v3: https://lore.kernel.org/r/20261114-bug-nvme-mpath-set-live-srcu-v3-0-d84651de6334@linux.dev
v2: https://lore.kernel.org/r/20261111-bug-nvme-mpath-set-live-srcu-v2-0-fc772914d293@linux.dev
v1: https://lore.kernel.org/r/20261110-bug-nvme-mpath-set-live-srcu-v1-1-1f58b405b0f8@linux.dev

---
Qiliang Yuan (3):
      nvme-multipath: keep a large delayed_removal_secs from wrapping around
      nvme-multipath: apply delayed_removal_secs changes to a pending removal
      nvme-multipath: don't wait for a grace period in nvme_mpath_set_live()

 drivers/nvme/host/core.c      |  7 +++++--
 drivers/nvme/host/multipath.c | 37 +++++++++++++++++++++++++++++++++++--
 drivers/nvme/host/nvme.h      |  1 +
 3 files changed, 41 insertions(+), 4 deletions(-)
---
base-commit: 4405c18c95d2d0f99f6c581ef0ee8591a1aa6ccd
change-id: 20261110-bug-nvme-mpath-set-live-srcu-cbd8965f1457

Best regards,
-- 
Qiliang Yuan <qiliang.yuan@linux.dev>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-20 19:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20  1:25 [PATCH v6 0/3] nvme-multipath: requeue work fixes Qiliang Yuan
2026-11-20  1:25 ` [PATCH v6 1/3] nvme-multipath: keep a large delayed_removal_secs from wrapping around Qiliang Yuan
2026-11-20 17:35   ` Nilay Shroff
2026-11-20  1:25 ` [PATCH v6 2/3] nvme-multipath: apply delayed_removal_secs changes to a pending removal Qiliang Yuan
2026-11-20  1:25 ` [PATCH v6 3/3] nvme-multipath: don't wait for a grace period in nvme_mpath_set_live() Qiliang Yuan
2026-11-20 19:54 ` [PATCH v6 0/3] nvme-multipath: requeue work fixes Keith Busch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®