* [PATCH net] net/mlx5: E-Switch, skip vport change work for disabled vports
@ 2026-11-18 16:51 Tariq Toukan
2026-11-21 23:44 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Tariq Toukan @ 2026-11-18 16:51 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
netdev, Paolo Abeni
Cc: Gal Pressman, Leon Romanovsky, open list, linux-rdma, Mark Bloch,
Parav Pandit, Roi Dayan, Saeed Mahameed, Shay Drory,
Tariq Toukan, Uri Dar, Vu Pham
From: Uri Dar <udar@nvidia.com>
A vport change work can still be pending when its vport is disabled.
For an SF, the vport is then freed in FW and the work's query fails
with syndrome 0x29d722. A disabled vport has nothing to sync, so skip
the work.
Fixes: d970812b91d0 ("net/mlx5: E-switch, Add eswitch helpers for SF vport")
Signed-off-by: Uri Dar <udar@nvidia.com>
Reviewed-by: Shay Drory <shayd@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
index 76f808e06a88..174197f69888 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
@@ -758,7 +758,8 @@ static void esw_vport_change_handler(struct work_struct *work)
struct mlx5_eswitch *esw = vport->dev->priv.eswitch;
mutex_lock(&esw->state_lock);
- esw_vport_change_handle_locked(vport);
+ if (vport->enabled)
+ esw_vport_change_handle_locked(vport);
mutex_unlock(&esw->state_lock);
}
base-commit: aa40afa831ebfe45e40a23721711059f2ac584d4
--
2.44.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] net/mlx5: E-Switch, skip vport change work for disabled vports
2026-11-18 16:51 [PATCH net] net/mlx5: E-Switch, skip vport change work for disabled vports Tariq Toukan
@ 2026-11-21 23:44 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-11-21 23:44 UTC (permalink / raw)
To: Tariq Toukan
Cc: andrew+netdev, davem, edumazet, kuba, netdev, pabeni, gal, leon,
linux-kernel, linux-rdma, mbloch, parav, roid, saeedm, shayd,
udar, vuhuong
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 18 Nov 2026 18:51:55 +0200 you wrote:
> From: Uri Dar <udar@nvidia.com>
>
> A vport change work can still be pending when its vport is disabled.
> For an SF, the vport is then freed in FW and the work's query fails
> with syndrome 0x29d722. A disabled vport has nothing to sync, so skip
> the work.
>
> [...]
Here is the summary with links:
- [net] net/mlx5: E-Switch, skip vport change work for disabled vports
https://git.kernel.org/netdev/net/c/890f23ba87a7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-21 23:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 16:51 [PATCH net] net/mlx5: E-Switch, skip vport change work for disabled vports Tariq Toukan
2026-11-21 23:44 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®