mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kyuwon Cho <kyuwoncho18@gmail.com>
To: netdev@vger.kernel.org
Cc: Jay Vosburgh <jv@jvosburgh.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Hangbin Liu <hangbin.liu@linux.dev>,
	linux-kernel@vger.kernel.org
Subject: [PATCH net v3 0/2] bonding: keep non-Ethernet slaves out of 802.3ad bonds
Date: Sun, 22 Nov 2026 23:59:08 +0900	[thread overview]
Message-ID: <179535729502.2645501.5219010464870440@gmail.com> (raw)

bond_open() adds the 8-byte lacpdu_mcast_addr to every slave of an
802.3ad bond, so a slave whose addr_len is 16, such as an ip6tnl device,
makes dev_mc_add() read past it. Patch 1 rejects such a slave at enslave
time in every case; patch 2 stops an enslaved bond from changing its
type afterwards.

The issue was found by an LLM-guided test generator that we are
developing as a research prototype.

v3:
- Add patch 2: as the Sashiko review of v1 pointed out, a bond enslaved
  to an 802.3ad bond could still change its type.
- Patch 1 is unchanged; its tags are kept.
- Hangbin asked on v2 whether the bond type should be reset when the
  mode is set to 802.3ad; as answered there, the first Ethernet slave
  resets it, so this series leaves it alone.
v2: https://lore.kernel.org/netdev/179505868590.3571070.12381528230330714812@gmail.com/
- Move the check above the type handling, as Jay suggested.
v1: https://lore.kernel.org/netdev/179500849159.1877154.14715369660816392826@gmail.com/

The patches were written with LLM assistance; we reviewed and tested
them. With them, neither the direct nor the nested reproducer triggers
the report. Enslaving Ethernet devices into an 802.3ad bond, a
non-Ethernet device into an active-backup bond, and the type change of
a bond enslaved to a balance-rr bond, as in bond-eth-type-change.sh,
work as before.

Kyuwon Cho (2):
  bonding: reject a non-Ethernet 802.3ad slave even when the type
    matches
  bonding: don't let an 802.3ad slave change its type

 drivers/net/bonding/bond_main.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-11-22 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 14:59 Kyuwon Cho [this message]
2026-11-22 14:59 ` [PATCH net v3 1/2] bonding: reject a non-Ethernet 802.3ad slave even when the type matches Kyuwon Cho
2026-11-22 14:59 ` [PATCH net v3 2/2] bonding: don't let an 802.3ad slave change its type Kyuwon Cho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179535729502.2645501.5219010464870440@gmail.com \
    --to=kyuwoncho18@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hangbin.liu@linux.dev \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®