From: Kyuwon Cho <kyuwoncho18@gmail.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Hangbin Liu <hangbin.liu@linux.dev>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] bonding: reject a non-Ethernet 802.3ad slave even when the type matches
Date: Sun, 22 Nov 2026 06:59:05 -0800 (PST) [thread overview]
Message-ID: <179535949326.2658908.10317801004319925337@gmail.com> (raw)
In-Reply-To: <179535255333.3135.10581087211469618015@kernel.org>
On Sun, 22 Nov 2026 13:02:33 +0000, netdev-bot+sashiko@kernel.org wrote:
> [Severity: High]
> Is this check enough to keep a non-Ethernet slave out of an 802.3ad bond?
> It only looks at the slave's type when the slave is enslaved. A slave that
> is itself a bond can still change type after that.
The issue is real: the nested case gives the same KASAN report in
bond_open(), also with v2 applied. v3 adds a second patch that refuses
NETDEV_PRE_TYPE_CHANGE for a slave of an 802.3ad bond, as team does for
its ports; other modes still allow it, as bond-eth-type-change.sh
expects.
Kyuwon Cho
pw-bot: cr
prev parent reply other threads:[~2026-11-22 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:38 Kyuwon Cho
2026-11-18 19:37 ` Jay Vosburgh
2026-11-22 13:02 ` netdev-bot+sashiko
2026-11-22 14:59 ` Kyuwon Cho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179535949326.2658908.10317801004319925337@gmail.com \
--to=kyuwoncho18@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hangbin.liu@linux.dev \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®