mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v4 0/3] ACPI: PMIC: a small refactoring
Date: Fri, 7 Jun 2024 11:05:51 +0200	[thread overview]
Message-ID: <179d5111-5cc8-4a17-b735-84f02e0144f5@redhat.com> (raw)
In-Reply-To: <20240606205712.3187675-1-andriy.shevchenko@linux.intel.com>

Hi,

On 6/6/24 10:54 PM, Andy Shevchenko wrote:
> Use sizeof(), dev_err()/dev_warn(), and regmap bulk read
> where it makes sense.
> 
> In v4:
> - dropped controversial changes (Hans)

Thanks, the whole series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans




> 
> Andy Shevchenko (3):
>   ACPI: PMIC: Use sizeof() instead of hard coded value
>   ACPI: PMIC: Convert pr_*() to dev_*() printing macros
>   ACPI: PMIC: Replace open coded be16_to_cpu()
> 
>  drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 13 ++++++++-----
>  drivers/acpi/pmic/intel_pmic_chtwc.c    |  5 +++--
>  drivers/acpi/pmic/intel_pmic_xpower.c   |  7 ++++---
>  3 files changed, 15 insertions(+), 10 deletions(-)
> 


  parent reply	other threads:[~2024-06-07  9:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06 20:54 Andy Shevchenko
2024-06-06 20:54 ` [PATCH v4 1/3] ACPI: PMIC: Use sizeof() instead of hard coded value Andy Shevchenko
2024-06-06 20:54 ` [PATCH v4 2/3] ACPI: PMIC: Convert pr_*() to dev_*() printing macros Andy Shevchenko
2024-06-06 20:54 ` [PATCH v4 3/3] ACPI: PMIC: Replace open coded be16_to_cpu() Andy Shevchenko
2024-06-07  9:05 ` Hans de Goede [this message]
2024-06-13 19:21   ` [PATCH v4 0/3] ACPI: PMIC: a small refactoring Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179d5111-5cc8-4a17-b735-84f02e0144f5@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®