From: Joe Perches <joe@perches.com>
To: Shawn Landden <shawn@git.icu>, linux-kernel@vger.kernel.org
Cc: "Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] Use fall-through attribute rather than magic comments
Date: Sat, 16 Mar 2019 01:08:04 -0700 [thread overview]
Message-ID: <17a4be1ffdaf908ff02a51bf8dea707117067f9b.camel@perches.com> (raw)
In-Reply-To: <20190316033841.7659-1-shawn@git.icu>
On Fri, 2019-03-15 at 21:38 -0600, Shawn Landden wrote:
> The -Wimplicit-fallthrough warning recognizes magic comments
> https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
> It is my opinion that magic comments are a bad idea. Comments should not
> change the interpretation (even regarding errors) of C code.
> (It also happens to break distcc as distcc compiles pre-processed .i files.)
>
> I am aware this can cause some merge pain.
>
> Also, if my style is OK, then needs some changes to checkpatch.pl. (CCed)
I think it's a pretty good idea
https://lkml.org/lkml/2017/2/10/485
It's generally better to add a patch first to the include
file and then conversion patches by subsystem instead of one
gigantic patch spanning multiple subsystems.
Or send a script that does the conversion.
next prev parent reply other threads:[~2019-03-16 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 3:38 Shawn Landden
2019-03-16 8:08 ` Joe Perches [this message]
2019-03-16 21:42 ` Gustavo A. R. Silva
2019-03-18 12:22 ` kbuild test robot
2019-03-18 12:30 ` kbuild test robot
2019-03-19 10:34 ` kbuild test robot
2019-03-19 10:34 ` [PATCH] fix semicolon.cocci warnings kbuild test robot
2019-06-17 15:56 ` [PATCH] Use fall-through attribute rather than magic comments Pavel Machek
2019-06-17 16:25 ` Joe Perches
2019-06-17 16:41 ` David Laight
2019-06-18 7:34 ` Pavel Machek
2019-06-18 9:30 ` Joe Perches
2019-06-18 10:45 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17a4be1ffdaf908ff02a51bf8dea707117067f9b.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn@git.icu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®