mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Pavel Machek <pavel@ucw.cz>, Shawn Landden <shawn@git.icu>
Cc: linux-kernel@vger.kernel.org,
	"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
	Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] Use fall-through attribute rather than magic comments
Date: Mon, 17 Jun 2019 09:25:56 -0700	[thread overview]
Message-ID: <45e070039e66b1cb1490a78d4805bc73cc09f571.camel@perches.com> (raw)
In-Reply-To: <20190617155643.GA32544@amd>

On Mon, 2019-06-17 at 17:56 +0200, Pavel Machek wrote:
> Hi!
> 
> > +/*
> > + *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough
> > + *   gcc: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
> > + */
> > +#if __has_attribute(__fallthrough__)
> > +# define __fallthrough                    __attribute__((__fallthrough__))
> > +#else
> > +# define __fallthrough
> > +#endif
> 
> Is it good idea to add the __'s ? They look kind of ugly. 

Dunno.

I agree it's kind of ugly, but it should always work.

I think the generic problem is introducing a new unprefixed
reserved identifier.  Underscored identifiers are reserved.

There is already a fallthrough: label used in kernel sources
in net/sctp/sm_make_chunk.c that should probably be changed.


  reply	other threads:[~2019-06-17 16:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16  3:38 Shawn Landden
2019-03-16  8:08 ` Joe Perches
2019-03-16 21:42 ` Gustavo A. R. Silva
2019-03-18 12:22 ` kbuild test robot
2019-03-18 12:30 ` kbuild test robot
2019-03-19 10:34 ` kbuild test robot
2019-03-19 10:34 ` [PATCH] fix semicolon.cocci warnings kbuild test robot
2019-06-17 15:56 ` [PATCH] Use fall-through attribute rather than magic comments Pavel Machek
2019-06-17 16:25   ` Joe Perches [this message]
2019-06-17 16:41     ` David Laight
2019-06-18  7:34     ` Pavel Machek
2019-06-18  9:30       ` Joe Perches
2019-06-18 10:45         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45e070039e66b1cb1490a78d4805bc73cc09f571.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=shawn@git.icu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®