From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Wanpeng Li" <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v8 2/4] KVM: X86: Add Paravirt TLB Shootdown
Date: Wed, 13 Dec 2017 13:33:02 +0100 [thread overview]
Message-ID: <17aebf52-c84c-c12f-1f74-b1b69a67d41f@redhat.com> (raw)
In-Reply-To: <1513128784-5924-3-git-send-email-wanpeng.li@hotmail.com>
On 13/12/2017 02:33, Wanpeng Li wrote:
> @@ -53,6 +54,7 @@ struct kvm_steal_time {
>
> #define KVM_VCPU_NOT_PREEMPTED (0 << 0)
> #define KVM_VCPU_PREEMPTED (1 << 0)
> +#define KVM_VCPU_SHOULD_FLUSH (1 << 1)
>
> #define KVM_CLOCK_PAIRING_WALLCLOCK 0
Two issues with the name:
1) it doesn't say *what* is flushed
2) in the usual meaning of "should", it would be just a recommendation
i.e. it's fine not to flush the TLB. This is not true in this case, so
KVM_VCPU_FLUSH_TLB is better.
Paolo
next prev parent reply other threads:[~2017-12-13 12:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 1:33 [PATCH v8 0/4] " Wanpeng Li
2017-12-13 1:33 ` [PATCH v8 1/4] KVM: X86: Add vCPU running/preempted state Wanpeng Li
2017-12-13 10:20 ` David Hildenbrand
2017-12-13 11:38 ` Wanpeng Li
2017-12-13 11:45 ` David Hildenbrand
2017-12-13 12:31 ` Paolo Bonzini
2017-12-13 1:33 ` [PATCH v8 2/4] KVM: X86: Add Paravirt TLB Shootdown Wanpeng Li
2017-12-13 12:33 ` Paolo Bonzini [this message]
2017-12-13 1:33 ` [PATCH v8 3/4] KVM: X86: introduce invalidate_gpa argument to tlb flush Wanpeng Li
2017-12-13 13:35 ` Peter Zijlstra
2017-12-13 1:33 ` [PATCH v8 4/4] KVM: X86: Add flush_on_enter before guest enter Wanpeng Li
2017-12-13 12:54 ` Peter Zijlstra
2017-12-13 13:32 ` Paolo Bonzini
2017-12-13 13:35 ` Peter Zijlstra
2017-12-13 13:37 ` Paolo Bonzini
2017-12-13 9:42 ` [PATCH v8 0/4] KVM: X86: Add Paravirt TLB Shootdown Wanpeng Li
2017-12-13 12:47 ` Paolo Bonzini
2017-12-13 13:13 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17aebf52-c84c-c12f-1f74-b1b69a67d41f@redhat.com \
--to=pbonzini@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®