From: Peter Zijlstra <peterz@infradead.org>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Wanpeng Li" <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v8 4/4] KVM: X86: Add flush_on_enter before guest enter
Date: Wed, 13 Dec 2017 14:35:54 +0100 [thread overview]
Message-ID: <20171213133554.hy3mocgbpu7rmh3m@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1513128784-5924-5-git-send-email-wanpeng.li@hotmail.com>
On Tue, Dec 12, 2017 at 05:33:04PM -0800, Wanpeng Li wrote:
> + if (xchg(&vcpu->arch.st.steal.preempted, KVM_VCPU_NOT_PREEMPTED) ==
> + (KVM_VCPU_SHOULD_FLUSH | KVM_VCPU_PREEMPTED)) {
> + /*
> + * Do TLB_FLUSH before entering the guest, its passed
> + * the stage of request checking
> + */
> + kvm_vcpu_flush_tlb(vcpu, false);
> + }
And not a single word, _anywhere_ on why this doesn't need
invalidate_gpa or wtf that actually is.
next prev parent reply other threads:[~2017-12-13 13:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 1:33 [PATCH v8 0/4] KVM: X86: Add Paravirt TLB Shootdown Wanpeng Li
2017-12-13 1:33 ` [PATCH v8 1/4] KVM: X86: Add vCPU running/preempted state Wanpeng Li
2017-12-13 10:20 ` David Hildenbrand
2017-12-13 11:38 ` Wanpeng Li
2017-12-13 11:45 ` David Hildenbrand
2017-12-13 12:31 ` Paolo Bonzini
2017-12-13 1:33 ` [PATCH v8 2/4] KVM: X86: Add Paravirt TLB Shootdown Wanpeng Li
2017-12-13 12:33 ` Paolo Bonzini
2017-12-13 1:33 ` [PATCH v8 3/4] KVM: X86: introduce invalidate_gpa argument to tlb flush Wanpeng Li
2017-12-13 13:35 ` Peter Zijlstra
2017-12-13 1:33 ` [PATCH v8 4/4] KVM: X86: Add flush_on_enter before guest enter Wanpeng Li
2017-12-13 12:54 ` Peter Zijlstra
2017-12-13 13:32 ` Paolo Bonzini
2017-12-13 13:35 ` Peter Zijlstra [this message]
2017-12-13 13:37 ` Paolo Bonzini
2017-12-13 9:42 ` [PATCH v8 0/4] KVM: X86: Add Paravirt TLB Shootdown Wanpeng Li
2017-12-13 12:47 ` Paolo Bonzini
2017-12-13 13:13 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213133554.hy3mocgbpu7rmh3m@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®