From: Yisheng Xie <xieyisheng1@huawei.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
David Airlie <airlied@linux.ie>, <ysxie@foxmail.com>,
<dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v3 19/27] drm: replace devm_ioremap_nocache with devm_ioremap
Date: Fri, 12 Jan 2018 17:37:01 +0800 [thread overview]
Message-ID: <17b117da-ef14-b531-2a8f-192a86ed6cd7@huawei.com> (raw)
In-Reply-To: <CA+M3ks79ff=O7hG2yus_Cjvd-hrzRbtrDrTawQdpqfT0JdH8kQ@mail.gmail.com>
Hi Benjamin ,
On 2018/1/9 17:21, Benjamin Gaignard wrote:
> 2017-12-23 12:01 GMT+01:00 Yisheng Xie <xieyisheng1@huawei.com>:
>> > Default ioremap is ioremap_nocache, so devm_ioremap has the same
>> > function with devm_ioremap_nocache, which can just be killed to
>> > save the size of devres.o
> That looks true for arm and arm64 architectures but not, for exemple, for ia64:
> https://elixir.free-electrons.com/linux/v4.15-rc7/source/arch/ia64/mm/ioremap.c
>
> If there is still one architecture doing a difference between cached
> and uncached
> ioremap we can't remove devm_ioremap_nocache...
Right.
>
> This patch only concern arm chipsets so we can apply it but that will
> not help you to
> reduce devres size.
Yes, And sorry for disturb. Please ignore about this patch.
Thanks
Yisheng
>
prev parent reply other threads:[~2018-01-12 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 11:01 Yisheng Xie
2018-01-09 9:21 ` Benjamin Gaignard
2018-01-12 9:37 ` Yisheng Xie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17b117da-ef14-b531-2a8f-192a86ed6cd7@huawei.com \
--to=xieyisheng1@huawei.com \
--cc=airlied@linux.ie \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysxie@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®