From: Sander Speetjens <sander.speetjens@gmail.com>
To: Stefan Wahren <wahrenst@gmx.net>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Eric Anholt <eric@anholt.net>, Stephen Boyd <sboyd@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] firmware: raspberrypi: Store child devices in struct rpi_firmware
Date: Mon, 9 Nov 2026 06:55:48 +0100 [thread overview]
Message-ID: <17b8daee-c5df-4b03-a839-38b5ef3edf3e@gmail.com> (raw)
In-Reply-To: <63ecdac3-f8b3-4d44-9b0a-37346568d326@gmx.net>
Hi Stefan,
On 11/8/26 22:06, Stefan Wahren wrote:
> Hi Sander,
>
> Am 07.11.26 um 19:21 schrieb Sander Speetjens:
>> The hwmon and clock platform devices were kept in global variables.
>> Move them into struct rpi_firmware so each instance owns its own
>> children and their lifetimes are correctly paired with the parent.
>>
>> Also check the return value of platform_device_register_data() so that
>> an error pointer is never stored. The child devices are optional; do
>> not propagate registration failures so the main firmware interface
>> remains available.
>>
>> Signed-off-by: Sander Speetjens <sander.speetjens@gmail.com>
>
> the first version of this patch contained fixes tags, but they were
> dropped without mention it in the cover letter.
I was not 100% sure if the commit needed them. If you say that it is
needed, I will add it again.
Kind regards
Sander Speetjens
prev parent reply other threads:[~2026-11-09 5:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 18:21 [PATCH v2 0/6] firmware: raspberrypi: Style cleanups and fix child device lifetime Sander Speetjens
2026-11-07 18:21 ` [PATCH v2 1/6] firmware: raspberrypi: Add blank line after declaration in response_callback Sander Speetjens
2026-11-07 18:21 ` [PATCH v2 2/6] firmware: raspberrypi: Fix indentation of return statement Sander Speetjens
2026-11-07 18:21 ` [PATCH v2 3/6] firmware: raspberrypi: Add blank line after declaration in probe error path Sander Speetjens
2026-11-07 18:21 ` [PATCH v2 4/6] firmware: raspberrypi: Remove unnecessary braces in transaction helper Sander Speetjens
2026-11-08 21:03 ` Stefan Wahren
2026-11-07 18:21 ` [PATCH v2 5/6] firmware: raspberrypi: Document memory barriers in property list path Sander Speetjens
2026-11-07 18:46 ` Manuel Ebner
2026-11-07 18:21 ` [PATCH v2 6/6] firmware: raspberrypi: Store child devices in struct rpi_firmware Sander Speetjens
2026-11-08 21:06 ` Stefan Wahren
2026-11-09 5:55 ` Sander Speetjens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17b8daee-c5df-4b03-a839-38b5ef3edf3e@gmail.com \
--to=sander.speetjens@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=sboyd@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®