mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: Sander Speetjens <sander.speetjens@gmail.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Eric Anholt <eric@anholt.net>, Stephen Boyd <sboyd@kernel.org>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] firmware: raspberrypi: Remove unnecessary braces in transaction helper
Date: Sun, 8 Nov 2026 22:03:46 +0100	[thread overview]
Message-ID: <2eef459e-da8f-4db9-8e10-2711730d92de@gmx.net> (raw)
In-Reply-To: <20261107-fix-raspberrypi-firmware-v2-4-5bfe605a5cc5@gmail.com>

Hi Sander,

Am 07.11.26 um 19:21 schrieb Sander Speetjens:
> Braces are not needed around the single-statement arms of the
> wait_for_completion_timeout() check.
>
> Signed-off-by: Sander Speetjens <sander.speetjens@gmail.com>

technically there is nothing wrong with this patch, but imho this 
doesn't add any benefit. It makes it harder to backport possible patches 
in future.

Best regards


  reply	other threads:[~2026-11-08 21:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07 18:21 [PATCH v2 0/6] firmware: raspberrypi: Style cleanups and fix child device lifetime Sander Speetjens
2026-11-07 18:21 ` [PATCH v2 1/6] firmware: raspberrypi: Add blank line after declaration in response_callback Sander Speetjens
2026-11-07 18:21 ` [PATCH v2 2/6] firmware: raspberrypi: Fix indentation of return statement Sander Speetjens
2026-11-07 18:21 ` [PATCH v2 3/6] firmware: raspberrypi: Add blank line after declaration in probe error path Sander Speetjens
2026-11-07 18:21 ` [PATCH v2 4/6] firmware: raspberrypi: Remove unnecessary braces in transaction helper Sander Speetjens
2026-11-08 21:03   ` Stefan Wahren [this message]
2026-11-07 18:21 ` [PATCH v2 5/6] firmware: raspberrypi: Document memory barriers in property list path Sander Speetjens
2026-11-07 18:46   ` Manuel Ebner
2026-11-07 18:21 ` [PATCH v2 6/6] firmware: raspberrypi: Store child devices in struct rpi_firmware Sander Speetjens
2026-11-08 21:06   ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2eef459e-da8f-4db9-8e10-2711730d92de@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=eric@anholt.net \
    --cc=florian.fainelli@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenz@kernel.org \
    --cc=sander.speetjens@gmail.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®