From: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
To: Stephan Gerhold <stephan.gerhold@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com,
chris.lew@oss.qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: shikra: Add BAM-DMUX support
Date: Thu, 11 Jun 2026 21:31:06 +0530 [thread overview]
Message-ID: <17bfa853-d0a6-4f83-a164-a17fb02f67a6@oss.qualcomm.com> (raw)
In-Reply-To: <aip3_fyE8tMtJZIW@linaro.org>
On 11-06-2026 02:25 pm, Stephan Gerhold wrote:
> On Thu, Jun 11, 2026 at 02:11:59PM +0530, Vishnu Santhosh wrote:
>> + bam_dmux: bam-dmux {
>> + compatible = "qcom,bam-dmux";
>> +
>> + interrupts-extended = <&modem_smsm 1 IRQ_TYPE_EDGE_BOTH>,
>> + <&modem_smsm 11 IRQ_TYPE_EDGE_BOTH>;
>> + interrupt-names = "pc",
>> + "pc-ack";
>> +
>> + qcom,smem-states = <&apps_smsm 1>,
>> + <&apps_smsm 11>;
>> + qcom,smem-state-names = "pc",
>> + "pc-ack";
>> +
>> + dmas = <&bam_dmux_dma 4>, <&bam_dmux_dma 5>;
>> + dma-names = "tx", "rx";
>> + };
> This should be a child node of the modem remoteproc. See msm8916.dtsi
> for example.
Thanks for the context! We actually referenced msm8916.dtsi during
bring-up and initially placed bam-dmux as a
remoteproc child. We then hit the issue that the driver was not probing
at all. After some digging, we realized
that qcom_q6v5_mss.c (used by msm8916) explicitly calls
of_platform_device_create() for its qcom,bam-dmux child,
but qcom_q6v5_pas.c which Shikra uses has no such logic, so the platform
device was never created.
There was a prior attempt to fix this generically by adding
of_platform_populate() to qcom_q6v5.c
(https://lore.kernel.org/all/20251223123227.1317244-3-gaurav.kohli@oss.qualcomm.com/),
but it was blocked
because GLINK/SMD edge child nodes would also get spurious platform
devices registered for them.
That series remains unresolved at v1.
Since your driver already manages modem lifecycle independently via SMSM
state bits without remoteproc dependency,
we moved it to the root level where of_platform_populate() picks it up
at boot, and everything worked.
Would love to get your suggestion on whether this approach is welcomed,
since it needs zero driver changes.
Thanks,
Vishnu
next prev parent reply other threads:[~2026-06-11 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 8:41 Vishnu Santhosh
2026-06-11 8:55 ` Stephan Gerhold
2026-06-11 9:10 ` Konrad Dybcio
2026-06-11 9:14 ` Stephan Gerhold
2026-06-11 16:01 ` Vishnu Santhosh [this message]
2026-06-11 16:57 ` Stephan Gerhold
2026-07-11 3:55 ` Vishnu Santhosh
2026-07-11 3:48 ` Vishnu Santhosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17bfa853-d0a6-4f83-a164-a17fb02f67a6@oss.qualcomm.com \
--to=vishnu.santhosh@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=chris.lew@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®