* [PATCH net] netdevsim: fix devlink rate node leak on devlink_free()
@ 2026-11-17 6:32 xietangxin
2026-11-17 10:30 ` Xuanqiang Luo
0 siblings, 1 reply; 2+ messages in thread
From: xietangxin @ 2026-11-17 6:32 UTC (permalink / raw)
To: Jakub Kicinski, Andrew Lunn, David S . Miller, Eric Dumazet, Paolo Abeni
Cc: Dmytro Linkin, Vlad Buslov, Jiri Pirko, netdev, linux-kernel,
stable, syzbot+bbd81e1e2276c534dea1, gaoxingwang1, huyizhen2
netdevsim allows switching the eswitch mode to switchdev with zero VFs
and creating rate nodes on such a device. However during device teardown
nsim_dev_reload_destroy() only drops the eswitch back to legacy when VFs
were configured, so the rate nodes are never destroyed and trigger the
WARN_ON(devlink_rates_check()) in devlink_free():
WARNING: net/devlink/core.c:544 at devlink_free+0x18c/0x26c, CPU#2: bash/5032
Modules linked in: netdevsim ...
CPU: 2 UID: 0 PID: 5032 Comm: bash Not tainted 7.4.0-rc3+ #77 PREEMPTLAZY
Call trace:
devlink_free+0x18c/0x26c (P)
nsim_drv_remove+0x9c/0xb4 [netdevsim]
nsim_bus_remove+0x10/0x1c [netdevsim]
del_device_store+0x110/0x190 [netdevsim]
...
Evaluate the eswitch mode check unconditionally, so rate nodes are
destroyed whether or not any VF was ever configured.
Reproduce by:
$ echo "10 1" > /sys/bus/netdevsim/new_device
$ devlink dev eswitch set netdevsim/netdevsim10 mode switchdev
$ devlink port function rate add netdevsim/netdevsim10/n1
$ echo 10 > /sys/bus/netdevsim/del_device
Fixes: 885226f5680e ("netdevsim: Implement support for devlink rate nodes")
Cc: stable@vger.kernel.org
Reported-by: syzbot+bbd81e1e2276c534dea1@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/6af9824c.920b2b3a.148c65.0009.GAE@google.com/
Signed-off-by: xietangxin <xietangxin@h-partners.com>
---
drivers/net/netdevsim/dev.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
index c6b17b387327..b483c25dfecd 100644
--- a/drivers/net/netdevsim/dev.c
+++ b/drivers/net/netdevsim/dev.c
@@ -1700,11 +1700,10 @@ static void nsim_dev_reload_destroy(struct nsim_dev *nsim_dev)
return;
debugfs_remove(nsim_dev->take_snapshot);
- if (nsim_dev_get_vfs(nsim_dev)) {
+ if (nsim_dev_get_vfs(nsim_dev))
nsim_bus_dev_set_vfs(nsim_dev->nsim_bus_dev, 0);
- if (nsim_esw_mode_is_switchdev(nsim_dev))
- nsim_esw_legacy_enable(nsim_dev, NULL);
- }
+ if (nsim_esw_mode_is_switchdev(nsim_dev))
+ nsim_esw_legacy_enable(nsim_dev, NULL);
nsim_dev_port_del_all(nsim_dev);
nsim_dev_hwstats_exit(nsim_dev);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net] netdevsim: fix devlink rate node leak on devlink_free()
2026-11-17 6:32 [PATCH net] netdevsim: fix devlink rate node leak on devlink_free() xietangxin
@ 2026-11-17 10:30 ` Xuanqiang Luo
0 siblings, 0 replies; 2+ messages in thread
From: Xuanqiang Luo @ 2026-11-17 10:30 UTC (permalink / raw)
To: xietangxin
Cc: Dmytro Linkin, Vlad Buslov, Jiri Pirko, netdev, linux-kernel,
stable, syzbot+bbd81e1e2276c534dea1, gaoxingwang1, huyizhen2,
Jakub Kicinski, Andrew Lunn, David S . Miller, Eric Dumazet,
Paolo Abeni
On 2026/11/17 at 15:32 xietangxin wrote:
> netdevsim allows switching the eswitch mode to switchdev with zero VFs
> and creating rate nodes on such a device. However during device teardown
> nsim_dev_reload_destroy() only drops the eswitch back to legacy when VFs
> were configured, so the rate nodes are never destroyed and trigger the
> WARN_ON(devlink_rates_check()) in devlink_free():
>
> WARNING: net/devlink/core.c:544 at devlink_free+0x18c/0x26c, CPU#2: bash/5032
> Modules linked in: netdevsim ...
> CPU: 2 UID: 0 PID: 5032 Comm: bash Not tainted 7.4.0-rc3+ #77 PREEMPTLAZY
> Call trace:
> devlink_free+0x18c/0x26c (P)
> nsim_drv_remove+0x9c/0xb4 [netdevsim]
> nsim_bus_remove+0x10/0x1c [netdevsim]
> del_device_store+0x110/0x190 [netdevsim]
> ...
>
> Evaluate the eswitch mode check unconditionally, so rate nodes are
> destroyed whether or not any VF was ever configured.
>
> Reproduce by:
> $ echo "10 1" > /sys/bus/netdevsim/new_device
> $ devlink dev eswitch set netdevsim/netdevsim10 mode switchdev
> $ devlink port function rate add netdevsim/netdevsim10/n1
> $ echo 10 > /sys/bus/netdevsim/del_device
>
> Fixes: 885226f5680e ("netdevsim: Implement support for devlink rate nodes")
> Cc: stable@vger.kernel.org
> Reported-by: syzbot+bbd81e1e2276c534dea1@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/netdev/6af9824c.920b2b3a.148c65.0009.GAE@google.com/
> Signed-off-by: xietangxin <xietangxin@h-partners.com>
> ---
The rate nodes are also left behind on the reload path. I reproduced this
locally on 7.3.0 (net/main)
WARNING: net/devlink/dev.c:437 at
devlink_reload_reinit_sanity_check+0x178/0x1c8
Call trace:
devlink_reload_reinit_sanity_check+0x178/0x1c8 (P)
devlink_reload+0x298/0x2b8
devlink_nl_reload_doit+0x5cc/0x870
genl_family_rcv_msg_doit+0x15c/0x1f0
...
Please mention reload in the changelog, as it now also resets a zero-VF
switchdev device to legacy mode, like the existing VF case.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 6:32 [PATCH net] netdevsim: fix devlink rate node leak on devlink_free() xietangxin
2026-11-17 10:30 ` Xuanqiang Luo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®