From: Marek Vasut <marex@nabladev.com>
To: Frank Li <Frank.li@oss.nxp.com>,
Francesco Dolcini <francesco@dolcini.it>
Cc: linux-arm-kernel@lists.infradead.org,
Aswath Govindraju <a-govindraju@ti.com>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] arm64: dts: imx95: Add support for Data Modul i.MX95 eDM SBC
Date: Wed, 30 Sep 2026 21:29:34 +0200 [thread overview]
Message-ID: <17f240e5-9c65-4562-ba51-535b0c69c5fd@nabladev.com> (raw)
In-Reply-To: <ar1bhpji35CbArtY@SMW015318>
On 9/30/26 8:57 PM, Frank Li wrote:
> On Wed, Sep 30, 2026 at 07:44:13PM +0200, Francesco Dolcini wrote:
>> On Tue, Sep 29, 2026 at 05:20:27PM +0200, Marek Vasut wrote:
>>> On 9/29/26 4:45 PM, Frank Li wrote:
>>>
>>> Hello Frank,
>>>
>>>>> + backlight_lvds: backlight-lvds {
>>>>> + compatible = "pwm-backlight";
>>>>> + pinctrl-names = "default";
>>>>> + pinctrl-0 = <&pinctrl_panel_backlight_lvds>;
>>>>> + brightness-levels = <0 1 10 20 30 40 50 60 70 75 80 90 100>;
>>>>> + default-brightness-level = <7>;
>>>>> + enable-gpios = <&gpio2 27 GPIO_ACTIVE_HIGH>;
>>>>> + pwms = <&tpm3 3 5000000 0>;
>>>>> + /* Disabled by default, unless display board plugged in. */
>>>>> + status = "disabled";
>>>>> + };
>>>>
>>>> The both backlight is not used in this dts, can you remove it and
>>>> add these when it real use.
>>> It's the same thing we do on the other boards, so I would prefer to keep
>>> this consistent:
>>
>> I agree with Marek, and I would not use the criteria about being used or
>> not.
>
>
> Others boards: some has dtso, which use it. And krzy have some concern for
> similar case although he have not reply alex's answer.
>
> https://lore.kernel.org/imx/30599533-91de-41fd-9420-3f8693ec92ac@kernel.org/
>
> And it is most likely go through nexus connector node to support display
> panel in future.
I do not think nexus node will apply to this connector, no.
> So I suggest remove it now and add it when need.
Can we please go with consistency between these boards from one vendor ?
Thank you.
next prev parent reply other threads:[~2026-09-30 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 20:47 [PATCH v5 1/3] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6563 Marek Vasut
2026-09-28 20:47 ` [PATCH v5 2/3] dt-bindings: arm: fsl: Document Data Modul i.MX95 eDM SBC Marek Vasut
2026-09-28 20:47 ` [PATCH v5 3/3] arm64: dts: imx95: Add support for " Marek Vasut
2026-09-29 14:45 ` Frank Li
2026-09-29 15:20 ` Marek Vasut
2026-09-30 17:44 ` Francesco Dolcini
2026-09-30 18:57 ` Frank Li
2026-09-30 19:29 ` Marek Vasut [this message]
2026-09-30 21:21 ` Frank Li
2026-09-30 21:49 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f240e5-9c65-4562-ba51-535b0c69c5fd@nabladev.com \
--to=marex@nabladev.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.li@oss.nxp.com \
--cc=a-govindraju@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco@dolcini.it \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®